All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emese Revfy <re.emese@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	PaX Team <pageexec@freemail.hu>,
	Brad Spengler <spender@grsecurity.net>,
	kernel-hardening@lists.openwall.com,
	Michal Marek <mmarek@suse.com>, Kees Cook <keescook@chromium.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	David Brown <david.brown@linaro.org>
Subject: Re: [PATCH v7 1/6] Shared library support
Date: Tue, 3 May 2016 23:25:27 +0200	[thread overview]
Message-ID: <20160503232527.6e02867a5d4b8f28f6c0f854@gmail.com> (raw)
In-Reply-To: <CAK7LNAR-+4+Xdhbs6hoPUTYppLqFwY8dxqdSuw_5j6Pge4uYVg@mail.gmail.com>

On Mon, 2 May 2016 14:03:00 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

Hi,

> > diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
> > index 55c96cb..e4e88ab 100644
> > --- a/scripts/Makefile.clean
> > +++ b/scripts/Makefile.clean
> > @@ -38,7 +38,8 @@ subdir-ymn    := $(addprefix $(obj)/,$(subdir-ymn))
> >  __clean-files  := $(extra-y) $(extra-m) $(extra-)       \
> >                    $(always) $(targets) $(clean-files)   \
> >                    $(host-progs)                         \
> > -                  $(hostprogs-y) $(hostprogs-m) $(hostprogs-)
> > +                  $(hostprogs-y) $(hostprogs-m) $(hostprogs-) \
> > +                  $(hostlibs-y) $(hostlibs-m) $(hostlibs-)
> 
> $(hostcxxlibs-y)$(hostcxxlibs-m) is missing here.
> 
> 
> BTW, are you planning to support hostlibs without .so extention in the future?
> 
> 
> You are changing the top Makefile to clean with "*.so" pattern rule.
> 
> Do you need to change both the top Makefile and Makefile.clean
> for belt-and-braces cleaning?

It doesn't delete the *.so files without the hunk from the top Makefile. 
The mrproper and distclean targets remove them with this patch:
https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/f23b7eb247ccc9f1007e53313af343980dd52591
But I think this isn't the best solution much like doing it from the top Makefile.

-- 
Emese

WARNING: multiple messages have this Message-ID (diff)
From: Emese Revfy <re.emese@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	PaX Team <pageexec@freemail.hu>,
	Brad Spengler <spender@grsecurity.net>,
	kernel-hardening@lists.openwall.com,
	Michal Marek <mmarek@suse.com>, Kees Cook <keescook@chromium.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	David Brown <david.brown@linaro.org>
Subject: [kernel-hardening] Re: [PATCH v7 1/6] Shared library support
Date: Tue, 3 May 2016 23:25:27 +0200	[thread overview]
Message-ID: <20160503232527.6e02867a5d4b8f28f6c0f854@gmail.com> (raw)
In-Reply-To: <CAK7LNAR-+4+Xdhbs6hoPUTYppLqFwY8dxqdSuw_5j6Pge4uYVg@mail.gmail.com>

On Mon, 2 May 2016 14:03:00 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

Hi,

> > diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
> > index 55c96cb..e4e88ab 100644
> > --- a/scripts/Makefile.clean
> > +++ b/scripts/Makefile.clean
> > @@ -38,7 +38,8 @@ subdir-ymn    := $(addprefix $(obj)/,$(subdir-ymn))
> >  __clean-files  := $(extra-y) $(extra-m) $(extra-)       \
> >                    $(always) $(targets) $(clean-files)   \
> >                    $(host-progs)                         \
> > -                  $(hostprogs-y) $(hostprogs-m) $(hostprogs-)
> > +                  $(hostprogs-y) $(hostprogs-m) $(hostprogs-) \
> > +                  $(hostlibs-y) $(hostlibs-m) $(hostlibs-)
> 
> $(hostcxxlibs-y)$(hostcxxlibs-m) is missing here.
> 
> 
> BTW, are you planning to support hostlibs without .so extention in the future?
> 
> 
> You are changing the top Makefile to clean with "*.so" pattern rule.
> 
> Do you need to change both the top Makefile and Makefile.clean
> for belt-and-braces cleaning?

It doesn't delete the *.so files without the hunk from the top Makefile. 
The mrproper and distclean targets remove them with this patch:
https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/f23b7eb247ccc9f1007e53313af343980dd52591
But I think this isn't the best solution much like doing it from the top Makefile.

-- 
Emese

  parent reply	other threads:[~2016-05-03 21:18 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 18:19 [PATCH v7 0/6] Introduce GCC plugin infrastructure Emese Revfy
2016-04-22 18:19 ` [kernel-hardening] " Emese Revfy
2016-04-22 18:21 ` [PATCH v7 1/6] Shared library support Emese Revfy
2016-04-22 18:21   ` [kernel-hardening] " Emese Revfy
2016-05-02  5:03   ` Masahiro Yamada
2016-05-02  5:03     ` [kernel-hardening] " Masahiro Yamada
2016-05-02 17:56     ` Emese Revfy
2016-05-02 17:56       ` [kernel-hardening] " Emese Revfy
2016-05-03  2:00       ` Masahiro Yamada
2016-05-03  2:00         ` [kernel-hardening] " Masahiro Yamada
2016-05-03 21:29         ` Emese Revfy
2016-05-03 21:29           ` [kernel-hardening] " Emese Revfy
2016-05-04  4:09           ` Masahiro Yamada
2016-05-04  4:09             ` [kernel-hardening] " Masahiro Yamada
2016-05-05 18:40             ` Emese Revfy
2016-05-05 18:40               ` [kernel-hardening] " Emese Revfy
2016-05-03  2:06       ` Masahiro Yamada
2016-05-03  2:06         ` [kernel-hardening] " Masahiro Yamada
2016-05-03 21:25     ` Emese Revfy [this message]
2016-05-03 21:25       ` Emese Revfy
2016-05-05 18:43       ` Emese Revfy
2016-05-05 18:43         ` [kernel-hardening] " Emese Revfy
2016-04-22 18:22 ` [PATCH v7 2/6] GCC plugin infrastructure Emese Revfy
2016-04-22 18:22   ` [kernel-hardening] " Emese Revfy
2016-05-02  5:07   ` Masahiro Yamada
2016-05-02  5:07     ` [kernel-hardening] " Masahiro Yamada
2016-05-02 17:59     ` Emese Revfy
2016-05-11 11:24   ` Michal Marek
2016-05-11 11:24     ` [kernel-hardening] " Michal Marek
2016-05-12 15:04     ` Emese Revfy
2016-05-12 15:04       ` [kernel-hardening] " Emese Revfy
2016-04-22 18:23 ` [PATCH v7 3/6] The GCC plugin infrastructure supports the arm and arm64 architectures too Emese Revfy
2016-04-22 18:23   ` [kernel-hardening] " Emese Revfy
2016-05-02  5:08   ` Masahiro Yamada
2016-05-02  5:08     ` [kernel-hardening] " Masahiro Yamada
2016-04-22 18:24 ` [PATCH v7 4/6] Add Cyclomatic complexity GCC plugin Emese Revfy
2016-04-22 18:24   ` [kernel-hardening] " Emese Revfy
2016-05-02  5:09   ` Masahiro Yamada
2016-05-02  5:09     ` [kernel-hardening] " Masahiro Yamada
2016-04-22 18:26 ` [PATCH v7 5/6] Documentation for the GCC plugin infrastructure Emese Revfy
2016-04-22 18:26   ` [kernel-hardening] " Emese Revfy
2016-05-02  5:10   ` Masahiro Yamada
2016-05-02  5:10     ` [kernel-hardening] " Masahiro Yamada
2016-05-02 18:07     ` Emese Revfy
2016-05-02 18:07       ` [kernel-hardening] " Emese Revfy
2016-04-22 18:27 ` [PATCH v7 6/6] Add sancov plugin Emese Revfy
2016-04-22 18:27   ` [kernel-hardening] " Emese Revfy
2016-04-22 18:51   ` Dmitry Vyukov
2016-04-22 18:51     ` [kernel-hardening] " Dmitry Vyukov
2016-04-26 20:40 ` [PATCH v7 0/6] Introduce GCC plugin infrastructure Kees Cook
2016-04-26 20:40   ` [kernel-hardening] " Kees Cook
2016-04-26 20:40   ` Kees Cook
2016-04-27  1:40   ` Masahiro Yamada
2016-04-27  1:40     ` [kernel-hardening] " Masahiro Yamada
2016-04-27  1:40     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160503232527.6e02867a5d4b8f28f6c0f854@gmail.com \
    --to=re.emese@gmail.com \
    --cc=david.brown@linaro.org \
    --cc=dvyukov@google.com \
    --cc=fengguang.wu@intel.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mmarek@suse.com \
    --cc=pageexec@freemail.hu \
    --cc=spender@grsecurity.net \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.