From: Mark Brown <broonie@kernel.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers
Date: Thu, 5 May 2016 20:17:28 +0100 [thread overview]
Message-ID: <20160505191728.GK6292@sirena.org.uk> (raw)
In-Reply-To: <87pot0pbnf.fsf@belgarion.home>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote:
> Mark Brown <broonie@kernel.org> writes:
> > I see that, I just don't know why that helps.
> Ok, so let me explain.
> As you already understood, AC97_VENDOR* is needed in bus.c for the
> autoscanning. The remaining is the reason why I don't want to include
> ac97_codec.h in bus.c, which follows.
> In order to have a clean split between former ac97 bus implementation and this
> new one, I didn't want to include any former ac97 includes, excepting in
> sound/ac97/compat.c.
It's probably a good idea to articulate some of this in the commit log
then!
> This transition will be easier if the new ac97 code is isolated as much as
> possible from the former code while providing backward compatibility ... hence
> this patch.
It'd probably have been clearer to me if it were splitting out all the
register definitions rather than just some of them.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers
Date: Thu, 5 May 2016 20:17:28 +0100 [thread overview]
Message-ID: <20160505191728.GK6292@sirena.org.uk> (raw)
In-Reply-To: <87pot0pbnf.fsf@belgarion.home>
On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote:
> Mark Brown <broonie@kernel.org> writes:
> > I see that, I just don't know why that helps.
> Ok, so let me explain.
> As you already understood, AC97_VENDOR* is needed in bus.c for the
> autoscanning. The remaining is the reason why I don't want to include
> ac97_codec.h in bus.c, which follows.
> In order to have a clean split between former ac97 bus implementation and this
> new one, I didn't want to include any former ac97 includes, excepting in
> sound/ac97/compat.c.
It's probably a good idea to articulate some of this in the commit log
then!
> This transition will be easier if the new ac97 code is isolated as much as
> possible from the former code while providing backward compatibility ... hence
> this patch.
It'd probably have been clearer to me if it were splitting out all the
register definitions rather than just some of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160505/2dd6048c/attachment.sig>
next prev parent reply other threads:[~2016-05-05 19:17 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 21:15 [RFC PATCH 0/7] AC97 device/driver model revamp Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-04-30 21:15 ` [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-05-03 11:51 ` Mark Brown
2016-05-03 11:51 ` Mark Brown
2016-05-03 19:22 ` Robert Jarzmik
2016-05-03 19:22 ` Robert Jarzmik
2016-05-03 19:22 ` Robert Jarzmik
2016-05-04 9:07 ` Mark Brown
2016-05-04 9:07 ` Mark Brown
2016-05-05 19:06 ` Robert Jarzmik
2016-05-05 19:06 ` Robert Jarzmik
2016-05-05 19:06 ` Robert Jarzmik
2016-05-05 19:17 ` Mark Brown [this message]
2016-05-05 19:17 ` Mark Brown
2016-05-05 19:46 ` Robert Jarzmik
2016-05-05 19:46 ` Robert Jarzmik
2016-05-06 17:17 ` Mark Brown
2016-05-06 17:17 ` Mark Brown
2017-09-04 17:25 ` Applied "ALSA: ac97: split out the generic ac97 registers" to the asoc tree Mark Brown
2017-09-04 17:25 ` Mark Brown
2017-09-04 17:25 ` Mark Brown
2016-04-30 21:15 ` [RFC PATCH 2/7] ALSA: ac97: add an ac97 bus Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-05-03 16:29 ` Mark Brown
2016-05-03 16:29 ` Mark Brown
2016-05-03 19:43 ` Robert Jarzmik
2016-05-03 19:43 ` Robert Jarzmik
2016-05-04 16:22 ` Mark Brown
2016-05-04 16:22 ` Mark Brown
2016-05-05 19:14 ` Robert Jarzmik
2016-05-05 19:14 ` Robert Jarzmik
2016-05-09 9:31 ` Takashi Iwai
2016-05-09 9:31 ` Takashi Iwai
2016-05-09 9:31 ` Takashi Iwai
2016-05-14 9:50 ` Robert Jarzmik
2016-05-14 9:50 ` Robert Jarzmik
2016-05-14 9:50 ` Robert Jarzmik
2016-05-14 15:13 ` Takashi Iwai
2016-05-14 15:13 ` Takashi Iwai
2016-05-14 15:13 ` Takashi Iwai
2016-05-15 21:29 ` Robert Jarzmik
2016-05-15 21:29 ` Robert Jarzmik
2016-05-15 21:29 ` Robert Jarzmik
2016-05-16 5:40 ` Takashi Iwai
2016-05-16 5:40 ` Takashi Iwai
2016-05-16 5:40 ` Takashi Iwai
2016-05-16 8:53 ` Robert Jarzmik
2016-05-16 8:53 ` Robert Jarzmik
2016-05-16 8:53 ` Robert Jarzmik
2016-05-16 12:58 ` Takashi Iwai
2016-05-16 12:58 ` Takashi Iwai
2016-05-16 12:58 ` Takashi Iwai
2016-05-16 13:12 ` Mark Brown
2016-05-16 13:12 ` Mark Brown
2016-04-30 21:15 ` [RFC PATCH 3/7] ASoC: wm9713: add ac97 new bus support Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-04-30 21:15 ` [RFC PATCH 4/7] ASoC: pxa: switch to new ac97 " Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-04-30 21:15 ` [RFC PATCH 5/7] ARM: pxa: mioa701 remove wm9713 from platform devices Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-04-30 21:15 ` [RFC PATCH 6/7] ASoC: mioa701_wm9713: convert to new ac97 bus Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-04-30 21:15 ` [RFC PATCH 7/7] ASoC: add new ac97 bus support Robert Jarzmik
2016-04-30 21:15 ` Robert Jarzmik
2016-05-09 9:04 ` [RFC PATCH 0/7] AC97 device/driver model revamp Takashi Iwai
2016-05-09 9:04 ` Takashi Iwai
2016-05-09 9:04 ` Takashi Iwai
2016-05-14 8:13 ` Robert Jarzmik
2016-05-14 8:13 ` Robert Jarzmik
2016-05-14 8:13 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505191728.GK6292@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.