From: Jan Kara <jack@suse.cz>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: hch@infradead.org, jack@suse.cz, linux-block@vger.kernel.org,
linux-nvdimm@lists.01.org, david@fromorbit.com,
linux-kernel@vger.kernel.org, micah.parrish@hpe.com,
axboe@fb.com, adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH v4 6/6] block: Update blkdev_dax_capable() for consistency
Date: Wed, 11 May 2016 10:05:37 +0200 [thread overview]
Message-ID: <20160511080537.GA14744@quack2.suse.cz> (raw)
In-Reply-To: <1462897437-16626-7-git-send-email-toshi.kani@hpe.com>
On Tue 10-05-16 10:23:57, Toshi Kani wrote:
> blkdev_dax_capable() is similar to bdev_dax_supported(), but needs
> to remain as a separate interface for checking dax capability of
> a raw block device.
>
> Rename and relocate blkdev_dax_capable() to keep them maintained
> consistently, and call bdev_direct_access() for the dax capability
> check.
...
> +bool bdev_dax_capable(struct block_device *bdev)
> +{
> + struct gendisk *disk = bdev->bd_disk;
> + struct blk_dax_ctl dax = {
> + .size = PAGE_SIZE,
> + };
> +
> + if (!IS_ENABLED(CONFIG_FS_DAX))
> + return false;
Frankly, I prefer the #ifdef CONFIG_FS_DAX and just compile the code out
when DAX is not enabled (like it was with blkdev_dax_capable()). That way we
don't grow the kernel for people who don't care about DAX.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com,
viro@zeniv.linux.org.uk, axboe@fb.com, hch@infradead.org,
boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca,
ross.zwisler@linux.intel.com, micah.parrish@hpe.com,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/6] block: Update blkdev_dax_capable() for consistency
Date: Wed, 11 May 2016 10:05:37 +0200 [thread overview]
Message-ID: <20160511080537.GA14744@quack2.suse.cz> (raw)
In-Reply-To: <1462897437-16626-7-git-send-email-toshi.kani@hpe.com>
On Tue 10-05-16 10:23:57, Toshi Kani wrote:
> blkdev_dax_capable() is similar to bdev_dax_supported(), but needs
> to remain as a separate interface for checking dax capability of
> a raw block device.
>
> Rename and relocate blkdev_dax_capable() to keep them maintained
> consistently, and call bdev_direct_access() for the dax capability
> check.
...
> +bool bdev_dax_capable(struct block_device *bdev)
> +{
> + struct gendisk *disk = bdev->bd_disk;
> + struct blk_dax_ctl dax = {
> + .size = PAGE_SIZE,
> + };
> +
> + if (!IS_ENABLED(CONFIG_FS_DAX))
> + return false;
Frankly, I prefer the #ifdef CONFIG_FS_DAX and just compile the code out
when DAX is not enabled (like it was with blkdev_dax_capable()). That way we
don't grow the kernel for people who don't care about DAX.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com,
viro@zeniv.linux.org.uk, axboe@fb.com, hch@infradead.org,
boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca,
ross.zwisler@linux.intel.com, micah.parrish@hpe.com,
linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/6] block: Update blkdev_dax_capable() for consistency
Date: Wed, 11 May 2016 10:05:37 +0200 [thread overview]
Message-ID: <20160511080537.GA14744@quack2.suse.cz> (raw)
In-Reply-To: <1462897437-16626-7-git-send-email-toshi.kani@hpe.com>
On Tue 10-05-16 10:23:57, Toshi Kani wrote:
> blkdev_dax_capable() is similar to bdev_dax_supported(), but needs
> to remain as a separate interface for checking dax capability of
> a raw block device.
>
> Rename and relocate blkdev_dax_capable() to keep them maintained
> consistently, and call bdev_direct_access() for the dax capability
> check.
...
> +bool bdev_dax_capable(struct block_device *bdev)
> +{
> + struct gendisk *disk = bdev->bd_disk;
> + struct blk_dax_ctl dax = {
> + .size = PAGE_SIZE,
> + };
> +
> + if (!IS_ENABLED(CONFIG_FS_DAX))
> + return false;
Frankly, I prefer the #ifdef CONFIG_FS_DAX and just compile the code out
when DAX is not enabled (like it was with blkdev_dax_capable()). That way we
don't grow the kernel for people who don't care about DAX.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-05-11 8:05 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 16:23 [PATCH v4 0/6] Add alignment check for DAX mount Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 1/6] block: Add vfs_msg() interface Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 2/6] block: Add bdev_dax_supported() for dax mount checks Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 3/6] ext4: Add alignment check for DAX mount Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 4/6] ext2: " Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 5/6] xfs: " Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 6/6] block: Update blkdev_dax_capable() for consistency Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 19:49 ` Dan Williams
2016-05-10 19:49 ` Dan Williams
2016-05-10 19:49 ` Dan Williams
2016-05-10 21:36 ` Toshi Kani
2016-05-10 21:36 ` Toshi Kani
2016-05-10 21:36 ` Toshi Kani
2016-05-11 8:05 ` Jan Kara [this message]
2016-05-11 8:05 ` Jan Kara
2016-05-11 8:05 ` Jan Kara
2016-05-11 14:25 ` Toshi Kani
2016-05-11 14:25 ` Toshi Kani
2016-05-11 14:25 ` Toshi Kani
2016-05-11 15:26 ` Jan Kara
2016-05-11 15:26 ` Jan Kara
2016-05-11 15:26 ` Jan Kara
2016-05-17 22:07 ` Dan Williams
2016-05-17 22:07 ` Dan Williams
2016-05-17 22:07 ` Dan Williams
2016-05-17 23:02 ` Toshi Kani
2016-05-18 7:54 ` [PATCH] remove unused blkdev_dax_capable() function Arnd Bergmann
2016-05-18 7:54 ` Arnd Bergmann
2016-05-18 14:01 ` Toshi Kani
2016-05-18 14:01 ` Toshi Kani
2016-05-18 14:01 ` Toshi Kani
2016-05-18 19:30 ` Vishal Verma
2016-05-18 19:30 ` Vishal Verma
2016-05-18 19:30 ` Vishal Verma
2016-05-20 11:32 ` kbuild test robot
2016-05-20 11:32 ` kbuild test robot
2016-05-20 11:32 ` kbuild test robot
2016-05-20 15:48 ` Kani, Toshimitsu
2016-05-20 15:48 ` Kani, Toshimitsu
2016-05-20 15:48 ` Kani, Toshimitsu
2016-05-20 15:48 ` Kani, Toshimitsu
2016-05-11 13:20 ` [PATCH v4 0/6] Add alignment check for DAX mount Carlos Maiolino
2016-05-19 23:37 ` Eric Sandeen
2016-05-19 23:37 ` Eric Sandeen
2016-05-19 23:37 ` Eric Sandeen
2016-05-20 14:50 ` Kani, Toshimitsu
2016-05-20 14:50 ` Kani, Toshimitsu
2016-05-20 14:50 ` Kani, Toshimitsu
2016-05-20 14:50 ` Kani, Toshimitsu
2016-05-20 17:34 ` Verma, Vishal L
2016-05-20 17:34 ` Verma, Vishal L
2016-05-20 17:34 ` Verma, Vishal L
2016-05-20 17:34 ` Verma, Vishal L
2016-05-20 17:49 ` Kani, Toshimitsu
2016-05-20 17:49 ` Kani, Toshimitsu
2016-05-20 17:49 ` Kani, Toshimitsu
2016-05-20 17:49 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511080537.GA14744@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@fb.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=micah.parrish@hpe.com \
--cc=toshi.kani@hpe.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.