From: Jan Kara <jack@suse.cz>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [RFC v3] [PATCH 0/18] DAX page fault locking
Date: Wed, 11 May 2016 11:19:30 +0200 [thread overview]
Message-ID: <20160511091930.GE14744@quack2.suse.cz> (raw)
In-Reply-To: <20160510223937.GA10222@linux.intel.com>
On Tue 10-05-16 16:39:37, Ross Zwisler wrote:
> On Tue, May 10, 2016 at 02:30:03PM -0600, Ross Zwisler wrote:
> > On Tue, May 10, 2016 at 05:28:14PM +0200, Jan Kara wrote:
> > > On Mon 09-05-16 11:38:28, Jan Kara wrote:
> > > Somehow, I'm not able to reproduce the warnings... Anyway, I think I see
> > > what's going on. Can you check whether the warning goes away when you
> > > change the condition at the end of page_cache_tree_delete() to:
> > >
> > > if (!dax_mapping(mapping) && !workingset_node_pages(node) &&
> > > list_empty(&node->private_list)) {
> >
> > Yep, this took care of both of the issues that I reported. I'll restart my
> > testing with this in my baseline, but as of this fix I don't have any more
> > open testing issues. :)
>
> Well, looks like I spoke too soon. The two tests that were failing for me are
> now passing, but I can still create what looks like a related failure using
> XFS, DAX, and the two xfstests generic/231 and generic/232 run back-to-back.
Hum, full xfstests run completes for me just fine. Can you reproduce the
issue with the attached debug patch? Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-mm@kvack.org, Dan Williams <dan.j.williams@intel.com>,
linux-nvdimm@lists.01.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [RFC v3] [PATCH 0/18] DAX page fault locking
Date: Wed, 11 May 2016 11:19:30 +0200 [thread overview]
Message-ID: <20160511091930.GE14744@quack2.suse.cz> (raw)
In-Reply-To: <20160510223937.GA10222@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
On Tue 10-05-16 16:39:37, Ross Zwisler wrote:
> On Tue, May 10, 2016 at 02:30:03PM -0600, Ross Zwisler wrote:
> > On Tue, May 10, 2016 at 05:28:14PM +0200, Jan Kara wrote:
> > > On Mon 09-05-16 11:38:28, Jan Kara wrote:
> > > Somehow, I'm not able to reproduce the warnings... Anyway, I think I see
> > > what's going on. Can you check whether the warning goes away when you
> > > change the condition at the end of page_cache_tree_delete() to:
> > >
> > > if (!dax_mapping(mapping) && !workingset_node_pages(node) &&
> > > list_empty(&node->private_list)) {
> >
> > Yep, this took care of both of the issues that I reported. I'll restart my
> > testing with this in my baseline, but as of this fix I don't have any more
> > open testing issues. :)
>
> Well, looks like I spoke too soon. The two tests that were failing for me are
> now passing, but I can still create what looks like a related failure using
> XFS, DAX, and the two xfstests generic/231 and generic/232 run back-to-back.
Hum, full xfstests run completes for me just fine. Can you reproduce the
issue with the attached debug patch? Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
[-- Attachment #2: 0001-Debugging-workingset.patch --]
[-- Type: text/x-patch, Size: 1673 bytes --]
>From 8f01c60e8be5d5671b09b07a5fb647177e33293d Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@suse.cz>
Date: Wed, 11 May 2016 11:14:11 +0200
Subject: [PATCH] Debugging workingset
Signed-off-by: Jan Kara <jack@suse.cz>
---
mm/workingset.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/mm/workingset.c b/mm/workingset.c
index 8a75f8d2916a..b692fc756fda 100644
--- a/mm/workingset.c
+++ b/mm/workingset.c
@@ -12,6 +12,7 @@
#include <linux/swap.h>
#include <linux/fs.h>
#include <linux/mm.h>
+#include <linux/dax.h>
/*
* Double CLOCK lists
@@ -402,6 +403,7 @@ static enum lru_status shadow_lru_isolate(struct list_head *item,
node = container_of(item, struct radix_tree_node, private_list);
mapping = node->private_data;
+ WARN_ON(dax_mapping(mapping));
/* Coming from the list, invert the lock order */
if (!spin_trylock(&mapping->tree_lock)) {
@@ -418,7 +420,18 @@ static enum lru_status shadow_lru_isolate(struct list_head *item,
* no pages, so we expect to be able to remove them all and
* delete and free the empty node afterwards.
*/
-
+ if (!node->count || (node->count & RADIX_TREE_COUNT_MASK)) {
+ printk(KERN_ERR "Wrong node->count %u.\n", node->count);
+ if (!mapping->host) {
+ printk(KERN_ERR "Node mapping has no host!\n");
+ } else {
+ printk(KERN_ERR "Host sb %s ino %lu\n", mapping->host->i_sb->s_id, mapping->host->i_ino);
+ }
+ printk(KERN_ERR "Node dump:");
+ for (i = 0; i < RADIX_TREE_MAP_SIZE; i++)
+ printk(KERN_CONT " %lx", (unsigned long)node->slots[i]);
+ printk(KERN_CONT "\n");
+ }
BUG_ON(!node->count);
BUG_ON(node->count & RADIX_TREE_COUNT_MASK);
--
2.6.6
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-mm@kvack.org, Dan Williams <dan.j.williams@intel.com>,
linux-nvdimm@lists.01.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [RFC v3] [PATCH 0/18] DAX page fault locking
Date: Wed, 11 May 2016 11:19:30 +0200 [thread overview]
Message-ID: <20160511091930.GE14744@quack2.suse.cz> (raw)
In-Reply-To: <20160510223937.GA10222@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
On Tue 10-05-16 16:39:37, Ross Zwisler wrote:
> On Tue, May 10, 2016 at 02:30:03PM -0600, Ross Zwisler wrote:
> > On Tue, May 10, 2016 at 05:28:14PM +0200, Jan Kara wrote:
> > > On Mon 09-05-16 11:38:28, Jan Kara wrote:
> > > Somehow, I'm not able to reproduce the warnings... Anyway, I think I see
> > > what's going on. Can you check whether the warning goes away when you
> > > change the condition at the end of page_cache_tree_delete() to:
> > >
> > > if (!dax_mapping(mapping) && !workingset_node_pages(node) &&
> > > list_empty(&node->private_list)) {
> >
> > Yep, this took care of both of the issues that I reported. I'll restart my
> > testing with this in my baseline, but as of this fix I don't have any more
> > open testing issues. :)
>
> Well, looks like I spoke too soon. The two tests that were failing for me are
> now passing, but I can still create what looks like a related failure using
> XFS, DAX, and the two xfstests generic/231 and generic/232 run back-to-back.
Hum, full xfstests run completes for me just fine. Can you reproduce the
issue with the attached debug patch? Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
[-- Attachment #2: 0001-Debugging-workingset.patch --]
[-- Type: text/x-patch, Size: 0 bytes --]
next prev parent reply other threads:[~2016-05-11 9:19 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 21:35 [RFC v3] [PATCH 0/18] DAX page fault locking Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` [PATCH 01/18] ext4: Handle transient ENOSPC properly for DAX Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` [PATCH 02/18] ext4: Fix race in transient ENOSPC detection Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` [PATCH 03/18] DAX: move RADIX_DAX_ definitions to dax.c Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` [PATCH 04/18] dax: Remove complete_unwritten argument Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` [PATCH 05/18] ext2: Avoid DAX zeroing to corrupt data Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-29 16:30 ` Ross Zwisler
2016-04-29 16:30 ` Ross Zwisler
2016-04-29 16:30 ` Ross Zwisler
2016-04-18 21:35 ` [PATCH 06/18] dax: Remove dead zeroing code from fault handlers Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-29 16:48 ` Ross Zwisler
2016-04-18 21:35 ` [PATCH 07/18] ext4: Refactor direct IO code Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` [PATCH 08/18] ext4: Pre-zero allocated blocks for DAX IO Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-29 18:01 ` Ross Zwisler
2016-04-29 18:01 ` Ross Zwisler
2016-04-29 18:01 ` Ross Zwisler
2016-05-02 13:09 ` Jan Kara
2016-05-02 13:09 ` Jan Kara
2016-04-18 21:35 ` [PATCH 09/18] dax: Remove zeroing from dax_io() Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-29 18:56 ` Ross Zwisler
2016-04-29 18:56 ` Ross Zwisler
2016-04-18 21:35 ` [PATCH 10/18] dax: Remove pointless writeback from dax_do_io() Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-29 19:00 ` Ross Zwisler
2016-04-29 19:00 ` Ross Zwisler
2016-04-29 19:00 ` Ross Zwisler
2016-04-18 21:35 ` [PATCH 11/18] dax: Fix condition for filling of PMD holes Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-29 19:08 ` Ross Zwisler
2016-04-29 19:08 ` Ross Zwisler
2016-04-29 19:08 ` Ross Zwisler
2016-05-02 13:16 ` Jan Kara
2016-05-02 13:16 ` Jan Kara
2016-04-18 21:35 ` [PATCH 12/18] dax: Remove redundant inode size checks Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` [PATCH 13/18] dax: Make huge page handling depend of CONFIG_BROKEN Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-29 19:53 ` Ross Zwisler
2016-04-29 19:53 ` Ross Zwisler
2016-05-02 13:19 ` Jan Kara
2016-05-02 13:19 ` Jan Kara
2016-05-02 13:19 ` Jan Kara
2016-04-18 21:35 ` [PATCH 14/18] dax: Define DAX lock bit for radix tree exceptional entry Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-29 20:03 ` Ross Zwisler
2016-04-29 20:03 ` Ross Zwisler
2016-04-29 20:03 ` Ross Zwisler
2016-04-18 21:35 ` [PATCH 15/18] dax: Allow DAX code to replace exceptional entries Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-29 20:29 ` Ross Zwisler
2016-04-29 20:29 ` Ross Zwisler
2016-04-18 21:35 ` [PATCH 16/18] dax: New fault locking Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-27 4:27 ` NeilBrown
2016-04-27 4:27 ` NeilBrown
2016-05-06 4:13 ` Ross Zwisler
2016-05-06 4:13 ` Ross Zwisler
2016-05-06 4:13 ` Ross Zwisler
2016-05-10 12:27 ` Jan Kara
2016-05-10 12:27 ` Jan Kara
2016-05-11 19:26 ` Ross Zwisler
2016-05-11 19:26 ` Ross Zwisler
2016-05-12 7:58 ` Jan Kara
2016-05-12 7:58 ` Jan Kara
2016-04-18 21:35 ` [PATCH 17/18] dax: Use radix tree entry lock to protect cow faults Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-19 11:46 ` Jerome Glisse
2016-04-19 11:46 ` Jerome Glisse
2016-04-19 11:46 ` Jerome Glisse
2016-04-19 14:33 ` Jan Kara
2016-04-19 14:33 ` Jan Kara
2016-04-19 14:33 ` Jan Kara
2016-04-19 15:19 ` Jerome Glisse
2016-04-19 15:19 ` Jerome Glisse
2016-04-19 15:19 ` Jerome Glisse
2016-04-19 15:19 ` Jerome Glisse
2016-04-18 21:35 ` [PATCH 18/18] dax: Remove i_mmap_lock protection Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-04-18 21:35 ` Jan Kara
2016-05-06 3:35 ` [RFC v3] [PATCH 0/18] DAX page fault locking Ross Zwisler
2016-05-06 3:35 ` Ross Zwisler
2016-05-06 20:33 ` Ross Zwisler
2016-05-06 20:33 ` Ross Zwisler
2016-05-09 9:38 ` Jan Kara
2016-05-09 9:38 ` Jan Kara
2016-05-09 9:38 ` Jan Kara
2016-05-10 15:28 ` Jan Kara
2016-05-10 15:28 ` Jan Kara
2016-05-10 15:28 ` Jan Kara
2016-05-10 20:30 ` Ross Zwisler
2016-05-10 20:30 ` Ross Zwisler
2016-05-10 20:30 ` Ross Zwisler
2016-05-10 22:39 ` Ross Zwisler
2016-05-10 22:39 ` Ross Zwisler
2016-05-11 9:19 ` Jan Kara [this message]
2016-05-11 9:19 ` Jan Kara
2016-05-11 9:19 ` Jan Kara
2016-05-11 15:52 ` Ross Zwisler
2016-05-11 15:52 ` Ross Zwisler
2016-05-11 15:52 ` Ross Zwisler
2016-05-09 21:28 ` Verma, Vishal L
2016-05-10 11:52 ` Jan Kara
2016-05-10 11:52 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511091930.GE14744@quack2.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.