All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <tomi.valkeinen@ti.com>, <plagnioj@jcrosoft.com>,
	<robdclark@gmail.com>, <airlied@linux.ie>, <tony@atomide.com>
Cc: <linux-fbdev@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<laurent.pinchart@ideasonboard.com>, <jsarha@ti.com>,
	<dri-devel@lists.freedesktop.org>
Subject: [PATCH 11/26] drm/omap: connector-analog-tv: Support only Composite type in legacy boot
Date: Mon, 30 May 2016 14:42:43 +0300	[thread overview]
Message-ID: <20160530114258.30879-12-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20160530114258.30879-1-peter.ujfalusi@ti.com>

In legacy mode (non DT mode) support only composite connector type. The
only user for this is rx51, using composite type.
Dropping the connector_type selection via pdata will allow cleanups in
omapdss (drm vs fbdev).

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
index 8511c648a15c..d963b4a9cfc0 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
@@ -25,7 +25,6 @@ struct panel_drv_data {
 
 	struct omap_video_timings timings;
 
-	enum omap_dss_venc_type connector_type;
 	bool invert_polarity;
 };
 
@@ -45,10 +44,6 @@ static const struct omap_video_timings tvc_pal_timings = {
 
 static const struct of_device_id tvc_of_match[];
 
-struct tvc_of_data {
-	enum omap_dss_venc_type connector_type;
-};
-
 #define to_panel_data(x) container_of(x, struct panel_drv_data, dssdev)
 
 static int tvc_connect(struct omap_dss_device *dssdev)
@@ -99,7 +94,7 @@ static int tvc_enable(struct omap_dss_device *dssdev)
 	in->ops.atv->set_timings(in, &ddata->timings);
 
 	if (!ddata->dev->of_node) {
-		in->ops.atv->set_type(in, ddata->connector_type);
+		in->ops.atv->set_type(in, OMAP_DSS_VENC_TYPE_COMPOSITE);
 
 		in->ops.atv->invert_vid_out_polarity(in,
 			ddata->invert_polarity);
@@ -207,7 +202,6 @@ static int tvc_probe_pdata(struct platform_device *pdev)
 
 	ddata->in = in;
 
-	ddata->connector_type = pdata->connector_type;
 	ddata->invert_polarity = pdata->invert_polarity;
 
 	dssdev = &ddata->dssdev;
-- 
2.8.3

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: tomi.valkeinen@ti.com, plagnioj@jcrosoft.com,
	robdclark@gmail.com, airlied@linux.ie, tony@atomide.com
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com,
	jsarha@ti.com, dri-devel@lists.freedesktop.org
Subject: [PATCH 11/26] drm/omap: connector-analog-tv: Support only Composite type in legacy boot
Date: Mon, 30 May 2016 11:42:43 +0000	[thread overview]
Message-ID: <20160530114258.30879-12-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20160530114258.30879-1-peter.ujfalusi@ti.com>

In legacy mode (non DT mode) support only composite connector type. The
only user for this is rx51, using composite type.
Dropping the connector_type selection via pdata will allow cleanups in
omapdss (drm vs fbdev).

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
index 8511c648a15c..d963b4a9cfc0 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
@@ -25,7 +25,6 @@ struct panel_drv_data {
 
 	struct omap_video_timings timings;
 
-	enum omap_dss_venc_type connector_type;
 	bool invert_polarity;
 };
 
@@ -45,10 +44,6 @@ static const struct omap_video_timings tvc_pal_timings = {
 
 static const struct of_device_id tvc_of_match[];
 
-struct tvc_of_data {
-	enum omap_dss_venc_type connector_type;
-};
-
 #define to_panel_data(x) container_of(x, struct panel_drv_data, dssdev)
 
 static int tvc_connect(struct omap_dss_device *dssdev)
@@ -99,7 +94,7 @@ static int tvc_enable(struct omap_dss_device *dssdev)
 	in->ops.atv->set_timings(in, &ddata->timings);
 
 	if (!ddata->dev->of_node) {
-		in->ops.atv->set_type(in, ddata->connector_type);
+		in->ops.atv->set_type(in, OMAP_DSS_VENC_TYPE_COMPOSITE);
 
 		in->ops.atv->invert_vid_out_polarity(in,
 			ddata->invert_polarity);
@@ -207,7 +202,6 @@ static int tvc_probe_pdata(struct platform_device *pdev)
 
 	ddata->in = in;
 
-	ddata->connector_type = pdata->connector_type;
 	ddata->invert_polarity = pdata->invert_polarity;
 
 	dssdev = &ddata->dssdev;
-- 
2.8.3


WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: tomi.valkeinen@ti.com, plagnioj@jcrosoft.com,
	robdclark@gmail.com, airlied@linux.ie, tony@atomide.com
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com,
	jsarha@ti.com, dri-devel@lists.freedesktop.org
Subject: [PATCH 11/26] drm/omap: connector-analog-tv: Support only Composite type in legacy boot
Date: Mon, 30 May 2016 14:42:43 +0300	[thread overview]
Message-ID: <20160530114258.30879-12-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20160530114258.30879-1-peter.ujfalusi@ti.com>

In legacy mode (non DT mode) support only composite connector type. The
only user for this is rx51, using composite type.
Dropping the connector_type selection via pdata will allow cleanups in
omapdss (drm vs fbdev).

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
index 8511c648a15c..d963b4a9cfc0 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
@@ -25,7 +25,6 @@ struct panel_drv_data {
 
 	struct omap_video_timings timings;
 
-	enum omap_dss_venc_type connector_type;
 	bool invert_polarity;
 };
 
@@ -45,10 +44,6 @@ static const struct omap_video_timings tvc_pal_timings = {
 
 static const struct of_device_id tvc_of_match[];
 
-struct tvc_of_data {
-	enum omap_dss_venc_type connector_type;
-};
-
 #define to_panel_data(x) container_of(x, struct panel_drv_data, dssdev)
 
 static int tvc_connect(struct omap_dss_device *dssdev)
@@ -99,7 +94,7 @@ static int tvc_enable(struct omap_dss_device *dssdev)
 	in->ops.atv->set_timings(in, &ddata->timings);
 
 	if (!ddata->dev->of_node) {
-		in->ops.atv->set_type(in, ddata->connector_type);
+		in->ops.atv->set_type(in, OMAP_DSS_VENC_TYPE_COMPOSITE);
 
 		in->ops.atv->invert_vid_out_polarity(in,
 			ddata->invert_polarity);
@@ -207,7 +202,6 @@ static int tvc_probe_pdata(struct platform_device *pdev)
 
 	ddata->in = in;
 
-	ddata->connector_type = pdata->connector_type;
 	ddata->invert_polarity = pdata->invert_polarity;
 
 	dssdev = &ddata->dssdev;
-- 
2.8.3

  parent reply	other threads:[~2016-05-30 11:43 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-30 11:42 [PATCH 00/26] fb/drm: omapdss: Clean up the headers and separate the two stack Peter Ujfalusi
2016-05-30 11:42 ` Peter Ujfalusi
2016-05-30 11:42 ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 01/26] omapfb: panel-tpo-td028ttec1: Remove legacy boot support Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:56   ` Belisko Marek
2016-05-30 11:56     ` Belisko Marek
2016-05-30 12:35     ` Peter Ujfalusi
2016-05-30 12:35       ` Peter Ujfalusi
2016-05-30 12:35       ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 02/26] omapfb: panel-nec-nl8048hl11: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 03/26] omapfb: panel-tpo-td043mtea1: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 04/26] omapfb: panel-sharp-ls037v7dw01: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 05/26] omapfb: panel-lgphilips-lb035q02: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 06/26] omapfb: panel-dsi-cm: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 07/26] omapfb: connector-hdmi: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 08/26] omapfb: connector-dvi: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 09/26] omapfb: encoder-tfp410: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 10/26] omapdss: omap-panel-data.h: Remove struct omap_dss_device declaration Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` Peter Ujfalusi [this message]
2016-05-30 11:42   ` [PATCH 11/26] drm/omap: connector-analog-tv: Support only Composite type in legacy boot Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 12/26] omapfb: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 13/26] ARM: OMAP: rx51-video: Do not set TV connector_type Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 14/26] omapdss: omap-panel-data.h: Remove connector_type from atv pdata Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 15/26] ARM/video: omap2: Move omap_display_init declaration to mach-omap2/display.h Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 16/26] drm/omap: Remove reference to pdata->default_device Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 17/26] omapfb: " Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 18/26] video: omapdss: Remove unused members from struct omap_dss_board_info Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 19/26] video/platform_data: omapdss: Create new header file for platform data Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 20/26] ARM: OMAP2: Use the platform_data header for omapdss Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 21/26] omapdss: hdmi audio: Make header file independent of video/omapdss.h Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 22/26] drm/omap: Do not include video/omapdss.h directly in drivers Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 23/26] omapfb: Create new header file for omapfb DSS implementation Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 24/26] [media] omap_vout: Switch to use the video/omapfb_dss.h header file Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 25/26] omapfb: Copy video/omapdss.h content to video/omapfb_dss.h Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42 ` [PATCH 26/26] drm/omap: Remove the video/omapdss.h and move it's content to local header file Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 11:42   ` Peter Ujfalusi
2016-05-30 14:26 ` [PATCH 00/26] fb/drm: omapdss: Clean up the headers and separate the two stack Tomi Valkeinen
2016-05-30 14:26   ` Tomi Valkeinen
2016-05-30 14:26   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160530114258.30879-12-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=robdclark@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.