All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	devicetree@vger.kernel.org, magnus.damm@gmail.com,
	linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 13/13] ARM: dts: blanche: add Ethernet support
Date: Wed, 1 Jun 2016 10:24:51 +0900	[thread overview]
Message-ID: <20160601012451.GL20527@verge.net.au> (raw)
In-Reply-To: <1669958.qjJ7i3NBPv@wasted.cogentembedded.com>

On Wed, Jun 01, 2016 at 01:33:49AM +0300, Sergei Shtylyov wrote:
> R8A7792  SoC  doesn't have the EtherMAC core, so SMSC  LAN89218  Ethernet
> chip was used instead on the Blanche board; this chip  is compatible with
> SMSC LAN9115  for  which there's a (device tree aware) driver. Describe
> the  chip in  the  Blanche device tree;  enable DHCP and NFS root in the
> kernel command line for the kernel booting.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

At this time I do not have access to documentation or hardware for this
board. So I am relying on you to test this and make sure it complies
with the spec.

What you have looks reasonable to me:

Acked-by: Simon Horman <horms+renesas@verge.net.au>

WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/13] ARM: dts: blanche: add Ethernet support
Date: Wed, 1 Jun 2016 10:24:51 +0900	[thread overview]
Message-ID: <20160601012451.GL20527@verge.net.au> (raw)
In-Reply-To: <1669958.qjJ7i3NBPv@wasted.cogentembedded.com>

On Wed, Jun 01, 2016 at 01:33:49AM +0300, Sergei Shtylyov wrote:
> R8A7792  SoC  doesn't have the EtherMAC core, so SMSC  LAN89218  Ethernet
> chip was used instead on the Blanche board; this chip  is compatible with
> SMSC LAN9115  for  which there's a (device tree aware) driver. Describe
> the  chip in  the  Blanche device tree;  enable DHCP and NFS root in the
> kernel command line for the kernel booting.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

At this time I do not have access to documentation or hardware for this
board. So I am relying on you to test this and make sure it complies
with the spec.

What you have looks reasonable to me:

Acked-by: Simon Horman <horms+renesas@verge.net.au>

  reply	other threads:[~2016-06-01  1:24 UTC|newest]

Thread overview: 147+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 22:06 [PATCH 00/13] Add R8A7794/SILK board eMMC DT support Sergei Shtylyov
2016-05-31 22:06 ` Sergei Shtylyov
2016-05-31 22:09 ` [PATCH 01/13] ARM: shmobile: r8a7792: add clock index macros Sergei Shtylyov
2016-06-01  0:52   ` Simon Horman
2016-06-01 13:57     ` Sergei Shtylyov
2016-06-22 19:52     ` Sergei Shtylyov
2016-06-22 22:33       ` Simon Horman
     [not found]         ` <20160622223330.GA15843-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2016-06-23  7:46           ` Geert Uytterhoeven
2016-06-23  7:46             ` Geert Uytterhoeven
2016-06-23 10:49           ` Sergei Shtylyov
2016-06-23 10:49             ` Sergei Shtylyov
     [not found]   ` <2280165.siMXMbFrFe-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01  7:22     ` Geert Uytterhoeven
2016-06-01  7:22       ` Geert Uytterhoeven
2016-06-01 14:09       ` Sergei Shtylyov
2016-05-31 22:11 ` [PATCH 02/13] ARM: shmobile: r8a7792: add power domain " Sergei Shtylyov
2016-06-01  7:32   ` Geert Uytterhoeven
2016-05-31 22:15 ` [PATCH 03/13] soc: renesas: rcar-sysc: add R8A7792 support Sergei Shtylyov
2016-06-01  7:38   ` Geert Uytterhoeven
2016-05-31 22:18 ` [PATCH 04/13] ARM: shmobile: r8a7792: basic SoC support Sergei Shtylyov
2016-05-31 22:18   ` Sergei Shtylyov
2016-06-01  0:25   ` Simon Horman
2016-06-01  0:25     ` Simon Horman
2016-06-01  7:47   ` Geert Uytterhoeven
2016-06-01  7:47     ` Geert Uytterhoeven
2016-06-01 21:00     ` Sergei Shtylyov
2016-06-01 21:00       ` Sergei Shtylyov
2016-06-06 18:59   ` Sergei Shtylyov
2016-06-06 18:59     ` Sergei Shtylyov
2016-05-31 22:20 ` [PATCH 05/13] DT: clock: rcar-gen2-cpg-clocks: document R8A7792 support Sergei Shtylyov
2016-06-01  0:25   ` Simon Horman
2016-06-01  0:30     ` Simon Horman
2016-06-01  7:50     ` Geert Uytterhoeven
2016-06-01  7:48   ` Geert Uytterhoeven
2016-06-03  1:49   ` Rob Herring
2016-05-31 22:21 ` [PATCH 06/13] DT: clock: cpg-mstp-clocks: document-R8A7792-support Sergei Shtylyov
2016-06-01  0:28   ` Simon Horman
2016-06-01  7:51   ` Geert Uytterhoeven
2016-06-03  1:50   ` Rob Herring
2016-05-31 22:24 ` [PATCH 07/13] ARM: dts: r8a7792: initial SoC device tree Sergei Shtylyov
2016-05-31 22:24   ` Sergei Shtylyov
2016-06-01  0:57   ` Simon Horman
2016-06-01  0:57     ` Simon Horman
2016-06-01 14:00     ` Sergei Shtylyov
2016-06-01 14:00       ` Sergei Shtylyov
2016-06-06 22:26     ` Sergei Shtylyov
2016-06-06 22:26       ` Sergei Shtylyov
2016-06-07  7:13       ` Geert Uytterhoeven
2016-06-07  7:13         ` Geert Uytterhoeven
2016-06-07 20:58         ` Sergei Shtylyov
2016-06-07 20:58           ` Sergei Shtylyov
2016-06-10  1:02           ` Simon Horman
2016-06-10  1:02             ` Simon Horman
2016-06-10 19:29             ` Sergei Shtylyov
2016-06-10 19:29               ` Sergei Shtylyov
2016-06-10 20:42               ` Geert Uytterhoeven
2016-06-10 20:42                 ` Geert Uytterhoeven
2016-06-10 20:50                 ` Sergei Shtylyov
2016-06-10 20:50                   ` Sergei Shtylyov
2016-06-13  7:12                   ` Geert Uytterhoeven
2016-06-13  7:12                     ` Geert Uytterhoeven
2016-06-13 11:24                     ` Sergei Shtylyov
2016-06-13 11:24                       ` Sergei Shtylyov
     [not found]                       ` <7d93d81d-cca9-e434-6488-0ea839f81663-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-13 11:48                         ` Geert Uytterhoeven
2016-06-13 11:48                           ` Geert Uytterhoeven
2016-06-13 11:48                           ` Geert Uytterhoeven
2016-06-14  1:08                     ` Kuninori Morimoto
2016-06-14  1:08                       ` Kuninori Morimoto
2016-06-17  2:14                       ` Kuninori Morimoto
2016-06-17  2:14                         ` Kuninori Morimoto
2016-06-17  6:27                         ` Geert Uytterhoeven
2016-06-17  6:27                           ` Geert Uytterhoeven
     [not found]               ` <8efb1c7e-5463-2556-744c-d327886d92d4-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-14  0:43                 ` Simon Horman
2016-06-14  0:43                   ` Simon Horman
2016-06-14  0:43                   ` Simon Horman
2016-06-14 21:08                   ` Sergei Shtylyov
2016-06-14 21:08                     ` Sergei Shtylyov
2016-06-16  0:06                     ` Simon Horman
2016-06-16  0:06                       ` Simon Horman
2016-06-01  9:23   ` Geert Uytterhoeven
2016-06-01  9:23     ` Geert Uytterhoeven
2016-05-31 22:25 ` [PATCH 08/13] ARM: dts: r8a7792: add SYS-DMAC support Sergei Shtylyov
2016-05-31 22:25   ` Sergei Shtylyov
2016-06-01  1:03   ` Simon Horman
2016-06-01  1:03     ` Simon Horman
     [not found]   ` <5621267.GpvUaW18zI-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01  8:15     ` Geert Uytterhoeven
2016-06-01  8:15       ` Geert Uytterhoeven
2016-06-01  8:15       ` Geert Uytterhoeven
2016-05-31 22:26 ` [PATCH 09/13] ARM: dts: r8a7792: add [H]SCIF support Sergei Shtylyov
2016-05-31 22:26   ` Sergei Shtylyov
2016-06-01  1:13   ` Simon Horman
2016-06-01  1:13     ` Simon Horman
2016-06-03 14:33     ` Sergei Shtylyov
2016-06-03 14:33       ` Sergei Shtylyov
2016-06-01  8:17   ` Geert Uytterhoeven
2016-06-01  8:17     ` Geert Uytterhoeven
2016-05-31 22:29 ` [PATCH 10/13] ARM: dts: r8a7792: add IRQC support Sergei Shtylyov
2016-05-31 22:29   ` Sergei Shtylyov
2016-06-01  1:18   ` Simon Horman
2016-06-01  1:18     ` Simon Horman
2016-06-01 14:02     ` Sergei Shtylyov
2016-06-01 14:02       ` Sergei Shtylyov
     [not found]   ` <3573091.BUvyGW3hVt-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01  8:17     ` Geert Uytterhoeven
2016-06-01  8:17       ` Geert Uytterhoeven
2016-06-01  8:17       ` Geert Uytterhoeven
2016-05-31 22:30 ` [PATCH 11/13] DT: arm: shmobile: document Blanche board Sergei Shtylyov
2016-05-31 23:51   ` Simon Horman
     [not found]     ` <20160531235119.GA20527-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2016-06-01 13:34       ` Sergei Shtylyov
2016-06-01 13:34         ` Sergei Shtylyov
2016-06-01  8:19   ` Geert Uytterhoeven
2016-06-03  1:50   ` Rob Herring
2016-05-31 22:32 ` [PATCH 12/13] ARM: dts: blanche: initial device tree Sergei Shtylyov
2016-05-31 22:32   ` Sergei Shtylyov
2016-06-01  1:21   ` Simon Horman
2016-06-01  1:21     ` Simon Horman
2016-06-02 21:34     ` Sergei Shtylyov
2016-06-02 21:34       ` Sergei Shtylyov
2016-06-01  8:36   ` Geert Uytterhoeven
2016-06-01  8:36     ` Geert Uytterhoeven
2016-06-01  8:36     ` Geert Uytterhoeven
2016-05-31 22:33 ` [PATCH 13/13] ARM: dts: blanche: add Ethernet support Sergei Shtylyov
2016-05-31 22:33   ` Sergei Shtylyov
2016-06-01  1:24   ` Simon Horman [this message]
2016-06-01  1:24     ` Simon Horman
     [not found]   ` <1669958.qjJ7i3NBPv-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01  8:22     ` Geert Uytterhoeven
2016-06-01  8:22       ` Geert Uytterhoeven
2016-06-01  8:22       ` Geert Uytterhoeven
2016-06-01 12:16       ` Sergei Shtylyov
2016-06-01 12:16         ` Sergei Shtylyov
     [not found]         ` <a60346f2-2abb-342b-dd20-38d401c4ceb3-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-01 12:27           ` Geert Uytterhoeven
2016-06-01 12:27             ` Geert Uytterhoeven
2016-06-01 12:27             ` Geert Uytterhoeven
2016-06-02 21:33             ` Sergei Shtylyov
2016-06-02 21:33               ` Sergei Shtylyov
     [not found] ` <13205049.n7pM8utpHF-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01  7:04   ` [PATCH 00/13] Add R8A7794/SILK board eMMC DT support Geert Uytterhoeven
2016-06-01  7:04     ` Geert Uytterhoeven
2016-06-01  7:04     ` Geert Uytterhoeven
2016-06-01 10:30     ` Sergei Shtylyov
2016-06-01 10:30       ` Sergei Shtylyov
  -- strict thread matches above, loose matches on Subject: below --
2016-05-21 10:17 [PATCH v2 1/2] ip6_gre: Fix MTU setting for ip6gretap Haishuang Yan
2016-05-21 10:17 ` [PATCH v2 2/2] ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit path Haishuang Yan
2016-05-24 21:34   ` David Miller
2016-05-24 21:34     ` [PATCH v2 2/2] ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit path., Re: [PATCH] ARM: shmobile: rcar-gen2: Use ICRAM1 for jump stub on all SoCs, [PATCH 12/13] ARM: dts: blanche: initial device tree David Miller, Simon Horman, Sergei Shtylyov
2016-05-24 21:34 ` [PATCH v2 1/2] ip6_gre: Fix MTU setting for ip6gretap David Miller
2016-05-17 15:15 [PATCH] ARM: shmobile: rcar-gen2: Use ICRAM1 for jump stub on all SoCs Geert Uytterhoeven
2016-05-17 15:15 ` Geert Uytterhoeven
2016-05-25  1:01 ` Simon Horman
2016-05-25  1:01   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160601012451.GL20527@verge.net.au \
    --to=horms@verge.net.au \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.