From: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: hzpeterchen@gmail.com, Ulf Hansson <ulf.hansson@linaro.org>, Sebastian Reichel <sre@kernel.org>, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Javier Martinez Canillas <javier@osg.samsung.com>, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pm@vger.kernel.or, Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Kukjin Kim <kgene@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Subject: Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property Date: Thu, 2 Jun 2016 21:02:18 -0500 [thread overview] Message-ID: <20160603020218.GA19436@rob-hp-laptop> (raw) In-Reply-To: <1464768141-25420-7-git-send-email-k.kozlowski@samsung.com> On Wed, Jun 01, 2016 at 10:02:15AM +0200, Krzysztof Kozlowski wrote: > Some devices need real hard-reset by cutting the power. During power > sequence turn off and on the regulator, if it is provided. > > Additionally add support for instantiating the pwrseq-simple device on a > generic property 'power-sequence'. The device will attach itself to the > node containing the property and parse the node's properties like > reset-gpios, ext-supply etc. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > .../bindings/power/pwrseq/pwrseq-simple.txt | 29 +++++++- > drivers/power/pwrseq/pwrseq_simple.c | 85 +++++++++++++++++++++- > 2 files changed, 107 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt b/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt > index ce0e76749671..a8c3f13ee83f 100644 > --- a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt > +++ b/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt > @@ -1,11 +1,17 @@ > -* The simple MMC power sequence provider > +* The simple power sequence provider > > -The purpose of the simple MMC power sequence provider is to supports a set of > +The purpose of the simple power sequence provider is to supports a set of > common properties between various SOC designs. It thus enables us to use the > same provider for several SOC designs. > > -Required properties: > -- compatible : contains "mmc-pwrseq-simple". > +The driver supports two types of bindings: > +1. Separate node > + Required properties: > + - compatible : contains "mmc-pwrseq-simple". Please note that this is not recommended for new users. > + > +2. Property for any node > + Required properties: > + - power-sequence > > Optional properties: > - reset-gpios : contains a list of GPIO specifiers. The reset GPIOs are asserted > @@ -16,6 +22,7 @@ Optional properties: > See ../clocks/clock-bindings.txt for details. > - clock-names : Must include the following entry: > "ext_clock" (External clock provided to the card). > +- ext-supply : External regulator supply What happens when there are 2 supplies? I'd prefer the name not be genericish and use the real supply names. Then the power seq code should just turn on all supplies it finds. If the order or timing to turn on matters, then sorry, no generic sequence. > > Example: > > @@ -24,4 +31,18 @@ Example: > reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; > clocks = <&clk_32768_ck>; > clock-names = "ext_clock"; > + ext-supply = <&buck8>; > } > + > + usb3503@08 { > + compatible = "smsc,usb3503"; > + reg = <0x08>; > + > + intn-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>; > + connect-gpios = <&gpx3 4 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpx3 5 GPIO_ACTIVE_HIGH>; > + initial-mode = <1>; > + > + power-sequence; > + ext-supply = <&buck8_reg>; > + };
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property Date: Thu, 2 Jun 2016 21:02:18 -0500 [thread overview] Message-ID: <20160603020218.GA19436@rob-hp-laptop> (raw) In-Reply-To: <1464768141-25420-7-git-send-email-k.kozlowski@samsung.com> On Wed, Jun 01, 2016 at 10:02:15AM +0200, Krzysztof Kozlowski wrote: > Some devices need real hard-reset by cutting the power. During power > sequence turn off and on the regulator, if it is provided. > > Additionally add support for instantiating the pwrseq-simple device on a > generic property 'power-sequence'. The device will attach itself to the > node containing the property and parse the node's properties like > reset-gpios, ext-supply etc. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > .../bindings/power/pwrseq/pwrseq-simple.txt | 29 +++++++- > drivers/power/pwrseq/pwrseq_simple.c | 85 +++++++++++++++++++++- > 2 files changed, 107 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt b/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt > index ce0e76749671..a8c3f13ee83f 100644 > --- a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt > +++ b/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt > @@ -1,11 +1,17 @@ > -* The simple MMC power sequence provider > +* The simple power sequence provider > > -The purpose of the simple MMC power sequence provider is to supports a set of > +The purpose of the simple power sequence provider is to supports a set of > common properties between various SOC designs. It thus enables us to use the > same provider for several SOC designs. > > -Required properties: > -- compatible : contains "mmc-pwrseq-simple". > +The driver supports two types of bindings: > +1. Separate node > + Required properties: > + - compatible : contains "mmc-pwrseq-simple". Please note that this is not recommended for new users. > + > +2. Property for any node > + Required properties: > + - power-sequence > > Optional properties: > - reset-gpios : contains a list of GPIO specifiers. The reset GPIOs are asserted > @@ -16,6 +22,7 @@ Optional properties: > See ../clocks/clock-bindings.txt for details. > - clock-names : Must include the following entry: > "ext_clock" (External clock provided to the card). > +- ext-supply : External regulator supply What happens when there are 2 supplies? I'd prefer the name not be genericish and use the real supply names. Then the power seq code should just turn on all supplies it finds. If the order or timing to turn on matters, then sorry, no generic sequence. > > Example: > > @@ -24,4 +31,18 @@ Example: > reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; > clocks = <&clk_32768_ck>; > clock-names = "ext_clock"; > + ext-supply = <&buck8>; > } > + > + usb3503 at 08 { > + compatible = "smsc,usb3503"; > + reg = <0x08>; > + > + intn-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>; > + connect-gpios = <&gpx3 4 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpx3 5 GPIO_ACTIVE_HIGH>; > + initial-mode = <1>; > + > + power-sequence; > + ext-supply = <&buck8_reg>; > + };
next prev parent reply other threads:[~2016-06-03 2:02 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-01 8:02 [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting) Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 01/12] power/mmc: Move pwrseq drivers to power/pwrseq Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 02/12] MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 03/12] power: pwrseq: Enable COMPILE_TEST for drivers Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 04/12] power: pwrseq: Remove mmc prefix from mmc_pwrseq Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 05/12] power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-03 2:02 ` Rob Herring [this message] 2016-06-03 2:02 ` Rob Herring 2016-06-03 12:35 ` Krzysztof Kozlowski 2016-06-03 12:35 ` Krzysztof Kozlowski 2016-06-06 3:22 ` Peter Chen 2016-06-06 3:22 ` Peter Chen 2016-06-07 9:29 ` Krzysztof Kozlowski 2016-06-07 9:29 ` Krzysztof Kozlowski 2016-06-07 9:29 ` Krzysztof Kozlowski 2016-06-08 19:03 ` Rob Herring 2016-06-08 19:03 ` Rob Herring 2016-06-09 2:34 ` Chen-Yu Tsai 2016-06-09 2:34 ` Chen-Yu Tsai 2016-06-09 2:34 ` Chen-Yu Tsai 2016-06-09 5:11 ` Krzysztof Kozlowski 2016-06-09 5:11 ` Krzysztof Kozlowski 2016-06-09 5:11 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 07/12] power: pwrseq: Add support for USB hubs with external power Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 08/12] usb: hub: Handle deferred probe Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 09/12] EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:57 ` Stephen Boyd 2016-06-01 8:57 ` Stephen Boyd 2016-06-01 8:57 ` Stephen Boyd 2016-06-01 9:06 ` Krzysztof Kozlowski 2016-06-01 9:06 ` Krzysztof Kozlowski 2016-06-01 12:05 ` Peter Chen 2016-06-01 12:05 ` Peter Chen 2016-06-01 18:16 ` Stephen Boyd 2016-06-01 18:16 ` Stephen Boyd 2016-06-02 1:24 ` Peter Chen 2016-06-02 1:24 ` Peter Chen 2016-06-02 23:59 ` Stephen Boyd 2016-06-02 23:59 ` Stephen Boyd 2016-06-01 8:02 ` [PATCH v3 10/12] EXAMPLE CODE: usb: hub: Power sequence the ports on activation Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 11/12] ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3 Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 8:02 ` [PATCH v3 12/12] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization " Krzysztof Kozlowski 2016-06-01 8:02 ` Krzysztof Kozlowski 2016-06-01 11:59 ` Peter Chen 2016-06-01 11:59 ` Peter Chen 2016-06-02 7:26 ` Krzysztof Kozlowski 2016-06-02 7:26 ` Krzysztof Kozlowski 2016-06-02 7:58 ` Peter Chen 2016-06-02 7:58 ` Peter Chen 2016-06-06 20:43 ` [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting) Heiko Stübner 2016-06-06 20:43 ` Heiko Stübner 2016-06-07 6:03 ` Krzysztof Kozlowski 2016-06-07 6:03 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160603020218.GA19436@rob-hp-laptop \ --to=robh@kernel.org \ --cc=b.zolnierkie@samsung.com \ --cc=dbaryshkov@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=dwmw2@infradead.org \ --cc=galak@codeaurora.org \ --cc=gregkh@linuxfoundation.org \ --cc=hzpeterchen@gmail.com \ --cc=ijc+devicetree@hellion.org.uk \ --cc=javier@osg.samsung.com \ --cc=k.kozlowski@samsung.com \ --cc=kgene@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-pm@vger.kernel.or \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=sre@kernel.org \ --cc=stern@rowland.harvard.edu \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.