From: Bjorn Helgaas <bhelgaas@google.com> To: linux-pci@vger.kernel.org Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>, "Rob Herring" <robh@kernel.org>, "Jason Cooper" <jason@lakedaemon.net>, "Scott Branden" <sbranden@broadcom.com>, "Jon Mason" <jonmason@broadcom.com>, "Jingoo Han" <jingoohan1@gmail.com>, "Pratyush Anand" <pratyush.anand@gmail.com>, linux-kernel@vger.kernel.org, rfi@lists.rocketboards.org, linux-renesas-soc@vger.kernel.org, "Simon Horman" <horms@verge.net.au>, "Thierry Reding" <thierry.reding@gmail.com>, "Tanmay Inamdar" <tinamdar@apm.com>, "Ray Jui" <rjui@broadcom.com>, linux-tegra@vger.kernel.org, "Ley Foon Tan" <lftan@altera.com>, "Michal Simek" <michal.simek@xilinx.com>, "Sören Brinkmann" <soren.brinkmann@xilinx.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v1 24/25] PCI: versatile: Request host bridge window resources with core function Date: Mon, 06 Jun 2016 18:07:44 -0500 [thread overview] Message-ID: <20160606230744.20936.46906.stgit@bhelgaas-glaptop2.roam.corp.google.com> (raw) In-Reply-To: <20160606225630.20936.77349.stgit@bhelgaas-glaptop2.roam.corp.google.com> Use devm_request_pci_bus_resources() to request host bridge window resources instead of doing it by hand in the driver. No functional change intended. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/pci/host/pci-versatile.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c index f843a72..273edac 100644 --- a/drivers/pci/host/pci-versatile.c +++ b/drivers/pci/host/pci-versatile.c @@ -80,12 +80,15 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev, if (err) return err; + err = devm_request_pci_bus_resources(dev, res); + if (err) + goto out_release_res; + resource_list_for_each_entry(win, res) { - struct resource *parent, *res = win->res; + struct resource *res = win->res; switch (resource_type(res)) { case IORESOURCE_IO: - parent = &ioport_resource; err = pci_remap_iospace(res, iobase); if (err) { dev_warn(dev, "error %d: failed to map resource %pR\n", @@ -94,7 +97,6 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev, } break; case IORESOURCE_MEM: - parent = &iomem_resource; res_valid |= !(res->flags & IORESOURCE_PREFETCH); writel(res->start >> 28, PCI_IMAP(mem)); @@ -106,10 +108,6 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev, default: continue; } - - err = devm_request_resource(dev, parent, res); - if (err) - goto out_release_res; } if (!res_valid) {
WARNING: multiple messages have this Message-ID (diff)
From: bhelgaas@google.com (Bjorn Helgaas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v1 24/25] PCI: versatile: Request host bridge window resources with core function Date: Mon, 06 Jun 2016 18:07:44 -0500 [thread overview] Message-ID: <20160606230744.20936.46906.stgit@bhelgaas-glaptop2.roam.corp.google.com> (raw) In-Reply-To: <20160606225630.20936.77349.stgit@bhelgaas-glaptop2.roam.corp.google.com> Use devm_request_pci_bus_resources() to request host bridge window resources instead of doing it by hand in the driver. No functional change intended. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/pci/host/pci-versatile.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c index f843a72..273edac 100644 --- a/drivers/pci/host/pci-versatile.c +++ b/drivers/pci/host/pci-versatile.c @@ -80,12 +80,15 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev, if (err) return err; + err = devm_request_pci_bus_resources(dev, res); + if (err) + goto out_release_res; + resource_list_for_each_entry(win, res) { - struct resource *parent, *res = win->res; + struct resource *res = win->res; switch (resource_type(res)) { case IORESOURCE_IO: - parent = &ioport_resource; err = pci_remap_iospace(res, iobase); if (err) { dev_warn(dev, "error %d: failed to map resource %pR\n", @@ -94,7 +97,6 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev, } break; case IORESOURCE_MEM: - parent = &iomem_resource; res_valid |= !(res->flags & IORESOURCE_PREFETCH); writel(res->start >> 28, PCI_IMAP(mem)); @@ -106,10 +108,6 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev, default: continue; } - - err = devm_request_resource(dev, parent, res); - if (err) - goto out_release_res; } if (!res_valid) {
next prev parent reply other threads:[~2016-06-06 23:07 UTC|newest] Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-06 23:04 [PATCH v1 00/25] PCI: Request host bridge window resources Bjorn Helgaas 2016-06-06 23:04 ` Bjorn Helgaas 2016-06-06 23:04 ` Bjorn Helgaas 2016-06-06 23:04 ` [PATCH v1 01/25] PCI: Add devm_request_pci_bus_resources() Bjorn Helgaas 2016-06-06 23:04 ` Bjorn Helgaas 2016-06-06 23:04 ` Bjorn Helgaas 2016-06-06 23:05 ` [PATCH v1 02/25] PCI: designware: Free bridge resource list on failure Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` [PATCH v1 03/25] PCI: designware: Request host bridge window resources Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` [PATCH v1 04/25] PCI: designware: Simplify host bridge window iteration Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` [PATCH v1 05/25] PCI: iproc: Request host bridge window resources Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` [PATCH v1 06/25] PCI: xgene: Free bridge resource list on failure Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` [PATCH v1 08/25] PCI: xilinx: " Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` [PATCH v1 09/25] PCI: xilinx: Request host bridge window resources Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` [PATCH v1 10/25] PCI: xilinx-nwl: Free bridge resource list on failure Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:06 ` [PATCH v1 11/25] PCI: xilinx-nwl: Request host bridge window resources Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` [PATCH v1 12/25] PCI: xilinx-nwl: Use dev_printk() when possible Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` [PATCH v1 13/25] PCI: altera: Request host bridge window resources with core function Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` [PATCH v1 14/25] PCI: altera: Simplify host bridge window iteration Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` [PATCH v1 15/25] PCI: generic: Free resource list close to where it's allocated Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas [not found] ` <20160606230636.20936.29083.stgit-1RhO1Y9PlrlHTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org> 2016-06-20 16:56 ` Tyler Baker 2016-06-20 16:56 ` Tyler Baker 2016-06-20 16:56 ` Tyler Baker 2016-06-20 16:56 ` Tyler Baker [not found] ` <CANMBJr41muA9mTNAa6MtWuMmeNLQxT4NjLe45=ExdFiH8vwzyw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-06-20 17:22 ` Lorenzo Pieralisi 2016-06-20 17:22 ` Lorenzo Pieralisi 2016-06-20 17:22 ` Lorenzo Pieralisi 2016-06-20 17:22 ` Lorenzo Pieralisi 2016-06-21 15:14 ` Bjorn Helgaas 2016-06-21 15:14 ` Bjorn Helgaas 2016-06-21 15:14 ` Bjorn Helgaas 2016-06-06 23:06 ` [PATCH v1 16/25] PCI: generic: Request host bridge window resources with core function Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` [PATCH v1 17/25] PCI: generic: Simplify host bridge window iteration Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:06 ` [PATCH v1 18/25] PCI: mvebu: Request host bridge window resources with core function Bjorn Helgaas 2016-06-06 23:06 ` Bjorn Helgaas 2016-06-06 23:07 ` [PATCH v1 19/25] PCI: rcar Gen2: Request host bridge window resources Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-21 10:41 ` Geert Uytterhoeven 2016-06-21 10:41 ` Geert Uytterhoeven 2016-06-21 14:26 ` Bjorn Helgaas 2016-06-21 14:26 ` Bjorn Helgaas 2016-06-21 14:26 ` Bjorn Helgaas 2016-06-21 14:26 ` Bjorn Helgaas 2016-06-21 15:41 ` Valentine Barshak 2016-06-21 15:41 ` Valentine Barshak [not found] ` <20160621154100.GA4782-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-06-21 16:49 ` Bjorn Helgaas 2016-06-21 16:49 ` Bjorn Helgaas 2016-06-21 16:49 ` Bjorn Helgaas 2016-06-24 14:19 ` Geert Uytterhoeven 2016-06-24 14:19 ` Geert Uytterhoeven 2016-06-24 14:19 ` Geert Uytterhoeven 2016-06-06 23:07 ` [PATCH v1 21/25] PCI: rcar: Simplify host bridge window iteration Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-06 23:07 ` [PATCH v1 22/25] PCI: tegra: Remove top-level resource from hierarchy Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-06 23:07 ` [PATCH v1 23/25] PCI: tegra: Request host bridge window resources with core function Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas [this message] 2016-06-06 23:07 ` [PATCH v1 24/25] PCI: versatile: " Bjorn Helgaas 2016-06-06 23:07 ` [PATCH v1 25/25] PCI: versatile: Simplify host bridge window iteration Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-07 8:21 ` [PATCH v1 00/25] PCI: Request host bridge window resources Arnd Bergmann 2016-06-07 8:21 ` Arnd Bergmann 2016-06-07 13:11 ` Bjorn Helgaas 2016-06-07 13:11 ` Bjorn Helgaas 2016-06-07 13:25 ` Arnd Bergmann 2016-06-07 13:25 ` Arnd Bergmann 2016-06-07 13:25 ` Arnd Bergmann 2016-06-07 23:34 ` Bjorn Helgaas 2016-06-07 23:34 ` Bjorn Helgaas 2016-06-07 23:34 ` Bjorn Helgaas 2016-06-07 23:34 ` Bjorn Helgaas 2016-06-18 17:58 ` Bjorn Helgaas 2016-06-18 17:58 ` Bjorn Helgaas [not found] ` <20160606225630.20936.77349.stgit-1RhO1Y9PlrlHTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org> 2016-06-06 23:05 ` [PATCH v1 07/25] PCI: xgene: " Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:05 ` Bjorn Helgaas 2016-06-06 23:07 ` [PATCH v1 20/25] PCI: rcar: Request host bridge window resources with core function Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-06 23:07 ` Bjorn Helgaas 2016-06-10 19:00 ` [PATCH v1 00/25] PCI: Request host bridge window resources Duc Dang 2016-07-05 4:37 ` Duc Dang 2016-06-10 19:00 ` Duc Dang 2016-06-18 18:07 ` Bjorn Helgaas 2016-06-18 18:07 ` Bjorn Helgaas 2016-06-18 18:07 ` Bjorn Helgaas 2016-06-21 11:58 ` wangyijing 2016-06-21 11:58 ` wangyijing 2016-06-21 15:03 ` Bjorn Helgaas 2016-06-21 15:03 ` Bjorn Helgaas 2016-06-21 15:03 ` Bjorn Helgaas 2016-06-21 15:03 ` Bjorn Helgaas 2016-06-22 1:07 ` wangyijing 2016-06-22 1:07 ` wangyijing
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160606230744.20936.46906.stgit@bhelgaas-glaptop2.roam.corp.google.com \ --to=bhelgaas@google.com \ --cc=horms@verge.net.au \ --cc=jason@lakedaemon.net \ --cc=jingoohan1@gmail.com \ --cc=jonmason@broadcom.com \ --cc=lftan@altera.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=pratyush.anand@gmail.com \ --cc=rfi@lists.rocketboards.org \ --cc=rjui@broadcom.com \ --cc=robh@kernel.org \ --cc=sbranden@broadcom.com \ --cc=soren.brinkmann@xilinx.com \ --cc=thierry.reding@gmail.com \ --cc=thomas.petazzoni@free-electrons.com \ --cc=tinamdar@apm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.