From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, keith.busch@intel.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields
Date: Tue, 7 Jun 2016 10:10:09 +0200 [thread overview]
Message-ID: <20160607081009.xd7wsyfuv4swuf4p@c203.arch.suse.de> (raw)
In-Reply-To: <1465248052-17811-2-git-send-email-hch@lst.de>
On Mon, Jun 06, 2016 at 11:20:43PM +0200, Christoph Hellwig wrote:
> These have been added in NVMe 1.2 and we'll need at least oaes for the
> NVMe target driver.
>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Jay Freyensee <james.p.freyensee@intel.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> include/linux/nvme.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 7d51b29..ff5ebc3 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -107,7 +107,10 @@ struct nvme_id_ctrl {
> __u8 mdts;
> __le16 cntlid;
> __le32 ver;
> - __u8 rsvd84[172];
> + __le32 rtd3r;
> + __le32 rtd3e;
> + __le32 oaes;
Just out of curiosity, why not CTRATT as well?
> + __u8 rsvd96[160];
> __le16 oacs;
> __u8 acl;
> __u8 aerl;
> --
> 2.1.4
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, keith.busch@intel.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields
Date: Tue, 7 Jun 2016 10:10:09 +0200 [thread overview]
Message-ID: <20160607081009.xd7wsyfuv4swuf4p@c203.arch.suse.de> (raw)
In-Reply-To: <1465248052-17811-2-git-send-email-hch@lst.de>
On Mon, Jun 06, 2016 at 11:20:43PM +0200, Christoph Hellwig wrote:
> These have been added in NVMe 1.2 and we'll need at least oaes for the
> NVMe target driver.
>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Jay Freyensee <james.p.freyensee@intel.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> include/linux/nvme.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 7d51b29..ff5ebc3 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -107,7 +107,10 @@ struct nvme_id_ctrl {
> __u8 mdts;
> __le16 cntlid;
> __le32 ver;
> - __u8 rsvd84[172];
> + __le32 rtd3r;
> + __le32 rtd3e;
> + __le32 oaes;
Just out of curiosity, why not CTRATT as well?
> + __u8 rsvd96[160];
> __le16 oacs;
> __u8 acl;
> __u8 aerl;
> --
> 2.1.4
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
WARNING: multiple messages have this Message-ID (diff)
From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields
Date: Tue, 7 Jun 2016 10:10:09 +0200 [thread overview]
Message-ID: <20160607081009.xd7wsyfuv4swuf4p@c203.arch.suse.de> (raw)
In-Reply-To: <1465248052-17811-2-git-send-email-hch@lst.de>
On Mon, Jun 06, 2016@11:20:43PM +0200, Christoph Hellwig wrote:
> These have been added in NVMe 1.2 and we'll need at least oaes for the
> NVMe target driver.
>
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
> Reviewed-by: Jay Freyensee <james.p.freyensee at intel.com>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
> include/linux/nvme.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 7d51b29..ff5ebc3 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -107,7 +107,10 @@ struct nvme_id_ctrl {
> __u8 mdts;
> __le16 cntlid;
> __le32 ver;
> - __u8 rsvd84[172];
> + __le32 rtd3r;
> + __le32 rtd3e;
> + __le32 oaes;
Just out of curiosity, why not CTRATT as well?
> + __u8 rsvd96[160];
> __le16 oacs;
> __u8 acl;
> __u8 aerl;
> --
> 2.1.4
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-06-07 8:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 21:20 general preparation for NVMe over Fabrics support Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-07 8:10 ` Johannes Thumshirn [this message]
2016-06-07 8:10 ` Johannes Thumshirn
2016-06-07 8:10 ` Johannes Thumshirn
2016-06-07 8:38 ` Johannes Thumshirn
2016-06-07 8:38 ` Johannes Thumshirn
2016-06-07 8:38 ` Johannes Thumshirn
2016-06-07 10:49 ` Christoph Hellwig
2016-06-07 10:49 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 02/10] nvme.h: Add get_log_page command strucure Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 03/10] nvme.h: add NVM command set SQE/CQE size defines Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 04/10] nvme.h: add AER constants Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 05/10] nvme.h: add constants for PSDT and FUSE values Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 06/10] nvme: allow for size limitations from transport drivers Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 07/10] nvme: factor out a add nvme_is_write helper Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 08/10] nvme: move the workaround for I/O queue-less controllers from PCIe to core Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 09/10] nvme: update nvme_cancel_io() a bit Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-06 21:20 ` [PATCH 10/10] nvme: move nvme_cancel_request() to core.c Christoph Hellwig
2016-06-06 21:20 ` Christoph Hellwig
2016-06-09 16:38 ` general preparation for NVMe over Fabrics support Keith Busch
2016-06-09 16:38 ` Keith Busch
2016-06-09 17:12 ` Christoph Hellwig
2016-06-09 17:12 ` Christoph Hellwig
2016-06-12 13:33 ` Jens Axboe
2016-06-12 13:33 ` Jens Axboe
2016-06-13 8:03 ` Christoph Hellwig
2016-06-13 8:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607081009.xd7wsyfuv4swuf4p@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.