From: Chris Wilson <chris@chris-wilson.co.uk>
To: Zhi Wang <zhi.a.wang@intel.com>
Cc: intel-gfx@lists.freedesktop.org, zhiyuan.lv@intel.com
Subject: Re: [PATCH v8 06/10] drm/i915: Make ring buffer size of a LRC context configurable
Date: Wed, 8 Jun 2016 17:03:48 +0100 [thread overview]
Message-ID: <20160608160348.GP32344@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1465399828-17082-7-git-send-email-zhi.a.wang@intel.com>
On Wed, Jun 08, 2016 at 11:30:24AM -0400, Zhi Wang wrote:
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index cbc84e6..344b5d3 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -2478,7 +2478,8 @@ static int execlists_context_deferred_alloc(struct i915_gem_context *ctx,
> return PTR_ERR(ctx_obj);
> }
>
> - ringbuf = intel_engine_create_ringbuffer(engine, 4 * PAGE_SIZE);
> + ringbuf = intel_engine_create_ringbuffer(engine,
> + ctx->ring_size);
It fits onto one line now! Plus, please try to align the start of the
next line with the opening bracket (or whatever vertical alignment makes
sense). For vim, set cino=:0,(0
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-08 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 15:30 [PATCH v8 00/10] Introduce the implementation of GVT context Zhi Wang
2016-06-08 15:30 ` [PATCH v8 01/10] drm/i915: Factor out i915_pvinfo.h Zhi Wang
2016-06-08 15:30 ` [PATCH v8 02/10] drm/i915: Use offsetof() to calculate the offset of members in PVINFO page Zhi Wang
2016-06-08 15:30 ` [PATCH v8 03/10] drm/i915: Fold vGPU active check into inner functions Zhi Wang
2016-06-08 15:30 ` [PATCH v8 04/10] drm/i915: gvt: Introduce the basic architecture of GVT-g Zhi Wang
2016-06-08 15:30 ` [PATCH v8 05/10] drm/i915: Introduce host graphics memory partition for GVT-g Zhi Wang
2016-06-08 15:30 ` [PATCH v8 06/10] drm/i915: Make ring buffer size of a LRC context configurable Zhi Wang
2016-06-08 16:03 ` Chris Wilson [this message]
2016-06-08 15:30 ` [PATCH v8 07/10] drm/i915: Make addressing mode bits in context descriptor configurable Zhi Wang
2016-06-08 16:08 ` Chris Wilson
2016-06-08 16:13 ` Wang, Zhi A
2016-06-08 15:30 ` [PATCH v8 08/10] drm/i915: Introduce execlist context status change notification Zhi Wang
2016-06-08 15:30 ` [PATCH v8 09/10] drm/i915: Support LRC context single submission Zhi Wang
2016-06-08 15:30 ` [PATCH v8 10/10] drm/i915: Introduce GVT context creation API Zhi Wang
2016-06-08 16:00 ` ✗ Ro.CI.BAT: warning for Introduce the implementation of GVT context (rev6) Patchwork
2016-06-08 16:00 ` [PATCH v8 00/10] Introduce the implementation of GVT context Chris Wilson
2016-06-08 16:05 ` Wang, Zhi A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608160348.GP32344@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhi.a.wang@intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.