From: Will Deacon <will.deacon@arm.com>
To: Aleksey Makarov <aleksey.makarov@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Graeme Gregory <graeme.gregory@linaro.org>,
Jon Masters <jcm@redhat.com>, "Zheng, Lv" <lv.zheng@intel.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v3 5/5] ACPI: ARM64: support for ACPI_TABLE_UPGRADE
Date: Tue, 14 Jun 2016 17:41:16 +0100 [thread overview]
Message-ID: <20160614164116.GF16531@arm.com> (raw)
In-Reply-To: <02dde480-cc01-6372-5baa-02ecf0037074@linaro.org>
On Tue, Jun 14, 2016 at 06:51:19PM +0300, Aleksey Makarov wrote:
>
> On 06/02/2016 08:49 PM, Aleksey Makarov wrote:
> > From: Jon Masters <jcm@redhat.com>
> >
> > This patch adds support for ACPI_TABLE_UPGRADE for ARM64
>
> Hi Catalin, Will,
>
> Can you review this v3 patch please? I changed PFN_PHYS(max_pfn) to
> MEMBLOCK_ALLOC_ACCESSIBLE.
I'm inclined to agree with Mark that this is something that should be
done by the bootloader (e.g. GRUB) if it's needed, rather than something
we should support in the kernel. Jon pitched the feature as a developer
aid for triaging problems, so it's not like we're in a state where some
widely available machine cannot currently boot Linux without this.
Having said that, the patch isn't exactly invasive and I suspect it's
only a matter of time before we will actually want something like this.
So I've come full circle on this patch:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/5] ACPI: ARM64: support for ACPI_TABLE_UPGRADE
Date: Tue, 14 Jun 2016 17:41:16 +0100 [thread overview]
Message-ID: <20160614164116.GF16531@arm.com> (raw)
In-Reply-To: <02dde480-cc01-6372-5baa-02ecf0037074@linaro.org>
On Tue, Jun 14, 2016 at 06:51:19PM +0300, Aleksey Makarov wrote:
>
> On 06/02/2016 08:49 PM, Aleksey Makarov wrote:
> > From: Jon Masters <jcm@redhat.com>
> >
> > This patch adds support for ACPI_TABLE_UPGRADE for ARM64
>
> Hi Catalin, Will,
>
> Can you review this v3 patch please? I changed PFN_PHYS(max_pfn) to
> MEMBLOCK_ALLOC_ACCESSIBLE.
I'm inclined to agree with Mark that this is something that should be
done by the bootloader (e.g. GRUB) if it's needed, rather than something
we should support in the kernel. Jon pitched the feature as a developer
aid for triaging problems, so it's not like we're in a state where some
widely available machine cannot currently boot Linux without this.
Having said that, the patch isn't exactly invasive and I suspect it's
only a matter of time before we will actually want something like this.
So I've come full circle on this patch:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2016-06-14 16:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 16:15 [PATCH v2 0/5] ACPI: ARM64: support for ACPI_TABLE_UPGRADE Aleksey Makarov
2016-05-19 16:15 ` Aleksey Makarov
2016-05-19 16:15 ` [PATCH v2 1/5] ACPI: table upgrade: use cacheable map for tables Aleksey Makarov
2016-05-19 16:15 ` Aleksey Makarov
2016-05-19 16:15 ` [PATCH v2 2/5] ACPI: table upgrade: refactor function definitions Aleksey Makarov
2016-05-19 16:15 ` Aleksey Makarov
2016-05-20 0:52 ` Zheng, Lv
2016-05-20 0:52 ` Zheng, Lv
2016-05-20 0:52 ` Zheng, Lv
2016-05-19 16:15 ` [PATCH v2 3/5] ACPI: table upgrade: move arch-specific symbol to asm/acpi.h Aleksey Makarov
2016-05-19 16:15 ` Aleksey Makarov
2016-05-19 16:15 ` [PATCH v2 4/5] ACPI: table upgrade: introduce ARCH_HAS_ACPI_TABLE_UPGRADE Aleksey Makarov
2016-05-19 16:15 ` Aleksey Makarov
2016-05-19 16:15 ` [PATCH v2 5/5] ACPI: ARM64: support for ACPI_TABLE_UPGRADE Aleksey Makarov
2016-05-19 16:15 ` Aleksey Makarov
2016-05-27 17:14 ` Catalin Marinas
2016-05-27 17:14 ` Catalin Marinas
2016-05-27 17:14 ` Catalin Marinas
2016-06-02 17:49 ` [PATCH v3 " Aleksey Makarov
2016-06-02 17:49 ` Aleksey Makarov
2016-06-14 15:51 ` Aleksey Makarov
2016-06-14 15:51 ` Aleksey Makarov
2016-06-14 16:41 ` Will Deacon [this message]
2016-06-14 16:41 ` Will Deacon
2016-05-19 21:22 ` [PATCH v2 0/5] " Rafael J. Wysocki
2016-05-19 21:22 ` Rafael J. Wysocki
2016-05-19 21:22 ` Rafael J. Wysocki
2016-05-27 13:46 ` Aleksey Makarov
2016-05-27 13:46 ` Aleksey Makarov
2016-05-27 13:46 ` Aleksey Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614164116.GF16531@arm.com \
--to=will.deacon@arm.com \
--cc=aleksey.makarov@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=graeme.gregory@linaro.org \
--cc=jcm@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.