From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, linux-crypto@vger.kernel.org,
tony@atomide.com, davem@davemloft.net, lokeshvutla@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 01/27] crypto: omap-sham: use runtime_pm autosuspend for clock handling
Date: Fri, 24 Jun 2016 21:30:36 +0800 [thread overview]
Message-ID: <20160624133036.GA21111@gondor.apana.org.au> (raw)
In-Reply-To: <1466601840-18486-2-git-send-email-t-kristo@ti.com>
On Wed, Jun 22, 2016 at 04:23:34PM +0300, Tero Kristo wrote:
> Calling runtime PM API for every block causes serious performance hit to
> crypto operations that are done on a long buffer. As crypto is performed
> on a page boundary, encrypting large buffers can cause a series of crypto
> operations divided by page. The runtime PM API is also called those many
> times.
>
> Convert the driver to use runtime_pm autosuspend instead, with a default
> timeout value of 1 second. This results in upto ~50% speedup.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
Patches 1-4 applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: herbert@gondor.apana.org.au (Herbert Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 01/27] crypto: omap-sham: use runtime_pm autosuspend for clock handling
Date: Fri, 24 Jun 2016 21:30:36 +0800 [thread overview]
Message-ID: <20160624133036.GA21111@gondor.apana.org.au> (raw)
In-Reply-To: <1466601840-18486-2-git-send-email-t-kristo@ti.com>
On Wed, Jun 22, 2016 at 04:23:34PM +0300, Tero Kristo wrote:
> Calling runtime PM API for every block causes serious performance hit to
> crypto operations that are done on a long buffer. As crypto is performed
> on a page boundary, encrypting large buffers can cause a series of crypto
> operations divided by page. The runtime PM API is also called those many
> times.
>
> Convert the driver to use runtime_pm autosuspend instead, with a default
> timeout value of 1 second. This results in upto ~50% speedup.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
Patches 1-4 applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-06-24 13:30 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 13:23 [PATCHv2 00/27] crypto: fixes for omap family of devices Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 01/27] crypto: omap-sham: use runtime_pm autosuspend for clock handling Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-24 13:30 ` Herbert Xu [this message]
2016-06-24 13:30 ` Herbert Xu
2016-06-22 13:23 ` [PATCHv2 02/27] crypto: omap-sham: change queue size from 1 to 10 Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 03/27] crypto: omap: do not call dmaengine_terminate_all Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 04/27] crypto: omap-sham: set sw fallback to 240 bytes Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 05/27] crypto: omap-sham: avoid executing tasklet where not needed Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-24 10:30 ` Herbert Xu
2016-06-24 10:30 ` Herbert Xu
2016-06-27 5:04 ` Tero Kristo
2016-06-27 5:04 ` Tero Kristo
2016-06-27 5:04 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 06/27] crypto: ahash: increase the maximum allowed statesize Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-24 10:32 ` Herbert Xu
2016-06-24 10:32 ` Herbert Xu
2016-06-27 4:58 ` Tero Kristo
2016-06-27 4:58 ` Tero Kristo
2016-06-27 4:58 ` Tero Kristo
2016-06-27 5:00 ` Herbert Xu
2016-06-27 5:00 ` Herbert Xu
2016-07-04 9:17 ` Tero Kristo
2016-07-04 9:17 ` Tero Kristo
2016-07-04 9:19 ` Herbert Xu
2016-07-04 9:19 ` Herbert Xu
2016-07-04 9:27 ` Tero Kristo
2016-07-04 9:27 ` Tero Kristo
2016-07-04 9:27 ` Tero Kristo
2016-07-04 9:42 ` Herbert Xu
2016-07-04 9:42 ` Herbert Xu
2016-06-22 13:23 ` [PATCHv2 07/27] crypto: omap-sham: implement context export/import APIs Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 08/27] crypto: omap-des: Fix support for unequal lengths Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 09/27] crypto: omap-aes - Fix enabling clocks Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 10/27] crypto: omap-aes: Add support for multiple cores Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 11/27] crypto: omap-aes: Add fallback support Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 12/27] crypto: engine: avoid unnecessary context switches Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 13/27] crypto: omap-aes: fix crypto engine initialization order Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 14/27] crypto: omap-des: " Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 15/27] ARM: dts: DRA7: Add DT node for DES IP Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 16/27] ARM: dts: DRA7: Add DT nodes for AES IP Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 17/27] ARM: dts: DRA7: Add support for SHA IP Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 18/27] ARM: dts: DRA7: Add DT node for RNG IP Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 19/27] ARM: dts: AM43xx: clk: Add RNG clk node Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 20/27] ARM: dts: AM43xx: Add node for RNG Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 21/27] ARM: DRA7: hwmod: Add data for DES IP Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 22/27] ARM: DRA7: hwmod: Add data for AES IP Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 23/27] ARM: DRA7: hwmod: Add data for SHA IP Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 24/27] ARM: DRA7: hwmod: Add data for RNG IP Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 25/27] ARM: OMAP: DRA7xx: Make L4SEC clock domain SWSUP only Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 26/27] ARM: AM43xx: hwmod: Add data for DES Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:23 ` Tero Kristo
2016-06-22 13:24 ` [PATCHv2 27/27] ARM: AMx3xx: hwmod: Add data for RNG Tero Kristo
2016-06-22 13:24 ` Tero Kristo
2016-06-22 13:24 ` Tero Kristo
2016-06-23 4:49 ` [PATCHv2 00/27] crypto: fixes for omap family of devices Tony Lindgren
2016-06-23 4:49 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624133036.GA21111@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.