All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: linux-amlogic@lists.infradead.org, linux-media@vger.kernel.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com, carlo@caione.org,
	khilman@baylibre.com, mchehab@kernel.org,
	devicetree@vger.kernel.org, narmstrong@baylibre.com,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver
Date: Tue, 28 Jun 2016 21:17:58 +0200	[thread overview]
Message-ID: <20160628191802.21227-1-martin.blumenstingl@googlemail.com> (raw)
In-Reply-To: <20160626210622.5257-1-martin.blumenstingl@googlemail.com>

Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different
register layout for their Infrared Remoete Controller. The decoder mode
is now configured in another register. Without the changes to the
meson-ir driver we are simply getting incorrect "durations" reported
from the hardware (because the hardware is not in time measurement aka
software decode mode).

This problem was also noticed by some people trying to use this on an
ODROID-C1 and ODROID-C2 - the workaround there (probably because the
datasheets were not publicy available yet at that time) was to switch
to ir_raw_event_store_edge (which leaves it up to the kernel to measure
the duration of a pulse). See [0] and [1] for the corresponding
patches.


Changes in v3:
- based on the patches of Neil Armstrong
- depending on the platform either the old (default) or new registers
  (this has to be enabled explicitly by using "amlogic,meson8b-ir" or
  "amlogic,meson-gxbb-ir")
- the changes to arch/arm/boot/dts/meson.dtsi are not part of this
  series anymore, because the size specified there is valid for the
  Meson 6b version of the IR decoder
- Add the IR decoder to meson-gxbb.dtsi and enable it on the supported
  boards


[0] https://github.com/erdoukki/linux-amlogic-1/commit/969b2e2242fb14a13cb651f9a1cf771b599c958b
[1] http://forum.odroid.com/viewtopic.php?f=135&t=20504


Martin Blumenstingl (1):
  ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards

Neil Armstrong (3):
  dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings
  media: rc: meson-ir: Add support for newer versions of the IR decoder
  ARM64: meson-gxbb: Add Infrared Remote Controller decoder

 .../devicetree/bindings/media/meson-ir.txt         |  5 +++-
 .../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts |  4 +++
 arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi   |  4 +++
 .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi      |  4 +++
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi        |  7 ++++++
 drivers/media/rc/meson-ir.c                        | 29 ++++++++++++++++++----
 6 files changed, 47 insertions(+), 6 deletions(-)

-- 
2.9.0

WARNING: multiple messages have this Message-ID (diff)
From: martin.blumenstingl@googlemail.com (Martin Blumenstingl)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver
Date: Tue, 28 Jun 2016 21:17:58 +0200	[thread overview]
Message-ID: <20160628191802.21227-1-martin.blumenstingl@googlemail.com> (raw)
In-Reply-To: <20160626210622.5257-1-martin.blumenstingl@googlemail.com>

Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different
register layout for their Infrared Remoete Controller. The decoder mode
is now configured in another register. Without the changes to the
meson-ir driver we are simply getting incorrect "durations" reported
from the hardware (because the hardware is not in time measurement aka
software decode mode).

This problem was also noticed by some people trying to use this on an
ODROID-C1 and ODROID-C2 - the workaround there (probably because the
datasheets were not publicy available yet at that time) was to switch
to ir_raw_event_store_edge (which leaves it up to the kernel to measure
the duration of a pulse). See [0] and [1] for the corresponding
patches.


Changes in v3:
- based on the patches of Neil Armstrong
- depending on the platform either the old (default) or new registers
  (this has to be enabled explicitly by using "amlogic,meson8b-ir" or
  "amlogic,meson-gxbb-ir")
- the changes to arch/arm/boot/dts/meson.dtsi are not part of this
  series anymore, because the size specified there is valid for the
  Meson 6b version of the IR decoder
- Add the IR decoder to meson-gxbb.dtsi and enable it on the supported
  boards


[0] https://github.com/erdoukki/linux-amlogic-1/commit/969b2e2242fb14a13cb651f9a1cf771b599c958b
[1] http://forum.odroid.com/viewtopic.php?f=135&t=20504


Martin Blumenstingl (1):
  ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards

Neil Armstrong (3):
  dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings
  media: rc: meson-ir: Add support for newer versions of the IR decoder
  ARM64: meson-gxbb: Add Infrared Remote Controller decoder

 .../devicetree/bindings/media/meson-ir.txt         |  5 +++-
 .../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts |  4 +++
 arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi   |  4 +++
 .../boot/dts/amlogic/meson-gxbb-vega-s95.dtsi      |  4 +++
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi        |  7 ++++++
 drivers/media/rc/meson-ir.c                        | 29 ++++++++++++++++++----
 6 files changed, 47 insertions(+), 6 deletions(-)

-- 
2.9.0

  parent reply	other threads:[~2016-06-28 19:17 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26 21:06 [v2] media: rc: fix Meson IR decoder Martin Blumenstingl
2016-06-26 21:06 ` Martin Blumenstingl
2016-06-26 21:06 ` Martin Blumenstingl
2016-06-26 21:06 ` [PATCH v2 1/2] media: rc: meson-ir: fix enabling raw/soft-decoding mode Martin Blumenstingl
2016-06-26 21:06   ` Martin Blumenstingl
2016-06-26 21:06   ` Martin Blumenstingl
2016-06-26 21:06 ` [PATCH v2 2/2] ARM: dts: meson: fixed size of the meson-ir registers Martin Blumenstingl
2016-06-26 21:06   ` Martin Blumenstingl
2016-06-26 21:06   ` Martin Blumenstingl
2016-06-27  8:43   ` Carlo Caione
2016-06-27  8:43     ` Carlo Caione
2016-06-27  8:43     ` Carlo Caione
2016-06-27  6:27 ` [v2] media: rc: fix Meson IR decoder Neil Armstrong
2016-06-27 10:53   ` Martin Blumenstingl
2016-06-27  6:28 ` Neil Armstrong
2016-06-27  6:28   ` Neil Armstrong
     [not found] ` <20160626210622.5257-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-06-27 12:57   ` Neil Armstrong
2016-06-27 12:57     ` Neil Armstrong
2016-06-27 12:57     ` Neil Armstrong
2016-06-27 12:57     ` Neil Armstrong
2016-06-28 19:17 ` Martin Blumenstingl [this message]
2016-06-28 19:17   ` [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver Martin Blumenstingl
2016-06-28 19:17   ` [PATCH v3 1/4] dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings Martin Blumenstingl
2016-06-28 19:17     ` Martin Blumenstingl
2016-07-01  1:34     ` Rob Herring
2016-07-01  1:34       ` Rob Herring
2016-06-28 19:18   ` [PATCH v3 2/4] media: rc: meson-ir: Add support for newer versions of the IR decoder Martin Blumenstingl
2016-06-28 19:18     ` Martin Blumenstingl
2016-06-28 19:18   ` [PATCH v3 3/4] ARM64: meson-gxbb: Add Infrared Remote Controller decoder Martin Blumenstingl
2016-06-28 19:18     ` Martin Blumenstingl
2016-06-28 19:18   ` [PATCH v3 4/4] ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards Martin Blumenstingl
2016-06-28 19:18     ` Martin Blumenstingl
2016-08-08  5:54   ` [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver Kevin Hilman
2016-08-08  5:54     ` Kevin Hilman
2016-08-19 21:55   ` [PATCH v4 0/6] " Martin Blumenstingl
2016-08-19 21:55     ` Martin Blumenstingl
2016-08-19 21:55     ` Martin Blumenstingl
2016-08-19 21:55     ` Martin Blumenstingl
2016-08-19 21:55     ` [PATCH v4 1/6] pinctrl: amlogic: gxbb: add the IR remote pin Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 22:23       ` Kevin Hilman
2016-08-19 22:23         ` Kevin Hilman
2016-08-19 22:23         ` Kevin Hilman
     [not found]     ` <20160819215547.20063-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-19 21:55       ` [PATCH v4 2/6] ARM64: dts: amlogic: add the pin for the IR remote Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55       ` [PATCH v4 3/6] dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55       ` [PATCH v4 6/6] ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55         ` Martin Blumenstingl
2016-08-19 21:55     ` [PATCH v4 4/6] media: rc: meson-ir: Add support for newer versions of the IR decoder Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 22:28       ` Kevin Hilman
2016-08-19 22:28         ` Kevin Hilman
2016-08-19 22:28         ` Kevin Hilman
2016-08-19 22:28         ` Kevin Hilman
2016-08-25 12:41         ` Mauro Carvalho Chehab
2016-08-25 12:41           ` Mauro Carvalho Chehab
2016-08-25 12:41           ` Mauro Carvalho Chehab
2016-08-19 21:55     ` [PATCH v4 5/6] ARM64: dts: meson-gxbb: Add Infrared Remote Controller decoder Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-19 21:55       ` Martin Blumenstingl
2016-08-20  9:54     ` [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver Martin Blumenstingl
2016-08-20  9:54       ` Martin Blumenstingl
2016-08-20  9:54       ` Martin Blumenstingl
2016-08-20  9:54       ` Martin Blumenstingl
2016-08-20  9:54       ` [PATCH v5 1/6] pinctrl: amlogic: gxbb: add the IR remote input pin Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
     [not found]         ` <20160820095424.636-2-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-22 13:51           ` Linus Walleij
2016-08-22 13:51             ` Linus Walleij
2016-08-22 13:51             ` Linus Walleij
2016-08-22 13:51             ` Linus Walleij
2016-08-20  9:54       ` [PATCH v5 3/6] dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54       ` [PATCH v5 4/6] media: rc: meson-ir: Add support for newer versions of the IR decoder Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54       ` [PATCH v5 5/6] ARM64: dts: meson-gxbb: Add Infrared Remote Controller decoder Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
2016-08-20  9:54         ` Martin Blumenstingl
     [not found]       ` <20160820095424.636-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-20  9:54         ` [PATCH v5 2/6] ARM64: dts: amlogic: add the input pin for the IR remote Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
     [not found]           ` <20160820095424.636-3-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-08-22 13:52             ` Linus Walleij
2016-08-22 13:52               ` Linus Walleij
2016-08-22 13:52               ` Linus Walleij
2016-08-22 13:52               ` Linus Walleij
2016-08-20  9:54         ` [PATCH v5 6/6] ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-20  9:54           ` Martin Blumenstingl
2016-08-29 19:28         ` [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver Kevin Hilman
2016-08-29 19:28           ` Kevin Hilman
2016-08-29 19:28           ` Kevin Hilman
2016-08-29 19:28           ` Kevin Hilman
2016-08-20  9:53   ` Martin Blumenstingl
2016-08-20  9:53     ` Martin Blumenstingl
2016-08-20  9:53     ` Martin Blumenstingl
2016-08-20  9:53     ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160628191802.21227-1-martin.blumenstingl@googlemail.com \
    --to=martin.blumenstingl@googlemail.com \
    --cc=carlo@caione.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.