From: Andi Shyti <andi.shyti@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: weiyj_lk@163.com, Marek Szyprowski <m.szyprowski@samsung.com>,
Joerg Roedel <joro@8bytes.org>, Kukjin Kim <kgene@kernel.org>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()
Date: Thu, 07 Jul 2016 11:34:43 +0900 [thread overview]
Message-ID: <20160707023443.GF23620@samsunx.samsung> (raw)
In-Reply-To: <577D0316.1050502@samsung.com>
Hi,
just a question,
> > pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
> > - if (IS_ERR(pdev))
> > - return PTR_ERR(pdev);
> > + if (!pdev)
> > + return -ENOMEM;
> >
> > /*
> > * use the first registered sysmmu device for performing
> >
>
is ENOMEM the right return value? of_platform_device_create()
doesn't fail only in case of malloc failure.
Shouldn't it be ENODEV instead, which might also mean with some
imagination that there is no memory available for that device?
Thanks,
Andi
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
WARNING: multiple messages have this Message-ID (diff)
From: andi.shyti@samsung.com (Andi Shyti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()
Date: Thu, 07 Jul 2016 11:34:43 +0900 [thread overview]
Message-ID: <20160707023443.GF23620@samsunx.samsung> (raw)
In-Reply-To: <577D0316.1050502@samsung.com>
Hi,
just a question,
> > pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
> > - if (IS_ERR(pdev))
> > - return PTR_ERR(pdev);
> > + if (!pdev)
> > + return -ENOMEM;
> >
> > /*
> > * use the first registered sysmmu device for performing
> >
>
is ENOMEM the right return value? of_platform_device_create()
doesn't fail only in case of malloc failure.
Shouldn't it be ENODEV instead, which might also mean with some
imagination that there is no memory available for that device?
Thanks,
Andi
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
next prev parent reply other threads:[~2016-07-07 2:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 12:15 [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup() weiyj_lk
2016-07-06 12:15 ` weiyj_lk at 163.com
2016-07-06 12:47 ` Dennis Chen
2016-07-06 12:47 ` Dennis Chen
2016-07-06 13:09 ` Krzysztof Kozlowski
2016-07-06 13:09 ` Krzysztof Kozlowski
2016-07-07 2:34 ` Andi Shyti [this message]
2016-07-07 2:34 ` Andi Shyti
2016-07-07 2:50 ` Wei Yongjun
2016-07-07 2:50 ` Wei Yongjun
2016-07-18 7:34 ` Marek Szyprowski
2016-07-18 7:34 ` Marek Szyprowski
[not found] ` <1467807354-26503-1-git-send-email-weiyj_lk-9Onoh4P/yGk@public.gmane.org>
2016-07-07 2:59 ` [PATCH -next v2] " weiyj_lk-9Onoh4P/yGk
2016-07-07 2:59 ` weiyj_lk at 163.com
2016-07-07 4:25 ` Andi Shyti
2016-07-07 4:25 ` Andi Shyti
[not found] ` <1467860372-6940-1-git-send-email-weiyj_lk-9Onoh4P/yGk@public.gmane.org>
2016-07-07 9:43 ` Krzysztof Kozlowski
2016-07-07 9:43 ` Krzysztof Kozlowski
2016-07-07 12:09 ` Wei Yongjun
2016-07-07 12:09 ` Wei Yongjun
2016-07-07 12:17 ` [PATCH -next v3] " weiyj_lk
2016-07-07 12:17 ` weiyj_lk at 163.com
2016-07-07 12:17 ` weiyj_lk-9Onoh4P/yGk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707023443.GF23620@samsunx.samsung \
--to=andi.shyti@samsung.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.