From: Alexander Gordeev <agordeev@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: tglx@linutronix.de, axboe@fb.com, linux-block@vger.kernel.org,
linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/13] pci: Provide sensible irq vector alloc/free routines
Date: Mon, 11 Jul 2016 12:43:41 +0200 [thread overview]
Message-ID: <20160711104340.GB21169@agordeev.lab.eng.brq.redhat.com> (raw)
In-Reply-To: <20160710034737.GB15720@lst.de>
On Sun, Jul 10, 2016 at 05:47:37AM +0200, Christoph Hellwig wrote:
> On Wed, Jul 06, 2016 at 10:05:45AM +0200, Alexander Gordeev wrote:
> > > + pci_enable_msi, pci_enable_msi_range, pci_enable_msi_exact, pci_disable_msi,
> > > + pci_msi_vec_count, pci_enable_msix_range, pci_enable_msix_exact,
> > > + pci_disable_msix, pci_msix_vec_count
> >
> > Description of these functions can be removed when all drivers migrated
> > to the new API. Also implementation descriptions + examples would still
> > be needed AFAICT.
>
> I diagreed - if we deprecated functions the only thing that should
> be mentioned is a "don't use these".
I will try to paraphrase myself. The new API deprecates pci_enable_msi*_range
functions, but I am not that sure about others. Certainly, pci_msi*_vec_count
and pci_enable_msi*_exact could have (and AFAIR do have) uses that can not be
covered by automatic initialization of pci_alloc_irq_vectors().
WARNING: multiple messages have this Message-ID (diff)
From: agordeev@redhat.com (Alexander Gordeev)
Subject: [PATCH 07/13] pci: Provide sensible irq vector alloc/free routines
Date: Mon, 11 Jul 2016 12:43:41 +0200 [thread overview]
Message-ID: <20160711104340.GB21169@agordeev.lab.eng.brq.redhat.com> (raw)
In-Reply-To: <20160710034737.GB15720@lst.de>
On Sun, Jul 10, 2016@05:47:37AM +0200, Christoph Hellwig wrote:
> On Wed, Jul 06, 2016@10:05:45AM +0200, Alexander Gordeev wrote:
> > > + pci_enable_msi, pci_enable_msi_range, pci_enable_msi_exact, pci_disable_msi,
> > > + pci_msi_vec_count, pci_enable_msix_range, pci_enable_msix_exact,
> > > + pci_disable_msix, pci_msix_vec_count
> >
> > Description of these functions can be removed when all drivers migrated
> > to the new API. Also implementation descriptions + examples would still
> > be needed AFAICT.
>
> I diagreed - if we deprecated functions the only thing that should
> be mentioned is a "don't use these".
I will try to paraphrase myself. The new API deprecates pci_enable_msi*_range
functions, but I am not that sure about others. Certainly, pci_msi*_vec_count
and pci_enable_msi*_exact could have (and AFAIR do have) uses that can not be
covered by automatic initialization of pci_alloc_irq_vectors().
next prev parent reply other threads:[~2016-07-11 10:38 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 8:39 automatic interrupt affinity for MSI/MSI-X capable devices V3 Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` [PATCH 01/13] irq/msi: Remove unused MSI_FLAG_IDENTITY_MAP Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 10:32 ` [tip:irq/core] genirq/msi: " tip-bot for Thomas Gleixner
2016-07-04 8:39 ` [PATCH 02/13] irq: Introduce IRQD_AFFINITY_MANAGED flag Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 10:32 ` [tip:irq/core] genirq: " tip-bot for Thomas Gleixner
2016-07-04 8:39 ` [PATCH 03/13] irq: Add affinity hint to irq allocation Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 10:33 ` [tip:irq/core] genirq: " tip-bot for Thomas Gleixner
[not found] ` <1468875386-31662-1-git-send-email-vincent.stehle@laposte.net>
2016-07-19 3:56 ` [PATCH next] genirq: fix missing irq allocation affinity hint Christoph Hellwig
2016-07-19 12:03 ` Thomas Gleixner
2016-07-04 8:39 ` [PATCH 04/13] irq: Use affinity hint in irqdesc allocation Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 10:33 ` [tip:irq/core] genirq: " tip-bot for Thomas Gleixner
2016-07-04 8:39 ` [PATCH 05/13] irq/msi: Make use of affinity aware allocations Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 10:33 ` [tip:irq/core] genirq/msi: " tip-bot for Thomas Gleixner
2016-07-04 8:39 ` [PATCH 06/13] irq: add a helper spread an affinity mask for MSI/MSI-X vectors Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 10:34 ` [tip:irq/core] genirq: Add a helper to " tip-bot for Christoph Hellwig
2016-07-04 8:39 ` [PATCH 07/13] pci: Provide sensible irq vector alloc/free routines Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-06 8:05 ` Alexander Gordeev
2016-07-06 8:05 ` Alexander Gordeev
2016-07-10 3:47 ` Christoph Hellwig
2016-07-10 3:47 ` Christoph Hellwig
2016-07-11 10:43 ` Alexander Gordeev [this message]
2016-07-11 10:43 ` Alexander Gordeev
2016-07-12 9:13 ` Christoph Hellwig
2016-07-12 9:13 ` Christoph Hellwig
2016-07-12 12:46 ` Alexander Gordeev
2016-07-12 12:46 ` Alexander Gordeev
2016-07-04 8:39 ` [PATCH 08/13] pci: spread interrupt vectors in pci_alloc_irq_vectors Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-07 11:05 ` Alexander Gordeev
2016-07-07 11:05 ` Alexander Gordeev
2016-07-10 3:57 ` Christoph Hellwig
2016-07-10 3:57 ` Christoph Hellwig
2016-07-12 6:49 ` Alexander Gordeev
2016-07-12 6:49 ` Alexander Gordeev
2016-07-04 8:39 ` [PATCH 09/13] blk-mq: don't redistribute hardware queues on a CPU hotplug event Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` [PATCH 10/13] blk-mq: only allocate a single mq_map per tag_set Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` [PATCH 11/13] blk-mq: allow the driver to pass in an affinity mask Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` [PATCH 12/13] nvme: switch to use pci_alloc_irq_vectors Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-07 19:30 ` Alexander Gordeev
2016-07-07 19:30 ` Alexander Gordeev
2016-07-10 3:59 ` Christoph Hellwig
2016-07-10 3:59 ` Christoph Hellwig
2016-07-04 8:39 ` [PATCH 13/13] nvme: remove the post_scan callout Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 8:39 ` Christoph Hellwig
2016-07-04 10:30 ` automatic interrupt affinity for MSI/MSI-X capable devices V3 Thomas Gleixner
2016-07-04 10:30 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2016-06-14 19:58 automatic interrupt affinity for MSI/MSI-X capable devices V2 Christoph Hellwig
2016-06-14 19:59 ` [PATCH 07/13] pci: Provide sensible irq vector alloc/free routines Christoph Hellwig
2016-06-14 19:59 ` Christoph Hellwig
2016-06-14 19:59 ` Christoph Hellwig
2016-06-23 11:16 ` Alexander Gordeev
2016-06-23 11:16 ` Alexander Gordeev
2016-06-30 16:54 ` Christoph Hellwig
2016-06-30 16:54 ` Christoph Hellwig
2016-06-30 17:28 ` Alexander Gordeev
2016-06-30 17:28 ` Alexander Gordeev
2016-06-30 17:35 ` Christoph Hellwig
2016-06-30 17:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711104340.GB21169@agordeev.lab.eng.brq.redhat.com \
--to=agordeev@redhat.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.