From: Daniel Vetter <daniel@ffwll.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dave Airlie <airlied@redhat.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [patch 2/2] qxl: silence uninitialized variable warning
Date: Tue, 12 Jul 2016 16:20:36 +0200 [thread overview]
Message-ID: <20160712142036.GP23520@phenom.ffwll.local> (raw)
In-Reply-To: <20160711084716.GB31411@mwanda>
On Mon, Jul 11, 2016 at 11:47:16AM +0300, Dan Carpenter wrote:
> GCC doesn't complain about this but my static checker does. We're
> passing "drawable" before initializing it. It's not actually used so
> it's harmless and I just removed it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Both of your qxl patches applied to drm-misc, thanks.
-Daniel
>
> diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_draw.c
> index 56e1d63..ffe8853 100644
> --- a/drivers/gpu/drm/qxl/qxl_draw.c
> +++ b/drivers/gpu/drm/qxl/qxl_draw.c
> @@ -37,7 +37,6 @@ static int alloc_clips(struct qxl_device *qdev,
> * the qxl_clip_rects. This is *not* the same as the memory allocated
> * on the device, it is offset to qxl_clip_rects.chunk.data */
> static struct qxl_rect *drawable_set_clipping(struct qxl_device *qdev,
> - struct qxl_drawable *drawable,
> unsigned num_clips,
> struct qxl_bo *clips_bo)
> {
> @@ -349,7 +350,7 @@ void qxl_draw_dirty_fb(struct qxl_device *qdev,
> if (ret)
> goto out_release_backoff;
>
> - rects = drawable_set_clipping(qdev, drawable, num_clips, clips_bo);
> + rects = drawable_set_clipping(qdev, num_clips, clips_bo);
> if (!rects)
> goto out_release_backoff;
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dave Airlie <airlied@redhat.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [patch 2/2] qxl: silence uninitialized variable warning
Date: Tue, 12 Jul 2016 14:20:36 +0000 [thread overview]
Message-ID: <20160712142036.GP23520@phenom.ffwll.local> (raw)
In-Reply-To: <20160711084716.GB31411@mwanda>
On Mon, Jul 11, 2016 at 11:47:16AM +0300, Dan Carpenter wrote:
> GCC doesn't complain about this but my static checker does. We're
> passing "drawable" before initializing it. It's not actually used so
> it's harmless and I just removed it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Both of your qxl patches applied to drm-misc, thanks.
-Daniel
>
> diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_draw.c
> index 56e1d63..ffe8853 100644
> --- a/drivers/gpu/drm/qxl/qxl_draw.c
> +++ b/drivers/gpu/drm/qxl/qxl_draw.c
> @@ -37,7 +37,6 @@ static int alloc_clips(struct qxl_device *qdev,
> * the qxl_clip_rects. This is *not* the same as the memory allocated
> * on the device, it is offset to qxl_clip_rects.chunk.data */
> static struct qxl_rect *drawable_set_clipping(struct qxl_device *qdev,
> - struct qxl_drawable *drawable,
> unsigned num_clips,
> struct qxl_bo *clips_bo)
> {
> @@ -349,7 +350,7 @@ void qxl_draw_dirty_fb(struct qxl_device *qdev,
> if (ret)
> goto out_release_backoff;
>
> - rects = drawable_set_clipping(qdev, drawable, num_clips, clips_bo);
> + rects = drawable_set_clipping(qdev, num_clips, clips_bo);
> if (!rects)
> goto out_release_backoff;
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dave Airlie <airlied@redhat.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [patch 2/2] qxl: silence uninitialized variable warning
Date: Tue, 12 Jul 2016 16:20:36 +0200 [thread overview]
Message-ID: <20160712142036.GP23520@phenom.ffwll.local> (raw)
In-Reply-To: <20160711084716.GB31411@mwanda>
On Mon, Jul 11, 2016 at 11:47:16AM +0300, Dan Carpenter wrote:
> GCC doesn't complain about this but my static checker does. We're
> passing "drawable" before initializing it. It's not actually used so
> it's harmless and I just removed it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Both of your qxl patches applied to drm-misc, thanks.
-Daniel
>
> diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_draw.c
> index 56e1d63..ffe8853 100644
> --- a/drivers/gpu/drm/qxl/qxl_draw.c
> +++ b/drivers/gpu/drm/qxl/qxl_draw.c
> @@ -37,7 +37,6 @@ static int alloc_clips(struct qxl_device *qdev,
> * the qxl_clip_rects. This is *not* the same as the memory allocated
> * on the device, it is offset to qxl_clip_rects.chunk.data */
> static struct qxl_rect *drawable_set_clipping(struct qxl_device *qdev,
> - struct qxl_drawable *drawable,
> unsigned num_clips,
> struct qxl_bo *clips_bo)
> {
> @@ -349,7 +350,7 @@ void qxl_draw_dirty_fb(struct qxl_device *qdev,
> if (ret)
> goto out_release_backoff;
>
> - rects = drawable_set_clipping(qdev, drawable, num_clips, clips_bo);
> + rects = drawable_set_clipping(qdev, num_clips, clips_bo);
> if (!rects)
> goto out_release_backoff;
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-12 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 8:47 [patch 2/2] qxl: silence uninitialized variable warning Dan Carpenter
2016-07-11 8:47 ` Dan Carpenter
2016-07-11 8:47 ` Dan Carpenter
2016-07-12 14:20 ` Daniel Vetter [this message]
2016-07-12 14:20 ` Daniel Vetter
2016-07-12 14:20 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712142036.GP23520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.