All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	pali.rohar@gmail.com, sre@kernel.org,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
	aaro.koskinen@iki.fi, patrikbachan@gmail.com, serge@hallyn.com,
	linux-media@vger.kernel.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] userspace API definitions for auto-focus coil
Date: Tue, 12 Jul 2016 20:32:01 -0300	[thread overview]
Message-ID: <20160712203201.7ffd8f22@recife.lan> (raw)
In-Reply-To: <20160618153846.GA15662@amd>

Em Sat, 18 Jun 2016 17:38:46 +0200
Pavel Machek <pavel@ucw.cz> escreveu:

> Hi!
> 
> > > Not V4L2_CID_USER_AD5820...?  
> > 
> > The rest of the controls have no USER as part of the macro name, so I
> > wouldn't use it here either.  
> 
> Ok.
> 
> > > Ok, separate header file for 2 lines seemed like a bit of overkill,
> > > but why not.  
> > 
> > That follows an existing pattern of how controls have been implemented in
> > other drivers.  
> 
> Ok.
> 
> > Could you merge this with the driver patch? I've dropped that from my ad5820
> > branch as it does not compile.  
> 
> Yes, merged patch should be in your inbox now.

The V4L2 core changes should be on a separate patch. Btw, you'll also
need to patch documentation to reflect such changes. We're right now
moving from DocBook to ReST markup language. The patches for it are
right now on a separate topic branch (docs-next), to be merged for
Kernel 4.8 on the next merge window.

You should either base the patch on such branch or wait for it to be
merged back mainstream to write such documentation additions.


> 
> Thanks,
> 									Pavel
> 


-- 
Thanks,
Mauro

WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Cc: Sakari Ailus <sakari.ailus-X3B1VOXEql0@public.gmane.org>,
	Ivaylo Dimitrov
	<ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	kernel list
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	aaro.koskinen-X3B1VOXEql0@public.gmane.org,
	patrikbachan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org,
	linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] userspace API definitions for auto-focus coil
Date: Tue, 12 Jul 2016 20:32:01 -0300	[thread overview]
Message-ID: <20160712203201.7ffd8f22@recife.lan> (raw)
In-Reply-To: <20160618153846.GA15662@amd>

Em Sat, 18 Jun 2016 17:38:46 +0200
Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> escreveu:

> Hi!
> 
> > > Not V4L2_CID_USER_AD5820...?  
> > 
> > The rest of the controls have no USER as part of the macro name, so I
> > wouldn't use it here either.  
> 
> Ok.
> 
> > > Ok, separate header file for 2 lines seemed like a bit of overkill,
> > > but why not.  
> > 
> > That follows an existing pattern of how controls have been implemented in
> > other drivers.  
> 
> Ok.
> 
> > Could you merge this with the driver patch? I've dropped that from my ad5820
> > branch as it does not compile.  
> 
> Yes, merged patch should be in your inbox now.

The V4L2 core changes should be on a separate patch. Btw, you'll also
need to patch documentation to reflect such changes. We're right now
moving from DocBook to ReST markup language. The patches for it are
right now on a separate topic branch (docs-next), to be merged for
Kernel 4.8 on the next merge window.

You should either base the patch on such branch or wait for it to be
merged back mainstream to write such documentation additions.


> 
> Thanks,
> 									Pavel
> 


-- 
Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: mchehab@osg.samsung.com (Mauro Carvalho Chehab)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] userspace API definitions for auto-focus coil
Date: Tue, 12 Jul 2016 20:32:01 -0300	[thread overview]
Message-ID: <20160712203201.7ffd8f22@recife.lan> (raw)
In-Reply-To: <20160618153846.GA15662@amd>

Em Sat, 18 Jun 2016 17:38:46 +0200
Pavel Machek <pavel@ucw.cz> escreveu:

> Hi!
> 
> > > Not V4L2_CID_USER_AD5820...?  
> > 
> > The rest of the controls have no USER as part of the macro name, so I
> > wouldn't use it here either.  
> 
> Ok.
> 
> > > Ok, separate header file for 2 lines seemed like a bit of overkill,
> > > but why not.  
> > 
> > That follows an existing pattern of how controls have been implemented in
> > other drivers.  
> 
> Ok.
> 
> > Could you merge this with the driver patch? I've dropped that from my ad5820
> > branch as it does not compile.  
> 
> Yes, merged patch should be in your inbox now.

The V4L2 core changes should be on a separate patch. Btw, you'll also
need to patch documentation to reflect such changes. We're right now
moving from DocBook to ReST markup language. The patches for it are
right now on a separate topic branch (docs-next), to be merged for
Kernel 4.8 on the next merge window.

You should either base the patch on such branch or wait for it to be
merged back mainstream to write such documentation additions.


> 
> Thanks,
> 									Pavel
> 


-- 
Thanks,
Mauro

  reply	other threads:[~2016-07-12 23:32 UTC|newest]

Thread overview: 158+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 18:19 [PATCH] support for AD5820 camera auto-focus coil Pavel Machek
2016-05-17 18:19 ` Pavel Machek
2016-05-17 18:33 ` Marcus Folkesson
2016-05-17 18:33   ` Marcus Folkesson
2016-05-18  8:30   ` Pavel Machek
2016-05-18  8:30     ` Pavel Machek
2016-05-21  5:43 ` [PATCHv2] " Pavel Machek
2016-05-21  5:43   ` Pavel Machek
2016-05-21  6:25   ` Ivaylo Dimitrov
2016-05-21  6:25     ` Ivaylo Dimitrov
2016-05-21 10:56     ` [PATCHv3] " Pavel Machek
2016-05-21 10:56       ` Pavel Machek
2016-05-21 11:43       ` Ivaylo Dimitrov
2016-05-21 11:43         ` Ivaylo Dimitrov
2016-05-23  7:41         ` Pali Rohár
2016-05-23  7:41           ` Pali Rohár
2016-05-23  7:41           ` Pali Rohár
2016-05-24  9:04         ` Pavel Machek
2016-05-24  9:04           ` Pavel Machek
2016-05-24  9:16           ` Ivaylo Dimitrov
2016-05-24  9:16             ` Ivaylo Dimitrov
2016-05-24 20:20             ` Pavel Machek
2016-05-24 20:20               ` Pavel Machek
2016-05-26  3:46               ` Ivaylo Dimitrov
2016-05-26  3:46                 ` Ivaylo Dimitrov
2016-05-24  9:17           ` [PATCHv4] " Pavel Machek
2016-05-24  9:17             ` Pavel Machek
2016-05-25 21:26             ` Sakari Ailus
2016-05-25 21:26               ` Sakari Ailus
2016-05-27 20:33               ` Pavel Machek
2016-05-27 20:33                 ` Pavel Machek
2016-05-27 20:51               ` [PATCHv5] " Pavel Machek
2016-05-27 20:51                 ` Pavel Machek
2016-05-31 21:22                 ` Sakari Ailus
2016-05-31 21:22                   ` Sakari Ailus
2016-05-31 21:34                   ` Pavel Machek
2016-05-31 21:34                     ` Pavel Machek
2016-06-01 15:24                     ` Sakari Ailus
2016-06-01 15:24                       ` Sakari Ailus
2016-06-01 22:08                       ` Pavel Machek
2016-06-01 22:08                         ` Pavel Machek
2016-06-02  7:45                         ` Sakari Ailus
2016-06-02  7:45                           ` Sakari Ailus
2016-06-02 19:27                           ` Pavel Machek
2016-06-02 19:27                             ` Pavel Machek
2016-06-02 21:23                             ` Sakari Ailus
2016-06-02 21:23                               ` Sakari Ailus
2016-06-02 19:30                           ` [PATCH] device tree description " Pavel Machek
2016-06-02 19:30                             ` Pavel Machek
2016-06-02 19:30                             ` Pavel Machek
2016-06-02 21:27                             ` Sakari Ailus
2016-06-02 21:27                               ` Sakari Ailus
2016-06-03  6:19                               ` Pavel Machek
2016-06-03  6:19                                 ` Pavel Machek
2016-06-05 19:07                               ` [PATCH] userspace API definitions for " Pavel Machek
2016-06-05 19:07                                 ` Pavel Machek
2016-06-05 19:07                                 ` Pavel Machek
2016-06-06  6:06                                 ` Ivaylo Dimitrov
2016-06-06  6:06                                   ` Ivaylo Dimitrov
2016-06-06  7:21                                   ` Pavel Machek
2016-06-06  7:21                                     ` Pavel Machek
2016-06-11 22:06                                   ` Sakari Ailus
2016-06-11 22:06                                     ` Sakari Ailus
2016-06-11 22:06                                     ` Sakari Ailus
2016-06-12  7:54                                     ` Pavel Machek
2016-06-12  7:54                                       ` Pavel Machek
2016-06-17 21:28                                       ` Sakari Ailus
2016-06-17 21:28                                         ` Sakari Ailus
2016-06-17 21:28                                         ` Sakari Ailus
2016-06-12  8:48                                     ` Pavel Machek
2016-06-12  8:48                                       ` Pavel Machek
2016-06-12 11:22                                       ` Sakari Ailus
2016-06-12 11:22                                         ` Sakari Ailus
2016-06-12 11:22                                         ` Sakari Ailus
2016-06-13 19:17                                         ` Pavel Machek
2016-06-13 19:17                                           ` Pavel Machek
2016-06-13 19:17                                           ` Pavel Machek
2016-06-17 21:35                                           ` Sakari Ailus
2016-06-17 21:35                                             ` Sakari Ailus
2016-06-18 15:37                                             ` [PATCHv4] support for AD5820 camera " Pavel Machek
2016-06-18 15:37                                               ` Pavel Machek
2016-06-18 15:38                                             ` [PATCH] userspace API definitions for " Pavel Machek
2016-06-18 15:38                                               ` Pavel Machek
2016-07-12 23:32                                               ` Mauro Carvalho Chehab [this message]
2016-07-12 23:32                                                 ` Mauro Carvalho Chehab
2016-07-12 23:32                                                 ` Mauro Carvalho Chehab
2016-07-13  6:57                                                 ` Pavel Machek
2016-07-13  6:57                                                   ` Pavel Machek
2016-07-13  7:26                                                 ` Pavel Machek
2016-07-13  7:26                                                   ` Pavel Machek
2016-06-06 13:29                             ` [PATCH] device tree description for AD5820 camera " Rob Herring
2016-06-06 13:29                               ` Rob Herring
2016-06-07  7:10                             ` [PATCHv2] " Pavel Machek
2016-06-07  7:10                               ` Pavel Machek
2016-06-09 22:37                               ` Sakari Ailus
2016-06-09 22:37                                 ` Sakari Ailus
2016-06-04 23:27                 ` [PATCHv5] support " kbuild test robot
2016-06-04 23:27                   ` kbuild test robot
2016-06-05  0:46                 ` kbuild test robot
2016-06-05  0:46                   ` kbuild test robot
2016-06-12 20:41                 ` [PATCH 1/1] v4l: Add camera voice coil lens control class, current control Sakari Ailus
2016-06-12 21:48                   ` Ivaylo Dimitrov
2016-06-17 22:11                     ` Pavel Machek
2016-06-17 22:39                       ` Laurent Pinchart
2016-06-18 11:28                         ` Pavel Machek
2016-06-17 22:06                   ` Pavel Machek
2016-08-05 10:26                 ` [PATCHv6] support for AD5820 camera auto-focus coil Pavel Machek
2016-08-05 10:26                   ` Pavel Machek
2016-08-05 10:30                   ` Pali Rohár
2016-08-05 10:30                     ` Pali Rohár
2016-08-08  8:09                   ` Sakari Ailus
2016-08-08  8:09                     ` Sakari Ailus
2016-08-08 21:41                     ` Pavel Machek
2016-08-08 21:41                       ` Pavel Machek
2016-08-08 21:41                       ` Pavel Machek
2016-08-10 12:01                       ` Sakari Ailus
2016-08-10 12:01                         ` Sakari Ailus
2016-08-10 12:01                         ` Sakari Ailus
2016-08-08 23:23                         ` Pavel Machek
2016-08-08 23:23                           ` Pavel Machek
2016-08-08 23:23                           ` Pavel Machek
2016-08-11 11:16                           ` Sakari Ailus
2016-08-11 11:16                             ` Sakari Ailus
2016-08-18 10:45                             ` Pavel Machek
2016-08-18 10:45                               ` Pavel Machek
2016-08-18 20:26                               ` Sakari Ailus
2016-08-18 20:26                                 ` Sakari Ailus
2016-08-18 20:26                                 ` Sakari Ailus
2016-08-18 21:28                                 ` Pavel Machek
2016-08-18 21:28                                   ` Pavel Machek
2016-08-18 21:28                                   ` Pavel Machek
2016-11-03 10:27                                 ` Pavel Machek
2016-11-03 10:27                                   ` Pavel Machek
2016-11-03 21:49                                   ` Sakari Ailus
2016-11-03 21:49                                     ` Sakari Ailus
2016-11-04  7:45                                     ` Pavel Machek
2016-11-04  7:45                                       ` Pavel Machek
2016-11-04 14:49                                       ` Tony Lindgren
2016-11-04 14:49                                         ` Tony Lindgren
2016-12-14 13:38                       ` Pali Rohár
2016-12-14 13:38                         ` Pali Rohár
2016-12-14 15:08                         ` Tony Lindgren
2016-12-14 15:08                           ` Tony Lindgren
2016-12-14 15:08                           ` Tony Lindgren
2016-12-15  6:50                           ` Sakari Ailus
2016-12-15  6:50                             ` Sakari Ailus
2016-12-15  6:50                             ` Sakari Ailus
2016-12-19 22:23                             ` Pavel Machek
2016-12-19 22:23                               ` Pavel Machek
2016-08-10  7:34                     ` Pali Rohár
2016-08-10  7:34                       ` Pali Rohár
2016-08-10  7:34                       ` Pali Rohár
2016-08-08 21:40                       ` Pavel Machek
2016-08-08 21:40                         ` Pavel Machek
2016-08-08 21:40                         ` Pavel Machek
2016-08-10 12:00                       ` Sakari Ailus
2016-08-10 12:00                         ` Sakari Ailus
2016-08-10 12:00                         ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160712203201.7ffd8f22@recife.lan \
    --to=mchehab@osg.samsung.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pali.rohar@gmail.com \
    --cc=patrikbachan@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@iki.fi \
    --cc=serge@hallyn.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.