From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Brian Foster <bfoster@redhat.com>
Cc: david@fromorbit.com, linux-fsdevel@vger.kernel.org,
vishal.l.verma@intel.com, xfs@oss.sgi.com
Subject: Re: [PATCH 042/119] xfs: log rmap intent items
Date: Sat, 16 Jul 2016 00:34:09 -0700 [thread overview]
Message-ID: <20160716073408.GD21529@birch.djwong.org> (raw)
In-Reply-To: <20160715183346.GB55338@bfoster.bfoster>
On Fri, Jul 15, 2016 at 02:33:46PM -0400, Brian Foster wrote:
> On Thu, Jun 16, 2016 at 06:22:21PM -0700, Darrick J. Wong wrote:
> > Provide a mechanism for higher levels to create RUI/RUD items, submit
> > them to the log, and a stub function to deal with recovered RUI items.
> > These parts will be connected to the rmapbt in a later patch.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
>
> The commit log makes no mention of log recovery.. perhaps this should be
> split in two?
>
> > fs/xfs/Makefile | 1
> > fs/xfs/xfs_log_recover.c | 344 +++++++++++++++++++++++++++++++++++++++++++++-
> > fs/xfs/xfs_trans.h | 17 ++
> > fs/xfs/xfs_trans_rmap.c | 235 +++++++++++++++++++++++++++++++
> > 4 files changed, 589 insertions(+), 8 deletions(-)
> > create mode 100644 fs/xfs/xfs_trans_rmap.c
> >
> >
> > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> > index 8ae0a10..1980110 100644
> > --- a/fs/xfs/Makefile
> > +++ b/fs/xfs/Makefile
> > @@ -110,6 +110,7 @@ xfs-y += xfs_log.o \
> > xfs_trans_buf.o \
> > xfs_trans_extfree.o \
> > xfs_trans_inode.o \
> > + xfs_trans_rmap.o \
> >
> > # optional features
> > xfs-$(CONFIG_XFS_QUOTA) += xfs_dquot.o \
> > diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> > index b33187b..c9fe0c4 100644
> > --- a/fs/xfs/xfs_log_recover.c
> > +++ b/fs/xfs/xfs_log_recover.c
> > @@ -44,6 +44,7 @@
> > #include "xfs_bmap_btree.h"
> > #include "xfs_error.h"
> > #include "xfs_dir2.h"
> > +#include "xfs_rmap_item.h"
> >
> > #define BLK_AVG(blk1, blk2) ((blk1+blk2) >> 1)
> >
> > @@ -1912,6 +1913,8 @@ xlog_recover_reorder_trans(
> > case XFS_LI_QUOTAOFF:
> > case XFS_LI_EFD:
> > case XFS_LI_EFI:
> > + case XFS_LI_RUI:
> > + case XFS_LI_RUD:
> > trace_xfs_log_recover_item_reorder_tail(log,
> > trans, item, pass);
> > list_move_tail(&item->ri_list, &inode_list);
> > @@ -3416,6 +3419,101 @@ xlog_recover_efd_pass2(
> > }
> >
> > /*
> > + * This routine is called to create an in-core extent rmap update
> > + * item from the rui format structure which was logged on disk.
> > + * It allocates an in-core rui, copies the extents from the format
> > + * structure into it, and adds the rui to the AIL with the given
> > + * LSN.
> > + */
> > +STATIC int
> > +xlog_recover_rui_pass2(
> > + struct xlog *log,
> > + struct xlog_recover_item *item,
> > + xfs_lsn_t lsn)
> > +{
> > + int error;
> > + struct xfs_mount *mp = log->l_mp;
> > + struct xfs_rui_log_item *ruip;
> > + struct xfs_rui_log_format *rui_formatp;
> > +
> > + rui_formatp = item->ri_buf[0].i_addr;
> > +
> > + ruip = xfs_rui_init(mp, rui_formatp->rui_nextents);
> > + error = xfs_rui_copy_format(&item->ri_buf[0], &ruip->rui_format);
> > + if (error) {
> > + xfs_rui_item_free(ruip);
> > + return error;
> > + }
> > + atomic_set(&ruip->rui_next_extent, rui_formatp->rui_nextents);
> > +
> > + spin_lock(&log->l_ailp->xa_lock);
> > + /*
> > + * The RUI has two references. One for the RUD and one for RUI to ensure
> > + * it makes it into the AIL. Insert the RUI into the AIL directly and
> > + * drop the RUI reference. Note that xfs_trans_ail_update() drops the
> > + * AIL lock.
> > + */
> > + xfs_trans_ail_update(log->l_ailp, &ruip->rui_item, lsn);
> > + xfs_rui_release(ruip);
> > + return 0;
> > +}
> > +
> > +
> > +/*
> > + * This routine is called when an RUD format structure is found in a committed
> > + * transaction in the log. Its purpose is to cancel the corresponding RUI if it
> > + * was still in the log. To do this it searches the AIL for the RUI with an id
> > + * equal to that in the RUD format structure. If we find it we drop the RUD
> > + * reference, which removes the RUI from the AIL and frees it.
> > + */
> > +STATIC int
> > +xlog_recover_rud_pass2(
> > + struct xlog *log,
> > + struct xlog_recover_item *item)
> > +{
> > + struct xfs_rud_log_format *rud_formatp;
> > + struct xfs_rui_log_item *ruip = NULL;
> > + struct xfs_log_item *lip;
> > + __uint64_t rui_id;
> > + struct xfs_ail_cursor cur;
> > + struct xfs_ail *ailp = log->l_ailp;
> > +
> > + rud_formatp = item->ri_buf[0].i_addr;
> > + ASSERT(item->ri_buf[0].i_len == (sizeof(struct xfs_rud_log_format) +
> > + ((rud_formatp->rud_nextents - 1) *
> > + sizeof(struct xfs_map_extent))));
> > + rui_id = rud_formatp->rud_rui_id;
> > +
> > + /*
> > + * Search for the RUI with the id in the RUD format structure in the
> > + * AIL.
> > + */
> > + spin_lock(&ailp->xa_lock);
> > + lip = xfs_trans_ail_cursor_first(ailp, &cur, 0);
> > + while (lip != NULL) {
> > + if (lip->li_type == XFS_LI_RUI) {
> > + ruip = (struct xfs_rui_log_item *)lip;
> > + if (ruip->rui_format.rui_id == rui_id) {
> > + /*
> > + * Drop the RUD reference to the RUI. This
> > + * removes the RUI from the AIL and frees it.
> > + */
> > + spin_unlock(&ailp->xa_lock);
> > + xfs_rui_release(ruip);
> > + spin_lock(&ailp->xa_lock);
> > + break;
> > + }
> > + }
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + }
> > +
> > + xfs_trans_ail_cursor_done(&cur);
> > + spin_unlock(&ailp->xa_lock);
> > +
> > + return 0;
> > +}
> > +
> > +/*
> > * This routine is called when an inode create format structure is found in a
> > * committed transaction in the log. It's purpose is to initialise the inodes
> > * being allocated on disk. This requires us to get inode cluster buffers that
> > @@ -3640,6 +3738,8 @@ xlog_recover_ra_pass2(
> > case XFS_LI_EFI:
> > case XFS_LI_EFD:
> > case XFS_LI_QUOTAOFF:
> > + case XFS_LI_RUI:
> > + case XFS_LI_RUD:
> > default:
> > break;
> > }
> > @@ -3663,6 +3763,8 @@ xlog_recover_commit_pass1(
> > case XFS_LI_EFD:
> > case XFS_LI_DQUOT:
> > case XFS_LI_ICREATE:
> > + case XFS_LI_RUI:
> > + case XFS_LI_RUD:
> > /* nothing to do in pass 1 */
> > return 0;
> > default:
> > @@ -3693,6 +3795,10 @@ xlog_recover_commit_pass2(
> > return xlog_recover_efi_pass2(log, item, trans->r_lsn);
> > case XFS_LI_EFD:
> > return xlog_recover_efd_pass2(log, item);
> > + case XFS_LI_RUI:
> > + return xlog_recover_rui_pass2(log, item, trans->r_lsn);
> > + case XFS_LI_RUD:
> > + return xlog_recover_rud_pass2(log, item);
> > case XFS_LI_DQUOT:
> > return xlog_recover_dquot_pass2(log, buffer_list, item,
> > trans->r_lsn);
> > @@ -4165,6 +4271,18 @@ xlog_recover_process_data(
> > return 0;
> > }
> >
> > +/* Is this log item a deferred action intent? */
> > +static inline bool xlog_item_is_intent(struct xfs_log_item *lip)
> > +{
> > + switch (lip->li_type) {
> > + case XFS_LI_EFI:
> > + case XFS_LI_RUI:
> > + return true;
> > + default:
> > + return false;
> > + }
> > +}
> > +
> > /*
> > * Process an extent free intent item that was recovered from
> > * the log. We need to free the extents that it describes.
> > @@ -4265,17 +4383,23 @@ xlog_recover_process_efis(
> > lip = xfs_trans_ail_cursor_first(ailp, &cur, 0);
> > while (lip != NULL) {
> > /*
> > - * We're done when we see something other than an EFI.
> > - * There should be no EFIs left in the AIL now.
> > + * We're done when we see something other than an intent.
> > + * There should be no intents left in the AIL now.
> > */
> > - if (lip->li_type != XFS_LI_EFI) {
> > + if (!xlog_item_is_intent(lip)) {
> > #ifdef DEBUG
> > for (; lip; lip = xfs_trans_ail_cursor_next(ailp, &cur))
> > - ASSERT(lip->li_type != XFS_LI_EFI);
> > + ASSERT(!xlog_item_is_intent(lip));
> > #endif
> > break;
> > }
> >
> > + /* Skip anything that isn't an EFI */
> > + if (lip->li_type != XFS_LI_EFI) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
>
> Hmm, so previously this function used the existence of any non-EFI item
> as an end of traversal marker, since the freeing operations add more
> items to the AIL. It's not immediately clear to me whether this is just
> an efficiency thing or a potential problem, but I wonder if we should
> grab the last item and use that or its lsn as an end of list marker.
FWIW I designed all this under the impression that it was safe to stop looking
for intent items once we found something that wasn't an intent item because all
the new items generated during log recovery came after, and therefore there was
no problem.
> At the very least we need to update the comment at the top of the
> function wrt to the current behavior.
Oops, missed that, yeah.
> > /*
> > * Skip EFIs that we've already processed.
> > */
> > @@ -4320,14 +4444,20 @@ xlog_recover_cancel_efis(
> > * We're done when we see something other than an EFI.
> > * There should be no EFIs left in the AIL now.
> > */
>
> Need to update this comment as for process_efis()...
Yep.
> > - if (lip->li_type != XFS_LI_EFI) {
> > + if (!xlog_item_is_intent(lip)) {
> > #ifdef DEBUG
> > for (; lip; lip = xfs_trans_ail_cursor_next(ailp, &cur))
> > - ASSERT(lip->li_type != XFS_LI_EFI);
> > + ASSERT(!xlog_item_is_intent(lip));
> > #endif
> > break;
> > }
> >
> > + /* Skip anything that isn't an EFI */
> > + if (lip->li_type != XFS_LI_EFI) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
> > efip = container_of(lip, struct xfs_efi_log_item, efi_item);
> >
> > spin_unlock(&ailp->xa_lock);
> > @@ -4343,6 +4473,190 @@ xlog_recover_cancel_efis(
> > }
> >
> > /*
> > + * Process an rmap update intent item that was recovered from the log.
> > + * We need to update the rmapbt.
> > + */
> > +STATIC int
> > +xlog_recover_process_rui(
> > + struct xfs_mount *mp,
> > + struct xfs_rui_log_item *ruip)
> > +{
> > + int i;
> > + int error = 0;
> > + struct xfs_map_extent *rmap;
> > + xfs_fsblock_t startblock_fsb;
> > + bool op_ok;
> > +
> > + ASSERT(!test_bit(XFS_RUI_RECOVERED, &ruip->rui_flags));
> > +
> > + /*
> > + * First check the validity of the extents described by the
> > + * RUI. If any are bad, then assume that all are bad and
> > + * just toss the RUI.
> > + */
> > + for (i = 0; i < ruip->rui_format.rui_nextents; i++) {
> > + rmap = &(ruip->rui_format.rui_extents[i]);
> > + startblock_fsb = XFS_BB_TO_FSB(mp,
> > + XFS_FSB_TO_DADDR(mp, rmap->me_startblock));
> > + switch (rmap->me_flags & XFS_RMAP_EXTENT_TYPE_MASK) {
> > + case XFS_RMAP_EXTENT_MAP:
> > + case XFS_RMAP_EXTENT_MAP_SHARED:
> > + case XFS_RMAP_EXTENT_UNMAP:
> > + case XFS_RMAP_EXTENT_UNMAP_SHARED:
> > + case XFS_RMAP_EXTENT_CONVERT:
> > + case XFS_RMAP_EXTENT_CONVERT_SHARED:
> > + case XFS_RMAP_EXTENT_ALLOC:
> > + case XFS_RMAP_EXTENT_FREE:
> > + op_ok = true;
> > + break;
> > + default:
> > + op_ok = false;
> > + break;
> > + }
> > + if (!op_ok || (startblock_fsb == 0) ||
> > + (rmap->me_len == 0) ||
> > + (startblock_fsb >= mp->m_sb.sb_dblocks) ||
> > + (rmap->me_len >= mp->m_sb.sb_agblocks) ||
> > + (rmap->me_flags & ~XFS_RMAP_EXTENT_FLAGS)) {
> > + /*
> > + * This will pull the RUI from the AIL and
> > + * free the memory associated with it.
> > + */
> > + set_bit(XFS_RUI_RECOVERED, &ruip->rui_flags);
> > + xfs_rui_release(ruip);
> > + return -EIO;
> > + }
> > + }
> > +
> > + /* XXX: do nothing for now */
> > + set_bit(XFS_RUI_RECOVERED, &ruip->rui_flags);
> > + xfs_rui_release(ruip);
> > + return error;
> > +}
> > +
> > +/*
> > + * When this is called, all of the RUIs which did not have
> > + * corresponding RUDs should be in the AIL. What we do now
> > + * is update the rmaps associated with each one.
> > + *
> > + * Since we process the RUIs in normal transactions, they
> > + * will be removed at some point after the commit. This prevents
> > + * us from just walking down the list processing each one.
> > + * We'll use a flag in the RUI to skip those that we've already
> > + * processed and use the AIL iteration mechanism's generation
> > + * count to try to speed this up at least a bit.
> > + *
> > + * When we start, we know that the RUIs are the only things in
> > + * the AIL. As we process them, however, other items are added
> > + * to the AIL. Since everything added to the AIL must come after
> > + * everything already in the AIL, we stop processing as soon as
> > + * we see something other than an RUI in the AIL.
> > + */
> > +STATIC int
> > +xlog_recover_process_ruis(
> > + struct xlog *log)
> > +{
> > + struct xfs_log_item *lip;
> > + struct xfs_rui_log_item *ruip;
> > + int error = 0;
> > + struct xfs_ail_cursor cur;
> > + struct xfs_ail *ailp;
> > +
> > + ailp = log->l_ailp;
> > + spin_lock(&ailp->xa_lock);
> > + lip = xfs_trans_ail_cursor_first(ailp, &cur, 0);
> > + while (lip != NULL) {
> > + /*
> > + * We're done when we see something other than an intent.
> > + * There should be no intents left in the AIL now.
> > + */
> > + if (!xlog_item_is_intent(lip)) {
> > +#ifdef DEBUG
> > + for (; lip; lip = xfs_trans_ail_cursor_next(ailp, &cur))
> > + ASSERT(!xlog_item_is_intent(lip));
> > +#endif
> > + break;
> > + }
> > +
> > + /* Skip anything that isn't an RUI */
> > + if (lip->li_type != XFS_LI_RUI) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
> > + /*
> > + * Skip RUIs that we've already processed.
> > + */
> > + ruip = container_of(lip, struct xfs_rui_log_item, rui_item);
> > + if (test_bit(XFS_RUI_RECOVERED, &ruip->rui_flags)) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
> > + spin_unlock(&ailp->xa_lock);
> > + error = xlog_recover_process_rui(log->l_mp, ruip);
> > + spin_lock(&ailp->xa_lock);
> > + if (error)
> > + goto out;
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + }
> > +out:
> > + xfs_trans_ail_cursor_done(&cur);
> > + spin_unlock(&ailp->xa_lock);
> > + return error;
> > +}
> > +
> > +/*
> > + * A cancel occurs when the mount has failed and we're bailing out. Release all
> > + * pending RUIs so they don't pin the AIL.
> > + */
> > +STATIC int
> > +xlog_recover_cancel_ruis(
> > + struct xlog *log)
> > +{
> > + struct xfs_log_item *lip;
> > + struct xfs_rui_log_item *ruip;
> > + int error = 0;
> > + struct xfs_ail_cursor cur;
> > + struct xfs_ail *ailp;
> > +
> > + ailp = log->l_ailp;
> > + spin_lock(&ailp->xa_lock);
> > + lip = xfs_trans_ail_cursor_first(ailp, &cur, 0);
> > + while (lip != NULL) {
> > + /*
> > + * We're done when we see something other than an RUI.
> > + * There should be no RUIs left in the AIL now.
> > + */
> > + if (!xlog_item_is_intent(lip)) {
> > +#ifdef DEBUG
> > + for (; lip; lip = xfs_trans_ail_cursor_next(ailp, &cur))
> > + ASSERT(!xlog_item_is_intent(lip));
> > +#endif
> > + break;
> > + }
> > +
> > + /* Skip anything that isn't an RUI */
> > + if (lip->li_type != XFS_LI_RUI) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
> > + ruip = container_of(lip, struct xfs_rui_log_item, rui_item);
> > +
> > + spin_unlock(&ailp->xa_lock);
> > + xfs_rui_release(ruip);
> > + spin_lock(&ailp->xa_lock);
> > +
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + }
> > +
> > + xfs_trans_ail_cursor_done(&cur);
> > + spin_unlock(&ailp->xa_lock);
> > + return error;
> > +}
>
> How about we combine this and cancel_efis() into a cancel_intents()
> function so we only have to make one pass? It looks like the only
> difference is the item-specific release call.
Yeah, sounds like a good refactor.
> > +
> > +/*
> > * This routine performs a transaction to null out a bad inode pointer
> > * in an agi unlinked inode hash bucket.
> > */
> > @@ -5144,11 +5458,19 @@ xlog_recover_finish(
> > */
> > if (log->l_flags & XLOG_RECOVERY_NEEDED) {
> > int error;
> > +
> > + error = xlog_recover_process_ruis(log);
> > + if (error) {
> > + xfs_alert(log->l_mp, "Failed to recover RUIs");
> > + return error;
> > + }
> > +
> > error = xlog_recover_process_efis(log);
> > if (error) {
> > xfs_alert(log->l_mp, "Failed to recover EFIs");
> > return error;
> > }
> > +
>
> Is the order important here in any way (e.g., RUIs before EFIs)? If so,
> it might be a good idea to call it out.
AFAIK the intent items within a particular type have to be replayed in
order, but between types, there isn't a problem with the current code.
That said, I'd also been wondering if it made more sense to iterate the
list of items /once/ and actually replay items in order. Less iteration
and the order of replayed items matches the log order much more closely.
> > /*
> > * Sync the log to get all the EFIs out of the AIL.
> > * This isn't absolutely necessary, but it helps in
> > @@ -5176,9 +5498,15 @@ xlog_recover_cancel(
> > struct xlog *log)
> > {
> > int error = 0;
> > + int err2;
> >
> > - if (log->l_flags & XLOG_RECOVERY_NEEDED)
> > - error = xlog_recover_cancel_efis(log);
> > + if (log->l_flags & XLOG_RECOVERY_NEEDED) {
> > + error = xlog_recover_cancel_ruis(log);
> > +
> > + err2 = xlog_recover_cancel_efis(log);
> > + if (err2 && !error)
> > + error = err2;
> > + }
> >
> > return error;
> > }
> > diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h
> > index f8d363f..c48be63 100644
> > --- a/fs/xfs/xfs_trans.h
> > +++ b/fs/xfs/xfs_trans.h
> > @@ -235,4 +235,21 @@ void xfs_trans_buf_copy_type(struct xfs_buf *dst_bp,
> > extern kmem_zone_t *xfs_trans_zone;
> > extern kmem_zone_t *xfs_log_item_desc_zone;
> >
> > +enum xfs_rmap_intent_type;
> > +
> > +struct xfs_rui_log_item *xfs_trans_get_rui(struct xfs_trans *tp, uint nextents);
> > +void xfs_trans_log_start_rmap_update(struct xfs_trans *tp,
> > + struct xfs_rui_log_item *ruip, enum xfs_rmap_intent_type type,
> > + __uint64_t owner, int whichfork, xfs_fileoff_t startoff,
> > + xfs_fsblock_t startblock, xfs_filblks_t blockcount,
> > + xfs_exntst_t state);
> > +
> > +struct xfs_rud_log_item *xfs_trans_get_rud(struct xfs_trans *tp,
> > + struct xfs_rui_log_item *ruip, uint nextents);
> > +int xfs_trans_log_finish_rmap_update(struct xfs_trans *tp,
> > + struct xfs_rud_log_item *rudp, enum xfs_rmap_intent_type type,
> > + __uint64_t owner, int whichfork, xfs_fileoff_t startoff,
> > + xfs_fsblock_t startblock, xfs_filblks_t blockcount,
> > + xfs_exntst_t state);
> > +
> > #endif /* __XFS_TRANS_H__ */
> > diff --git a/fs/xfs/xfs_trans_rmap.c b/fs/xfs/xfs_trans_rmap.c
> > new file mode 100644
> > index 0000000..b55a725
> > --- /dev/null
> > +++ b/fs/xfs/xfs_trans_rmap.c
> > @@ -0,0 +1,235 @@
> > +/*
> > + * Copyright (C) 2016 Oracle. All Rights Reserved.
> > + *
> > + * Author: Darrick J. Wong <darrick.wong@oracle.com>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version 2
> > + * of the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it would be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write the Free Software Foundation,
> > + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
> > + */
> > +#include "xfs.h"
> > +#include "xfs_fs.h"
> > +#include "xfs_shared.h"
> > +#include "xfs_format.h"
> > +#include "xfs_log_format.h"
> > +#include "xfs_trans_resv.h"
> > +#include "xfs_mount.h"
> > +#include "xfs_defer.h"
> > +#include "xfs_trans.h"
> > +#include "xfs_trans_priv.h"
> > +#include "xfs_rmap_item.h"
> > +#include "xfs_alloc.h"
> > +#include "xfs_rmap_btree.h"
> > +
> > +/*
> > + * This routine is called to allocate an "rmap update intent"
> > + * log item that will hold nextents worth of extents. The
> > + * caller must use all nextents extents, because we are not
> > + * flexible about this at all.
> > + */
> > +struct xfs_rui_log_item *
> > +xfs_trans_get_rui(
> > + struct xfs_trans *tp,
> > + uint nextents)
> > +{
> > + struct xfs_rui_log_item *ruip;
> > +
> > + ASSERT(tp != NULL);
> > + ASSERT(nextents > 0);
> > +
> > + ruip = xfs_rui_init(tp->t_mountp, nextents);
> > + ASSERT(ruip != NULL);
> > +
> > + /*
> > + * Get a log_item_desc to point at the new item.
> > + */
> > + xfs_trans_add_item(tp, &ruip->rui_item);
> > + return ruip;
> > +}
> > +
> > +/*
> > + * This routine is called to indicate that the described
> > + * extent is to be logged as needing to be freed. It should
> > + * be called once for each extent to be freed.
> > + */
>
> Stale comment.
<nod>
> > +void
> > +xfs_trans_log_start_rmap_update(
> > + struct xfs_trans *tp,
> > + struct xfs_rui_log_item *ruip,
> > + enum xfs_rmap_intent_type type,
> > + __uint64_t owner,
> > + int whichfork,
> > + xfs_fileoff_t startoff,
> > + xfs_fsblock_t startblock,
> > + xfs_filblks_t blockcount,
> > + xfs_exntst_t state)
> > +{
> > + uint next_extent;
> > + struct xfs_map_extent *rmap;
> > +
> > + tp->t_flags |= XFS_TRANS_DIRTY;
> > + ruip->rui_item.li_desc->lid_flags |= XFS_LID_DIRTY;
> > +
> > + /*
> > + * atomic_inc_return gives us the value after the increment;
> > + * we want to use it as an array index so we need to subtract 1 from
> > + * it.
> > + */
> > + next_extent = atomic_inc_return(&ruip->rui_next_extent) - 1;
> > + ASSERT(next_extent < ruip->rui_format.rui_nextents);
> > + rmap = &(ruip->rui_format.rui_extents[next_extent]);
> > + rmap->me_owner = owner;
> > + rmap->me_startblock = startblock;
> > + rmap->me_startoff = startoff;
> > + rmap->me_len = blockcount;
> > + rmap->me_flags = 0;
> > + if (state == XFS_EXT_UNWRITTEN)
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNWRITTEN;
> > + if (whichfork == XFS_ATTR_FORK)
> > + rmap->me_flags |= XFS_RMAP_EXTENT_ATTR_FORK;
> > + switch (type) {
> > + case XFS_RMAP_MAP:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_MAP;
> > + break;
> > + case XFS_RMAP_MAP_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_MAP_SHARED;
> > + break;
> > + case XFS_RMAP_UNMAP:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNMAP;
> > + break;
> > + case XFS_RMAP_UNMAP_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNMAP_SHARED;
> > + break;
> > + case XFS_RMAP_CONVERT:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_CONVERT;
> > + break;
> > + case XFS_RMAP_CONVERT_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_CONVERT_SHARED;
> > + break;
> > + case XFS_RMAP_ALLOC:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_ALLOC;
> > + break;
> > + case XFS_RMAP_FREE:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_FREE;
> > + break;
> > + default:
> > + ASSERT(0);
> > + }
>
> Between here and the finish function, it looks like we could use a
> helper to convert the state and whatnot to extent flags.
Ok.
> > +}
> > +
> > +
> > +/*
> > + * This routine is called to allocate an "extent free done"
> > + * log item that will hold nextents worth of extents. The
> > + * caller must use all nextents extents, because we are not
> > + * flexible about this at all.
> > + */
>
> Comment needs updating.
Ok.
> Brian
>
> > +struct xfs_rud_log_item *
> > +xfs_trans_get_rud(
> > + struct xfs_trans *tp,
> > + struct xfs_rui_log_item *ruip,
> > + uint nextents)
> > +{
> > + struct xfs_rud_log_item *rudp;
> > +
> > + ASSERT(tp != NULL);
> > + ASSERT(nextents > 0);
> > +
> > + rudp = xfs_rud_init(tp->t_mountp, ruip, nextents);
> > + ASSERT(rudp != NULL);
> > +
> > + /*
> > + * Get a log_item_desc to point at the new item.
> > + */
> > + xfs_trans_add_item(tp, &rudp->rud_item);
> > + return rudp;
> > +}
> > +
> > +/*
> > + * Finish an rmap update and log it to the RUD. Note that the transaction is
> > + * marked dirty regardless of whether the rmap update succeeds or fails to
> > + * support the RUI/RUD lifecycle rules.
> > + */
> > +int
> > +xfs_trans_log_finish_rmap_update(
> > + struct xfs_trans *tp,
> > + struct xfs_rud_log_item *rudp,
> > + enum xfs_rmap_intent_type type,
> > + __uint64_t owner,
> > + int whichfork,
> > + xfs_fileoff_t startoff,
> > + xfs_fsblock_t startblock,
> > + xfs_filblks_t blockcount,
> > + xfs_exntst_t state)
> > +{
> > + uint next_extent;
> > + struct xfs_map_extent *rmap;
> > + int error;
> > +
> > + /* XXX: actually finish the rmap update here */
> > + error = -EFSCORRUPTED;
> > +
> > + /*
> > + * Mark the transaction dirty, even on error. This ensures the
> > + * transaction is aborted, which:
> > + *
> > + * 1.) releases the RUI and frees the RUD
> > + * 2.) shuts down the filesystem
> > + */
> > + tp->t_flags |= XFS_TRANS_DIRTY;
> > + rudp->rud_item.li_desc->lid_flags |= XFS_LID_DIRTY;
> > +
> > + next_extent = rudp->rud_next_extent;
> > + ASSERT(next_extent < rudp->rud_format.rud_nextents);
> > + rmap = &(rudp->rud_format.rud_extents[next_extent]);
> > + rmap->me_owner = owner;
> > + rmap->me_startblock = startblock;
> > + rmap->me_startoff = startoff;
> > + rmap->me_len = blockcount;
> > + rmap->me_flags = 0;
> > + if (state == XFS_EXT_UNWRITTEN)
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNWRITTEN;
> > + if (whichfork == XFS_ATTR_FORK)
> > + rmap->me_flags |= XFS_RMAP_EXTENT_ATTR_FORK;
> > + switch (type) {
> > + case XFS_RMAP_MAP:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_MAP;
> > + break;
> > + case XFS_RMAP_MAP_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_MAP_SHARED;
> > + break;
> > + case XFS_RMAP_UNMAP:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNMAP;
> > + break;
> > + case XFS_RMAP_UNMAP_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNMAP_SHARED;
> > + break;
> > + case XFS_RMAP_CONVERT:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_CONVERT;
> > + break;
> > + case XFS_RMAP_CONVERT_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_CONVERT_SHARED;
> > + break;
> > + case XFS_RMAP_ALLOC:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_ALLOC;
> > + break;
> > + case XFS_RMAP_FREE:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_FREE;
> > + break;
> > + default:
> > + ASSERT(0);
> > + }
> > + rudp->rud_next_extent++;
> > +
> > + return error;
> > +}
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, vishal.l.verma@intel.com, xfs@oss.sgi.com
Subject: Re: [PATCH 042/119] xfs: log rmap intent items
Date: Sat, 16 Jul 2016 00:34:09 -0700 [thread overview]
Message-ID: <20160716073408.GD21529@birch.djwong.org> (raw)
In-Reply-To: <20160715183346.GB55338@bfoster.bfoster>
On Fri, Jul 15, 2016 at 02:33:46PM -0400, Brian Foster wrote:
> On Thu, Jun 16, 2016 at 06:22:21PM -0700, Darrick J. Wong wrote:
> > Provide a mechanism for higher levels to create RUI/RUD items, submit
> > them to the log, and a stub function to deal with recovered RUI items.
> > These parts will be connected to the rmapbt in a later patch.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
>
> The commit log makes no mention of log recovery.. perhaps this should be
> split in two?
>
> > fs/xfs/Makefile | 1
> > fs/xfs/xfs_log_recover.c | 344 +++++++++++++++++++++++++++++++++++++++++++++-
> > fs/xfs/xfs_trans.h | 17 ++
> > fs/xfs/xfs_trans_rmap.c | 235 +++++++++++++++++++++++++++++++
> > 4 files changed, 589 insertions(+), 8 deletions(-)
> > create mode 100644 fs/xfs/xfs_trans_rmap.c
> >
> >
> > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> > index 8ae0a10..1980110 100644
> > --- a/fs/xfs/Makefile
> > +++ b/fs/xfs/Makefile
> > @@ -110,6 +110,7 @@ xfs-y += xfs_log.o \
> > xfs_trans_buf.o \
> > xfs_trans_extfree.o \
> > xfs_trans_inode.o \
> > + xfs_trans_rmap.o \
> >
> > # optional features
> > xfs-$(CONFIG_XFS_QUOTA) += xfs_dquot.o \
> > diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> > index b33187b..c9fe0c4 100644
> > --- a/fs/xfs/xfs_log_recover.c
> > +++ b/fs/xfs/xfs_log_recover.c
> > @@ -44,6 +44,7 @@
> > #include "xfs_bmap_btree.h"
> > #include "xfs_error.h"
> > #include "xfs_dir2.h"
> > +#include "xfs_rmap_item.h"
> >
> > #define BLK_AVG(blk1, blk2) ((blk1+blk2) >> 1)
> >
> > @@ -1912,6 +1913,8 @@ xlog_recover_reorder_trans(
> > case XFS_LI_QUOTAOFF:
> > case XFS_LI_EFD:
> > case XFS_LI_EFI:
> > + case XFS_LI_RUI:
> > + case XFS_LI_RUD:
> > trace_xfs_log_recover_item_reorder_tail(log,
> > trans, item, pass);
> > list_move_tail(&item->ri_list, &inode_list);
> > @@ -3416,6 +3419,101 @@ xlog_recover_efd_pass2(
> > }
> >
> > /*
> > + * This routine is called to create an in-core extent rmap update
> > + * item from the rui format structure which was logged on disk.
> > + * It allocates an in-core rui, copies the extents from the format
> > + * structure into it, and adds the rui to the AIL with the given
> > + * LSN.
> > + */
> > +STATIC int
> > +xlog_recover_rui_pass2(
> > + struct xlog *log,
> > + struct xlog_recover_item *item,
> > + xfs_lsn_t lsn)
> > +{
> > + int error;
> > + struct xfs_mount *mp = log->l_mp;
> > + struct xfs_rui_log_item *ruip;
> > + struct xfs_rui_log_format *rui_formatp;
> > +
> > + rui_formatp = item->ri_buf[0].i_addr;
> > +
> > + ruip = xfs_rui_init(mp, rui_formatp->rui_nextents);
> > + error = xfs_rui_copy_format(&item->ri_buf[0], &ruip->rui_format);
> > + if (error) {
> > + xfs_rui_item_free(ruip);
> > + return error;
> > + }
> > + atomic_set(&ruip->rui_next_extent, rui_formatp->rui_nextents);
> > +
> > + spin_lock(&log->l_ailp->xa_lock);
> > + /*
> > + * The RUI has two references. One for the RUD and one for RUI to ensure
> > + * it makes it into the AIL. Insert the RUI into the AIL directly and
> > + * drop the RUI reference. Note that xfs_trans_ail_update() drops the
> > + * AIL lock.
> > + */
> > + xfs_trans_ail_update(log->l_ailp, &ruip->rui_item, lsn);
> > + xfs_rui_release(ruip);
> > + return 0;
> > +}
> > +
> > +
> > +/*
> > + * This routine is called when an RUD format structure is found in a committed
> > + * transaction in the log. Its purpose is to cancel the corresponding RUI if it
> > + * was still in the log. To do this it searches the AIL for the RUI with an id
> > + * equal to that in the RUD format structure. If we find it we drop the RUD
> > + * reference, which removes the RUI from the AIL and frees it.
> > + */
> > +STATIC int
> > +xlog_recover_rud_pass2(
> > + struct xlog *log,
> > + struct xlog_recover_item *item)
> > +{
> > + struct xfs_rud_log_format *rud_formatp;
> > + struct xfs_rui_log_item *ruip = NULL;
> > + struct xfs_log_item *lip;
> > + __uint64_t rui_id;
> > + struct xfs_ail_cursor cur;
> > + struct xfs_ail *ailp = log->l_ailp;
> > +
> > + rud_formatp = item->ri_buf[0].i_addr;
> > + ASSERT(item->ri_buf[0].i_len == (sizeof(struct xfs_rud_log_format) +
> > + ((rud_formatp->rud_nextents - 1) *
> > + sizeof(struct xfs_map_extent))));
> > + rui_id = rud_formatp->rud_rui_id;
> > +
> > + /*
> > + * Search for the RUI with the id in the RUD format structure in the
> > + * AIL.
> > + */
> > + spin_lock(&ailp->xa_lock);
> > + lip = xfs_trans_ail_cursor_first(ailp, &cur, 0);
> > + while (lip != NULL) {
> > + if (lip->li_type == XFS_LI_RUI) {
> > + ruip = (struct xfs_rui_log_item *)lip;
> > + if (ruip->rui_format.rui_id == rui_id) {
> > + /*
> > + * Drop the RUD reference to the RUI. This
> > + * removes the RUI from the AIL and frees it.
> > + */
> > + spin_unlock(&ailp->xa_lock);
> > + xfs_rui_release(ruip);
> > + spin_lock(&ailp->xa_lock);
> > + break;
> > + }
> > + }
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + }
> > +
> > + xfs_trans_ail_cursor_done(&cur);
> > + spin_unlock(&ailp->xa_lock);
> > +
> > + return 0;
> > +}
> > +
> > +/*
> > * This routine is called when an inode create format structure is found in a
> > * committed transaction in the log. It's purpose is to initialise the inodes
> > * being allocated on disk. This requires us to get inode cluster buffers that
> > @@ -3640,6 +3738,8 @@ xlog_recover_ra_pass2(
> > case XFS_LI_EFI:
> > case XFS_LI_EFD:
> > case XFS_LI_QUOTAOFF:
> > + case XFS_LI_RUI:
> > + case XFS_LI_RUD:
> > default:
> > break;
> > }
> > @@ -3663,6 +3763,8 @@ xlog_recover_commit_pass1(
> > case XFS_LI_EFD:
> > case XFS_LI_DQUOT:
> > case XFS_LI_ICREATE:
> > + case XFS_LI_RUI:
> > + case XFS_LI_RUD:
> > /* nothing to do in pass 1 */
> > return 0;
> > default:
> > @@ -3693,6 +3795,10 @@ xlog_recover_commit_pass2(
> > return xlog_recover_efi_pass2(log, item, trans->r_lsn);
> > case XFS_LI_EFD:
> > return xlog_recover_efd_pass2(log, item);
> > + case XFS_LI_RUI:
> > + return xlog_recover_rui_pass2(log, item, trans->r_lsn);
> > + case XFS_LI_RUD:
> > + return xlog_recover_rud_pass2(log, item);
> > case XFS_LI_DQUOT:
> > return xlog_recover_dquot_pass2(log, buffer_list, item,
> > trans->r_lsn);
> > @@ -4165,6 +4271,18 @@ xlog_recover_process_data(
> > return 0;
> > }
> >
> > +/* Is this log item a deferred action intent? */
> > +static inline bool xlog_item_is_intent(struct xfs_log_item *lip)
> > +{
> > + switch (lip->li_type) {
> > + case XFS_LI_EFI:
> > + case XFS_LI_RUI:
> > + return true;
> > + default:
> > + return false;
> > + }
> > +}
> > +
> > /*
> > * Process an extent free intent item that was recovered from
> > * the log. We need to free the extents that it describes.
> > @@ -4265,17 +4383,23 @@ xlog_recover_process_efis(
> > lip = xfs_trans_ail_cursor_first(ailp, &cur, 0);
> > while (lip != NULL) {
> > /*
> > - * We're done when we see something other than an EFI.
> > - * There should be no EFIs left in the AIL now.
> > + * We're done when we see something other than an intent.
> > + * There should be no intents left in the AIL now.
> > */
> > - if (lip->li_type != XFS_LI_EFI) {
> > + if (!xlog_item_is_intent(lip)) {
> > #ifdef DEBUG
> > for (; lip; lip = xfs_trans_ail_cursor_next(ailp, &cur))
> > - ASSERT(lip->li_type != XFS_LI_EFI);
> > + ASSERT(!xlog_item_is_intent(lip));
> > #endif
> > break;
> > }
> >
> > + /* Skip anything that isn't an EFI */
> > + if (lip->li_type != XFS_LI_EFI) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
>
> Hmm, so previously this function used the existence of any non-EFI item
> as an end of traversal marker, since the freeing operations add more
> items to the AIL. It's not immediately clear to me whether this is just
> an efficiency thing or a potential problem, but I wonder if we should
> grab the last item and use that or its lsn as an end of list marker.
FWIW I designed all this under the impression that it was safe to stop looking
for intent items once we found something that wasn't an intent item because all
the new items generated during log recovery came after, and therefore there was
no problem.
> At the very least we need to update the comment at the top of the
> function wrt to the current behavior.
Oops, missed that, yeah.
> > /*
> > * Skip EFIs that we've already processed.
> > */
> > @@ -4320,14 +4444,20 @@ xlog_recover_cancel_efis(
> > * We're done when we see something other than an EFI.
> > * There should be no EFIs left in the AIL now.
> > */
>
> Need to update this comment as for process_efis()...
Yep.
> > - if (lip->li_type != XFS_LI_EFI) {
> > + if (!xlog_item_is_intent(lip)) {
> > #ifdef DEBUG
> > for (; lip; lip = xfs_trans_ail_cursor_next(ailp, &cur))
> > - ASSERT(lip->li_type != XFS_LI_EFI);
> > + ASSERT(!xlog_item_is_intent(lip));
> > #endif
> > break;
> > }
> >
> > + /* Skip anything that isn't an EFI */
> > + if (lip->li_type != XFS_LI_EFI) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
> > efip = container_of(lip, struct xfs_efi_log_item, efi_item);
> >
> > spin_unlock(&ailp->xa_lock);
> > @@ -4343,6 +4473,190 @@ xlog_recover_cancel_efis(
> > }
> >
> > /*
> > + * Process an rmap update intent item that was recovered from the log.
> > + * We need to update the rmapbt.
> > + */
> > +STATIC int
> > +xlog_recover_process_rui(
> > + struct xfs_mount *mp,
> > + struct xfs_rui_log_item *ruip)
> > +{
> > + int i;
> > + int error = 0;
> > + struct xfs_map_extent *rmap;
> > + xfs_fsblock_t startblock_fsb;
> > + bool op_ok;
> > +
> > + ASSERT(!test_bit(XFS_RUI_RECOVERED, &ruip->rui_flags));
> > +
> > + /*
> > + * First check the validity of the extents described by the
> > + * RUI. If any are bad, then assume that all are bad and
> > + * just toss the RUI.
> > + */
> > + for (i = 0; i < ruip->rui_format.rui_nextents; i++) {
> > + rmap = &(ruip->rui_format.rui_extents[i]);
> > + startblock_fsb = XFS_BB_TO_FSB(mp,
> > + XFS_FSB_TO_DADDR(mp, rmap->me_startblock));
> > + switch (rmap->me_flags & XFS_RMAP_EXTENT_TYPE_MASK) {
> > + case XFS_RMAP_EXTENT_MAP:
> > + case XFS_RMAP_EXTENT_MAP_SHARED:
> > + case XFS_RMAP_EXTENT_UNMAP:
> > + case XFS_RMAP_EXTENT_UNMAP_SHARED:
> > + case XFS_RMAP_EXTENT_CONVERT:
> > + case XFS_RMAP_EXTENT_CONVERT_SHARED:
> > + case XFS_RMAP_EXTENT_ALLOC:
> > + case XFS_RMAP_EXTENT_FREE:
> > + op_ok = true;
> > + break;
> > + default:
> > + op_ok = false;
> > + break;
> > + }
> > + if (!op_ok || (startblock_fsb == 0) ||
> > + (rmap->me_len == 0) ||
> > + (startblock_fsb >= mp->m_sb.sb_dblocks) ||
> > + (rmap->me_len >= mp->m_sb.sb_agblocks) ||
> > + (rmap->me_flags & ~XFS_RMAP_EXTENT_FLAGS)) {
> > + /*
> > + * This will pull the RUI from the AIL and
> > + * free the memory associated with it.
> > + */
> > + set_bit(XFS_RUI_RECOVERED, &ruip->rui_flags);
> > + xfs_rui_release(ruip);
> > + return -EIO;
> > + }
> > + }
> > +
> > + /* XXX: do nothing for now */
> > + set_bit(XFS_RUI_RECOVERED, &ruip->rui_flags);
> > + xfs_rui_release(ruip);
> > + return error;
> > +}
> > +
> > +/*
> > + * When this is called, all of the RUIs which did not have
> > + * corresponding RUDs should be in the AIL. What we do now
> > + * is update the rmaps associated with each one.
> > + *
> > + * Since we process the RUIs in normal transactions, they
> > + * will be removed at some point after the commit. This prevents
> > + * us from just walking down the list processing each one.
> > + * We'll use a flag in the RUI to skip those that we've already
> > + * processed and use the AIL iteration mechanism's generation
> > + * count to try to speed this up at least a bit.
> > + *
> > + * When we start, we know that the RUIs are the only things in
> > + * the AIL. As we process them, however, other items are added
> > + * to the AIL. Since everything added to the AIL must come after
> > + * everything already in the AIL, we stop processing as soon as
> > + * we see something other than an RUI in the AIL.
> > + */
> > +STATIC int
> > +xlog_recover_process_ruis(
> > + struct xlog *log)
> > +{
> > + struct xfs_log_item *lip;
> > + struct xfs_rui_log_item *ruip;
> > + int error = 0;
> > + struct xfs_ail_cursor cur;
> > + struct xfs_ail *ailp;
> > +
> > + ailp = log->l_ailp;
> > + spin_lock(&ailp->xa_lock);
> > + lip = xfs_trans_ail_cursor_first(ailp, &cur, 0);
> > + while (lip != NULL) {
> > + /*
> > + * We're done when we see something other than an intent.
> > + * There should be no intents left in the AIL now.
> > + */
> > + if (!xlog_item_is_intent(lip)) {
> > +#ifdef DEBUG
> > + for (; lip; lip = xfs_trans_ail_cursor_next(ailp, &cur))
> > + ASSERT(!xlog_item_is_intent(lip));
> > +#endif
> > + break;
> > + }
> > +
> > + /* Skip anything that isn't an RUI */
> > + if (lip->li_type != XFS_LI_RUI) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
> > + /*
> > + * Skip RUIs that we've already processed.
> > + */
> > + ruip = container_of(lip, struct xfs_rui_log_item, rui_item);
> > + if (test_bit(XFS_RUI_RECOVERED, &ruip->rui_flags)) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
> > + spin_unlock(&ailp->xa_lock);
> > + error = xlog_recover_process_rui(log->l_mp, ruip);
> > + spin_lock(&ailp->xa_lock);
> > + if (error)
> > + goto out;
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + }
> > +out:
> > + xfs_trans_ail_cursor_done(&cur);
> > + spin_unlock(&ailp->xa_lock);
> > + return error;
> > +}
> > +
> > +/*
> > + * A cancel occurs when the mount has failed and we're bailing out. Release all
> > + * pending RUIs so they don't pin the AIL.
> > + */
> > +STATIC int
> > +xlog_recover_cancel_ruis(
> > + struct xlog *log)
> > +{
> > + struct xfs_log_item *lip;
> > + struct xfs_rui_log_item *ruip;
> > + int error = 0;
> > + struct xfs_ail_cursor cur;
> > + struct xfs_ail *ailp;
> > +
> > + ailp = log->l_ailp;
> > + spin_lock(&ailp->xa_lock);
> > + lip = xfs_trans_ail_cursor_first(ailp, &cur, 0);
> > + while (lip != NULL) {
> > + /*
> > + * We're done when we see something other than an RUI.
> > + * There should be no RUIs left in the AIL now.
> > + */
> > + if (!xlog_item_is_intent(lip)) {
> > +#ifdef DEBUG
> > + for (; lip; lip = xfs_trans_ail_cursor_next(ailp, &cur))
> > + ASSERT(!xlog_item_is_intent(lip));
> > +#endif
> > + break;
> > + }
> > +
> > + /* Skip anything that isn't an RUI */
> > + if (lip->li_type != XFS_LI_RUI) {
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + continue;
> > + }
> > +
> > + ruip = container_of(lip, struct xfs_rui_log_item, rui_item);
> > +
> > + spin_unlock(&ailp->xa_lock);
> > + xfs_rui_release(ruip);
> > + spin_lock(&ailp->xa_lock);
> > +
> > + lip = xfs_trans_ail_cursor_next(ailp, &cur);
> > + }
> > +
> > + xfs_trans_ail_cursor_done(&cur);
> > + spin_unlock(&ailp->xa_lock);
> > + return error;
> > +}
>
> How about we combine this and cancel_efis() into a cancel_intents()
> function so we only have to make one pass? It looks like the only
> difference is the item-specific release call.
Yeah, sounds like a good refactor.
> > +
> > +/*
> > * This routine performs a transaction to null out a bad inode pointer
> > * in an agi unlinked inode hash bucket.
> > */
> > @@ -5144,11 +5458,19 @@ xlog_recover_finish(
> > */
> > if (log->l_flags & XLOG_RECOVERY_NEEDED) {
> > int error;
> > +
> > + error = xlog_recover_process_ruis(log);
> > + if (error) {
> > + xfs_alert(log->l_mp, "Failed to recover RUIs");
> > + return error;
> > + }
> > +
> > error = xlog_recover_process_efis(log);
> > if (error) {
> > xfs_alert(log->l_mp, "Failed to recover EFIs");
> > return error;
> > }
> > +
>
> Is the order important here in any way (e.g., RUIs before EFIs)? If so,
> it might be a good idea to call it out.
AFAIK the intent items within a particular type have to be replayed in
order, but between types, there isn't a problem with the current code.
That said, I'd also been wondering if it made more sense to iterate the
list of items /once/ and actually replay items in order. Less iteration
and the order of replayed items matches the log order much more closely.
> > /*
> > * Sync the log to get all the EFIs out of the AIL.
> > * This isn't absolutely necessary, but it helps in
> > @@ -5176,9 +5498,15 @@ xlog_recover_cancel(
> > struct xlog *log)
> > {
> > int error = 0;
> > + int err2;
> >
> > - if (log->l_flags & XLOG_RECOVERY_NEEDED)
> > - error = xlog_recover_cancel_efis(log);
> > + if (log->l_flags & XLOG_RECOVERY_NEEDED) {
> > + error = xlog_recover_cancel_ruis(log);
> > +
> > + err2 = xlog_recover_cancel_efis(log);
> > + if (err2 && !error)
> > + error = err2;
> > + }
> >
> > return error;
> > }
> > diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h
> > index f8d363f..c48be63 100644
> > --- a/fs/xfs/xfs_trans.h
> > +++ b/fs/xfs/xfs_trans.h
> > @@ -235,4 +235,21 @@ void xfs_trans_buf_copy_type(struct xfs_buf *dst_bp,
> > extern kmem_zone_t *xfs_trans_zone;
> > extern kmem_zone_t *xfs_log_item_desc_zone;
> >
> > +enum xfs_rmap_intent_type;
> > +
> > +struct xfs_rui_log_item *xfs_trans_get_rui(struct xfs_trans *tp, uint nextents);
> > +void xfs_trans_log_start_rmap_update(struct xfs_trans *tp,
> > + struct xfs_rui_log_item *ruip, enum xfs_rmap_intent_type type,
> > + __uint64_t owner, int whichfork, xfs_fileoff_t startoff,
> > + xfs_fsblock_t startblock, xfs_filblks_t blockcount,
> > + xfs_exntst_t state);
> > +
> > +struct xfs_rud_log_item *xfs_trans_get_rud(struct xfs_trans *tp,
> > + struct xfs_rui_log_item *ruip, uint nextents);
> > +int xfs_trans_log_finish_rmap_update(struct xfs_trans *tp,
> > + struct xfs_rud_log_item *rudp, enum xfs_rmap_intent_type type,
> > + __uint64_t owner, int whichfork, xfs_fileoff_t startoff,
> > + xfs_fsblock_t startblock, xfs_filblks_t blockcount,
> > + xfs_exntst_t state);
> > +
> > #endif /* __XFS_TRANS_H__ */
> > diff --git a/fs/xfs/xfs_trans_rmap.c b/fs/xfs/xfs_trans_rmap.c
> > new file mode 100644
> > index 0000000..b55a725
> > --- /dev/null
> > +++ b/fs/xfs/xfs_trans_rmap.c
> > @@ -0,0 +1,235 @@
> > +/*
> > + * Copyright (C) 2016 Oracle. All Rights Reserved.
> > + *
> > + * Author: Darrick J. Wong <darrick.wong@oracle.com>
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > + * as published by the Free Software Foundation; either version 2
> > + * of the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it would be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write the Free Software Foundation,
> > + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
> > + */
> > +#include "xfs.h"
> > +#include "xfs_fs.h"
> > +#include "xfs_shared.h"
> > +#include "xfs_format.h"
> > +#include "xfs_log_format.h"
> > +#include "xfs_trans_resv.h"
> > +#include "xfs_mount.h"
> > +#include "xfs_defer.h"
> > +#include "xfs_trans.h"
> > +#include "xfs_trans_priv.h"
> > +#include "xfs_rmap_item.h"
> > +#include "xfs_alloc.h"
> > +#include "xfs_rmap_btree.h"
> > +
> > +/*
> > + * This routine is called to allocate an "rmap update intent"
> > + * log item that will hold nextents worth of extents. The
> > + * caller must use all nextents extents, because we are not
> > + * flexible about this at all.
> > + */
> > +struct xfs_rui_log_item *
> > +xfs_trans_get_rui(
> > + struct xfs_trans *tp,
> > + uint nextents)
> > +{
> > + struct xfs_rui_log_item *ruip;
> > +
> > + ASSERT(tp != NULL);
> > + ASSERT(nextents > 0);
> > +
> > + ruip = xfs_rui_init(tp->t_mountp, nextents);
> > + ASSERT(ruip != NULL);
> > +
> > + /*
> > + * Get a log_item_desc to point at the new item.
> > + */
> > + xfs_trans_add_item(tp, &ruip->rui_item);
> > + return ruip;
> > +}
> > +
> > +/*
> > + * This routine is called to indicate that the described
> > + * extent is to be logged as needing to be freed. It should
> > + * be called once for each extent to be freed.
> > + */
>
> Stale comment.
<nod>
> > +void
> > +xfs_trans_log_start_rmap_update(
> > + struct xfs_trans *tp,
> > + struct xfs_rui_log_item *ruip,
> > + enum xfs_rmap_intent_type type,
> > + __uint64_t owner,
> > + int whichfork,
> > + xfs_fileoff_t startoff,
> > + xfs_fsblock_t startblock,
> > + xfs_filblks_t blockcount,
> > + xfs_exntst_t state)
> > +{
> > + uint next_extent;
> > + struct xfs_map_extent *rmap;
> > +
> > + tp->t_flags |= XFS_TRANS_DIRTY;
> > + ruip->rui_item.li_desc->lid_flags |= XFS_LID_DIRTY;
> > +
> > + /*
> > + * atomic_inc_return gives us the value after the increment;
> > + * we want to use it as an array index so we need to subtract 1 from
> > + * it.
> > + */
> > + next_extent = atomic_inc_return(&ruip->rui_next_extent) - 1;
> > + ASSERT(next_extent < ruip->rui_format.rui_nextents);
> > + rmap = &(ruip->rui_format.rui_extents[next_extent]);
> > + rmap->me_owner = owner;
> > + rmap->me_startblock = startblock;
> > + rmap->me_startoff = startoff;
> > + rmap->me_len = blockcount;
> > + rmap->me_flags = 0;
> > + if (state == XFS_EXT_UNWRITTEN)
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNWRITTEN;
> > + if (whichfork == XFS_ATTR_FORK)
> > + rmap->me_flags |= XFS_RMAP_EXTENT_ATTR_FORK;
> > + switch (type) {
> > + case XFS_RMAP_MAP:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_MAP;
> > + break;
> > + case XFS_RMAP_MAP_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_MAP_SHARED;
> > + break;
> > + case XFS_RMAP_UNMAP:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNMAP;
> > + break;
> > + case XFS_RMAP_UNMAP_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNMAP_SHARED;
> > + break;
> > + case XFS_RMAP_CONVERT:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_CONVERT;
> > + break;
> > + case XFS_RMAP_CONVERT_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_CONVERT_SHARED;
> > + break;
> > + case XFS_RMAP_ALLOC:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_ALLOC;
> > + break;
> > + case XFS_RMAP_FREE:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_FREE;
> > + break;
> > + default:
> > + ASSERT(0);
> > + }
>
> Between here and the finish function, it looks like we could use a
> helper to convert the state and whatnot to extent flags.
Ok.
> > +}
> > +
> > +
> > +/*
> > + * This routine is called to allocate an "extent free done"
> > + * log item that will hold nextents worth of extents. The
> > + * caller must use all nextents extents, because we are not
> > + * flexible about this at all.
> > + */
>
> Comment needs updating.
Ok.
> Brian
>
> > +struct xfs_rud_log_item *
> > +xfs_trans_get_rud(
> > + struct xfs_trans *tp,
> > + struct xfs_rui_log_item *ruip,
> > + uint nextents)
> > +{
> > + struct xfs_rud_log_item *rudp;
> > +
> > + ASSERT(tp != NULL);
> > + ASSERT(nextents > 0);
> > +
> > + rudp = xfs_rud_init(tp->t_mountp, ruip, nextents);
> > + ASSERT(rudp != NULL);
> > +
> > + /*
> > + * Get a log_item_desc to point at the new item.
> > + */
> > + xfs_trans_add_item(tp, &rudp->rud_item);
> > + return rudp;
> > +}
> > +
> > +/*
> > + * Finish an rmap update and log it to the RUD. Note that the transaction is
> > + * marked dirty regardless of whether the rmap update succeeds or fails to
> > + * support the RUI/RUD lifecycle rules.
> > + */
> > +int
> > +xfs_trans_log_finish_rmap_update(
> > + struct xfs_trans *tp,
> > + struct xfs_rud_log_item *rudp,
> > + enum xfs_rmap_intent_type type,
> > + __uint64_t owner,
> > + int whichfork,
> > + xfs_fileoff_t startoff,
> > + xfs_fsblock_t startblock,
> > + xfs_filblks_t blockcount,
> > + xfs_exntst_t state)
> > +{
> > + uint next_extent;
> > + struct xfs_map_extent *rmap;
> > + int error;
> > +
> > + /* XXX: actually finish the rmap update here */
> > + error = -EFSCORRUPTED;
> > +
> > + /*
> > + * Mark the transaction dirty, even on error. This ensures the
> > + * transaction is aborted, which:
> > + *
> > + * 1.) releases the RUI and frees the RUD
> > + * 2.) shuts down the filesystem
> > + */
> > + tp->t_flags |= XFS_TRANS_DIRTY;
> > + rudp->rud_item.li_desc->lid_flags |= XFS_LID_DIRTY;
> > +
> > + next_extent = rudp->rud_next_extent;
> > + ASSERT(next_extent < rudp->rud_format.rud_nextents);
> > + rmap = &(rudp->rud_format.rud_extents[next_extent]);
> > + rmap->me_owner = owner;
> > + rmap->me_startblock = startblock;
> > + rmap->me_startoff = startoff;
> > + rmap->me_len = blockcount;
> > + rmap->me_flags = 0;
> > + if (state == XFS_EXT_UNWRITTEN)
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNWRITTEN;
> > + if (whichfork == XFS_ATTR_FORK)
> > + rmap->me_flags |= XFS_RMAP_EXTENT_ATTR_FORK;
> > + switch (type) {
> > + case XFS_RMAP_MAP:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_MAP;
> > + break;
> > + case XFS_RMAP_MAP_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_MAP_SHARED;
> > + break;
> > + case XFS_RMAP_UNMAP:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNMAP;
> > + break;
> > + case XFS_RMAP_UNMAP_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_UNMAP_SHARED;
> > + break;
> > + case XFS_RMAP_CONVERT:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_CONVERT;
> > + break;
> > + case XFS_RMAP_CONVERT_SHARED:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_CONVERT_SHARED;
> > + break;
> > + case XFS_RMAP_ALLOC:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_ALLOC;
> > + break;
> > + case XFS_RMAP_FREE:
> > + rmap->me_flags |= XFS_RMAP_EXTENT_FREE;
> > + break;
> > + default:
> > + ASSERT(0);
> > + }
> > + rudp->rud_next_extent++;
> > +
> > + return error;
> > +}
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-07-16 7:34 UTC|newest]
Thread overview: 472+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 1:17 [PATCH v6 000/119] xfs: add reverse mapping, reflink, dedupe, and online scrub support Darrick J. Wong
2016-06-17 1:17 ` Darrick J. Wong
2016-06-17 1:17 ` [PATCH 001/119] vfs: fix return type of ioctl_file_dedupe_range Darrick J. Wong
2016-06-17 1:17 ` Darrick J. Wong
2016-06-17 11:32 ` Christoph Hellwig
2016-06-17 11:32 ` Christoph Hellwig
2016-06-28 19:19 ` Darrick J. Wong
2016-06-28 19:19 ` Darrick J. Wong
2016-06-17 1:18 ` [PATCH 002/119] vfs: support FS_XFLAG_REFLINK and FS_XFLAG_COWEXTSIZE Darrick J. Wong
2016-06-17 1:18 ` Darrick J. Wong
2016-06-17 11:41 ` Christoph Hellwig
2016-06-17 11:41 ` Christoph Hellwig
2016-06-17 12:16 ` Brian Foster
2016-06-17 12:16 ` Brian Foster
2016-06-17 15:06 ` Christoph Hellwig
2016-06-17 15:06 ` Christoph Hellwig
2016-06-17 16:54 ` Darrick J. Wong
2016-06-17 16:54 ` Darrick J. Wong
2016-06-17 17:38 ` Brian Foster
2016-06-17 17:38 ` Brian Foster
2016-06-17 1:18 ` [PATCH 003/119] xfs: check offsets of variable length structures Darrick J. Wong
2016-06-17 1:18 ` Darrick J. Wong
2016-06-17 11:33 ` Christoph Hellwig
2016-06-17 11:33 ` Christoph Hellwig
2016-06-17 17:34 ` Brian Foster
2016-06-17 17:34 ` Brian Foster
2016-06-18 18:01 ` Darrick J. Wong
2016-06-18 18:01 ` Darrick J. Wong
2016-06-20 12:38 ` Brian Foster
2016-06-20 12:38 ` Brian Foster
2016-06-17 1:18 ` [PATCH 004/119] xfs: enable buffer deadlock postmortem diagnosis via ftrace Darrick J. Wong
2016-06-17 1:18 ` Darrick J. Wong
2016-06-17 11:34 ` Christoph Hellwig
2016-06-17 11:34 ` Christoph Hellwig
2016-06-21 0:47 ` Dave Chinner
2016-06-21 0:47 ` Dave Chinner
2016-06-17 1:18 ` [PATCH 005/119] xfs: check for a valid error_tag in errortag_add Darrick J. Wong
2016-06-17 1:18 ` Darrick J. Wong
2016-06-17 11:34 ` Christoph Hellwig
2016-06-17 11:34 ` Christoph Hellwig
2016-06-17 1:18 ` [PATCH 006/119] xfs: port differences from xfsprogs libxfs Darrick J. Wong
2016-06-17 1:18 ` Darrick J. Wong
2016-06-17 15:06 ` Christoph Hellwig
2016-06-20 0:21 ` Dave Chinner
2016-06-20 0:21 ` Dave Chinner
2016-07-13 23:39 ` Darrick J. Wong
2016-07-13 23:39 ` Darrick J. Wong
2016-06-17 1:18 ` [PATCH 007/119] xfs: rearrange xfs_bmap_add_free parameters Darrick J. Wong
2016-06-17 1:18 ` Darrick J. Wong
2016-06-17 11:39 ` Christoph Hellwig
2016-06-17 11:39 ` Christoph Hellwig
2016-06-17 1:18 ` [PATCH 008/119] xfs: separate freelist fixing into a separate helper Darrick J. Wong
2016-06-17 1:18 ` Darrick J. Wong
2016-06-17 11:52 ` Christoph Hellwig
2016-06-17 11:52 ` Christoph Hellwig
2016-06-21 0:48 ` Dave Chinner
2016-06-21 0:48 ` Dave Chinner
2016-06-21 1:40 ` Dave Chinner
2016-06-21 1:40 ` Dave Chinner
2016-06-17 1:18 ` [PATCH 009/119] xfs: convert list of extents to free into a regular list Darrick J. Wong
2016-06-17 1:18 ` Darrick J. Wong
2016-06-17 11:59 ` Christoph Hellwig
2016-06-17 11:59 ` Christoph Hellwig
2016-06-18 20:15 ` Darrick J. Wong
2016-06-18 20:15 ` Darrick J. Wong
2016-06-21 0:57 ` Dave Chinner
2016-06-21 0:57 ` Dave Chinner
2016-07-18 3:30 ` Eric Sandeen
2016-06-17 1:18 ` [PATCH 010/119] xfs: create a standard btree size calculator code Darrick J. Wong
2016-06-17 1:18 ` Darrick J. Wong
2016-06-20 14:31 ` Brian Foster
2016-06-20 14:31 ` Brian Foster
2016-06-20 19:34 ` Darrick J. Wong
2016-06-20 19:34 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 011/119] xfs: refactor btree maxlevels computation Darrick J. Wong
2016-06-17 1:19 ` Darrick J. Wong
2016-06-20 14:31 ` Brian Foster
2016-06-20 14:31 ` Brian Foster
2016-06-20 18:23 ` Darrick J. Wong
2016-06-20 18:23 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 012/119] xfs: during btree split, save new block key & ptr for future insertion Darrick J. Wong
2016-06-17 1:19 ` Darrick J. Wong
2016-06-21 13:00 ` Brian Foster
2016-06-21 13:00 ` Brian Foster
2016-06-27 22:30 ` Darrick J. Wong
2016-06-27 22:30 ` Darrick J. Wong
2016-06-28 12:31 ` Brian Foster
2016-06-28 12:31 ` Brian Foster
2016-06-17 1:19 ` [PATCH 013/119] xfs: support btrees with overlapping intervals for keys Darrick J. Wong
2016-06-17 1:19 ` Darrick J. Wong
2016-06-22 15:17 ` Brian Foster
2016-06-22 15:17 ` Brian Foster
2016-06-28 3:26 ` Darrick J. Wong
2016-06-28 3:26 ` Darrick J. Wong
2016-06-28 12:32 ` Brian Foster
2016-06-28 12:32 ` Brian Foster
2016-06-28 17:36 ` Darrick J. Wong
2016-06-28 17:36 ` Darrick J. Wong
2016-07-06 4:59 ` Dave Chinner
2016-07-06 4:59 ` Dave Chinner
2016-07-06 8:09 ` Darrick J. Wong
2016-07-06 8:09 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 014/119] xfs: introduce interval queries on btrees Darrick J. Wong
2016-06-17 1:19 ` Darrick J. Wong
2016-06-22 15:18 ` Brian Foster
2016-06-22 15:18 ` Brian Foster
2016-06-27 21:07 ` Darrick J. Wong
2016-06-27 21:07 ` Darrick J. Wong
2016-06-28 12:32 ` Brian Foster
2016-06-28 12:32 ` Brian Foster
2016-06-28 16:29 ` Darrick J. Wong
2016-06-28 16:29 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 015/119] xfs: refactor btree owner change into a separate visit-blocks function Darrick J. Wong
2016-06-17 1:19 ` Darrick J. Wong
2016-06-23 17:19 ` Brian Foster
2016-06-23 17:19 ` Brian Foster
2016-06-17 1:19 ` [PATCH 016/119] xfs: move deferred operations into a separate file Darrick J. Wong
2016-06-17 1:19 ` Darrick J. Wong
2016-06-27 13:14 ` Brian Foster
2016-06-27 13:14 ` Brian Foster
2016-06-27 19:14 ` Darrick J. Wong
2016-06-27 19:14 ` Darrick J. Wong
2016-06-28 12:32 ` Brian Foster
2016-06-28 12:32 ` Brian Foster
2016-06-28 18:51 ` Darrick J. Wong
2016-06-28 18:51 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 017/119] xfs: add tracepoints for the deferred ops mechanism Darrick J. Wong
2016-06-17 1:19 ` Darrick J. Wong
2016-06-27 13:15 ` Brian Foster
2016-06-27 13:15 ` Brian Foster
2016-06-17 1:19 ` [PATCH 018/119] xfs: enable the xfs_defer mechanism to process extents to free Darrick J. Wong
2016-06-17 1:19 ` Darrick J. Wong
2016-06-27 13:15 ` Brian Foster
2016-06-27 13:15 ` Brian Foster
2016-06-27 21:41 ` Darrick J. Wong
2016-06-27 21:41 ` Darrick J. Wong
2016-06-27 22:00 ` Darrick J. Wong
2016-06-27 22:00 ` Darrick J. Wong
2016-06-28 12:32 ` Brian Foster
2016-06-28 12:32 ` Brian Foster
2016-06-28 16:33 ` Darrick J. Wong
2016-06-28 16:33 ` Darrick J. Wong
2016-06-17 1:19 ` [PATCH 019/119] xfs: rework xfs_bmap_free callers to use xfs_defer_ops Darrick J. Wong
2016-06-17 1:19 ` Darrick J. Wong
2016-06-17 1:20 ` [PATCH 020/119] xfs: change xfs_bmap_{finish, cancel, init, free} -> xfs_defer_* Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-06-30 0:11 ` Darrick J. Wong
2016-06-30 0:11 ` Darrick J. Wong
2016-06-17 1:20 ` [PATCH 021/119] xfs: rename flist/free_list to dfops Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-06-17 1:20 ` [PATCH 022/119] xfs: add tracepoints and error injection for deferred extent freeing Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-06-17 1:20 ` [PATCH 023/119] xfs: introduce rmap btree definitions Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-06-30 17:32 ` Brian Foster
2016-06-30 17:32 ` Brian Foster
2016-06-17 1:20 ` [PATCH 024/119] xfs: add rmap btree stats infrastructure Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-06-30 17:32 ` Brian Foster
2016-06-30 17:32 ` Brian Foster
2016-06-17 1:20 ` [PATCH 025/119] xfs: rmap btree add more reserved blocks Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-06-30 17:32 ` Brian Foster
2016-06-30 17:32 ` Brian Foster
2016-06-17 1:20 ` [PATCH 026/119] xfs: add owner field to extent allocation and freeing Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-07-06 4:01 ` Dave Chinner
2016-07-06 4:01 ` Dave Chinner
2016-07-06 6:44 ` Darrick J. Wong
2016-07-06 6:44 ` Darrick J. Wong
2016-07-07 15:12 ` Brian Foster
2016-07-07 15:12 ` Brian Foster
2016-07-07 19:09 ` Darrick J. Wong
2016-07-07 19:09 ` Darrick J. Wong
2016-07-07 22:55 ` Dave Chinner
2016-07-07 22:55 ` Dave Chinner
2016-07-08 11:37 ` Brian Foster
2016-07-08 11:37 ` Brian Foster
2016-06-17 1:20 ` [PATCH 027/119] xfs: introduce rmap extent operation stubs Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-06-17 1:20 ` [PATCH 028/119] xfs: define the on-disk rmap btree format Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-07-06 4:05 ` Dave Chinner
2016-07-06 4:05 ` Dave Chinner
2016-07-06 6:44 ` Darrick J. Wong
2016-07-06 6:44 ` Darrick J. Wong
2016-07-07 18:41 ` Brian Foster
2016-07-07 18:41 ` Brian Foster
2016-07-07 19:18 ` Darrick J. Wong
2016-07-07 19:18 ` Darrick J. Wong
2016-07-07 23:14 ` Dave Chinner
2016-07-07 23:14 ` Dave Chinner
2016-07-07 23:58 ` Darrick J. Wong
2016-07-07 23:58 ` Darrick J. Wong
2016-06-17 1:20 ` [PATCH 029/119] xfs: add rmap btree growfs support Darrick J. Wong
2016-06-17 1:20 ` Darrick J. Wong
2016-06-17 1:21 ` [PATCH 030/119] xfs: rmap btree transaction reservations Darrick J. Wong
2016-06-17 1:21 ` Darrick J. Wong
2016-07-08 13:21 ` Brian Foster
2016-07-08 13:21 ` Brian Foster
2016-06-17 1:21 ` [PATCH 031/119] xfs: rmap btree requires more reserved free space Darrick J. Wong
2016-06-17 1:21 ` Darrick J. Wong
2016-07-08 13:21 ` Brian Foster
2016-07-08 13:21 ` Brian Foster
2016-07-13 16:50 ` Darrick J. Wong
2016-07-13 16:50 ` Darrick J. Wong
2016-07-13 18:32 ` Brian Foster
2016-07-13 18:32 ` Brian Foster
2016-07-13 23:50 ` Dave Chinner
2016-07-13 23:50 ` Dave Chinner
2016-06-17 1:21 ` [PATCH 032/119] xfs: add rmap btree operations Darrick J. Wong
2016-06-17 1:21 ` Darrick J. Wong
2016-07-08 18:33 ` Brian Foster
2016-07-08 18:33 ` Brian Foster
2016-07-08 23:53 ` Darrick J. Wong
2016-07-08 23:53 ` Darrick J. Wong
2016-06-17 1:21 ` [PATCH 033/119] xfs: support overlapping intervals in the rmap btree Darrick J. Wong
2016-06-17 1:21 ` Darrick J. Wong
2016-07-08 18:33 ` Brian Foster
2016-07-08 18:33 ` Brian Foster
2016-07-09 0:14 ` Darrick J. Wong
2016-07-09 0:14 ` Darrick J. Wong
2016-07-09 13:25 ` Brian Foster
2016-07-09 13:25 ` Brian Foster
2016-06-17 1:21 ` [PATCH 034/119] xfs: teach rmapbt to support interval queries Darrick J. Wong
2016-06-17 1:21 ` Darrick J. Wong
2016-07-08 18:34 ` Brian Foster
2016-07-08 18:34 ` Brian Foster
2016-07-09 0:16 ` Darrick J. Wong
2016-07-09 0:16 ` Darrick J. Wong
2016-07-09 13:25 ` Brian Foster
2016-07-09 13:25 ` Brian Foster
2016-06-17 1:21 ` [PATCH 035/119] xfs: add tracepoints for the rmap functions Darrick J. Wong
2016-06-17 1:21 ` Darrick J. Wong
2016-07-08 18:34 ` Brian Foster
2016-07-08 18:34 ` Brian Foster
2016-06-17 1:21 ` [PATCH 036/119] xfs: add an extent to the rmap btree Darrick J. Wong
2016-06-17 1:21 ` Darrick J. Wong
2016-07-11 18:49 ` Brian Foster
2016-07-11 18:49 ` Brian Foster
2016-07-11 23:01 ` Darrick J. Wong
2016-07-11 23:01 ` Darrick J. Wong
2016-06-17 1:21 ` [PATCH 037/119] xfs: remove an extent from " Darrick J. Wong
2016-06-17 1:21 ` Darrick J. Wong
2016-07-11 18:49 ` Brian Foster
2016-07-11 18:49 ` Brian Foster
2016-06-17 1:21 ` [PATCH 038/119] xfs: convert unwritten status of reverse mappings Darrick J. Wong
2016-06-17 1:21 ` Darrick J. Wong
2016-06-30 0:15 ` Darrick J. Wong
2016-06-30 0:15 ` Darrick J. Wong
2016-07-13 18:27 ` Brian Foster
2016-07-13 18:27 ` Brian Foster
2016-07-13 20:43 ` Darrick J. Wong
2016-07-13 20:43 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 039/119] xfs: add rmap btree insert and delete helpers Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-13 18:28 ` Brian Foster
2016-07-13 18:28 ` Brian Foster
2016-07-13 18:37 ` Darrick J. Wong
2016-07-13 18:37 ` Darrick J. Wong
2016-07-13 18:42 ` Brian Foster
2016-07-13 18:42 ` Brian Foster
2016-06-17 1:22 ` [PATCH 040/119] xfs: create helpers for mapping, unmapping, and converting file fork extents Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-13 18:28 ` Brian Foster
2016-07-13 18:28 ` Brian Foster
2016-07-13 18:47 ` Darrick J. Wong
2016-07-13 18:47 ` Darrick J. Wong
2016-07-13 23:54 ` Dave Chinner
2016-07-13 23:54 ` Dave Chinner
2016-07-13 23:55 ` Darrick J. Wong
2016-07-13 23:55 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 041/119] xfs: create rmap update intent log items Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-15 18:33 ` Brian Foster
2016-07-15 18:33 ` Brian Foster
2016-07-16 7:10 ` Darrick J. Wong
2016-07-16 7:10 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 042/119] xfs: log rmap intent items Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-15 18:33 ` Brian Foster
2016-07-15 18:33 ` Brian Foster
2016-07-16 7:34 ` Darrick J. Wong [this message]
2016-07-16 7:34 ` Darrick J. Wong
2016-07-18 12:55 ` Brian Foster
2016-07-18 12:55 ` Brian Foster
2016-07-19 17:10 ` Darrick J. Wong
2016-07-19 17:10 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 043/119] xfs: enable the xfs_defer mechanism to process rmaps to update Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-15 18:33 ` Brian Foster
2016-07-15 18:33 ` Brian Foster
2016-06-17 1:22 ` [PATCH 044/119] xfs: propagate bmap updates to rmapbt Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-15 18:33 ` Brian Foster
2016-07-15 18:33 ` Brian Foster
2016-07-16 7:26 ` Darrick J. Wong
2016-07-16 7:26 ` Darrick J. Wong
2016-07-18 1:21 ` Dave Chinner
2016-07-18 1:21 ` Dave Chinner
2016-07-18 12:56 ` Brian Foster
2016-07-18 12:56 ` Brian Foster
2016-07-18 12:55 ` Brian Foster
2016-07-18 12:55 ` Brian Foster
2016-07-19 1:53 ` Darrick J. Wong
2016-07-19 1:53 ` Darrick J. Wong
2016-07-19 11:37 ` Brian Foster
2016-07-19 11:37 ` Brian Foster
2016-06-17 1:22 ` [PATCH 045/119] xfs: add rmap btree geometry feature flag Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-07-18 13:34 ` Brian Foster
2016-06-17 1:22 ` [PATCH 046/119] xfs: add rmap btree block detection to log recovery Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-07-18 13:34 ` Brian Foster
2016-06-17 1:22 ` [PATCH 047/119] xfs: disable XFS_IOC_SWAPEXT when rmap btree is enabled Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-07-18 13:34 ` Brian Foster
2016-07-18 16:18 ` Darrick J. Wong
2016-07-18 16:18 ` Darrick J. Wong
2016-06-17 1:22 ` [PATCH 048/119] xfs: don't update rmapbt when fixing agfl Darrick J. Wong
2016-06-17 1:22 ` Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-07-18 13:34 ` Brian Foster
2016-07-18 15:53 ` Darrick J. Wong
2016-07-18 15:53 ` Darrick J. Wong
2016-06-17 1:23 ` [PATCH 049/119] xfs: enable the rmap btree functionality Darrick J. Wong
2016-06-17 1:23 ` Darrick J. Wong
2016-07-18 13:34 ` Brian Foster
2016-07-18 13:34 ` Brian Foster
2016-06-17 1:23 ` [PATCH 050/119] xfs: count the blocks in a btree Darrick J. Wong
2016-06-17 1:23 ` Darrick J. Wong
2016-06-17 1:23 ` [PATCH 051/119] xfs: introduce tracepoints for AG reservation code Darrick J. Wong
2016-06-17 1:23 ` Darrick J. Wong
2016-06-17 1:23 ` [PATCH 052/119] xfs: set up per-AG free space reservations Darrick J. Wong
2016-06-17 1:23 ` Darrick J. Wong
2016-06-17 1:23 ` [PATCH 053/119] xfs: define tracepoints for refcount btree activities Darrick J. Wong
2016-06-17 1:23 ` Darrick J. Wong
2016-06-17 1:23 ` [PATCH 054/119] xfs: introduce refcount btree definitions Darrick J. Wong
2016-06-17 1:23 ` Darrick J. Wong
2016-06-17 1:23 ` [PATCH 055/119] xfs: add refcount btree stats infrastructure Darrick J. Wong
2016-06-17 1:23 ` Darrick J. Wong
2016-06-17 1:23 ` [PATCH 056/119] xfs: refcount btree add more reserved blocks Darrick J. Wong
2016-06-17 1:23 ` Darrick J. Wong
2016-06-17 1:23 ` [PATCH 057/119] xfs: define the on-disk refcount btree format Darrick J. Wong
2016-06-17 1:23 ` Darrick J. Wong
2016-06-17 1:24 ` [PATCH 058/119] xfs: add refcount btree support to growfs Darrick J. Wong
2016-06-17 1:24 ` Darrick J. Wong
2016-06-17 1:24 ` [PATCH 059/119] xfs: account for the refcount btree in the alloc/free log reservation Darrick J. Wong
2016-06-17 1:24 ` Darrick J. Wong
2016-06-17 1:24 ` [PATCH 060/119] xfs: add refcount btree operations Darrick J. Wong
2016-06-17 1:24 ` Darrick J. Wong
2016-06-17 1:24 ` [PATCH 061/119] xfs: create refcount update intent log items Darrick J. Wong
2016-06-17 1:24 ` Darrick J. Wong
2016-06-17 1:24 ` [PATCH 062/119] xfs: log refcount intent items Darrick J. Wong
2016-06-17 1:24 ` Darrick J. Wong
2016-06-17 1:24 ` [PATCH 063/119] xfs: adjust refcount of an extent of blocks in refcount btree Darrick J. Wong
2016-06-17 1:24 ` Darrick J. Wong
2016-06-17 1:24 ` [PATCH 064/119] xfs: connect refcount adjust functions to upper layers Darrick J. Wong
2016-06-17 1:24 ` Darrick J. Wong
2016-06-17 1:24 ` [PATCH 065/119] xfs: adjust refcount when unmapping file blocks Darrick J. Wong
2016-06-17 1:24 ` Darrick J. Wong
2016-06-17 1:24 ` [PATCH 066/119] xfs: add refcount btree block detection to log recovery Darrick J. Wong
2016-06-17 1:24 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 067/119] xfs: refcount btree requires more reserved space Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 068/119] xfs: introduce reflink utility functions Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 069/119] xfs: create bmbt update intent log items Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 070/119] xfs: log bmap intent items Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 071/119] xfs: map an inode's offset to an exact physical block Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 072/119] xfs: implement deferred bmbt map/unmap operations Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 073/119] xfs: return work remaining at the end of a bunmapi operation Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 074/119] xfs: define tracepoints for reflink activities Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 075/119] xfs: add reflink feature flag to geometry Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:25 ` [PATCH 076/119] xfs: don't allow reflinked dir/dev/fifo/socket/pipe files Darrick J. Wong
2016-06-17 1:25 ` Darrick J. Wong
2016-06-17 1:26 ` [PATCH 077/119] xfs: introduce the CoW fork Darrick J. Wong
2016-06-17 1:26 ` Darrick J. Wong
2016-06-17 1:26 ` [PATCH 078/119] xfs: support bmapping delalloc extents in " Darrick J. Wong
2016-06-17 1:26 ` Darrick J. Wong
2016-06-17 1:26 ` [PATCH 079/119] xfs: create delalloc extents in " Darrick J. Wong
2016-06-17 1:26 ` Darrick J. Wong
2016-06-17 1:26 ` [PATCH 080/119] xfs: support allocating delayed " Darrick J. Wong
2016-06-17 1:26 ` Darrick J. Wong
2016-06-17 1:26 ` [PATCH 081/119] xfs: allocate " Darrick J. Wong
2016-06-17 1:26 ` Darrick J. Wong
2016-06-17 1:26 ` [PATCH 082/119] xfs: support removing extents from " Darrick J. Wong
2016-06-17 1:26 ` Darrick J. Wong
2016-06-17 1:26 ` [PATCH 083/119] xfs: move mappings from cow fork to data fork after copy-write Darrick J. Wong
2016-06-17 1:26 ` Darrick J. Wong
2016-06-17 1:26 ` [PATCH 084/119] xfs: implement CoW for directio writes Darrick J. Wong
2016-06-17 1:26 ` Darrick J. Wong
2016-06-17 1:26 ` [PATCH 085/119] xfs: copy-on-write reflinked blocks when zeroing ranges of blocks Darrick J. Wong
2016-06-17 1:26 ` Darrick J. Wong
2016-06-17 1:27 ` [PATCH 086/119] xfs: cancel CoW reservations and clear inode reflink flag when freeing blocks Darrick J. Wong
2016-06-17 1:27 ` Darrick J. Wong
2016-06-17 1:27 ` [PATCH 087/119] xfs: cancel pending CoW reservations when destroying inodes Darrick J. Wong
2016-06-17 1:27 ` Darrick J. Wong
2016-06-17 1:27 ` [PATCH 088/119] xfs: store in-progress CoW allocations in the refcount btree Darrick J. Wong
2016-06-17 1:27 ` Darrick J. Wong
2016-06-17 1:27 ` [PATCH 089/119] xfs: reflink extents from one file to another Darrick J. Wong
2016-06-17 1:27 ` Darrick J. Wong
2016-06-17 1:27 ` [PATCH 090/119] xfs: add clone file and clone range vfs functions Darrick J. Wong
2016-06-17 1:27 ` Darrick J. Wong
2016-06-17 1:27 ` [PATCH 091/119] xfs: add dedupe range vfs function Darrick J. Wong
2016-06-17 1:27 ` Darrick J. Wong
2016-06-17 1:27 ` [PATCH 092/119] xfs: teach get_bmapx and fiemap about shared extents and the CoW fork Darrick J. Wong
2016-06-17 1:27 ` Darrick J. Wong
2016-06-17 1:27 ` [PATCH 093/119] xfs: swap inode reflink flags when swapping inode extents Darrick J. Wong
2016-06-17 1:27 ` Darrick J. Wong
2016-06-17 1:27 ` [PATCH 094/119] xfs: unshare a range of blocks via fallocate Darrick J. Wong
2016-06-17 1:27 ` Darrick J. Wong
2016-06-17 1:28 ` [PATCH 095/119] xfs: CoW shared EOF block when truncating file Darrick J. Wong
2016-06-17 1:28 ` Darrick J. Wong
2016-06-17 1:28 ` [PATCH 096/119] xfs: support FS_XFLAG_REFLINK on reflink filesystems Darrick J. Wong
2016-06-17 1:28 ` Darrick J. Wong
2016-06-17 1:28 ` [PATCH 097/119] xfs: create a separate cow extent size hint for the allocator Darrick J. Wong
2016-06-17 1:28 ` Darrick J. Wong
2016-06-17 1:28 ` [PATCH 098/119] xfs: preallocate blocks for worst-case btree expansion Darrick J. Wong
2016-06-17 1:28 ` Darrick J. Wong
2016-06-17 1:28 ` [PATCH 099/119] xfs: don't allow reflink when the AG is low on space Darrick J. Wong
2016-06-17 1:28 ` Darrick J. Wong
2016-06-17 1:28 ` [PATCH 100/119] xfs: try other AGs to allocate a BMBT block Darrick J. Wong
2016-06-17 1:28 ` Darrick J. Wong
2016-06-17 1:28 ` [PATCH 101/119] xfs: promote buffered writes to CoW when cowextsz is set Darrick J. Wong
2016-06-17 1:28 ` Darrick J. Wong
2016-06-17 1:28 ` [PATCH 102/119] xfs: garbage collect old cowextsz reservations Darrick J. Wong
2016-06-17 1:28 ` Darrick J. Wong
2016-06-17 1:28 ` [PATCH 103/119] xfs: provide switch to force filesystem to copy-on-write all the time Darrick J. Wong
2016-06-17 1:28 ` Darrick J. Wong
2016-06-17 1:29 ` [PATCH 104/119] xfs: increase log reservations for reflink Darrick J. Wong
2016-06-17 1:29 ` Darrick J. Wong
2016-06-17 1:29 ` [PATCH 105/119] xfs: use interval query for rmap alloc operations on shared files Darrick J. Wong
2016-06-17 1:29 ` Darrick J. Wong
2016-06-17 1:29 ` [PATCH 106/119] xfs: convert unwritten status of reverse mappings for " Darrick J. Wong
2016-06-17 1:29 ` Darrick J. Wong
2016-06-17 1:29 ` [PATCH 107/119] xfs: set a default CoW extent size of 32 blocks Darrick J. Wong
2016-06-17 1:29 ` Darrick J. Wong
2016-06-17 1:29 ` [PATCH 108/119] xfs: don't allow realtime and reflinked files to mix Darrick J. Wong
2016-06-17 1:29 ` Darrick J. Wong
2016-06-17 1:29 ` [PATCH 109/119] xfs: don't mix reflink and DAX mode for now Darrick J. Wong
2016-06-17 1:29 ` Darrick J. Wong
2016-06-17 1:29 ` [PATCH 110/119] xfs: fail ->bmap for reflink inodes Darrick J. Wong
2016-06-17 1:29 ` Darrick J. Wong
2016-06-17 1:29 ` [PATCH 111/119] xfs: recognize the reflink feature bit Darrick J. Wong
2016-06-17 1:29 ` Darrick J. Wong
2016-06-17 1:29 ` [PATCH 112/119] xfs: introduce the XFS_IOC_GETFSMAPX ioctl Darrick J. Wong
2016-06-17 1:29 ` Darrick J. Wong
2016-06-17 1:30 ` [PATCH 113/119] xfs: scrub btree records and pointers while querying Darrick J. Wong
2016-06-17 1:30 ` Darrick J. Wong
2016-06-17 1:30 ` [PATCH 114/119] xfs: create sysfs hooks to scrub various files Darrick J. Wong
2016-06-17 1:30 ` Darrick J. Wong
2016-06-17 1:30 ` [PATCH 115/119] xfs: support scrubbing free space btrees Darrick J. Wong
2016-06-17 1:30 ` Darrick J. Wong
2016-06-17 1:30 ` [PATCH 116/119] xfs: support scrubbing inode btrees Darrick J. Wong
2016-06-17 1:30 ` Darrick J. Wong
2016-06-17 1:30 ` [PATCH 117/119] xfs: support scrubbing rmap btree Darrick J. Wong
2016-06-17 1:30 ` Darrick J. Wong
2016-06-17 1:30 ` [PATCH 118/119] xfs: support scrubbing refcount btree Darrick J. Wong
2016-06-17 1:30 ` Darrick J. Wong
2016-06-17 1:30 ` [PATCH 119/119] xfs: add btree scrub tracepoints Darrick J. Wong
2016-06-17 1:30 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160716073408.GD21529@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.