From: Josh Poimboeuf <jpoimboe@redhat.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, linux@arm.linux.org.uk, mhiramat@kernel.org,
masami.hiramatsu.pt@hitachi.com, jbaron@akamai.com,
heiko.carstens@de.ibm.com, ananth@linux.vnet.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net,
realmz6@gmail.com, x86@kernel.org, luto@amacapital.net,
keescook@chromium.org, torvalds@linux-foundation.org,
gregkh@linuxfoundation.org, rusty@rustcorp.com.au,
gnomes@lxorguk.ukuu.org.uk, alan@linux.intel.com,
dwmw2@infradead.org, arnd@arndb.de, ming.lei@canonical.com,
linux-arch@vger.kernel.org, benh@kernel.crashing.org,
ananth@in.ibm.com, pebolle@tiscali.nl, fontana@sharpeleven.org,
ciaran.farrell@suse.com, christopher.denicolo@suse.com,
david.vrabel@citrix.com, konrad.wilk@oracle.com, mcb30@ipxe.org,
jgross@suse.com, andrew.cooper3@citrix.com,
andriy.shevchenko@linux.intel.com, paul.gortmaker@windri
Subject: Re: [RFC v3 10/13] jump_label: port __jump_table to linker tables
Date: Fri, 22 Jul 2016 21:49:45 +0000 [thread overview]
Message-ID: <20160722214945.h7v7fvsnuhnvz6ux@treble> (raw)
In-Reply-To: <1469222687-1600-11-git-send-email-mcgrof@kernel.org>
On Fri, Jul 22, 2016 at 02:24:44PM -0700, Luis R. Rodriguez wrote:
> diff --git a/tools/objtool/special.c b/tools/objtool/special.c
> index bff8abb3a4aa..f0ad369f994b 100644
> --- a/tools/objtool/special.c
> +++ b/tools/objtool/special.c
> @@ -26,6 +26,10 @@
> #include "special.h"
> #include "warn.h"
>
> +#include "../../include/asm-generic/sections.h"
> +#include "../../include/asm-generic/tables.h"
> +#include "../../include/linux/stringify.h"
> +
> #define EX_ENTRY_SIZE 12
> #define EX_ORIG_OFFSET 0
> #define EX_NEW_OFFSET 4
> @@ -63,7 +67,9 @@ struct special_entry entries[] = {
> .feature = ALT_FEATURE_OFFSET,
> },
> {
> - .sec = "__jump_table",
> + .sec = __stringify(SECTION_TBL(SECTION_DATA,
> + __jump_table,
> + SECTION_ORDER_ANY)),
> .jump_or_nop = true,
> .size = JUMP_ENTRY_SIZE,
> .orig = JUMP_ORIG_OFFSET,
(continuing our discussion from another thread...)
I think tools code isn't allowed to include kernel files because the
tools subdirectory is supposed to be completely independent.
As far as I can tell, the section name will always be
".data.tbl.__jump_table.any". Is that true? If so, any reason why we
can't just hard-code the string here? As you saw, if the string
changes, objtool will complain and 0-day will report it.
--
Josh
WARNING: multiple messages have this Message-ID (diff)
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, linux@arm.linux.org.uk, mhiramat@kernel.org,
masami.hiramatsu.pt@hitachi.com, jbaron@akamai.com,
heiko.carstens@de.ibm.com, ananth@linux.vnet.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net,
realmz6@gmail.com, x86@kernel.org, luto@amacapital.net,
keescook@chromium.org, torvalds@linux-foundation.org,
gregkh@linuxfoundation.org, rusty@rustcorp.com.au,
gnomes@lxorguk.ukuu.org.uk, alan@linux.intel.com,
dwmw2@infradead.org, arnd@arndb.de, ming.lei@canonical.com,
linux-arch@vger.kernel.org, benh@kernel.crashing.org,
ananth@in.ibm.com, pebolle@tiscali.nl, fontana@sharpeleven.org,
ciaran.farrell@suse.com, christopher.denicolo@suse.com,
david.vrabel@citrix.com, konrad.wilk@oracle.com, mcb30@ipxe.org,
jgross@suse.com, andrew.cooper3@citrix.com,
andriy.shevchenko@linux.intel.com, paul.gortmaker@windri
Subject: Re: [RFC v3 10/13] jump_label: port __jump_table to linker tables
Date: Fri, 22 Jul 2016 16:49:45 -0500 [thread overview]
Message-ID: <20160722214945.h7v7fvsnuhnvz6ux@treble> (raw)
In-Reply-To: <1469222687-1600-11-git-send-email-mcgrof@kernel.org>
On Fri, Jul 22, 2016 at 02:24:44PM -0700, Luis R. Rodriguez wrote:
> diff --git a/tools/objtool/special.c b/tools/objtool/special.c
> index bff8abb3a4aa..f0ad369f994b 100644
> --- a/tools/objtool/special.c
> +++ b/tools/objtool/special.c
> @@ -26,6 +26,10 @@
> #include "special.h"
> #include "warn.h"
>
> +#include "../../include/asm-generic/sections.h"
> +#include "../../include/asm-generic/tables.h"
> +#include "../../include/linux/stringify.h"
> +
> #define EX_ENTRY_SIZE 12
> #define EX_ORIG_OFFSET 0
> #define EX_NEW_OFFSET 4
> @@ -63,7 +67,9 @@ struct special_entry entries[] = {
> .feature = ALT_FEATURE_OFFSET,
> },
> {
> - .sec = "__jump_table",
> + .sec = __stringify(SECTION_TBL(SECTION_DATA,
> + __jump_table,
> + SECTION_ORDER_ANY)),
> .jump_or_nop = true,
> .size = JUMP_ENTRY_SIZE,
> .orig = JUMP_ORIG_OFFSET,
(continuing our discussion from another thread...)
I think tools code isn't allowed to include kernel files because the
tools subdirectory is supposed to be completely independent.
As far as I can tell, the section name will always be
".data.tbl.__jump_table.any". Is that true? If so, any reason why we
can't just hard-code the string here? As you saw, if the string
changes, objtool will complain and 0-day will report it.
--
Josh
WARNING: multiple messages have this Message-ID (diff)
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, linux@arm.linux.org.uk, mhiramat@kernel.org,
masami.hiramatsu.pt@hitachi.com, jbaron@akamai.com,
heiko.carstens@de.ibm.com, ananth@linux.vnet.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net,
realmz6@gmail.com, x86@kernel.org, luto@amacapital.net,
keescook@chromium.org, torvalds@linux-foundation.org,
gregkh@linuxfoundation.org, rusty@rustcorp.com.au,
gnomes@lxorguk.ukuu.org.uk, alan@linux.intel.com,
dwmw2@infradead.org, arnd@arndb.de, ming.lei@canonical.com,
linux-arch@vger.kernel.org, benh@kernel.crashing.org,
ananth@in.ibm.com, pebolle@tiscali.nl, fontana@sharpeleven.org,
ciaran.farrell@suse.com, christopher.denicolo@suse.com,
david.vrabel@citrix.com, konrad.wilk@oracle.com, mcb30@ipxe.org,
jgross@suse.com, andrew.cooper3@citrix.com,
andriy.shevchenko@linux.intel.com, paul.gortmaker@windriver.com,
xen-devel@lists.xensource.com, ak@linux.intel.com,
pali.rohar@gmail.com, dvhart@infradead.org,
platform-driver-x86@vger.kernel.org, mmarek@suse.com,
linux@rasmusvillemoes.dk, jkosina@suse.cz, korea.drzix@gmail.com,
linux-kbuild@vger.kernel.org, tony.luck@intel.com,
akpm@linux-foundation.org, linux-ia64@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, rostedt@goodmis.org
Subject: Re: [RFC v3 10/13] jump_label: port __jump_table to linker tables
Date: Fri, 22 Jul 2016 16:49:45 -0500 [thread overview]
Message-ID: <20160722214945.h7v7fvsnuhnvz6ux@treble> (raw)
In-Reply-To: <1469222687-1600-11-git-send-email-mcgrof@kernel.org>
On Fri, Jul 22, 2016 at 02:24:44PM -0700, Luis R. Rodriguez wrote:
> diff --git a/tools/objtool/special.c b/tools/objtool/special.c
> index bff8abb3a4aa..f0ad369f994b 100644
> --- a/tools/objtool/special.c
> +++ b/tools/objtool/special.c
> @@ -26,6 +26,10 @@
> #include "special.h"
> #include "warn.h"
>
> +#include "../../include/asm-generic/sections.h"
> +#include "../../include/asm-generic/tables.h"
> +#include "../../include/linux/stringify.h"
> +
> #define EX_ENTRY_SIZE 12
> #define EX_ORIG_OFFSET 0
> #define EX_NEW_OFFSET 4
> @@ -63,7 +67,9 @@ struct special_entry entries[] = {
> .feature = ALT_FEATURE_OFFSET,
> },
> {
> - .sec = "__jump_table",
> + .sec = __stringify(SECTION_TBL(SECTION_DATA,
> + __jump_table,
> + SECTION_ORDER_ANY)),
> .jump_or_nop = true,
> .size = JUMP_ENTRY_SIZE,
> .orig = JUMP_ORIG_OFFSET,
(continuing our discussion from another thread...)
I think tools code isn't allowed to include kernel files because the
tools subdirectory is supposed to be completely independent.
As far as I can tell, the section name will always be
".data.tbl.__jump_table.any". Is that true? If so, any reason why we
can't just hard-code the string here? As you saw, if the string
changes, objtool will complain and 0-day will report it.
--
Josh
next prev parent reply other threads:[~2016-07-22 21:49 UTC|newest]
Thread overview: 176+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 21:24 [RFC v3 00/13] linux: generalize sections, ranges and linker tables Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 01/13] x86: remove LTO_REFERENCE_INITCALL() Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 02/13] dell-smo8800: include uaccess.h Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:31 ` Pali Rohár
2016-07-22 21:31 ` Pali Rohár
2016-07-22 21:31 ` Pali Rohár
2016-07-22 21:24 ` [RFC v3 03/13] scripts/module-common.lds: enable generation Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 04/13] sections.h: guard against asm and linker script Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 05/13] sections.h: add sections header to collect all section info Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:37 ` James Hogan
2016-07-22 21:37 ` James Hogan
2016-07-22 21:37 ` James Hogan
2016-07-22 21:41 ` Luis R. Rodriguez
2016-07-22 21:41 ` Luis R. Rodriguez
2016-07-22 21:41 ` Luis R. Rodriguez
2016-07-29 17:28 ` Steven Rostedt
2016-07-29 17:28 ` Steven Rostedt
2016-07-29 17:28 ` Steven Rostedt
2016-07-22 21:24 ` [RFC v3 06/13] ranges.h: add helpers to build and identify Linux section ranges Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 07/13] tables.h: add linker table support Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-25 15:30 ` Masami Hiramatsu
2016-07-25 15:30 ` Masami Hiramatsu
2016-07-25 15:30 ` Masami Hiramatsu
2016-07-27 23:02 ` Luis R. Rodriguez
2016-07-27 23:02 ` Luis R. Rodriguez
2016-07-27 23:02 ` Luis R. Rodriguez
2016-07-28 17:08 ` H. Peter Anvin
2016-07-28 17:08 ` H. Peter Anvin
2016-07-28 17:08 ` H. Peter Anvin
2016-07-28 17:08 ` H. Peter Anvin
2016-07-28 17:08 ` H. Peter Anvin
2016-07-29 10:06 ` Borislav Petkov
2016-07-29 10:06 ` Borislav Petkov
2016-07-29 10:06 ` Borislav Petkov
2016-08-08 15:05 ` Luis R. Rodriguez
2016-08-08 15:05 ` Luis R. Rodriguez
2016-08-08 15:05 ` Luis R. Rodriguez
2016-08-09 3:55 ` Borislav Petkov
2016-08-09 3:55 ` Borislav Petkov
2016-08-09 3:55 ` Borislav Petkov
2016-08-12 3:51 ` Luis R. Rodriguez
2016-08-12 3:51 ` Luis R. Rodriguez
2016-08-12 3:51 ` Luis R. Rodriguez
2016-08-12 5:23 ` Borislav Petkov
2016-08-12 5:23 ` Borislav Petkov
2016-08-12 5:23 ` Borislav Petkov
2016-08-12 6:50 ` Luis R. Rodriguez
2016-08-12 6:50 ` Luis R. Rodriguez
2016-08-12 6:50 ` Luis R. Rodriguez
2016-08-12 7:25 ` Borislav Petkov
2016-08-12 7:25 ` Borislav Petkov
2016-08-12 7:25 ` Borislav Petkov
2016-08-12 15:28 ` Luis R. Rodriguez
2016-08-12 15:28 ` Luis R. Rodriguez
2016-08-12 15:28 ` Luis R. Rodriguez
2016-08-12 15:51 ` Borislav Petkov
2016-08-12 15:51 ` Borislav Petkov
2016-08-12 15:51 ` Borislav Petkov
2016-08-12 17:04 ` Luis R. Rodriguez
2016-08-12 17:04 ` Luis R. Rodriguez
2016-08-12 17:04 ` Luis R. Rodriguez
2016-08-12 17:35 ` Borislav Petkov
2016-08-12 17:35 ` Borislav Petkov
2016-08-12 17:35 ` Borislav Petkov
2016-08-12 18:16 ` Kees Cook
2016-08-12 20:23 ` Greg KH
2016-08-12 20:23 ` Greg KH
2016-08-12 20:23 ` Greg KH
2016-08-12 20:46 ` Jiri Kosina
2016-08-12 20:46 ` Jiri Kosina
2016-08-12 20:46 ` Jiri Kosina
2016-08-12 22:00 ` Luis R. Rodriguez
2016-08-12 22:00 ` Luis R. Rodriguez
2016-08-12 22:00 ` Luis R. Rodriguez
2016-08-13 10:46 ` Greg KH
2016-08-13 10:46 ` Greg KH
2016-08-13 10:46 ` Greg KH
2016-08-13 17:54 ` Luis R. Rodriguez
2016-08-13 17:54 ` Luis R. Rodriguez
2016-08-13 17:54 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 08/13] firmware/Makefile: force recompilation if makefile changes Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 09/13] firmware: port built-in section to linker table Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 10/13] jump_label: port __jump_table to linker tables Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:49 ` Josh Poimboeuf [this message]
2016-07-22 21:49 ` Josh Poimboeuf
2016-07-22 21:49 ` Josh Poimboeuf
2016-07-22 22:26 ` Luis R. Rodriguez
2016-07-22 22:26 ` Luis R. Rodriguez
2016-07-22 22:26 ` Luis R. Rodriguez
2016-07-22 22:55 ` Josh Poimboeuf
2016-07-22 22:55 ` Josh Poimboeuf
2016-07-22 22:55 ` Josh Poimboeuf
2016-07-27 22:55 ` Luis R. Rodriguez
2016-07-27 22:55 ` Luis R. Rodriguez
2016-07-27 22:55 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 11/13] dynamic_debug: port to use " Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 12/13] kprobes: port .kprobes.text to section range Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-25 15:19 ` Masami Hiramatsu
2016-07-25 15:19 ` Masami Hiramatsu
2016-07-25 15:19 ` Masami Hiramatsu
2016-07-27 22:40 ` Luis R. Rodriguez
2016-07-27 22:40 ` Luis R. Rodriguez
2016-07-27 22:40 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 13/13] kprobes: port blacklist kprobes to linker table Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez
2016-07-25 15:27 ` Masami Hiramatsu
2016-07-25 15:27 ` Masami Hiramatsu
2016-07-25 15:27 ` Masami Hiramatsu
2016-07-27 23:00 ` Luis R. Rodriguez
2016-07-27 23:00 ` Luis R. Rodriguez
2016-07-27 23:00 ` Luis R. Rodriguez
2016-07-25 13:32 ` [RFC v3 00/13] linux: generalize sections, ranges and linker tables Masami Hiramatsu
2016-07-25 13:32 ` Masami Hiramatsu
2016-07-25 13:32 ` Masami Hiramatsu
2016-07-25 13:55 ` Richard Fontana
2016-07-25 13:55 ` Richard Fontana
2016-07-25 13:55 ` Richard Fontana
2016-07-27 22:46 ` Luis R. Rodriguez
2016-07-27 22:46 ` Luis R. Rodriguez
2016-07-27 22:46 ` Luis R. Rodriguez
2016-07-27 22:27 ` Luis R. Rodriguez
2016-08-09 14:24 ` One Thousand Gnomes
2016-08-09 14:24 ` One Thousand Gnomes
2016-08-09 14:24 ` One Thousand Gnomes
2016-08-09 16:09 ` James Bottomley
2016-08-09 16:09 ` James Bottomley
2016-08-09 16:09 ` James Bottomley
2016-08-10 4:51 ` Andy Lutomirski
2016-08-10 4:51 ` Andy Lutomirski
2016-08-15 20:15 ` Alan Cox
2016-08-15 20:15 ` Alan Cox
2016-08-15 21:00 ` Steven Rostedt
2016-08-15 21:00 ` Steven Rostedt
2016-08-15 21:00 ` Steven Rostedt
2016-08-15 22:40 ` James Bottomley
2016-08-15 22:40 ` James Bottomley
2016-08-15 22:40 ` James Bottomley
2016-08-15 22:44 ` James Bottomley
2016-08-15 22:44 ` James Bottomley
2016-08-15 22:44 ` James Bottomley
2016-08-10 17:03 ` Luis R. Rodriguez
2016-08-10 17:03 ` Luis R. Rodriguez
2016-08-10 17:03 ` Luis R. Rodriguez
2016-08-09 16:48 ` Richard Fontana
2016-08-09 16:48 ` Richard Fontana
2016-08-09 16:48 ` Richard Fontana
2016-08-09 16:52 ` Richard Fontana
2016-08-09 16:52 ` Richard Fontana
2016-08-09 16:52 ` Richard Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722214945.h7v7fvsnuhnvz6ux@treble \
--to=jpoimboe@redhat.com \
--cc=alan@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=andrew.cooper3@citrix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=christopher.denicolo@suse.com \
--cc=ciaran.farrell@suse.com \
--cc=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=dwmw2@infradead.org \
--cc=fontana@sharpeleven.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jbaron@akamai.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mcb30@ipxe.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=ming.lei@canonical.com \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windri \
--cc=pebolle@tiscali.nl \
--cc=realmz6@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.