From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-6IF/jdPJHihWk0Htik3J/w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
bjdooks-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org,
srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
Carlo Caione <carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v2 1/6] firmware: Amlogic: Add secure monitor driver
Date: Tue, 26 Jul 2016 11:20:18 +0100 [thread overview]
Message-ID: <20160726102017.GA12241@leverpostej> (raw)
In-Reply-To: <1467203656-14381-2-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
Hi,
Sorry for the delay.
I don't have any major comments, there are jsut a couple of minor
details.
> +config MESON_SM
> + bool
> + default ARCH_MESON
> + depends on ARM64_4K_PAGES
It would be good to have a commentin the code as to why we depend on
ARM64_4K_PAGES.
That way it's possible for others to figure out without having to go
digging through mail archives and/or git logs.
[...]
> +struct meson_sm_chip gxbb_chip = {
> + .shmem_size = 0x1000,
If you include <linux/sizes.h>, you can use SZ_4K here.
Immediately above this is probably the best place for the comment
regarding the 4K page restriction imposed by the FW interface.
Other than that this looks fine, so FWIW:
Acked-by: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/6] firmware: Amlogic: Add secure monitor driver
Date: Tue, 26 Jul 2016 11:20:18 +0100 [thread overview]
Message-ID: <20160726102017.GA12241@leverpostej> (raw)
In-Reply-To: <1467203656-14381-2-git-send-email-carlo@caione.org>
Hi,
Sorry for the delay.
I don't have any major comments, there are jsut a couple of minor
details.
> +config MESON_SM
> + bool
> + default ARCH_MESON
> + depends on ARM64_4K_PAGES
It would be good to have a commentin the code as to why we depend on
ARM64_4K_PAGES.
That way it's possible for others to figure out without having to go
digging through mail archives and/or git logs.
[...]
> +struct meson_sm_chip gxbb_chip = {
> + .shmem_size = 0x1000,
If you include <linux/sizes.h>, you can use SZ_4K here.
Immediately above this is probably the best place for the comment
regarding the 4K page restriction imposed by the FW interface.
Other than that this looks fine, so FWIW:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 1/6] firmware: Amlogic: Add secure monitor driver
Date: Tue, 26 Jul 2016 11:20:18 +0100 [thread overview]
Message-ID: <20160726102017.GA12241@leverpostej> (raw)
In-Reply-To: <1467203656-14381-2-git-send-email-carlo@caione.org>
Hi,
Sorry for the delay.
I don't have any major comments, there are jsut a couple of minor
details.
> +config MESON_SM
> + bool
> + default ARCH_MESON
> + depends on ARM64_4K_PAGES
It would be good to have a commentin the code as to why we depend on
ARM64_4K_PAGES.
That way it's possible for others to figure out without having to go
digging through mail archives and/or git logs.
[...]
> +struct meson_sm_chip gxbb_chip = {
> + .shmem_size = 0x1000,
If you include <linux/sizes.h>, you can use SZ_4K here.
Immediately above this is probably the best place for the comment
regarding the 4K page restriction imposed by the FW interface.
Other than that this looks fine, so FWIW:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
next prev parent reply other threads:[~2016-07-26 10:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 12:34 [PATCH v2 0/6] Add Amlogic secure monitor and NVMEM drivers Carlo Caione
2016-06-29 12:34 ` Carlo Caione
2016-06-29 12:34 ` Carlo Caione
[not found] ` <1467203656-14381-1-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2016-06-29 12:34 ` [PATCH v2 1/6] firmware: Amlogic: Add secure monitor driver Carlo Caione
2016-06-29 12:34 ` Carlo Caione
2016-06-29 12:34 ` Carlo Caione
[not found] ` <1467203656-14381-2-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2016-07-09 8:32 ` Carlo Caione
2016-07-09 8:32 ` Carlo Caione
2016-07-09 8:32 ` Carlo Caione
2016-07-26 10:20 ` Mark Rutland [this message]
2016-07-26 10:20 ` Mark Rutland
2016-07-26 10:20 ` Mark Rutland
2016-06-29 12:34 ` [PATCH v2 2/6] documentation: Add secure monitor bindings documentation Carlo Caione
2016-06-29 12:34 ` Carlo Caione
2016-06-29 12:34 ` Carlo Caione
2016-06-29 12:34 ` [PATCH v2 3/6] ARM64: dts: amlogic: gxbb: Enable secure monitor Carlo Caione
2016-06-29 12:34 ` Carlo Caione
2016-06-29 12:34 ` Carlo Caione
2016-06-29 12:34 ` [PATCH v2 4/6] nvmem: amlogic: Add Amlogic Meson EFUSE driver Carlo Caione
2016-06-29 12:34 ` Carlo Caione
2016-06-29 12:34 ` Carlo Caione
[not found] ` <1467203656-14381-5-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2016-07-01 10:00 ` Srinivas Kandagatla
2016-07-01 10:00 ` Srinivas Kandagatla
2016-07-01 10:00 ` Srinivas Kandagatla
[not found] ` <57763F42.3070106-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-02 8:27 ` Carlo Caione
2016-07-02 8:27 ` Carlo Caione
2016-07-02 8:27 ` Carlo Caione
2016-06-29 12:34 ` [PATCH v2 5/6] documentation: Add nvmem bindings documentation Carlo Caione
2016-06-29 12:34 ` Carlo Caione
2016-06-29 12:34 ` Carlo Caione
[not found] ` <1467203656-14381-6-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2016-07-01 10:00 ` Srinivas Kandagatla
2016-07-01 10:00 ` Srinivas Kandagatla
2016-07-01 10:00 ` Srinivas Kandagatla
2016-06-29 12:34 ` [PATCH v2 6/6] ARM64: dts: amlogic: gxbb: Enable NVMEM Carlo Caione
2016-06-29 12:34 ` Carlo Caione
2016-06-29 12:34 ` Carlo Caione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726102017.GA12241@leverpostej \
--to=mark.rutland-5wv7dgnigg8@public.gmane.org \
--cc=bjdooks-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
--cc=carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org \
--cc=carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=linux-6IF/jdPJHihWk0Htik3J/w@public.gmane.org \
--cc=linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.