From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> To: Andrey Pronin <apronin@chromium.org> Cc: Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com>, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Christophe Ricard <christophe.ricard@gmail.com>, dtor@chromium.org, smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH v3 1/2] tpm_tis_core: add optional max xfer size check Date: Tue, 9 Aug 2016 11:14:02 +0300 [thread overview] Message-ID: <20160809081402.GA10537@intel.com> (raw) In-Reply-To: <1469677797-74304-2-git-send-email-apronin@chromium.org> On Wed, Jul 27, 2016 at 08:49:56PM -0700, Andrey Pronin wrote: > If tpm reports a bigger burstcnt than allowed by the physical protocol, > set burstcnt to the max allowed value. > > In practice, seen in case of xfer issues (e.g. in spi interface case, > lost header causing flow control issues and wrong values returned on read > from TPM_STS). Without catching, causes the physical layer to reject xfer. > > Signed-off-by: Andrey Pronin <apronin@chromium.org> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> I don't have hardware to test this. Someone should validate that it does not break anything. Christophe, are you able to do this? /Jarkko > --- > drivers/char/tpm/tpm_tis_core.c | 9 ++++++++- > drivers/char/tpm/tpm_tis_core.h | 1 + > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c > index f22caf8..7c4fa0c 100644 > --- a/drivers/char/tpm/tpm_tis_core.c > +++ b/drivers/char/tpm/tpm_tis_core.c > @@ -168,8 +168,15 @@ static int get_burstcount(struct tpm_chip *chip) > return rc; > > burstcnt = (value >> 8) & 0xFFFF; > - if (burstcnt) > + if (burstcnt) { > + if (priv->phy_ops->max_xfer_size && > + (burstcnt > priv->phy_ops->max_xfer_size)) { > + dev_warn(&chip->dev, > + "Bad burstcnt read: %d\n", burstcnt); > + burstcnt = priv->phy_ops->max_xfer_size; > + } > return burstcnt; > + } > msleep(TPM_TIMEOUT); > } while (time_before(jiffies, stop)); > return -EBUSY; > diff --git a/drivers/char/tpm/tpm_tis_core.h b/drivers/char/tpm/tpm_tis_core.h > index 9191aab..58e8b14 100644 > --- a/drivers/char/tpm/tpm_tis_core.h > +++ b/drivers/char/tpm/tpm_tis_core.h > @@ -102,6 +102,7 @@ struct tpm_tis_phy_ops { > int (*read16)(struct tpm_tis_data *data, u32 addr, u16 *result); > int (*read32)(struct tpm_tis_data *data, u32 addr, u32 *result); > int (*write32)(struct tpm_tis_data *data, u32 addr, u32 src); > + u16 max_xfer_size; > }; > > static inline int tpm_tis_read_bytes(struct tpm_tis_data *data, u32 addr, > -- > 2.6.6 >
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> To: Andrey Pronin <apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: Christophe Ricard <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org Subject: Re: [PATCH v3 1/2] tpm_tis_core: add optional max xfer size check Date: Tue, 9 Aug 2016 11:14:02 +0300 [thread overview] Message-ID: <20160809081402.GA10537@intel.com> (raw) In-Reply-To: <1469677797-74304-2-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> On Wed, Jul 27, 2016 at 08:49:56PM -0700, Andrey Pronin wrote: > If tpm reports a bigger burstcnt than allowed by the physical protocol, > set burstcnt to the max allowed value. > > In practice, seen in case of xfer issues (e.g. in spi interface case, > lost header causing flow control issues and wrong values returned on read > from TPM_STS). Without catching, causes the physical layer to reject xfer. > > Signed-off-by: Andrey Pronin <apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> I don't have hardware to test this. Someone should validate that it does not break anything. Christophe, are you able to do this? /Jarkko > --- > drivers/char/tpm/tpm_tis_core.c | 9 ++++++++- > drivers/char/tpm/tpm_tis_core.h | 1 + > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c > index f22caf8..7c4fa0c 100644 > --- a/drivers/char/tpm/tpm_tis_core.c > +++ b/drivers/char/tpm/tpm_tis_core.c > @@ -168,8 +168,15 @@ static int get_burstcount(struct tpm_chip *chip) > return rc; > > burstcnt = (value >> 8) & 0xFFFF; > - if (burstcnt) > + if (burstcnt) { > + if (priv->phy_ops->max_xfer_size && > + (burstcnt > priv->phy_ops->max_xfer_size)) { > + dev_warn(&chip->dev, > + "Bad burstcnt read: %d\n", burstcnt); > + burstcnt = priv->phy_ops->max_xfer_size; > + } > return burstcnt; > + } > msleep(TPM_TIMEOUT); > } while (time_before(jiffies, stop)); > return -EBUSY; > diff --git a/drivers/char/tpm/tpm_tis_core.h b/drivers/char/tpm/tpm_tis_core.h > index 9191aab..58e8b14 100644 > --- a/drivers/char/tpm/tpm_tis_core.h > +++ b/drivers/char/tpm/tpm_tis_core.h > @@ -102,6 +102,7 @@ struct tpm_tis_phy_ops { > int (*read16)(struct tpm_tis_data *data, u32 addr, u16 *result); > int (*read32)(struct tpm_tis_data *data, u32 addr, u32 *result); > int (*write32)(struct tpm_tis_data *data, u32 addr, u32 src); > + u16 max_xfer_size; > }; > > static inline int tpm_tis_read_bytes(struct tpm_tis_data *data, u32 addr, > -- > 2.6.6 > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev
next prev parent reply other threads:[~2016-08-09 8:14 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-15 1:39 [PATCH 0/2] tpm: add optional max xfer size check Andrey Pronin 2016-07-15 1:39 ` [PATCH 1/2] tpm_tis_core: " Andrey Pronin 2016-07-15 3:13 ` Jason Gunthorpe 2016-07-15 3:13 ` Jason Gunthorpe 2016-07-15 3:25 ` Andrey Pronin 2016-07-15 3:48 ` Guenter Roeck 2016-07-18 18:53 ` Jarkko Sakkinen 2016-07-18 18:53 ` Jarkko Sakkinen 2016-07-15 1:39 ` [PATCH 2/2] tpm_tis_spi: add max xfer size Andrey Pronin 2016-07-15 1:39 ` Andrey Pronin 2016-07-20 2:34 ` [PATCH v2 0/2] tpm: add optional max xfer size check Andrey Pronin 2016-07-20 2:34 ` Andrey Pronin 2016-07-20 2:34 ` [PATCH v2 1/2] tpm_tis_core: " Andrey Pronin 2016-07-20 2:34 ` Andrey Pronin 2016-07-20 2:34 ` [PATCH v2 2/2] tpm_tis_spi: add max xfer size Andrey Pronin 2016-07-20 15:10 ` [PATCH v2 0/2] tpm: add optional max xfer size check Jarkko Sakkinen 2016-07-20 15:10 ` Jarkko Sakkinen 2016-07-28 3:49 ` [PATCH v3 " Andrey Pronin 2016-07-28 3:49 ` Andrey Pronin 2016-07-28 3:49 ` [PATCH v3 1/2] tpm_tis_core: " Andrey Pronin 2016-07-28 3:49 ` Andrey Pronin 2016-07-28 22:52 ` Dmitry Torokhov 2016-08-09 8:14 ` Jarkko Sakkinen [this message] 2016-08-09 8:14 ` Jarkko Sakkinen 2020-11-19 10:00 ` Dafna Hirschfeld 2020-11-20 15:15 ` Jarkko Sakkinen 2016-07-28 3:49 ` [PATCH v3 2/2] tpm_tis_spi: add max xfer size Andrey Pronin 2016-07-28 3:49 ` Andrey Pronin 2016-07-28 22:53 ` Dmitry Torokhov 2016-08-09 8:14 ` Jarkko Sakkinen 2016-08-09 8:14 ` Jarkko Sakkinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160809081402.GA10537@intel.com \ --to=jarkko.sakkinen@linux.intel.com \ --cc=apronin@chromium.org \ --cc=christophe.ricard@gmail.com \ --cc=dianders@chromium.org \ --cc=dtor@chromium.org \ --cc=jgunthorpe@obsidianresearch.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peterhuewe@gmx.de \ --cc=smbarber@chromium.org \ --cc=tpmdd-devel@lists.sourceforge.net \ --cc=tpmdd@selhorst.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.