From: Chris Wilson <chris@chris-wilson.co.uk>
To: Robert Bragg <robert@sixbynine.org>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org,
Sourab Gupta <sourab.gupta@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v3 03/11] drm/i915: return EACCES for check_cmd() failures
Date: Mon, 15 Aug 2016 16:04:04 +0100 [thread overview]
Message-ID: <20160815150404.GH3447@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20160815144128.7847-4-robert@sixbynine.org>
On Mon, Aug 15, 2016 at 03:41:20PM +0100, Robert Bragg wrote:
> check_cmd() is checking whether a command adheres to certain
> restrictions that ensure it's safe to execute within a privileged batch
> buffer. Returning false implies a privilege problem, not that the
> command is invalid.
>
> The distinction makes the difference between allowing the buffer to be
> executed as an unprivileged batch buffer or returning an EINVAL error to
> userspace without executing anything.
Ah, but you choose to actually execute it instead. We can't allow that
either.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-15 15:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 14:41 [PATCH v3 00/11] Enable Gen 7 Observation Architecture Robert Bragg
2016-08-15 14:41 ` [PATCH v3 01/11] drm/i915: Add i915 perf infrastructure Robert Bragg
2016-08-15 14:57 ` Chris Wilson
2016-08-16 14:59 ` Robert Bragg
2016-08-16 15:08 ` Chris Wilson
2016-08-15 14:41 ` [PATCH v3 02/11] drm/i915: rename OACONTROL GEN7_OACONTROL Robert Bragg
2016-08-15 14:41 ` [PATCH v3 03/11] drm/i915: return EACCES for check_cmd() failures Robert Bragg
2016-08-15 15:04 ` Chris Wilson [this message]
2016-08-18 21:18 ` Robert Bragg
2016-08-15 14:41 ` [PATCH v3 04/11] drm/i915: don't whitelist oacontrol in cmd parser Robert Bragg
2016-08-15 14:41 ` [PATCH v3 05/11] drm/i915: Add 'render basic' Haswell OA unit config Robert Bragg
2016-08-15 14:41 ` [PATCH v3 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit Robert Bragg
2016-08-15 15:47 ` Chris Wilson
2016-08-15 14:41 ` [PATCH v3 07/11] drm/i915: advertise available metrics via sysfs Robert Bragg
2016-08-15 14:41 ` [PATCH v3 08/11] drm/i915: Add dev.i915.perf_event_paranoid sysctl option Robert Bragg
2016-08-15 14:41 ` [PATCH v3 09/11] drm/i915: add oa_event_min_timer_exponent sysctl Robert Bragg
2016-08-15 14:41 ` [PATCH v3 10/11] drm/i915: Add more Haswell OA metric sets Robert Bragg
2016-08-15 14:41 ` [PATCH v3 11/11] drm/i915: Add a kerneldoc summary for i915_perf.c Robert Bragg
2016-08-15 15:13 ` ✗ Ro.CI.BAT: failure for Enable Gen 7 Observation Architecture (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815150404.GH3447@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robert@sixbynine.org \
--cc=sourab.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.