From: Chris Wilson <chris@chris-wilson.co.uk>
To: Robert Bragg <robert@sixbynine.org>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>,
intel-gfx@lists.freedesktop.org,
Sourab Gupta <sourab.gupta@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v3 01/11] drm/i915: Add i915 perf infrastructure
Date: Tue, 16 Aug 2016 16:08:56 +0100 [thread overview]
Message-ID: <20160816150856.GB6583@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <CAMou1-0H+F85002wrXfTcHqh0bqRqs_yxSx=RnTyEjpN+3fFWA@mail.gmail.com>
On Tue, Aug 16, 2016 at 03:59:24PM +0100, Robert Bragg wrote:
> On Mon, Aug 15, 2016 at 3:57 PM, Chris Wilson
> Alternatively you could follow the standard pattern for read. Dare I ask
> what is going to go into state that needs the obfuscation?
>
> I had dug around a bit when I was trying to decide how to handle the
> corner cases here and found some precedent for prioritize reporting any
> data copied over an error for a read().
Reporting completed bytes before the error is correct. I was referring
to going between passing the return value as a mixture of state and return,
when it just appears to be following the usual pattern of read(). i.e. I
could find anything to support why your internal read callback required
a different signature. It looks unusual, so I am expecting it to do
unusual things.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-16 15:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 14:41 [PATCH v3 00/11] Enable Gen 7 Observation Architecture Robert Bragg
2016-08-15 14:41 ` [PATCH v3 01/11] drm/i915: Add i915 perf infrastructure Robert Bragg
2016-08-15 14:57 ` Chris Wilson
2016-08-16 14:59 ` Robert Bragg
2016-08-16 15:08 ` Chris Wilson [this message]
2016-08-15 14:41 ` [PATCH v3 02/11] drm/i915: rename OACONTROL GEN7_OACONTROL Robert Bragg
2016-08-15 14:41 ` [PATCH v3 03/11] drm/i915: return EACCES for check_cmd() failures Robert Bragg
2016-08-15 15:04 ` Chris Wilson
2016-08-18 21:18 ` Robert Bragg
2016-08-15 14:41 ` [PATCH v3 04/11] drm/i915: don't whitelist oacontrol in cmd parser Robert Bragg
2016-08-15 14:41 ` [PATCH v3 05/11] drm/i915: Add 'render basic' Haswell OA unit config Robert Bragg
2016-08-15 14:41 ` [PATCH v3 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit Robert Bragg
2016-08-15 15:47 ` Chris Wilson
2016-08-15 14:41 ` [PATCH v3 07/11] drm/i915: advertise available metrics via sysfs Robert Bragg
2016-08-15 14:41 ` [PATCH v3 08/11] drm/i915: Add dev.i915.perf_event_paranoid sysctl option Robert Bragg
2016-08-15 14:41 ` [PATCH v3 09/11] drm/i915: add oa_event_min_timer_exponent sysctl Robert Bragg
2016-08-15 14:41 ` [PATCH v3 10/11] drm/i915: Add more Haswell OA metric sets Robert Bragg
2016-08-15 14:41 ` [PATCH v3 11/11] drm/i915: Add a kerneldoc summary for i915_perf.c Robert Bragg
2016-08-15 15:13 ` ✗ Ro.CI.BAT: failure for Enable Gen 7 Observation Architecture (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816150856.GB6583@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robert@sixbynine.org \
--cc=sourab.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.