From: Mark Brown <broonie@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: lgirdwood@gmail.com, mka@chromium.org, briannorris@chromium.org,
javier@dowhile0.org, linux-rockchip@lists.infradead.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] regulator: pwm: Prevent falling too fast
Date: Thu, 1 Sep 2016 20:51:06 +0100 [thread overview]
Message-ID: <20160901195106.GM5967@sirena.org.uk> (raw)
In-Reply-To: <1472617277-30814-2-git-send-email-dianders@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Tue, Aug 30, 2016 at 09:21:16PM -0700, Douglas Anderson wrote:
> In this patch we actually block returning from the set_voltage() call
> until we've finished delaying. A future patch atop this one might
> choose to return more immediately and let the voltages fall in the
> background. That would possibly to allow us to cancel a slow downward
> decay if there was a request to go back up.
We already have mechanisms in the core for drivers to tell the core how
long a ramp they need for a given voltage transition - you should extend
them (probably needs a set_voltage_time() operation adding) so that
anything like this can be done in the core rather than open coded in
drivers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org
Subject: Re: [PATCH v3 2/2] regulator: pwm: Prevent falling too fast
Date: Thu, 1 Sep 2016 20:51:06 +0100 [thread overview]
Message-ID: <20160901195106.GM5967@sirena.org.uk> (raw)
In-Reply-To: <1472617277-30814-2-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 688 bytes --]
On Tue, Aug 30, 2016 at 09:21:16PM -0700, Douglas Anderson wrote:
> In this patch we actually block returning from the set_voltage() call
> until we've finished delaying. A future patch atop this one might
> choose to return more immediately and let the voltages fall in the
> background. That would possibly to allow us to cancel a slow downward
> decay if there was a request to go back up.
We already have mechanisms in the core for drivers to tell the core how
long a ramp they need for a given voltage transition - you should extend
them (probably needs a set_voltage_time() operation adding) so that
anything like this can be done in the core rather than open coded in
drivers.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 200 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2016-09-01 21:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 4:21 [PATCH v3 1/2] regulator: pwm: Add support for a fixed delay after duty cycle changes Douglas Anderson
2016-08-31 4:21 ` Douglas Anderson
2016-08-31 4:21 ` [PATCH v3 2/2] regulator: pwm: Prevent falling too fast Douglas Anderson
2016-09-01 19:51 ` Mark Brown [this message]
2016-09-01 19:51 ` Mark Brown
2016-09-01 19:24 ` [PATCH v3 1/2] regulator: pwm: Add support for a fixed delay after duty cycle changes Mark Brown
2016-09-01 19:24 ` Mark Brown
2016-09-02 15:11 ` Rob Herring
2016-09-02 15:11 ` Rob Herring
2016-09-02 15:13 ` Rob Herring
2016-09-02 15:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901195106.GM5967@sirena.org.uk \
--to=broonie@kernel.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=javier@dowhile0.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.