From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> To: anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH v3 15/22] rpcrdma: RDMA/CM private message data structure Date: Thu, 15 Sep 2016 10:56:59 -0400 [thread overview] Message-ID: <20160915145659.11080.54491.stgit@manet.1015granger.net> (raw) In-Reply-To: <20160915143440.11080.89241.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> Introduce data structure used by both client and server to exchange implementation details during RDMA/CM connection establishment. This is an experimental out-of-band exchange between Linux RPC-over-RDMA Version One implementations, replacing the deprecated CCP (see RFC 5666bis). The purpose of this extension is to enable prototyping of features that might be introduced in a subsequent version of RPC-over-RDMA. Suggested by Christoph Hellwig and Devesh Sharma. Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> --- include/linux/sunrpc/rpc_rdma.h | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/include/linux/sunrpc/rpc_rdma.h b/include/linux/sunrpc/rpc_rdma.h index 3b1ff38..a7da6bf 100644 --- a/include/linux/sunrpc/rpc_rdma.h +++ b/include/linux/sunrpc/rpc_rdma.h @@ -41,6 +41,7 @@ #define _LINUX_SUNRPC_RPC_RDMA_H #include <linux/types.h> +#include <linux/bitops.h> #define RPCRDMA_VERSION 1 #define rpcrdma_version cpu_to_be32(RPCRDMA_VERSION) @@ -129,4 +130,38 @@ enum rpcrdma_proc { #define rdma_done cpu_to_be32(RDMA_DONE) #define rdma_error cpu_to_be32(RDMA_ERROR) +/* + * Private extension to RPC-over-RDMA Version One. + * Message passed during RDMA-CM connection set-up. + * + * Add new fields at the end, and don't permute existing + * fields. + */ +struct rpcrdma_connect_private { + __be32 cp_magic; + u8 cp_version; + u8 cp_flags; + u8 cp_send_size; + u8 cp_recv_size; +} __packed; + +#define rpcrdma_cmp_magic __cpu_to_be32(0xf6ab0e18) + +enum { + RPCRDMA_CMP_VERSION = 1, + RPCRDMA_CMP_F_SND_W_INV_OK = BIT(0), +}; + +static inline u8 +rpcrdma_encode_buffer_size(unsigned int size) +{ + return (size >> 10) - 1; +} + +static inline unsigned int +rpcrdma_decode_buffer_size(u8 val) +{ + return ((unsigned int)val + 1) << 10; +} + #endif /* _LINUX_SUNRPC_RPC_RDMA_H */ -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever <chuck.lever@oracle.com> To: anna.schumaker@netapp.com Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v3 15/22] rpcrdma: RDMA/CM private message data structure Date: Thu, 15 Sep 2016 10:56:59 -0400 [thread overview] Message-ID: <20160915145659.11080.54491.stgit@manet.1015granger.net> (raw) In-Reply-To: <20160915143440.11080.89241.stgit@manet.1015granger.net> Introduce data structure used by both client and server to exchange implementation details during RDMA/CM connection establishment. This is an experimental out-of-band exchange between Linux RPC-over-RDMA Version One implementations, replacing the deprecated CCP (see RFC 5666bis). The purpose of this extension is to enable prototyping of features that might be introduced in a subsequent version of RPC-over-RDMA. Suggested by Christoph Hellwig and Devesh Sharma. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> --- include/linux/sunrpc/rpc_rdma.h | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/include/linux/sunrpc/rpc_rdma.h b/include/linux/sunrpc/rpc_rdma.h index 3b1ff38..a7da6bf 100644 --- a/include/linux/sunrpc/rpc_rdma.h +++ b/include/linux/sunrpc/rpc_rdma.h @@ -41,6 +41,7 @@ #define _LINUX_SUNRPC_RPC_RDMA_H #include <linux/types.h> +#include <linux/bitops.h> #define RPCRDMA_VERSION 1 #define rpcrdma_version cpu_to_be32(RPCRDMA_VERSION) @@ -129,4 +130,38 @@ enum rpcrdma_proc { #define rdma_done cpu_to_be32(RDMA_DONE) #define rdma_error cpu_to_be32(RDMA_ERROR) +/* + * Private extension to RPC-over-RDMA Version One. + * Message passed during RDMA-CM connection set-up. + * + * Add new fields at the end, and don't permute existing + * fields. + */ +struct rpcrdma_connect_private { + __be32 cp_magic; + u8 cp_version; + u8 cp_flags; + u8 cp_send_size; + u8 cp_recv_size; +} __packed; + +#define rpcrdma_cmp_magic __cpu_to_be32(0xf6ab0e18) + +enum { + RPCRDMA_CMP_VERSION = 1, + RPCRDMA_CMP_F_SND_W_INV_OK = BIT(0), +}; + +static inline u8 +rpcrdma_encode_buffer_size(unsigned int size) +{ + return (size >> 10) - 1; +} + +static inline unsigned int +rpcrdma_decode_buffer_size(u8 val) +{ + return ((unsigned int)val + 1) << 10; +} + #endif /* _LINUX_SUNRPC_RPC_RDMA_H */
next prev parent reply other threads:[~2016-09-15 14:56 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-15 14:54 [PATCH v3 00/22] client-side NFS/RDMA patches ready for v4.9 Chuck Lever 2016-09-15 14:54 ` Chuck Lever [not found] ` <20160915143440.11080.89241.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2016-09-15 14:55 ` [PATCH v3 01/22] xprtrdma: Eliminate INLINE_THRESHOLD macros Chuck Lever 2016-09-15 14:55 ` Chuck Lever 2016-09-15 14:55 ` [PATCH v3 02/22] SUNRPC: Refactor rpc_xdr_buf_init() Chuck Lever 2016-09-15 14:55 ` Chuck Lever 2016-09-15 14:55 ` [PATCH v3 03/22] SUNRPC: Generalize the RPC buffer allocation API Chuck Lever 2016-09-15 14:55 ` Chuck Lever 2016-09-15 14:55 ` [PATCH v3 04/22] SUNRPC: Generalize the RPC buffer release API Chuck Lever 2016-09-15 14:55 ` Chuck Lever 2016-09-15 14:55 ` [PATCH v3 05/22] SUNRPC: Separate buffer pointers for RPC Call and Reply messages Chuck Lever 2016-09-15 14:55 ` Chuck Lever 2016-09-15 14:55 ` [PATCH v3 06/22] SUNRPC: Add a transport-specific private field in rpc_rqst Chuck Lever 2016-09-15 14:55 ` Chuck Lever 2016-09-15 14:55 ` [PATCH v3 07/22] xprtrdma: Initialize separate RPC call and reply buffers Chuck Lever 2016-09-15 14:55 ` Chuck Lever 2016-09-15 14:56 ` [PATCH v3 08/22] xprtrdma: Use smaller buffers for RPC-over-RDMA headers Chuck Lever 2016-09-15 14:56 ` Chuck Lever 2016-09-15 14:56 ` [PATCH v3 09/22] xprtrdma: Replace DMA_BIDIRECTIONAL Chuck Lever 2016-09-15 14:56 ` Chuck Lever 2016-09-15 14:56 ` [PATCH v3 10/22] xprtrdma: Delay DMA mapping Send and Receive buffers Chuck Lever 2016-09-15 14:56 ` Chuck Lever 2016-09-15 14:56 ` [PATCH v3 11/22] xprtrdma: Eliminate "ia" argument in rpcrdma_{alloc, free}_regbuf Chuck Lever 2016-09-15 14:56 ` Chuck Lever 2016-09-15 14:56 ` [PATCH v3 12/22] xprtrdma: Simplify rpcrdma_ep_post_recv() Chuck Lever 2016-09-15 14:56 ` Chuck Lever 2016-09-15 14:56 ` [PATCH v3 13/22] xprtrdma: Move send_wr to struct rpcrdma_req Chuck Lever 2016-09-15 14:56 ` Chuck Lever 2016-09-15 14:56 ` [PATCH v3 14/22] xprtrdma: Move recv_wr to struct rpcrdma_rep Chuck Lever 2016-09-15 14:56 ` Chuck Lever 2016-09-15 14:56 ` Chuck Lever [this message] 2016-09-15 14:56 ` [PATCH v3 15/22] rpcrdma: RDMA/CM private message data structure Chuck Lever 2016-09-15 14:57 ` [PATCH v3 16/22] xprtrdma: Client-side support for rpcrdma_connect_private Chuck Lever 2016-09-15 14:57 ` Chuck Lever 2016-09-15 14:57 ` [PATCH v3 17/22] xprtrdma: Basic support for Remote Invalidation Chuck Lever 2016-09-15 14:57 ` Chuck Lever 2016-09-15 14:57 ` [PATCH v3 18/22] xprtrdma: Use gathered Send for large inline messages Chuck Lever 2016-09-15 14:57 ` Chuck Lever 2016-09-15 14:57 ` [PATCH v3 19/22] xprtrdma: Support larger inline thresholds Chuck Lever 2016-09-15 14:57 ` Chuck Lever 2016-09-15 14:57 ` [PATCH v3 20/22] xprtrmda: Report address of frmr, not mw Chuck Lever 2016-09-15 14:57 ` Chuck Lever 2016-09-15 14:57 ` [PATCH v3 21/22] xprtrdma: Rename rpcrdma_receive_wc() Chuck Lever 2016-09-15 14:57 ` Chuck Lever 2016-09-15 14:57 ` [PATCH v3 22/22] xprtrdma: Eliminate rpcrdma_receive_worker() Chuck Lever 2016-09-15 14:57 ` Chuck Lever
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160915145659.11080.54491.stgit@manet.1015granger.net \ --to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \ --cc=anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \ --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.