All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4: optimize ext4 direct I/O locking for reading
Date: Fri, 30 Sep 2016 01:22:33 -0400	[thread overview]
Message-ID: <20160930052233.puwov5avj4kfedin@thunk.org> (raw)
In-Reply-To: <20160922133031.zjiyudqwthqp742g@thunk.org>

I've been looking at your patch and testing it, and it looks like
works fine as-is.

The other thing I like about this patch is it allows us to drop
ext4_inode_{block,resume}_unlocked_dio() and EXT4_STATE_DIOREAD_LOCK.

Thanks!!

					- Ted

  reply	other threads:[~2016-09-30  5:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  5:27 [PATCH] ext4: optimize ext4 direct I/O locking for reading Theodore Ts'o
2016-09-21 13:26 ` Christoph Hellwig
2016-09-21 14:37   ` Theodore Ts'o
2016-09-22 12:31     ` Jan Kara
2016-09-22 13:18       ` Christoph Hellwig
2016-09-22 13:30       ` Theodore Ts'o
2016-09-30  5:22         ` Theodore Ts'o [this message]
2016-10-03  7:41           ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160930052233.puwov5avj4kfedin@thunk.org \
    --to=tytso@mit.edu \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.