From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4: optimize ext4 direct I/O locking for reading
Date: Mon, 3 Oct 2016 09:41:03 +0200 [thread overview]
Message-ID: <20161003074103.GE6457@quack2.suse.cz> (raw)
In-Reply-To: <20160930052233.puwov5avj4kfedin@thunk.org>
On Fri 30-09-16 01:22:33, Ted Tso wrote:
> I've been looking at your patch and testing it, and it looks like
> works fine as-is.
Glad to hear that!
> The other thing I like about this patch is it allows us to drop
> ext4_inode_{block,resume}_unlocked_dio() and EXT4_STATE_DIOREAD_LOCK.
Well, not completely - we still need to deal with unlocked writes that
happen in ext4_direct_IO_write() when overwrite == 1. But that should be
doable in a similar way. We could just demote inode_lock to a shared mode
instead of dropping it in ext4_direct_IO_write() and then we could drop the
bits you mention above. I can look into that when I'll be looking into
converting ext4 into the new iomap infrastructure but that's definitely
material for the next merge window.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2016-10-03 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 5:27 [PATCH] ext4: optimize ext4 direct I/O locking for reading Theodore Ts'o
2016-09-21 13:26 ` Christoph Hellwig
2016-09-21 14:37 ` Theodore Ts'o
2016-09-22 12:31 ` Jan Kara
2016-09-22 13:18 ` Christoph Hellwig
2016-09-22 13:30 ` Theodore Ts'o
2016-09-30 5:22 ` Theodore Ts'o
2016-10-03 7:41 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003074103.GE6457@quack2.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.