All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Add devices to spidev device tree compatibility list
Date: Fri, 30 Sep 2016 09:08:32 -0700	[thread overview]
Message-ID: <20160930160832.fnnvxkwdh5ex4xqt@sirena.org.uk> (raw)
In-Reply-To: <1475230554-5986-1-git-send-email-fabien.lahoudere@collabora.co.uk>

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

On Fri, Sep 30, 2016 at 12:15:54PM +0200, Fabien Lahoudere wrote:

> - "fsl,mk20fn1m0vmd12" : a cortex m4 based chip

> +	{ .compatible = "fsl,MK20FN1M0VMD12" },

This compatible is in uppercase which is not the normal style for DT
bindings at all.  I'd also guess that this is a binding for a specific
application running on this device rather than the chip itself.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Fabien Lahoudere
	<fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] Add devices to spidev device tree compatibility list
Date: Fri, 30 Sep 2016 09:08:32 -0700	[thread overview]
Message-ID: <20160930160832.fnnvxkwdh5ex4xqt@sirena.org.uk> (raw)
In-Reply-To: <1475230554-5986-1-git-send-email-fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

On Fri, Sep 30, 2016 at 12:15:54PM +0200, Fabien Lahoudere wrote:

> - "fsl,mk20fn1m0vmd12" : a cortex m4 based chip

> +	{ .compatible = "fsl,MK20FN1M0VMD12" },

This compatible is in uppercase which is not the normal style for DT
bindings at all.  I'd also guess that this is a binding for a specific
application running on this device rather than the chip itself.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2016-09-30 16:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30 10:15 [PATCH 1/1] Add devices to spidev device tree compatibility list Fabien Lahoudere
2016-09-30 10:15 ` Fabien Lahoudere
2016-09-30 16:08 ` Mark Brown [this message]
2016-09-30 16:08   ` Mark Brown
2016-10-06 14:44   ` [PATCH v2 1/1] Add device " Fabien Lahoudere
2016-10-06 14:49     ` Mark Brown
2016-10-06 14:49       ` Mark Brown
2016-09-30 17:35 ` [PATCH 1/1] Add devices " Geert Uytterhoeven
2016-09-30 17:35   ` Geert Uytterhoeven
2016-10-06  8:01   ` Fabien Lahoudere
2016-10-06  8:01     ` Fabien Lahoudere

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160930160832.fnnvxkwdh5ex4xqt@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=fabien.lahoudere@collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.