Re: [Qemu-devel] [PATCH qemu v3 0/6] Fast (de)inflating & fast live migration - no-reply

From: no-reply@patchew.org
To: liang.z.li@intel.com
Cc: famz@redhat.com, qemu-devel@nongnu.org,
	virtio-dev@lists.oasis-open.org, thuth@redhat.com,
	liang.z.li@intel.com, kvm@vger.kernel.org, quintela@redhat.com,
	mst@redhat.com, dgilbert@redhat.com, dave.hansen@intel.com,
	amit.shah@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH qemu v3 0/6] Fast (de)inflating & fast live migration
Date: Fri, 21 Oct 2016 00:22:52 -0700 (PDT)	[thread overview]
Message-ID: <20161021072249.502017.33488@ex-std-node742.prod.rhcloud.com> (raw)
In-Reply-To: <1477032504-12745-1-git-send-email-liang.z.li@intel.com>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1477032504-12745-1-git-send-email-liang.z.li@intel.com
Subject: [Qemu-devel] [PATCH qemu v3 0/6] Fast (de)inflating & fast live migration

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
071260f migration: skip free pages during live migration
6a1e772 kvm: Add two new arch specific functions
506ddf9 bitmap: Add a new bitmap_move function
eb934f9 balloon: get free page info from guest
6f16986 virtio-balloon: speed up inflating & deflating process
879a4d4 virtio-balloon: update linux head file

=== OUTPUT BEGIN ===
Checking PATCH 1/6: virtio-balloon: update linux head file...
Checking PATCH 2/6: virtio-balloon: speed up inflating & deflating process...
Checking PATCH 3/6: balloon: get free page info from guest...
ERROR: suspect code indent for conditional statements (12, 17)
#145: FILE: hw/virtio/virtio-balloon.c:434:
+            if (s->bmap_len < hdr.start_pfn / BITS_PER_BYTE + hdr.bmap_len) {
+                 hdr.bmap_len = s->bmap_len - hdr.start_pfn / BITS_PER_BYTE;

total: 1 errors, 0 warnings, 324 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/6: bitmap: Add a new bitmap_move function...
Checking PATCH 5/6: kvm: Add two new arch specific functions...
Checking PATCH 6/6: migration: skip free pages during live migration...
=== OUTPUT END ===

Test command exited with code: 1

---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org