From: Lee Jones <lee.jones@linaro.org> To: Arnd Bergmann <arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, linus.walleij@linaro.org, tony@atomide.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] mfd: Fix all W=1 warnings Date: Wed, 26 Oct 2016 13:27:10 +0100 [thread overview] Message-ID: <20161026122710.GZ8574@dell> (raw) In-Reply-To: <5506538.euWBouSNJd@wuerfel> On Thu, 15 Sep 2016, Arnd Bergmann wrote: > On Thursday, September 15, 2016 11:45:14 AM CEST Lee Jones wrote: > > It really is as simple as it sounds! > > > > I seem to have one that you didn't find. Applied, thanks. > 8<-------- > From 6c63171eba728fc6d8bc6358884deaccd4cee33d Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann <arnd@arndb.de> > Date: Thu, 4 Aug 2016 15:28:51 +0200 > Subject: [PATCH] mfd: tps65912: move regmap config into core driver > > When building with extra warnings enabled, most files including > linux/mfd/tps65912.h warn about a static variable defined in the > header: > > include/linux/mfd/tps65912.h:331:35: warning: 'tps65912_regmap_config' defined but not used [-Wunused-const-variable=] > > We also duplicate the data structure between the i2c and spi front-end > drivers. Moving it into the driver code avoids the warning and > the duplication. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c > index a88cfa80dbc4..f33567bc428d 100644 > --- a/drivers/mfd/tps65912-core.c > +++ b/drivers/mfd/tps65912-core.c > @@ -77,6 +77,23 @@ static struct regmap_irq_chip tps65912_irq_chip = { > .init_ack_masked = true, > }; > > +static const struct regmap_range tps65912_yes_ranges[] = { > + regmap_reg_range(TPS65912_INT_STS, TPS65912_GPIO5), > +}; > + > +static const struct regmap_access_table tps65912_volatile_table = { > + .yes_ranges = tps65912_yes_ranges, > + .n_yes_ranges = ARRAY_SIZE(tps65912_yes_ranges), > +}; > + > +const struct regmap_config tps65912_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > + .cache_type = REGCACHE_RBTREE, > + .volatile_table = &tps65912_volatile_table, > +}; > +EXPORT_SYMBOL_GPL(tps65912_regmap_config); > + > int tps65912_device_init(struct tps65912 *tps) > { > int ret; > diff --git a/include/linux/mfd/tps65912.h b/include/linux/mfd/tps65912.h > index 1a603701550e..b25d0297ba88 100644 > --- a/include/linux/mfd/tps65912.h > +++ b/include/linux/mfd/tps65912.h > @@ -319,21 +319,7 @@ struct tps65912 { > struct regmap_irq_chip_data *irq_data; > }; > > -static const struct regmap_range tps65912_yes_ranges[] = { > - regmap_reg_range(TPS65912_INT_STS, TPS65912_GPIO5), > -}; > - > -static const struct regmap_access_table tps65912_volatile_table = { > - .yes_ranges = tps65912_yes_ranges, > - .n_yes_ranges = ARRAY_SIZE(tps65912_yes_ranges), > -}; > - > -static const struct regmap_config tps65912_regmap_config = { > - .reg_bits = 8, > - .val_bits = 8, > - .cache_type = REGCACHE_RBTREE, > - .volatile_table = &tps65912_volatile_table, > -}; > +extern const struct regmap_config tps65912_regmap_config; > > int tps65912_device_init(struct tps65912 *tps); > int tps65912_device_exit(struct tps65912 *tps); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/7] mfd: Fix all W=1 warnings Date: Wed, 26 Oct 2016 13:27:10 +0100 [thread overview] Message-ID: <20161026122710.GZ8574@dell> (raw) In-Reply-To: <5506538.euWBouSNJd@wuerfel> On Thu, 15 Sep 2016, Arnd Bergmann wrote: > On Thursday, September 15, 2016 11:45:14 AM CEST Lee Jones wrote: > > It really is as simple as it sounds! > > > > I seem to have one that you didn't find. Applied, thanks. > 8<-------- > From 6c63171eba728fc6d8bc6358884deaccd4cee33d Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann <arnd@arndb.de> > Date: Thu, 4 Aug 2016 15:28:51 +0200 > Subject: [PATCH] mfd: tps65912: move regmap config into core driver > > When building with extra warnings enabled, most files including > linux/mfd/tps65912.h warn about a static variable defined in the > header: > > include/linux/mfd/tps65912.h:331:35: warning: 'tps65912_regmap_config' defined but not used [-Wunused-const-variable=] > > We also duplicate the data structure between the i2c and spi front-end > drivers. Moving it into the driver code avoids the warning and > the duplication. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c > index a88cfa80dbc4..f33567bc428d 100644 > --- a/drivers/mfd/tps65912-core.c > +++ b/drivers/mfd/tps65912-core.c > @@ -77,6 +77,23 @@ static struct regmap_irq_chip tps65912_irq_chip = { > .init_ack_masked = true, > }; > > +static const struct regmap_range tps65912_yes_ranges[] = { > + regmap_reg_range(TPS65912_INT_STS, TPS65912_GPIO5), > +}; > + > +static const struct regmap_access_table tps65912_volatile_table = { > + .yes_ranges = tps65912_yes_ranges, > + .n_yes_ranges = ARRAY_SIZE(tps65912_yes_ranges), > +}; > + > +const struct regmap_config tps65912_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > + .cache_type = REGCACHE_RBTREE, > + .volatile_table = &tps65912_volatile_table, > +}; > +EXPORT_SYMBOL_GPL(tps65912_regmap_config); > + > int tps65912_device_init(struct tps65912 *tps) > { > int ret; > diff --git a/include/linux/mfd/tps65912.h b/include/linux/mfd/tps65912.h > index 1a603701550e..b25d0297ba88 100644 > --- a/include/linux/mfd/tps65912.h > +++ b/include/linux/mfd/tps65912.h > @@ -319,21 +319,7 @@ struct tps65912 { > struct regmap_irq_chip_data *irq_data; > }; > > -static const struct regmap_range tps65912_yes_ranges[] = { > - regmap_reg_range(TPS65912_INT_STS, TPS65912_GPIO5), > -}; > - > -static const struct regmap_access_table tps65912_volatile_table = { > - .yes_ranges = tps65912_yes_ranges, > - .n_yes_ranges = ARRAY_SIZE(tps65912_yes_ranges), > -}; > - > -static const struct regmap_config tps65912_regmap_config = { > - .reg_bits = 8, > - .val_bits = 8, > - .cache_type = REGCACHE_RBTREE, > - .volatile_table = &tps65912_volatile_table, > -}; > +extern const struct regmap_config tps65912_regmap_config; > > int tps65912_device_init(struct tps65912 *tps); > int tps65912_device_exit(struct tps65912 *tps); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-10-26 12:24 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-15 10:45 [PATCH 0/7] mfd: Fix all W=1 warnings Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-09-15 10:45 ` [PATCH 1/7] mfd: max8997-irq: 'inline' should be at the beginning of the declaration Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-09-15 11:28 ` Arnd Bergmann 2016-09-15 11:28 ` Arnd Bergmann 2016-09-15 10:45 ` [PATCH 2/7] mfd: ab8500-debugfs: Prevent initialised field from being over-written Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-09-15 11:31 ` Arnd Bergmann 2016-09-15 11:31 ` Arnd Bergmann 2016-09-15 10:45 ` [PATCH 3/7] mfd: db8500-prcmu: Remove unused *prcmu_set_ddr_opp() calls Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-10-06 20:35 ` Ulf Hansson 2016-10-06 20:35 ` Ulf Hansson 2016-10-06 20:35 ` Ulf Hansson 2016-09-15 10:45 ` [PATCH 4/7] mfd: ab8500-debugfs: Remove ab8500_dump_all_banks_to_mem() Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-09-15 10:45 ` [PATCH 5/7] mfd: ab8500-debugfs: Remove 'weak' function suspend_test_wake_cause_interrupt_is_mine() Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-09-15 10:45 ` [PATCH 6/7] mfd: omap-usb-host: Return value is not 'const int' Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-09-15 11:33 ` Arnd Bergmann 2016-09-15 11:33 ` Arnd Bergmann 2016-09-15 10:45 ` [PATCH 7/7] mfd: cros_ec_spi: Remove unused variable 'request' Lee Jones 2016-09-15 10:45 ` Lee Jones 2016-09-15 11:35 ` [PATCH 0/7] mfd: Fix all W=1 warnings Arnd Bergmann 2016-09-15 11:35 ` Arnd Bergmann 2016-10-26 12:27 ` Lee Jones [this message] 2016-10-26 12:27 ` Lee Jones 2016-09-15 12:44 ` Linus Walleij 2016-09-15 12:44 ` Linus Walleij 2016-09-15 12:44 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161026122710.GZ8574@dell \ --to=lee.jones@linaro.org \ --cc=arnd@arndb.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.