From: Rob Herring <robh@kernel.org> To: Jean-Francois Moine <moinejf@free.fr> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, Mark Brown <broonie@kernel.org>, Maxime Ripard <maxime.ripard@free-electrons.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2 Date: Sun, 30 Oct 2016 15:41:05 -0500 [thread overview] Message-ID: <20161030204104.cexblg73q4owe2gt@rob-hp-laptop> (raw) In-Reply-To: <20161025161441.6b248efe9229bd80e3f7a33c@free.fr> On Tue, Oct 25, 2016 at 04:14:41PM +0200, Jean-Francois Moine wrote: > On Mon, 24 Oct 2016 16:04:19 +0200 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > Hi, > > Hi Maxime, > > > On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: > > > Allwinner's recent SoCs, as A64, A83T and H3, contain a new display > > > engine, DE2. > > > This patch adds a DRM video driver for this device. > > > > > > Signed-off-by: Jean-Francois Moine <moinejf@free.fr> > > > > Output from checkpatch: > > total: 0 errors, 20 warnings, 83 checks, 1799 lines checked > > > > > --- > > > .../bindings/display/sunxi/sunxi-de2.txt | 83 +++ > > > drivers/gpu/drm/Kconfig | 2 + > > > drivers/gpu/drm/Makefile | 1 + > > > drivers/gpu/drm/sunxi/Kconfig | 21 + > > > drivers/gpu/drm/sunxi/Makefile | 7 + > > > drivers/gpu/drm/sunxi/de2_crtc.c | 475 +++++++++++++++++ > > > drivers/gpu/drm/sunxi/de2_crtc.h | 63 +++ > > > drivers/gpu/drm/sunxi/de2_de.c | 591 +++++++++++++++++++++ > > > drivers/gpu/drm/sunxi/de2_drm.h | 47 ++ > > > drivers/gpu/drm/sunxi/de2_drv.c | 378 +++++++++++++ > > > drivers/gpu/drm/sunxi/de2_plane.c | 119 +++++ > > > 11 files changed, 1787 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/sunxi/sunxi-de2.txt > > > create mode 100644 drivers/gpu/drm/sunxi/Kconfig > > > create mode 100644 drivers/gpu/drm/sunxi/Makefile > > > create mode 100644 drivers/gpu/drm/sunxi/de2_crtc.c > > > create mode 100644 drivers/gpu/drm/sunxi/de2_crtc.h > > > create mode 100644 drivers/gpu/drm/sunxi/de2_de.c > > > create mode 100644 drivers/gpu/drm/sunxi/de2_drm.h > > > create mode 100644 drivers/gpu/drm/sunxi/de2_drv.c > > > create mode 100644 drivers/gpu/drm/sunxi/de2_plane.c > > > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sunxi-de2.txt b/Documentation/devicetree/bindings/display/sunxi/sunxi-de2.txt > > > new file mode 100644 > > > index 0000000..f9cd67a > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/sunxi/sunxi-de2.txt [...] > > > + > > > +- resets: phandle to the reset of the device > > > + > > > +- ports: phandle's to the LCD ports > > > > Please use the OF graph. > > These ports are references to the graph of nodes. See > http://www.kernelhub.org/?msg=911825&p=2 I think what Maxime means is describe the DE to LCD connection with OF graph, not just a phandle. Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2 Date: Sun, 30 Oct 2016 15:41:05 -0500 [thread overview] Message-ID: <20161030204104.cexblg73q4owe2gt@rob-hp-laptop> (raw) In-Reply-To: <20161025161441.6b248efe9229bd80e3f7a33c@free.fr> On Tue, Oct 25, 2016 at 04:14:41PM +0200, Jean-Francois Moine wrote: > On Mon, 24 Oct 2016 16:04:19 +0200 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > Hi, > > Hi Maxime, > > > On Fri, Oct 21, 2016 at 09:26:18AM +0200, Jean-Francois Moine wrote: > > > Allwinner's recent SoCs, as A64, A83T and H3, contain a new display > > > engine, DE2. > > > This patch adds a DRM video driver for this device. > > > > > > Signed-off-by: Jean-Francois Moine <moinejf@free.fr> > > > > Output from checkpatch: > > total: 0 errors, 20 warnings, 83 checks, 1799 lines checked > > > > > --- > > > .../bindings/display/sunxi/sunxi-de2.txt | 83 +++ > > > drivers/gpu/drm/Kconfig | 2 + > > > drivers/gpu/drm/Makefile | 1 + > > > drivers/gpu/drm/sunxi/Kconfig | 21 + > > > drivers/gpu/drm/sunxi/Makefile | 7 + > > > drivers/gpu/drm/sunxi/de2_crtc.c | 475 +++++++++++++++++ > > > drivers/gpu/drm/sunxi/de2_crtc.h | 63 +++ > > > drivers/gpu/drm/sunxi/de2_de.c | 591 +++++++++++++++++++++ > > > drivers/gpu/drm/sunxi/de2_drm.h | 47 ++ > > > drivers/gpu/drm/sunxi/de2_drv.c | 378 +++++++++++++ > > > drivers/gpu/drm/sunxi/de2_plane.c | 119 +++++ > > > 11 files changed, 1787 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/sunxi/sunxi-de2.txt > > > create mode 100644 drivers/gpu/drm/sunxi/Kconfig > > > create mode 100644 drivers/gpu/drm/sunxi/Makefile > > > create mode 100644 drivers/gpu/drm/sunxi/de2_crtc.c > > > create mode 100644 drivers/gpu/drm/sunxi/de2_crtc.h > > > create mode 100644 drivers/gpu/drm/sunxi/de2_de.c > > > create mode 100644 drivers/gpu/drm/sunxi/de2_drm.h > > > create mode 100644 drivers/gpu/drm/sunxi/de2_drv.c > > > create mode 100644 drivers/gpu/drm/sunxi/de2_plane.c > > > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sunxi-de2.txt b/Documentation/devicetree/bindings/display/sunxi/sunxi-de2.txt > > > new file mode 100644 > > > index 0000000..f9cd67a > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/sunxi/sunxi-de2.txt [...] > > > + > > > +- resets: phandle to the reset of the device > > > + > > > +- ports: phandle's to the LCD ports > > > > Please use the OF graph. > > These ports are references to the graph of nodes. See > http://www.kernelhub.org/?msg=911825&p=2 I think what Maxime means is describe the DE to LCD connection with OF graph, not just a phandle. Rob
next prev parent reply other threads:[~2016-10-30 20:41 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-22 13:28 [PATCH v5 0/7] ARM: ASoC: drm: sun8i: Add DE2 HDMI audio and video Jean-Francois Moine 2016-10-22 13:28 ` Jean-Francois Moine [not found] ` <cover.1477142934.git.moinejf-GANU6spQydw@public.gmane.org> 2016-10-21 7:26 ` [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2 Jean-Francois Moine 2016-10-21 7:26 ` Jean-Francois Moine [not found] ` <8afc5e020c5767face34fe3a9ab300ce9e67ba00.1477142934.git.moinejf-GANU6spQydw@public.gmane.org> 2016-10-24 14:04 ` Maxime Ripard 2016-10-24 14:04 ` Maxime Ripard 2016-10-25 14:14 ` Jean-Francois Moine 2016-10-25 14:14 ` Jean-Francois Moine [not found] ` <20161025161441.6b248efe9229bd80e3f7a33c-GANU6spQydw@public.gmane.org> 2016-10-25 23:52 ` [linux-sunxi] " André Przywara 2016-10-25 23:52 ` André Przywara 2016-10-27 22:03 ` Maxime Ripard 2016-10-27 22:03 ` Maxime Ripard 2016-10-28 17:34 ` Jean-Francois Moine 2016-10-28 17:34 ` Jean-Francois Moine [not found] ` <20161028193420.0f7dc67ea1042ff72b09b701-GANU6spQydw@public.gmane.org> 2016-11-07 22:37 ` Maxime Ripard 2016-11-07 22:37 ` Maxime Ripard 2016-11-08 14:37 ` Jean-Francois Moine 2016-11-08 14:37 ` Jean-Francois Moine [not found] ` <20161108153752.a17440e784f2e3993c79ee69-GANU6spQydw@public.gmane.org> 2016-11-16 21:33 ` Maxime Ripard 2016-11-16 21:33 ` Maxime Ripard 2016-11-17 14:57 ` Jean-Francois Moine 2016-11-17 14:57 ` Jean-Francois Moine 2016-10-30 20:41 ` Rob Herring [this message] 2016-10-30 20:41 ` Rob Herring 2016-10-25 6:44 ` Daniel Vetter 2016-10-25 6:44 ` Daniel Vetter [not found] ` <20161025064422.4jua6qmpr7zu3ijt-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> 2016-10-25 6:46 ` Daniel Vetter 2016-10-25 6:46 ` Daniel Vetter 2016-10-25 14:16 ` Jean-Francois Moine 2016-10-25 14:16 ` Jean-Francois Moine 2016-10-30 20:41 ` Rob Herring 2016-10-30 20:41 ` Rob Herring 2016-10-21 7:44 ` [PATCH v5 2/7] ASoC: sunxi: Add a simple HDMI CODEC Jean-Francois Moine 2016-10-21 7:44 ` Jean-Francois Moine [not found] ` <5cb540f20f64d28bd7dee82a0e14ee5209631979.1477142934.git.moinejf-GANU6spQydw@public.gmane.org> 2016-10-27 16:54 ` Chen-Yu Tsai 2016-10-27 16:54 ` [linux-sunxi] " Chen-Yu Tsai [not found] ` <CAGb2v67cE8v3=XtTzDBst2D2U6wM8pffQYK9nEok+j4xnPT39A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-10-27 17:16 ` Jean-Francois Moine 2016-10-27 17:16 ` [linux-sunxi] " Jean-Francois Moine [not found] ` <20161027191634.f2fa6478cd07d84a60274339-GANU6spQydw@public.gmane.org> 2016-10-27 18:36 ` Mark Brown 2016-10-27 18:36 ` Mark Brown 2016-10-21 8:08 ` [PATCH v5 3/7] drm: sunxi: add DE2 HDMI support Jean-Francois Moine 2016-10-21 8:08 ` Jean-Francois Moine [not found] ` <36bd5454897c8ab77749e0294e4a4ecc2450dd12.1477142934.git.moinejf-GANU6spQydw@public.gmane.org> 2016-10-24 13:17 ` Maxime Ripard 2016-10-24 13:17 ` Maxime Ripard 2016-10-30 20:41 ` Rob Herring 2016-10-30 20:41 ` Rob Herring 2016-10-21 8:36 ` [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver Jean-Francois Moine 2016-10-21 8:36 ` Jean-Francois Moine [not found] ` <bee315efb909c1ee8b5fe7d3aeb9a33d713cb562.1477142934.git.moinejf-GANU6spQydw@public.gmane.org> 2016-10-23 1:33 ` [linux-sunxi] " Chen-Yu Tsai 2016-10-23 1:33 ` Chen-Yu Tsai [not found] ` <CAGb2v67gDd650TJk_-oHOehnzdH2qor=36HXdPt339Ji=ToAMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-10-23 7:45 ` Jean-Francois Moine 2016-10-23 7:45 ` [linux-sunxi] " Jean-Francois Moine [not found] ` <20161023094503.fbb22dd0701e3f2785828609-GANU6spQydw@public.gmane.org> 2016-10-24 12:34 ` Maxime Ripard 2016-10-24 12:34 ` [linux-sunxi] " Maxime Ripard 2016-10-27 15:13 ` [alsa-devel] " Jean-Francois Moine 2016-10-27 15:13 ` Jean-Francois Moine [not found] ` <20161027171325.d68baa5ff51da4921ff8b94d-GANU6spQydw@public.gmane.org> 2016-10-27 20:01 ` [alsa-devel] " Maxime Ripard 2016-10-27 20:01 ` [alsa-devel] [linux-sunxi] " Maxime Ripard 2016-11-06 18:02 ` Jean-Francois Moine 2016-11-06 18:02 ` [linux-sunxi] " Jean-Francois Moine 2016-11-07 20:05 ` Maxime Ripard 2016-11-07 20:05 ` Maxime Ripard 2016-11-08 10:51 ` Jean-Francois Moine 2016-11-08 10:51 ` [linux-sunxi] " Jean-Francois Moine [not found] ` <20161108115129.f315ca5feefd22614859bbe3-GANU6spQydw@public.gmane.org> 2016-11-14 21:22 ` Maxime Ripard 2016-11-14 21:22 ` [linux-sunxi] " Maxime Ripard 2016-10-21 10:01 ` [PATCH v5 5/7] ARM: dts: sun8i-h3: add HDMI audio and video nodes Jean-Francois Moine 2016-10-21 10:01 ` Jean-Francois Moine 2016-10-22 10:29 ` [PATCH v5 6/7] ARM: dts: sun8i-h3: Add HDMI audio and video to the Banana Pi M2+ Jean-Francois Moine 2016-10-22 10:29 ` Jean-Francois Moine 2016-10-22 11:06 ` [PATCH v5 7/7] ARM: dts: sun8i-h3: Add HDMI audio and video to the Orange PI 2 Jean-Francois Moine 2016-10-22 11:06 ` Jean-Francois Moine 2016-10-23 1:38 ` [linux-sunxi] [PATCH v5 0/7] ARM: ASoC: drm: sun8i: Add DE2 HDMI audio and video Chen-Yu Tsai 2016-10-23 1:38 ` Chen-Yu Tsai [not found] ` <CAGb2v64fgJShfyEHnjm6ryg00WhHkmnPj+FdjHcXBa6HQbyTuA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-10-23 7:35 ` Jean-Francois Moine 2016-10-23 7:35 ` Jean-Francois Moine
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161030204104.cexblg73q4owe2gt@rob-hp-laptop \ --to=robh@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-sunxi@googlegroups.com \ --cc=maxime.ripard@free-electrons.com \ --cc=moinejf@free.fr \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.