From: Dave Chinner <david@fromorbit.com> To: "Theodore Ts'o" <tytso@mit.edu>, Deepa Dinamani <deepa.kernel@gmail.com>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, tglx@linutronix.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, y2038@lists.linaro.org, linux-afs@lists.infradead.org, Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org Subject: Re: [RFC 0/6] vfs: Add timestamp range check support Date: Fri, 4 Nov 2016 10:48:02 +1100 [thread overview] Message-ID: <20161103234802.GK14023@dastard> (raw) In-Reply-To: <20161103204357.r7lgvbsv3euujijn@thunk.org> On Thu, Nov 03, 2016 at 04:43:57PM -0400, Theodore Ts'o wrote: > On Thu, Nov 03, 2016 at 09:48:27AM +1100, Dave Chinner wrote: > > > > We're going to need regression tests for this to ensure that it > > works properly and that we don't inadvertantly break it in future. > > Can you write some xfstests that exercise this functionality and > > validate that the mount behaviour, clamping and range limiting is > > working as intended? > > In order to have automated regression tests which are file system > independent, we need a way to query what are the timestamps that a > particular mounted file systme supports. We don't need that - we simply code it directly into the test infrastructure, like we've done for things like the maximum number of ACLs a filesystem supports (common/attr::_acl_get_max()). > The last option, which is admittedly ugly, would be to create an shell > function which knows how to figure out the max_timestamp and > min_timestamp by using the file system name and querying the > superblock using dumpe2fs, xfs_db, etc. Yup, precisely that. We shouldn't trust the kernel to tell us the correct thing to enable the test that tells us that thing is working correctly or not... > I'd argue for the last option because once we do get a programmtic way > to get the information via a system call such as fsinfo(2), we can > convert xfstests to use it, where as if we add an ioctl to return this > information, we'll have to support the ioctl forever. We have to support kernels that won't ever have something like fsinfo, so it has to be done the "ugly way". Cheers, Dave. -- Dave Chinner david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com> To: Theodore Ts'o <tytso@mit.edu>, Deepa Dinamani <deepa.kernel@gmail.com>, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, tglx@linutronix.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, y2038@lists.linaro.org, linux-afs@lists.infradead.org, Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org Subject: Re: [RFC 0/6] vfs: Add timestamp range check support Date: Fri, 4 Nov 2016 10:48:02 +1100 [thread overview] Message-ID: <20161103234802.GK14023@dastard> (raw) In-Reply-To: <20161103204357.r7lgvbsv3euujijn@thunk.org> On Thu, Nov 03, 2016 at 04:43:57PM -0400, Theodore Ts'o wrote: > On Thu, Nov 03, 2016 at 09:48:27AM +1100, Dave Chinner wrote: > > > > We're going to need regression tests for this to ensure that it > > works properly and that we don't inadvertantly break it in future. > > Can you write some xfstests that exercise this functionality and > > validate that the mount behaviour, clamping and range limiting is > > working as intended? > > In order to have automated regression tests which are file system > independent, we need a way to query what are the timestamps that a > particular mounted file systme supports. We don't need that - we simply code it directly into the test infrastructure, like we've done for things like the maximum number of ACLs a filesystem supports (common/attr::_acl_get_max()). > The last option, which is admittedly ugly, would be to create an shell > function which knows how to figure out the max_timestamp and > min_timestamp by using the file system name and querying the > superblock using dumpe2fs, xfs_db, etc. Yup, precisely that. We shouldn't trust the kernel to tell us the correct thing to enable the test that tells us that thing is working correctly or not... > I'd argue for the last option because once we do get a programmtic way > to get the information via a system call such as fsinfo(2), we can > convert xfstests to use it, where as if we add an ioctl to return this > information, we'll have to support the ioctl forever. We have to support kernels that won't ever have something like fsinfo, so it has to be done the "ugly way". Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ Y2038 mailing list Y2038@lists.linaro.org https://lists.linaro.org/mailman/listinfo/y2038
next prev parent reply other threads:[~2016-11-03 23:51 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-02 15:04 [RFC 0/6] vfs: Add timestamp range check support Deepa Dinamani 2016-11-02 15:04 ` Deepa Dinamani 2016-11-02 15:04 ` [RFC 1/6] vfs: Add file timestamp range support Deepa Dinamani 2016-11-02 15:04 ` [RFC 2/6] vfs: Add checks for filesystem timestamp limits Deepa Dinamani 2016-11-02 15:04 ` [RFC 3/6] afs: Add time limits in the super block Deepa Dinamani 2016-11-02 15:04 ` [RFC 4/6] ext4: Initialize timestamps limits Deepa Dinamani 2016-11-02 15:04 ` Deepa Dinamani 2016-11-02 15:04 ` [RFC 5/6] vfs: Add timestamp_truncate() api Deepa Dinamani 2016-11-02 15:04 ` [RFC 6/6] utimes: Clamp the timestamps before update Deepa Dinamani 2016-11-02 22:48 ` [RFC 0/6] vfs: Add timestamp range check support Dave Chinner 2016-11-03 6:54 ` Darrick J. Wong 2016-11-03 20:43 ` Theodore Ts'o 2016-11-03 20:43 ` Theodore Ts'o 2016-11-03 23:48 ` Dave Chinner [this message] 2016-11-03 23:48 ` Dave Chinner 2016-11-04 0:27 ` Andreas Dilger 2016-11-06 17:44 ` Deepa Dinamani 2016-11-06 20:28 ` Arnd Bergmann 2016-11-06 20:28 ` Arnd Bergmann 2016-11-06 21:14 ` Deepa Dinamani 2016-11-24 0:47 Deepa Dinamani
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161103234802.GK14023@dastard \ --to=david@fromorbit.com \ --cc=adilger.kernel@dilger.ca \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=deepa.kernel@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-afs@lists.infradead.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=tytso@mit.edu \ --cc=viro@zeniv.linux.org.uk \ --cc=y2038@lists.linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.