From: Jan Kara <jack@suse.cz>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org, Dave Chinner <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org, Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 01/11] ext4: Factor out checks from ext4_file_write_iter()
Date: Fri, 4 Nov 2016 05:20:03 +0100 [thread overview]
Message-ID: <20161104042003.GN24234@quack2.suse.cz> (raw)
In-Reply-To: <20161103210440.GA27351@linux.intel.com>
On Thu 03-11-16 15:04:40, Ross Zwisler wrote:
> On Tue, Nov 01, 2016 at 10:06:11PM +0100, Jan Kara wrote:
> > + /*
> > + * 'err==len' means that all of blocks has been preallocated no matter
> > + * they are initialized or not. For excluding unwritten extents, we
> > + * need to check m_flags.
>
> Does it make sense to clean up this comment, since you're moving it anyway?
>
> i.e.:
>
> 'err==len' means that all of the blocks have been preallocated, regardless
> of whether they have been initialized or not. To exclude unwritten extents
> we need to check m_flags.
OK, done. Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Dave Chinner <david@fromorbit.com>, Ted Tso <tytso@mit.edu>,
linux-nvdimm@lists.01.org
Subject: Re: [PATCH 01/11] ext4: Factor out checks from ext4_file_write_iter()
Date: Fri, 4 Nov 2016 05:20:03 +0100 [thread overview]
Message-ID: <20161104042003.GN24234@quack2.suse.cz> (raw)
In-Reply-To: <20161103210440.GA27351@linux.intel.com>
On Thu 03-11-16 15:04:40, Ross Zwisler wrote:
> On Tue, Nov 01, 2016 at 10:06:11PM +0100, Jan Kara wrote:
> > + /*
> > + * 'err==len' means that all of blocks has been preallocated no matter
> > + * they are initialized or not. For excluding unwritten extents, we
> > + * need to check m_flags.
>
> Does it make sense to clean up this comment, since you're moving it anyway?
>
> i.e.:
>
> 'err==len' means that all of the blocks have been preallocated, regardless
> of whether they have been initialized or not. To exclude unwritten extents
> we need to check m_flags.
OK, done. Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
To: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ted Tso <tytso-3s7WtUTddSA@public.gmane.org>,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 01/11] ext4: Factor out checks from ext4_file_write_iter()
Date: Fri, 4 Nov 2016 05:20:03 +0100 [thread overview]
Message-ID: <20161104042003.GN24234@quack2.suse.cz> (raw)
In-Reply-To: <20161103210440.GA27351-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Thu 03-11-16 15:04:40, Ross Zwisler wrote:
> On Tue, Nov 01, 2016 at 10:06:11PM +0100, Jan Kara wrote:
> > + /*
> > + * 'err==len' means that all of blocks has been preallocated no matter
> > + * they are initialized or not. For excluding unwritten extents, we
> > + * need to check m_flags.
>
> Does it make sense to clean up this comment, since you're moving it anyway?
>
> i.e.:
>
> 'err==len' means that all of the blocks have been preallocated, regardless
> of whether they have been initialized or not. To exclude unwritten extents
> we need to check m_flags.
OK, done. Thanks!
Honza
--
Jan Kara <jack-IBi9RG/b67k@public.gmane.org>
SUSE Labs, CR
next prev parent reply other threads:[~2016-11-04 4:20 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 21:06 [PATCH 0/11] ext4: Convert ext4 DAX IO to iomap framework Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` [PATCH 01/11] ext4: Factor out checks from ext4_file_write_iter() Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-03 21:04 ` Ross Zwisler
2016-11-03 21:04 ` Ross Zwisler
2016-11-04 4:20 ` Jan Kara [this message]
2016-11-04 4:20 ` Jan Kara
2016-11-04 4:20 ` Jan Kara
2016-11-01 21:06 ` [PATCH 02/11] ext4: Allow unaligned unlocked DAX IO Jan Kara
2016-11-01 21:06 ` Jan Kara
[not found] ` <1478034381-19037-3-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-11-02 14:27 ` Christoph Hellwig
2016-11-02 14:27 ` Christoph Hellwig
2016-11-03 23:55 ` Jan Kara
2016-11-01 21:06 ` [PATCH 03/11] ext4: Let S_DAX set only if DAX is really supported Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` [PATCH 04/11] ext4: Convert DAX reads to iomap infrastructure Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` [PATCH 05/11] ext4: Use iomap for zeroing blocks in DAX mode Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` [PATCH 06/11] ext4: DAX iomap write support Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` [PATCH 07/11] ext4: Avoid split extents for DAX writes Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` [PATCH 08/11] ext4: Convert DAX faults to iomap infrastructure Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-02 14:30 ` Christoph Hellwig
[not found] ` <20161102143006.GB18387-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-11-04 0:02 ` Jan Kara
2016-11-04 0:02 ` Jan Kara
2016-11-01 21:06 ` [PATCH 09/11] ext4: Rip out DAX handling from direct IO path Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` [PATCH 10/11] ext2: Use iomap_zero_range() for zeroing truncated page in DAX path Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` [PATCH 11/11] dax: Rip out get_block based IO support Jan Kara
2016-11-01 21:06 ` Jan Kara
2016-11-01 21:06 ` Jan Kara
[not found] ` <1478034381-19037-12-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2016-11-02 14:31 ` Christoph Hellwig
2016-11-02 14:31 ` Christoph Hellwig
2016-11-04 0:03 ` Jan Kara
2016-11-01 22:12 ` [PATCH 0/11] ext4: Convert ext4 DAX IO to iomap framework Dave Chinner
2016-11-01 22:12 ` Dave Chinner
2016-11-01 22:45 ` Ross Zwisler
2016-11-01 22:45 ` Ross Zwisler
2016-11-01 22:45 ` Ross Zwisler
2016-11-01 23:09 ` Jan Kara
2016-11-01 23:09 ` Jan Kara
2016-11-02 13:03 ` Theodore Ts'o
2016-11-02 22:23 ` Dave Chinner
[not found] ` <20161102130353.nt3oqodrik4hnfk6-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2016-11-04 0:55 ` Jan Kara
2016-11-04 0:55 ` Jan Kara
2016-11-08 11:08 [PATCH 0/11 v2] " Jan Kara
2016-11-08 11:08 ` [PATCH 01/11] ext4: Factor out checks from ext4_file_write_iter() Jan Kara
2016-11-10 21:25 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104042003.GN24234@quack2.suse.cz \
--to=jack@suse.cz \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.