From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nayna Jain <nayna@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de,
tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] tpm: enhance read_log_of() to support Physical TPM event log
Date: Thu, 24 Nov 2016 23:06:37 +0200 [thread overview]
Message-ID: <20161124210637.6dspokalv7tcql26@intel.com> (raw)
In-Reply-To: <1479922057-8752-3-git-send-email-nayna@linux.vnet.ibm.com>
On Wed, Nov 23, 2016 at 12:27:36PM -0500, Nayna Jain wrote:
> - memcpy(log->bios_event_log, __va(*basep), *sizep);
> + if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0)
> + memcpy(chip->log.bios_event_log, __va(be64_to_cpup(basep)),
> + log_size);
> + else
> + memcpy(chip->log.bios_event_log, __va(*basep), log_size);
This does not look good. You should be able rearrange your code in a way
that you only have only one memcpy call.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v5 2/3] tpm: enhance read_log_of() to support Physical TPM event log
Date: Thu, 24 Nov 2016 23:06:37 +0200 [thread overview]
Message-ID: <20161124210637.6dspokalv7tcql26@intel.com> (raw)
In-Reply-To: <1479922057-8752-3-git-send-email-nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
On Wed, Nov 23, 2016 at 12:27:36PM -0500, Nayna Jain wrote:
> - memcpy(log->bios_event_log, __va(*basep), *sizep);
> + if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0)
> + memcpy(chip->log.bios_event_log, __va(be64_to_cpup(basep)),
> + log_size);
> + else
> + memcpy(chip->log.bios_event_log, __va(*basep), log_size);
This does not look good. You should be able rearrange your code in a way
that you only have only one memcpy call.
/Jarkko
------------------------------------------------------------------------------
next prev parent reply other threads:[~2016-11-24 21:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 17:27 [PATCH v5 0/3] tpm: securityfs support for TPM 2.0 firmware event log Nayna Jain
2016-11-23 17:27 ` [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c Nayna Jain
2016-11-23 19:38 ` Jason Gunthorpe
2016-11-23 19:38 ` Jason Gunthorpe
2016-11-24 8:01 ` Nayna
2016-11-24 8:01 ` Nayna
2016-11-24 16:43 ` Jason Gunthorpe
2016-11-24 16:43 ` Jason Gunthorpe
2016-11-24 16:50 ` Nayna
2016-11-24 21:01 ` Jarkko Sakkinen
2016-11-25 19:43 ` Jason Gunthorpe
2016-11-25 19:43 ` Jason Gunthorpe
2016-11-23 17:27 ` [PATCH v5 2/3] tpm: enhance read_log_of() to support Physical TPM event log Nayna Jain
2016-11-23 17:27 ` Nayna Jain
2016-11-23 19:37 ` Jason Gunthorpe
2016-11-23 19:37 ` Jason Gunthorpe
2016-11-24 7:53 ` Nayna
2016-11-24 21:06 ` Jarkko Sakkinen [this message]
2016-11-24 21:06 ` Jarkko Sakkinen
2016-11-23 17:27 ` [PATCH v5 3/3] tpm: add securityfs support for TPM 2.0 firmware " Nayna Jain
2016-11-23 17:27 ` Nayna Jain
2016-11-24 21:10 ` Jarkko Sakkinen
2016-11-24 21:10 ` Jarkko Sakkinen
2016-11-25 2:51 ` [tpmdd-devel] " Stefan Berger
2016-11-25 8:11 ` Jarkko Sakkinen
2016-11-26 15:24 ` Jarkko Sakkinen
2016-11-26 15:24 ` Jarkko Sakkinen
2016-11-25 19:43 ` Jason Gunthorpe
2016-11-25 19:43 ` Jason Gunthorpe
2016-11-26 12:59 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124210637.6dspokalv7tcql26@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.