From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <mawilcox@microsoft.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Dave Chinner <david@fromorbit.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Linux MM <linux-mm@kvack.org>, Ingo Molnar <mingo@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/6] dax: remove leading space from labels
Date: Mon, 28 Nov 2016 12:20:35 -0700 [thread overview]
Message-ID: <20161128192035.GC6637@linux.intel.com> (raw)
In-Reply-To: <CAPcyv4g=4OAskS3x31H5yx0T+suDbpwQpSyDtb+36rwmKCGMng@mail.gmail.com>
On Thu, Nov 24, 2016 at 11:42:38AM -0800, Dan Williams wrote:
> On Thu, Nov 24, 2016 at 1:11 AM, Jan Kara <jack@suse.cz> wrote:
> > On Wed 23-11-16 11:44:18, Ross Zwisler wrote:
> >> No functional change.
> >>
> >> As of this commit:
> >>
> >> commit 218dd85887da (".gitattributes: set git diff driver for C source code
> >> files")
> >>
> >> git-diff and git-format-patch both generate diffs whose hunks are correctly
> >> prefixed by function names instead of labels, even if those labels aren't
> >> indented with spaces.
> >
> > Fine by me. I just have some 4 remaining DAX patches (will send them out
> > today) and they will clash with this. So I'd prefer if this happened after
> > they are merged...
>
> Let's just leave them alone, it's not like this thrash buys us
> anything at this point. We can just stop including spaces in new
> code.
Honestly I'm not sure which is better. I understand your argument about not
introducing "thrash" for cleanup like this, but at the same time knowingly
leaving inconsistencies in the code style just because seems...gross?
In any case, sure Jan, if this patch happens lets do it after your remaining
DAX patches.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jan Kara <jack@suse.cz>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Subject: Re: [PATCH 2/6] dax: remove leading space from labels
Date: Mon, 28 Nov 2016 12:20:35 -0700 [thread overview]
Message-ID: <20161128192035.GC6637@linux.intel.com> (raw)
In-Reply-To: <CAPcyv4g=4OAskS3x31H5yx0T+suDbpwQpSyDtb+36rwmKCGMng@mail.gmail.com>
On Thu, Nov 24, 2016 at 11:42:38AM -0800, Dan Williams wrote:
> On Thu, Nov 24, 2016 at 1:11 AM, Jan Kara <jack@suse.cz> wrote:
> > On Wed 23-11-16 11:44:18, Ross Zwisler wrote:
> >> No functional change.
> >>
> >> As of this commit:
> >>
> >> commit 218dd85887da (".gitattributes: set git diff driver for C source code
> >> files")
> >>
> >> git-diff and git-format-patch both generate diffs whose hunks are correctly
> >> prefixed by function names instead of labels, even if those labels aren't
> >> indented with spaces.
> >
> > Fine by me. I just have some 4 remaining DAX patches (will send them out
> > today) and they will clash with this. So I'd prefer if this happened after
> > they are merged...
>
> Let's just leave them alone, it's not like this thrash buys us
> anything at this point. We can just stop including spaces in new
> code.
Honestly I'm not sure which is better. I understand your argument about not
introducing "thrash" for cleanup like this, but at the same time knowingly
leaving inconsistencies in the code style just because seems...gross?
In any case, sure Jan, if this patch happens lets do it after your remaining
DAX patches.
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jan Kara <jack@suse.cz>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH 2/6] dax: remove leading space from labels
Date: Mon, 28 Nov 2016 12:20:35 -0700 [thread overview]
Message-ID: <20161128192035.GC6637@linux.intel.com> (raw)
In-Reply-To: <CAPcyv4g=4OAskS3x31H5yx0T+suDbpwQpSyDtb+36rwmKCGMng@mail.gmail.com>
On Thu, Nov 24, 2016 at 11:42:38AM -0800, Dan Williams wrote:
> On Thu, Nov 24, 2016 at 1:11 AM, Jan Kara <jack@suse.cz> wrote:
> > On Wed 23-11-16 11:44:18, Ross Zwisler wrote:
> >> No functional change.
> >>
> >> As of this commit:
> >>
> >> commit 218dd85887da (".gitattributes: set git diff driver for C source code
> >> files")
> >>
> >> git-diff and git-format-patch both generate diffs whose hunks are correctly
> >> prefixed by function names instead of labels, even if those labels aren't
> >> indented with spaces.
> >
> > Fine by me. I just have some 4 remaining DAX patches (will send them out
> > today) and they will clash with this. So I'd prefer if this happened after
> > they are merged...
>
> Let's just leave them alone, it's not like this thrash buys us
> anything at this point. We can just stop including spaces in new
> code.
Honestly I'm not sure which is better. I understand your argument about not
introducing "thrash" for cleanup like this, but at the same time knowingly
leaving inconsistencies in the code style just because seems...gross?
In any case, sure Jan, if this patch happens lets do it after your remaining
DAX patches.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-28 19:20 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 18:44 [PATCH 0/6] introduce DAX tracepoint support Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` [PATCH 1/6] dax: fix build breakage with ext4, dax and !iomap Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-24 9:02 ` Jan Kara
2016-11-24 9:02 ` Jan Kara
2016-11-24 9:02 ` Jan Kara
2016-11-24 9:02 ` Jan Kara
2016-11-28 19:15 ` Ross Zwisler
2016-11-28 19:15 ` Ross Zwisler
2016-11-28 19:15 ` Ross Zwisler
2016-11-29 8:53 ` Jan Kara
2016-11-29 8:53 ` Jan Kara
2016-11-29 8:53 ` Jan Kara
2016-11-29 8:53 ` Jan Kara
2016-11-30 19:04 ` Ross Zwisler
2016-11-30 19:04 ` Ross Zwisler
2016-11-30 19:04 ` Ross Zwisler
2016-11-30 19:04 ` Ross Zwisler
2016-12-01 7:53 ` Jan Kara
2016-12-01 7:53 ` Jan Kara
2016-12-01 7:53 ` Jan Kara
2016-12-01 7:53 ` Jan Kara
2016-11-23 18:44 ` [PATCH 2/6] dax: remove leading space from labels Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-24 9:11 ` Jan Kara
2016-11-24 9:11 ` Jan Kara
2016-11-24 9:11 ` Jan Kara
2016-11-24 19:42 ` Dan Williams
2016-11-24 19:42 ` Dan Williams
2016-11-24 19:42 ` Dan Williams
2016-11-28 19:20 ` Ross Zwisler [this message]
2016-11-28 19:20 ` Ross Zwisler
2016-11-28 19:20 ` Ross Zwisler
2016-11-23 18:44 ` [PATCH 3/6] dax: add tracepoint infrastructure, PMD tracing Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-24 9:16 ` Jan Kara
2016-11-24 9:16 ` Jan Kara
2016-11-24 9:16 ` Jan Kara
2016-11-24 9:16 ` Jan Kara
2016-11-24 17:32 ` Al Viro
2016-11-24 17:32 ` Al Viro
2016-11-24 17:32 ` Al Viro
2016-11-24 17:32 ` Al Viro
2016-11-25 2:49 ` Dave Chinner
2016-11-25 2:49 ` Dave Chinner
2016-11-25 2:49 ` Dave Chinner
2016-11-25 2:49 ` Dave Chinner
2016-11-25 4:14 ` Al Viro
2016-11-25 4:14 ` Al Viro
2016-11-25 4:14 ` Al Viro
2016-11-25 4:14 ` Al Viro
2016-11-25 7:06 ` Dave Chinner
2016-11-25 7:06 ` Dave Chinner
2016-11-25 7:06 ` Dave Chinner
2016-11-25 7:06 ` Dave Chinner
2016-11-25 7:37 ` Al Viro
2016-11-25 7:37 ` Al Viro
2016-11-25 7:37 ` Al Viro
2016-11-25 7:37 ` Al Viro
2016-11-25 19:51 ` Linus Torvalds
2016-11-25 19:51 ` Linus Torvalds
2016-11-25 19:51 ` Linus Torvalds
2016-11-25 20:36 ` Mike Marshall
2016-11-25 20:36 ` Mike Marshall
2016-11-25 20:36 ` Mike Marshall
2016-11-25 21:48 ` Theodore Ts'o
2016-11-25 21:48 ` Theodore Ts'o
2016-11-25 21:48 ` Theodore Ts'o
2016-11-25 23:38 ` Linus Torvalds
2016-11-25 23:38 ` Linus Torvalds
2016-11-25 23:38 ` Linus Torvalds
2016-11-28 8:33 ` Jan Kara
2016-11-28 8:33 ` Jan Kara
2016-11-28 8:33 ` Jan Kara
2016-11-27 22:42 ` Dave Chinner
2016-11-27 22:42 ` Dave Chinner
2016-11-27 22:42 ` Dave Chinner
2016-11-28 0:58 ` Linus Torvalds
2016-11-28 0:58 ` Linus Torvalds
2016-11-28 0:58 ` Linus Torvalds
2016-11-28 1:45 ` Al Viro
2016-11-28 1:45 ` Al Viro
2016-11-28 9:09 ` Dave Chinner
2016-11-28 9:09 ` Dave Chinner
2016-11-28 9:09 ` Dave Chinner
2016-11-25 3:00 ` Dave Chinner
2016-11-25 3:00 ` Dave Chinner
2016-11-25 3:00 ` Dave Chinner
2016-11-28 22:46 ` Ross Zwisler
2016-11-28 22:46 ` Ross Zwisler
2016-11-28 22:46 ` Ross Zwisler
2016-11-28 22:46 ` Ross Zwisler
2016-11-29 2:02 ` Dave Chinner
2016-11-29 2:02 ` Dave Chinner
2016-11-29 2:02 ` Dave Chinner
2017-03-08 22:05 ` Mike Marshall
2017-03-08 22:05 ` Mike Marshall
2017-03-08 22:05 ` Mike Marshall
2017-03-08 22:05 ` Mike Marshall
2016-11-23 18:44 ` [PATCH 4/6] dax: update MAINTAINERS entries for FS DAX Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` [PATCH 5/6] dax: add tracepoints to dax_pmd_load_hole() Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-24 9:20 ` Jan Kara
2016-11-24 9:20 ` Jan Kara
2016-11-24 9:20 ` Jan Kara
2016-11-23 18:44 ` [PATCH 6/6] dax: add tracepoints to dax_pmd_insert_mapping() Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-23 18:44 ` Ross Zwisler
2016-11-24 9:22 ` Jan Kara
2016-11-24 9:22 ` Jan Kara
2016-11-24 9:22 ` Jan Kara
2016-11-24 9:22 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128192035.GC6637@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mawilcox@microsoft.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.