All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emese Revfy <re.emese@gmail.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
	kernel-hardening@lists.openwall.com, keescook@chromium.org,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	pageexec@freemail.hu, spender@grsecurity.net, mmarek@suse.com
Subject: Re: [PATCH 3/3] powerpc: enable support for GCC plugins
Date: Tue, 6 Dec 2016 22:25:20 +0100	[thread overview]
Message-ID: <20161206222520.7fb37896488eff1b299eb3db@gmail.com> (raw)
In-Reply-To: <20161206062800.21800-3-andrew.donnellan@au1.ibm.com>

On Tue,  6 Dec 2016 17:28:00 +1100
Andrew Donnellan <andrew.donnellan@au1.ibm.com> wrote:

> +      # Various gccs between 4.5 and 5.1 have bugs on powerpc due to missing
> +      # header files. gcc <= 4.6 doesn't work at all, gccs from 4.8 to 5.1 have
> +      # issues with 64-bit targets.
> +      ifeq ($(ARCH),powerpc)
> +        ifeq ($(call cc-ifversion, -le, 0501, y), y)
> +	  @echo "Cannot use CONFIG_GCC_PLUGINS: plugin support on gcc <= 5.1 is buggy on powerpc, please upgrade to gcc 5.2 or newer" >&2 && exit 1
> +        endif
> +      endif

Hi,

What are these missing headers? Because if they aren't necessary then they can
be removed from gcc-common.h. There were missing headers on arm/arm64 and these
archs are supported. I think this version check is unnecessary because
gcc-plugin.sh also checks the missing headers.

What is the problem on gcc-4.5/gcc-4.6?

-- 
Emese

WARNING: multiple messages have this Message-ID (diff)
From: Emese Revfy <re.emese@gmail.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
	kernel-hardening@lists.openwall.com, keescook@chromium.org,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	pageexec@freemail.hu, spender@grsecurity.net, mmarek@suse.com
Subject: [kernel-hardening] Re: [PATCH 3/3] powerpc: enable support for GCC plugins
Date: Tue, 6 Dec 2016 22:25:20 +0100	[thread overview]
Message-ID: <20161206222520.7fb37896488eff1b299eb3db@gmail.com> (raw)
In-Reply-To: <20161206062800.21800-3-andrew.donnellan@au1.ibm.com>

On Tue,  6 Dec 2016 17:28:00 +1100
Andrew Donnellan <andrew.donnellan@au1.ibm.com> wrote:

> +      # Various gccs between 4.5 and 5.1 have bugs on powerpc due to missing
> +      # header files. gcc <= 4.6 doesn't work at all, gccs from 4.8 to 5.1 have
> +      # issues with 64-bit targets.
> +      ifeq ($(ARCH),powerpc)
> +        ifeq ($(call cc-ifversion, -le, 0501, y), y)
> +	  @echo "Cannot use CONFIG_GCC_PLUGINS: plugin support on gcc <= 5.1 is buggy on powerpc, please upgrade to gcc 5.2 or newer" >&2 && exit 1
> +        endif
> +      endif

Hi,

What are these missing headers? Because if they aren't necessary then they can
be removed from gcc-common.h. There were missing headers on arm/arm64 and these
archs are supported. I think this version check is unnecessary because
gcc-plugin.sh also checks the missing headers.

What is the problem on gcc-4.5/gcc-4.6?

-- 
Emese

  parent reply	other threads:[~2016-12-06 21:44 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06  6:27 [PATCH 1/3] gcc-plugins: fix definition of DISABLE_LATENT_ENTROPY_PLUGIN Andrew Donnellan
2016-12-06  6:27 ` [kernel-hardening] " Andrew Donnellan
2016-12-06  6:27 ` [PATCH 2/3] powerpc: correctly disable latent entropy GCC plugin on prom_init.o Andrew Donnellan
2016-12-06  6:27   ` [kernel-hardening] " Andrew Donnellan
2016-12-06  6:28 ` [PATCH 3/3] powerpc: enable support for GCC plugins Andrew Donnellan
2016-12-06  6:28   ` [kernel-hardening] " Andrew Donnellan
2016-12-06 20:40   ` Kees Cook
2016-12-06 20:40     ` [kernel-hardening] " Kees Cook
2016-12-06 20:40     ` Kees Cook
2016-12-07  1:05     ` [kernel-hardening] " Andrew Donnellan
2016-12-06 21:25   ` Emese Revfy [this message]
2016-12-06 21:25     ` Emese Revfy
2016-12-07  5:49     ` Andrew Donnellan
2016-12-07  5:49       ` [kernel-hardening] " Andrew Donnellan
2016-12-07  5:45   ` Andrew Donnellan
2016-12-07  5:45     ` [kernel-hardening] " Andrew Donnellan
2016-12-08 14:42   ` PaX Team
2016-12-08 14:42     ` [kernel-hardening] " PaX Team
2016-12-08 14:42     ` PaX Team
2016-12-08 18:06     ` Kees Cook
2016-12-08 18:06       ` [kernel-hardening] " Kees Cook
2016-12-08 18:06       ` Kees Cook
2016-12-09  2:48       ` Andrew Donnellan
2016-12-09  2:48         ` [kernel-hardening] " Andrew Donnellan
2016-12-09  2:48         ` Andrew Donnellan
2016-12-09 10:59         ` PaX Team
2016-12-09 10:59           ` [kernel-hardening] " PaX Team
2016-12-09 10:59           ` PaX Team
2016-12-09 10:59           ` PaX Team
2017-01-27  5:52           ` Andrew Donnellan
2017-01-27  5:52             ` [kernel-hardening] " Andrew Donnellan
2017-01-27  5:52             ` Andrew Donnellan
2017-01-27  5:55             ` Andrew Donnellan
2017-01-27  5:55               ` [kernel-hardening] " Andrew Donnellan
2017-01-27  5:55               ` Andrew Donnellan
2017-02-06 20:37 ` [1/3] gcc-plugins: fix definition of DISABLE_LATENT_ENTROPY_PLUGIN Michael Ellerman
2017-02-06 20:37   ` [kernel-hardening] " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161206222520.7fb37896488eff1b299eb3db@gmail.com \
    --to=re.emese@gmail.com \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mmarek@suse.com \
    --cc=pageexec@freemail.hu \
    --cc=spender@grsecurity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.