From: "Pali Rohár" <pali.rohar@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-omap@vger.kernel.org,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/9] ARM: dts: omap3: Add an empty chosen node to top level DTSI
Date: Mon, 2 Jan 2017 19:01:22 +0100 [thread overview]
Message-ID: <201701021901.22476@pali> (raw)
In-Reply-To: <1482158681-4530-3-git-send-email-javier@osg.samsung.com>
[-- Attachment #1: Type: Text/Plain, Size: 825 bytes --]
On Monday 19 December 2016 15:44:34 Javier Martinez Canillas wrote:
> Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage")
> removed the skeleton.dtsi usage since we want to get rid of it.
>
> But this can cause issues when booting a kernel with a boot-loader
> that doesn't create a chosen node if this isn't present in the DTB
> since the decompressor relies on a pre-existing chosen node to be
> available to insert the command line and merge other ATAGS info.
>
> Fixes: 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage")
> Reported-by: Pali Rohar <pali.rohar@gmail.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Including empty chosen node fixes (or rather workaround) this problem.
You can add my Tested-By.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, "Tony Lindgren" <tony@atomide.com>,
linux-kernel@vger.kernel.org,
"Russell King" <linux@armlinux.org.uk>,
"Rob Herring" <robh+dt@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/9] ARM: dts: omap3: Add an empty chosen node to top level DTSI
Date: Mon, 2 Jan 2017 19:01:22 +0100 [thread overview]
Message-ID: <201701021901.22476@pali> (raw)
In-Reply-To: <1482158681-4530-3-git-send-email-javier@osg.samsung.com>
[-- Attachment #1.1: Type: Text/Plain, Size: 825 bytes --]
On Monday 19 December 2016 15:44:34 Javier Martinez Canillas wrote:
> Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage")
> removed the skeleton.dtsi usage since we want to get rid of it.
>
> But this can cause issues when booting a kernel with a boot-loader
> that doesn't create a chosen node if this isn't present in the DTB
> since the decompressor relies on a pre-existing chosen node to be
> available to insert the command line and merge other ATAGS info.
>
> Fixes: 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage")
> Reported-by: Pali Rohar <pali.rohar@gmail.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Including empty chosen node fixes (or rather workaround) this problem.
You can add my Tested-By.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] ARM: dts: omap3: Add an empty chosen node to top level DTSI
Date: Mon, 2 Jan 2017 19:01:22 +0100 [thread overview]
Message-ID: <201701021901.22476@pali> (raw)
In-Reply-To: <1482158681-4530-3-git-send-email-javier@osg.samsung.com>
On Monday 19 December 2016 15:44:34 Javier Martinez Canillas wrote:
> Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage")
> removed the skeleton.dtsi usage since we want to get rid of it.
>
> But this can cause issues when booting a kernel with a boot-loader
> that doesn't create a chosen node if this isn't present in the DTB
> since the decompressor relies on a pre-existing chosen node to be
> available to insert the command line and merge other ATAGS info.
>
> Fixes: 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage")
> Reported-by: Pali Rohar <pali.rohar@gmail.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Including empty chosen node fixes (or rather workaround) this problem.
You can add my Tested-By.
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170102/310e22a8/attachment.sig>
next prev parent reply other threads:[~2017-01-02 18:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 14:44 [PATCH 0/9] ARM: omap: Add empty chosen node in SoCs top level DTSI Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 1/9] ARM: dts: omap2: Add an empty chosen node to " Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 2/9] ARM: dts: omap3: " Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2017-01-02 18:01 ` Pali Rohár [this message]
2017-01-02 18:01 ` Pali Rohár
2017-01-02 18:01 ` Pali Rohár
2016-12-19 14:44 ` [PATCH 3/9] ARM: dts: omap4: " Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 4/9] ARM: dts: omap5: " Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 5/9] ARM: dts: am33xx: " Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 6/9] ARM: dts: am4372: " Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 7/9] ARM: dts: dm814x: " Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 8/9] ARM: dts: dm816x: " Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` [PATCH 9/9] ARM: dts: dra7: " Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-19 14:44 ` Javier Martinez Canillas
2016-12-27 17:30 ` [PATCH 0/9] ARM: omap: Add empty chosen node in SoCs " Tony Lindgren
2016-12-27 17:30 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201701021901.22476@pali \
--to=pali.rohar@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.