From: Thierry Reding <thierry.reding@gmail.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
alexandre.torgue@st.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, fabrice.gasnier@st.com,
gerald.baeza@st.com, arnaud.pouliquen@st.com,
linaro-kernel@lists.linaro.org,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings
Date: Thu, 19 Jan 2017 10:04:27 +0100 [thread overview]
Message-ID: <20170119090427.GA28834@ulmo.ba.sec> (raw)
In-Reply-To: <1484749251-14445-4-git-send-email-benjamin.gaignard@st.com>
[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]
On Wed, Jan 18, 2017 at 03:20:46PM +0100, Benjamin Gaignard wrote:
> Define bindings for pwm-stm32
>
> version 8:
> - reword st,breakinput description.
>
> version 6:
> - change st,breakinput parameter format to make it usuable on stm32f7 too.
>
> version 2:
> - use parameters instead of compatible of handle the hardware configuration
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/pwm/pwm-stm32.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt
One last nit: please use "dt-bindings: pwm:" as prefix for the patch
subject. So it would read something like this:
dt-bindings: pwm: Add STM32 bindings
or similar. That's the style that's been used for a while now. I'd have
fixed that up myself, but since Lee plans to take this through the MFD
tree I'd like to see that fixed up before it gets applied.
With the above:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
lars@metafoo.de, alexandre.torgue@st.com,
linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org,
arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
pmeerw@pmeerw.net, knaack.h@gmx.de, gerald.baeza@st.com,
fabrice.gasnier@st.com, lee.jones@linaro.org,
linaro-kernel@lists.linaro.org, jic23@kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings
Date: Thu, 19 Jan 2017 10:04:27 +0100 [thread overview]
Message-ID: <20170119090427.GA28834@ulmo.ba.sec> (raw)
In-Reply-To: <1484749251-14445-4-git-send-email-benjamin.gaignard@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 1105 bytes --]
On Wed, Jan 18, 2017 at 03:20:46PM +0100, Benjamin Gaignard wrote:
> Define bindings for pwm-stm32
>
> version 8:
> - reword st,breakinput description.
>
> version 6:
> - change st,breakinput parameter format to make it usuable on stm32f7 too.
>
> version 2:
> - use parameters instead of compatible of handle the hardware configuration
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/pwm/pwm-stm32.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt
One last nit: please use "dt-bindings: pwm:" as prefix for the patch
subject. So it would read something like this:
dt-bindings: pwm: Add STM32 bindings
or similar. That's the style that's been used for a while now. I'd have
fixed that up myself, but since Lee plans to take this through the MFD
tree I'd like to see that fixed up before it gets applied.
With the above:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings
Date: Thu, 19 Jan 2017 10:04:27 +0100 [thread overview]
Message-ID: <20170119090427.GA28834@ulmo.ba.sec> (raw)
In-Reply-To: <1484749251-14445-4-git-send-email-benjamin.gaignard@st.com>
On Wed, Jan 18, 2017 at 03:20:46PM +0100, Benjamin Gaignard wrote:
> Define bindings for pwm-stm32
>
> version 8:
> - reword st,breakinput description.
>
> version 6:
> - change st,breakinput parameter format to make it usuable on stm32f7 too.
>
> version 2:
> - use parameters instead of compatible of handle the hardware configuration
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/pwm/pwm-stm32.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt
One last nit: please use "dt-bindings: pwm:" as prefix for the patch
subject. So it would read something like this:
dt-bindings: pwm: Add STM32 bindings
or similar. That's the style that's been used for a while now. I'd have
fixed that up myself, but since Lee plans to take this through the MFD
tree I'd like to see that fixed up before it gets applied.
With the above:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170119/8a632a2f/attachment.sig>
next prev parent reply other threads:[~2017-01-19 9:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 14:20 [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 1/8] MFD: add bindings for STM32 Timers driver Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 2/8] MFD: add " Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 3/8] PWM: add pwm-stm32 DT bindings Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-19 9:04 ` Thierry Reding [this message]
2017-01-19 9:04 ` Thierry Reding
2017-01-19 9:04 ` Thierry Reding
2017-01-18 14:20 ` [PATCH v8 4/8] PWM: add PWM driver for STM32 plaftorm Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-19 9:08 ` Thierry Reding
2017-01-19 9:08 ` Thierry Reding
2017-01-19 9:08 ` Thierry Reding
2017-01-18 14:20 ` [PATCH v8 5/8] IIO: add bindings for STM32 timer trigger driver Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-19 19:31 ` Rob Herring
2017-01-19 19:31 ` Rob Herring
2017-01-19 19:31 ` Rob Herring
2017-01-18 14:20 ` [PATCH v8 6/8] IIO: add " Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 7/8] ARM: dts: stm32: add Timers driver for stm32f429 MCU Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-18 14:20 ` [PATCH v8 8/8] ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco Benjamin Gaignard
2017-01-18 14:20 ` Benjamin Gaignard
2017-01-19 8:43 ` [PATCH v8 0/8] Add PWM and IIO timer drivers for STM32 Lee Jones
2017-01-19 8:43 ` Lee Jones
2017-01-19 16:02 ` Benjamin Gaignard
2017-01-19 16:02 ` Benjamin Gaignard
2017-01-19 16:02 ` Benjamin Gaignard
2017-01-19 16:02 ` Benjamin Gaignard
2017-01-19 19:35 ` Rob Herring
2017-01-19 19:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119090427.GA28834@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gerald.baeza@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.