Re: [PATCH v2] drm: Clean up the 1366x768 fixup codes

From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	dri-devel@lists.freedesktop.org,
	Gustavo Padovan <gustavo@padovan.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm: Clean up the 1366x768 fixup codes
Date: Thu, 26 Jan 2017 18:19:44 +0100	[thread overview]
Message-ID: <20170126171944.45v24d23bo3743su@phenom.ffwll.local> (raw)
In-Reply-To: <20170126144845.GG31595@intel.com>

On Thu, Jan 26, 2017 at 04:48:45PM +0200, Ville Syrjälä wrote:
> On Mon, Jan 23, 2017 at 09:23:52AM +0100, Daniel Vetter wrote:
> > On Fri, Jan 20, 2017 at 09:46:17PM +0200, Ville Syrjälä wrote:
> > > On Tue, Jan 17, 2017 at 05:43:29PM +0100, Takashi Iwai wrote:
> > > > This is just a cleanup, no functional change.
> > > > 
> > > > The fixup code for 1366x768 in drm_mode_create_from_cmdline_mode() is
> > > > basically a copy of the existing code in drm_edid.c.  Make the latter
> > > > code public so that it can be called from the former function.
> > > > 
> > > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > > ---
> > > > v1->v2: Fix the wrong line removal of drm_mode_set_crtcinfo() call
> > > 
> > > We prefer to include the changelog in the commit message proper.
> > > But it can be hoisted up easily enough when pushing.
> > > 
> > > lgtm
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Ville, can you pls also apply&push this to drm-misc.git?
> 
> This would need a backmerge of the preceding fix into drm-misc-next.

Ok, that should happen after -rc6 is out, we already need it for something
else. I'll forget about this one here now and assume you'll handle it :-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch