All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "snitzer@redhat.com" <snitzer@redhat.com>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"hch@infradead.org" <hch@infradead.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: hch's native NVMe multipathing [was: Re: [PATCH 1/2] Don't blacklist nvme]
Date: Thu, 16 Feb 2017 13:07:43 -0500	[thread overview]
Message-ID: <20170216180742.GC17828@localhost.localdomain> (raw)
In-Reply-To: <1487266648.2612.3.camel@sandisk.com>

On Thu, Feb 16, 2017 at 05:37:41PM +0000, Bart Van Assche wrote:
> On Thu, 2017-02-16 at 12:38 -0500, Keith Busch wrote:
> > Maybe I'm not seeing the bigger picture. Is there some part to multipath
> > that the kernel is not in a better position to handle?
> 
> Does this mean that the code to parse /etc/multipath.conf will be moved into
> the kernel? Or will we lose the ability to configure the policies that
> /etc/multipath.conf allows to configure?

No, I'm just considering the settings for a device that won't work
at all if multipath.conf is wrong. For example, the uuid attributes,
path priority, or path checker. These can't be considered configurable
policies if all but one of them are invalid for a specific device type.

It shouldn't even be an option to let a user select TUR path checker
for NVMe, and the only checkers multipath-tools provide that even make
sense for NVMe are deprecated.

WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: hch's native NVMe multipathing [was: Re: [PATCH 1/2] Don't blacklist nvme]
Date: Thu, 16 Feb 2017 13:07:43 -0500	[thread overview]
Message-ID: <20170216180742.GC17828@localhost.localdomain> (raw)
In-Reply-To: <1487266648.2612.3.camel@sandisk.com>

On Thu, Feb 16, 2017@05:37:41PM +0000, Bart Van Assche wrote:
> On Thu, 2017-02-16@12:38 -0500, Keith Busch wrote:
> > Maybe I'm not seeing the bigger picture. Is there some part to multipath
> > that the kernel is not in a better position to handle?
> 
> Does this mean that the code to parse /etc/multipath.conf will be moved into
> the kernel? Or will we lose the ability to configure the policies that
> /etc/multipath.conf allows to configure?

No, I'm just considering the settings for a device that won't work
at all if multipath.conf is wrong. For example, the uuid attributes,
path priority, or path checker. These can't be considered configurable
policies if all but one of them are invalid for a specific device type.

It shouldn't even be an option to let a user select TUR path checker
for NVMe, and the only checkers multipath-tools provide that even make
sense for NVMe are deprecated.

  reply	other threads:[~2017-02-16 17:59 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 21:19 [PATCH 1/2] Don't blacklist nvme Keith Busch
2017-02-14 21:19 ` [PATCH 2/2] Fill NVMe specific path info Keith Busch
2017-02-20 17:57   ` Benjamin Marzinski
2017-02-21 21:06     ` Keith Busch
2017-02-14 21:35 ` [PATCH 1/2] Don't blacklist nvme Bart Van Assche
2017-02-14 23:00   ` Keith Busch
2017-02-15 14:57     ` Christoph Hellwig
2017-02-15 17:24       ` Keith Busch
2017-02-16  1:58         ` Mike Snitzer
2017-02-16  2:01     ` Mike Snitzer
2017-02-16  2:35       ` Mike Snitzer
2017-02-15 14:56 ` Christoph Hellwig
2017-02-16  2:53   ` hch's native NVMe multipathing [was: Re: [PATCH 1/2] Don't blacklist nvme] Mike Snitzer
2017-02-16  2:53     ` Mike Snitzer
2017-02-16  5:00     ` [dm-devel] " Bart Van Assche
2017-02-16  5:00       ` Bart Van Assche
2017-02-16 12:37       ` Mike Snitzer
2017-02-16 12:37         ` Mike Snitzer
2017-02-16 19:46         ` Bart Van Assche
2017-02-16 19:46           ` Bart Van Assche
2017-02-16 20:23           ` Mike Snitzer
2017-02-16 20:23             ` Mike Snitzer
2017-02-16 20:58             ` Bart Van Assche
2017-02-16 20:58               ` Bart Van Assche
2017-02-16 14:26     ` [dm-devel] " Christoph Hellwig
2017-02-16 14:26       ` Christoph Hellwig
2017-02-16 15:13       ` Mike Snitzer
2017-02-16 15:13         ` Mike Snitzer
2017-02-16 17:38         ` Keith Busch
2017-02-16 17:38           ` Keith Busch
2017-02-16 17:37           ` Bart Van Assche
2017-02-16 17:37             ` Bart Van Assche
2017-02-16 18:07             ` Keith Busch [this message]
2017-02-16 18:07               ` Keith Busch
2017-02-16 18:21               ` Mike Snitzer
2017-02-16 18:21                 ` Mike Snitzer
2017-02-16 20:40                 ` Keith Busch
2017-02-16 20:40                   ` Keith Busch
2017-02-17  9:04                 ` [dm-devel] " hch
2017-02-17  9:04                   ` hch
2017-02-17 14:43                   ` Mike Snitzer
2017-02-17 14:43                     ` Mike Snitzer
2017-02-16 18:05         ` Sagi Grimberg
2017-02-16 18:05           ` Sagi Grimberg
2017-02-17  9:05           ` [dm-devel] " Christoph Hellwig
2017-02-17  9:05             ` Christoph Hellwig
2017-02-17 14:37             ` Mike Snitzer
2017-02-17 14:37               ` Mike Snitzer
2017-02-17  9:33         ` [dm-devel] " Christoph Hellwig
2017-02-17  9:33           ` Christoph Hellwig
2017-02-17 14:32           ` Mike Snitzer
2017-02-17 14:32             ` Mike Snitzer
2017-02-20 18:17   ` [PATCH 1/2] Don't blacklist nvme Benjamin Marzinski
2017-02-20 14:14 ` Mike Snitzer
2017-02-27  5:37 ` Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216180742.GC17828@localhost.localdomain \
    --to=keith.busch@intel.com \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.