From: Mark Brown <broonie@kernel.org>
To: Garlic Tseng <garlic.tseng@mediatek.com>
Cc: tiwai@suse.de, srv_heupstream@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
ir.lian@mediatek.com
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: mediatek: add power-domain get/put ctrl for mt2701
Date: Thu, 16 Feb 2017 18:26:49 +0000 [thread overview]
Message-ID: <20170216182649.k6vj3rpvzgbquax5@sirena.org.uk> (raw)
In-Reply-To: <1487222836-21174-2-git-send-email-garlic.tseng@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
On Thu, Feb 16, 2017 at 01:27:15PM +0800, Garlic Tseng wrote:
> pm_runtime_enable(&pdev->dev);
> if (!pm_runtime_enabled(&pdev->dev))
> goto err_pm_disable;
> + pm_runtime_get_sync(&pdev->dev);
You should really check for errors here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Garlic Tseng <garlic.tseng@mediatek.com>
Cc: alsa-devel@alsa-project.org, ir.lian@mediatek.com,
srv_heupstream@mediatek.com, tiwai@suse.de,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: mediatek: add power-domain get/put ctrl for mt2701
Date: Thu, 16 Feb 2017 18:26:49 +0000 [thread overview]
Message-ID: <20170216182649.k6vj3rpvzgbquax5@sirena.org.uk> (raw)
In-Reply-To: <1487222836-21174-2-git-send-email-garlic.tseng@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 244 bytes --]
On Thu, Feb 16, 2017 at 01:27:15PM +0800, Garlic Tseng wrote:
> pm_runtime_enable(&pdev->dev);
> if (!pm_runtime_enabled(&pdev->dev))
> goto err_pm_disable;
> + pm_runtime_get_sync(&pdev->dev);
You should really check for errors here.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 1/2] ASoC: mediatek: add power-domain get/put ctrl for mt2701
Date: Thu, 16 Feb 2017 18:26:49 +0000 [thread overview]
Message-ID: <20170216182649.k6vj3rpvzgbquax5@sirena.org.uk> (raw)
In-Reply-To: <1487222836-21174-2-git-send-email-garlic.tseng@mediatek.com>
On Thu, Feb 16, 2017 at 01:27:15PM +0800, Garlic Tseng wrote:
> pm_runtime_enable(&pdev->dev);
> if (!pm_runtime_enabled(&pdev->dev))
> goto err_pm_disable;
> + pm_runtime_get_sync(&pdev->dev);
You should really check for errors here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170216/92bdac0a/attachment.sig>
next prev parent reply other threads:[~2017-02-16 18:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 5:27 [alsa-devel] [PATCH 0/2] ASoC: mediatek: add power-domain ctrl for 2701 Garlic Tseng
2017-02-16 5:27 ` Garlic Tseng
2017-02-16 5:27 ` Garlic Tseng
2017-02-16 5:27 ` [alsa-devel] [PATCH 1/2] ASoC: mediatek: add power-domain get/put ctrl for mt2701 Garlic Tseng
2017-02-16 5:27 ` Garlic Tseng
2017-02-16 5:27 ` Garlic Tseng
2017-02-16 18:26 ` Mark Brown [this message]
2017-02-16 18:26 ` Mark Brown
2017-02-16 18:26 ` Mark Brown
2017-02-16 19:04 ` Applied "ASoC: mediatek: add power-domain get/put ctrl for mt2701" to the asoc tree Mark Brown
2017-02-16 19:04 ` Mark Brown
2017-02-16 19:04 ` Mark Brown
2017-02-16 5:27 ` [alsa-devel] [PATCH 2/2] ASoC: mediatek: add power-domains for mt2701-afe-pcm.txt Garlic Tseng
2017-02-16 5:27 ` Garlic Tseng
2017-02-16 5:27 ` Garlic Tseng
2017-02-16 19:04 ` Applied "ASoC: mediatek: add power-domains for mt2701-afe-pcm.txt" to the asoc tree Mark Brown
2017-02-16 19:04 ` Mark Brown
2017-02-16 19:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216182649.k6vj3rpvzgbquax5@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=garlic.tseng@mediatek.com \
--cc=ir.lian@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.