From: Xiong Zhou <xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Eryu Guan <eguan-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org,
fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 2/2] generic: test mmap io through DAX and non-DAX
Date: Fri, 17 Feb 2017 14:52:07 +0800 [thread overview]
Message-ID: <20170217065207.fr2lwf2jdobc6jsl@XZHOUW.usersys.redhat.com> (raw)
In-Reply-To: <20170217064624.GC24562-+7p9VZFSOIEFmhoHi+V13ACJwEvxM/w9@public.gmane.org>
On Fri, Feb 17, 2017 at 02:46:24PM +0800, Eryu Guan wrote:
> On Wed, Feb 08, 2017 at 12:11:18PM +0800, Xiong Zhou wrote:
> > Mount TEST_DEV as non-DAX, SCRATCH_DEV as DAX, then
> > do some IO between them. In this case we use mmap
> > and dio/buffered IO read/write test programme.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Signed-off-by: Xiong Zhou <xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> > tests/generic/407 | 152 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > tests/generic/407.out | 2 +
> > tests/generic/group | 1 +
> > 3 files changed, 155 insertions(+)
> > create mode 100755 tests/generic/407
> > create mode 100644 tests/generic/407.out
> >
> > diff --git a/tests/generic/407 b/tests/generic/407
> > new file mode 100755
> > index 0000000..b5b2ce4
> > --- /dev/null
> > +++ b/tests/generic/407
> > @@ -0,0 +1,152 @@
> > +#! /bin/bash
> > +# FS QA Test 407
> > +#
> > +# mmap direct/buffered io between DAX and non-DAX mountpoints.
> [snip]
> > +
> > +# make fs 2Mb aligned for PMD fault testing
> > +if [[ $FSTYP =~ ext ]] ; then
> > + _scratch_mkfs "-E stride=512,stripe_width=1" \
> > + > /dev/null 2>&1
> > +elif [[ $FSTYP =~ xfs ]] ; then
> > + _scratch_mkfs "-d su=2m,sw=1" > /dev/null 2>&1
> > +fi
>
> If FSTYP isn't extN nor xfs, then scratch device is not mkfs'ed, I think
> you're missing a default "else" here, which calls _scratch_mkfs without
> any options.
>
> If you're OK with this update, I can fix it at commit time.
Okay, Thank you!
>
> Thanks,
> Eryu
WARNING: multiple messages have this Message-ID (diff)
From: Xiong Zhou <xzhou@redhat.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Xiong Zhou <xzhou@redhat.com>,
ross.zwisler@linux.intel.com, fstests@vger.kernel.org,
linux-nvdimm@ml01.01.org, jmoyer@redhat.com
Subject: Re: [PATCH v6 2/2] generic: test mmap io through DAX and non-DAX
Date: Fri, 17 Feb 2017 14:52:07 +0800 [thread overview]
Message-ID: <20170217065207.fr2lwf2jdobc6jsl@XZHOUW.usersys.redhat.com> (raw)
In-Reply-To: <20170217064624.GC24562@eguan.usersys.redhat.com>
On Fri, Feb 17, 2017 at 02:46:24PM +0800, Eryu Guan wrote:
> On Wed, Feb 08, 2017 at 12:11:18PM +0800, Xiong Zhou wrote:
> > Mount TEST_DEV as non-DAX, SCRATCH_DEV as DAX, then
> > do some IO between them. In this case we use mmap
> > and dio/buffered IO read/write test programme.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > Signed-off-by: Xiong Zhou <xzhou@redhat.com>
> > ---
> > tests/generic/407 | 152 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > tests/generic/407.out | 2 +
> > tests/generic/group | 1 +
> > 3 files changed, 155 insertions(+)
> > create mode 100755 tests/generic/407
> > create mode 100644 tests/generic/407.out
> >
> > diff --git a/tests/generic/407 b/tests/generic/407
> > new file mode 100755
> > index 0000000..b5b2ce4
> > --- /dev/null
> > +++ b/tests/generic/407
> > @@ -0,0 +1,152 @@
> > +#! /bin/bash
> > +# FS QA Test 407
> > +#
> > +# mmap direct/buffered io between DAX and non-DAX mountpoints.
> [snip]
> > +
> > +# make fs 2Mb aligned for PMD fault testing
> > +if [[ $FSTYP =~ ext ]] ; then
> > + _scratch_mkfs "-E stride=512,stripe_width=1" \
> > + > /dev/null 2>&1
> > +elif [[ $FSTYP =~ xfs ]] ; then
> > + _scratch_mkfs "-d su=2m,sw=1" > /dev/null 2>&1
> > +fi
>
> If FSTYP isn't extN nor xfs, then scratch device is not mkfs'ed, I think
> you're missing a default "else" here, which calls _scratch_mkfs without
> any options.
>
> If you're OK with this update, I can fix it at commit time.
Okay, Thank you!
>
> Thanks,
> Eryu
next prev parent reply other threads:[~2017-02-17 6:52 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 3:07 [PATCH 0/4] mmap dio and DAX Xiong Zhou
2017-01-18 3:07 ` Xiong Zhou
[not found] ` <1484708826-23529-1-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-18 3:07 ` [PATCH 1/4] common/rc: add _require_scratch_dax Xiong Zhou
2017-01-18 3:07 ` Xiong Zhou
[not found] ` <1484708826-23529-2-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-19 4:17 ` Eryu Guan
2017-01-19 4:17 ` Eryu Guan
2017-01-18 3:07 ` [PATCH 2/4] src/t_mmap_dio: add mmap dio test Xiong Zhou
2017-01-18 3:07 ` Xiong Zhou
2017-01-18 3:07 ` [PATCH 3/4] xfs: test per-inode DAX flag by IO Xiong Zhou
2017-01-18 3:07 ` Xiong Zhou
[not found] ` <1484708826-23529-4-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-19 4:24 ` Eryu Guan
2017-01-19 4:24 ` Eryu Guan
2017-01-18 3:07 ` [PATCH 4/4] generic: test mmap dio through DAX and non-DAX Xiong Zhou
2017-01-18 3:07 ` Xiong Zhou
[not found] ` <1484708826-23529-5-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-19 5:54 ` Eryu Guan
2017-01-19 5:54 ` Eryu Guan
[not found] ` <20170119055405.GT1859-+7p9VZFSOIEFmhoHi+V13ACJwEvxM/w9@public.gmane.org>
2017-01-19 10:13 ` [PATCH v2 0/2] mmap dio and DAX Xiong Zhou
2017-01-19 10:13 ` Xiong Zhou
2017-01-19 10:13 ` [PATCH v2 1/2] xfs: test per-inode DAX flag by IO Xiong Zhou
[not found] ` <1484820838-5098-2-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-19 20:49 ` Ross Zwisler
2017-01-19 20:49 ` Ross Zwisler
[not found] ` <20170119204925.GB28456-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-01-20 1:15 ` Xiong Zhou
2017-01-20 1:15 ` Xiong Zhou
2017-01-20 2:21 ` [PATCH v3] " Xiong Zhou
[not found] ` <1484878888-11483-1-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-20 6:15 ` [PATCH v4 0/2] mmap dio and DAX Xiong Zhou
2017-01-20 6:15 ` Xiong Zhou
[not found] ` <1484892950-25178-1-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-20 6:15 ` [PATCH v4 1/2] xfs: test per-inode DAX flag by IO Xiong Zhou
2017-01-20 6:15 ` Xiong Zhou
[not found] ` <1484892950-25178-2-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-02-04 15:17 ` [PATCH] fixup! " Ross Zwisler
2017-02-04 15:17 ` Ross Zwisler
[not found] ` <1486221472-1007-1-git-send-email-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-05 6:21 ` [PATCH v5 0/2] mmap dio and DAX Xiong Zhou
2017-02-05 6:21 ` Xiong Zhou
2017-02-05 6:21 ` [PATCH v5 1/2] xfs: test per-inode DAX flag by IO Xiong Zhou
[not found] ` <1486275704-18917-2-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-02-06 19:13 ` Ross Zwisler
2017-02-06 19:13 ` Ross Zwisler
2017-02-05 6:21 ` [PATCH v5 2/2] generic: test mmap io through DAX and non-DAX Xiong Zhou
2017-02-06 19:17 ` Ross Zwisler
2017-02-08 4:11 ` [PATCH v6 0/2] mmap dio and DAX Xiong Zhou
2017-02-08 4:11 ` [PATCH v6 1/2] xfs: test per-inode DAX flag by IO Xiong Zhou
2017-02-08 4:11 ` [PATCH v6 2/2] generic: test mmap io through DAX and non-DAX Xiong Zhou
2017-02-17 6:46 ` Eryu Guan
[not found] ` <20170217064624.GC24562-+7p9VZFSOIEFmhoHi+V13ACJwEvxM/w9@public.gmane.org>
2017-02-17 6:52 ` Xiong Zhou [this message]
2017-02-17 6:52 ` Xiong Zhou
2017-01-20 6:15 ` [PATCH v4 " Xiong Zhou
2017-01-20 6:15 ` Xiong Zhou
2017-01-24 22:28 ` [PATCH v4 0/2] mmap dio and DAX Ross Zwisler
2017-02-03 5:57 ` Xiong Zhou
2017-02-03 6:29 ` Eryu Guan
[not found] ` <20170203055717.acjivw4o4zmxhd64-E9dkjZ7ERC1QcClZ3XN9yxcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2017-02-03 16:57 ` Ross Zwisler
2017-02-03 16:57 ` Ross Zwisler
[not found] ` <20170203165710.GA24667-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-04 10:14 ` Xiong Zhou
2017-02-04 10:14 ` Xiong Zhou
[not found] ` <1484820838-5098-1-git-send-email-xzhou-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-19 10:13 ` [PATCH v2 2/2] generic: test mmap dio through DAX and non-DAX Xiong Zhou
2017-01-19 10:13 ` Xiong Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217065207.fr2lwf2jdobc6jsl@XZHOUW.usersys.redhat.com \
--to=xzhou-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=eguan-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.