From: Brian Norris <briannorris@chromium.org> To: Bjorn Helgaas <bhelgaas@google.com> Cc: <linux-kernel@vger.kernel.org>, Shawn Lin <shawn.lin@rock-chips.com>, Jeffy Chen <jeffy.chen@rock-chips.com>, Wenrui Li <wenrui.li@rock-chips.com>, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Brian Norris <briannorris@chromium.org> Subject: [PATCH v2 1/5] PCI: rockchip: fix sign issues for current limits Date: Thu, 9 Mar 2017 18:46:13 -0800 [thread overview] Message-ID: <20170310024617.67303-1-briannorris@chromium.org> (raw) The regulator framework can return negative error codes via regulator_get_current_limit() for regulators that don't provide current information. The subsequent check for postive values isn't very useful, if the variable is unsigned. Let's just match the signedness of the return value. Prevents error messages like this, seen on Samsung Chromebook Plus: [ 1.069372] rockchip-pcie f8000000.pcie: invalid power supply Fixes: 4816c4c7b82b ("PCI: rockchip: Provide captured slot power limit and scale") Signed-off-by: Brian Norris <briannorris@chromium.org> Acked-by: Shawn Lin <shawn.lin@rock-chips.com> --- v2: add Shawn's ack --- drivers/pci/host/pcie-rockchip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index 26ddd3535272..d785f64ec03b 100644 --- a/drivers/pci/host/pcie-rockchip.c +++ b/drivers/pci/host/pcie-rockchip.c @@ -425,7 +425,8 @@ static struct pci_ops rockchip_pcie_ops = { static void rockchip_pcie_set_power_limit(struct rockchip_pcie *rockchip) { - u32 status, curr, scale, power; + int curr; + u32 status, scale, power; if (IS_ERR(rockchip->vpcie3v3)) return; -- 2.12.0.246.ga2ecc84866-goog
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> To: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Cc: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, Wenrui Li <wenrui.li-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: [PATCH v2 1/5] PCI: rockchip: fix sign issues for current limits Date: Thu, 9 Mar 2017 18:46:13 -0800 [thread overview] Message-ID: <20170310024617.67303-1-briannorris@chromium.org> (raw) The regulator framework can return negative error codes via regulator_get_current_limit() for regulators that don't provide current information. The subsequent check for postive values isn't very useful, if the variable is unsigned. Let's just match the signedness of the return value. Prevents error messages like this, seen on Samsung Chromebook Plus: [ 1.069372] rockchip-pcie f8000000.pcie: invalid power supply Fixes: 4816c4c7b82b ("PCI: rockchip: Provide captured slot power limit and scale") Signed-off-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Acked-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org> --- v2: add Shawn's ack --- drivers/pci/host/pcie-rockchip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index 26ddd3535272..d785f64ec03b 100644 --- a/drivers/pci/host/pcie-rockchip.c +++ b/drivers/pci/host/pcie-rockchip.c @@ -425,7 +425,8 @@ static struct pci_ops rockchip_pcie_ops = { static void rockchip_pcie_set_power_limit(struct rockchip_pcie *rockchip) { - u32 status, curr, scale, power; + int curr; + u32 status, scale, power; if (IS_ERR(rockchip->vpcie3v3)) return; -- 2.12.0.246.ga2ecc84866-goog
next reply other threads:[~2017-03-10 2:47 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-10 2:46 Brian Norris [this message] 2017-03-10 2:46 ` [PATCH v2 1/5] PCI: rockchip: fix sign issues for current limits Brian Norris 2017-03-10 2:46 ` [PATCH v2 2/5] PCI: rockchip: make 'return 0' more obvious in probe() Brian Norris 2017-03-10 2:46 ` Brian Norris 2017-03-10 2:46 ` [PATCH v2 3/5] PCI: rockchip: add remove() support Brian Norris 2017-03-10 2:46 ` Brian Norris 2017-03-10 3:22 ` Shawn Lin 2017-03-10 4:20 ` Shawn Lin 2017-03-10 19:40 ` Brian Norris 2017-03-10 19:40 ` Brian Norris 2017-03-13 2:26 ` Shawn Lin 2017-03-20 22:29 ` Brian Norris 2017-03-20 22:29 ` Brian Norris 2017-03-24 14:25 ` Bjorn Helgaas 2017-03-24 17:22 ` Brian Norris 2017-03-30 23:28 ` Bjorn Helgaas 2017-03-30 23:28 ` Bjorn Helgaas 2017-03-31 0:26 ` Brian Norris 2017-03-31 5:17 ` Bjorn Helgaas 2017-03-31 5:17 ` Bjorn Helgaas 2017-03-31 16:40 ` Brian Norris 2017-04-11 18:18 ` Brian Norris 2017-03-10 2:46 ` [PATCH v2 4/5] PCI: export pci_remap_iospace() and pci_unmap_iospace() Brian Norris 2017-03-10 2:46 ` Brian Norris 2017-03-10 2:46 ` [PATCH v2 5/5] PCI: rockchip: modularize Brian Norris 2017-03-10 2:46 ` Brian Norris 2017-03-23 22:27 ` [PATCH v2 1/5] PCI: rockchip: fix sign issues for current limits Bjorn Helgaas 2017-03-23 22:33 ` Brian Norris 2017-03-24 1:24 ` Shawn Lin 2017-04-21 19:03 ` Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170310024617.67303-1-briannorris@chromium.org \ --to=briannorris@chromium.org \ --cc=bhelgaas@google.com \ --cc=jeffy.chen@rock-chips.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=shawn.lin@rock-chips.com \ --cc=wenrui.li@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.