From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Chris Brandt <chris.brandt@renesas.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Simon Horman <horms+renesas@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
rtc-linux@googlegroups.com, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH 1/5] rtc: rtc-sh: add support for rza series
Date: Fri, 17 Mar 2017 16:11:17 +0100 [thread overview]
Message-ID: <20170317151117.a7q4fz4ucqg5ngdi@piout.net> (raw)
In-Reply-To: <20170316175112.27913-2-chris.brandt@renesas.com>
Mostly good, one nitpick:
On 16/03/2017 at 13:51:08 -0400, Chris Brandt wrote:
> res = platform_get_resource(pdev, IORESOURCE_IO, 0);
> + if (res == NULL)
if (!res) is preferred here
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Chris Brandt <chris.brandt@renesas.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Simon Horman <horms+renesas@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
rtc-linux@googlegroups.com, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/5] rtc: rtc-sh: add support for rza series
Date: Fri, 17 Mar 2017 16:11:17 +0100 [thread overview]
Message-ID: <20170317151117.a7q4fz4ucqg5ngdi@piout.net> (raw)
In-Reply-To: <20170316175112.27913-2-chris.brandt@renesas.com>
Mostly good, one nitpick:
On 16/03/2017 at 13:51:08 -0400, Chris Brandt wrote:
> res = platform_get_resource(pdev, IORESOURCE_IO, 0);
> + if (res == NULL)
if (!res) is preferred here
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-17 15:11 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 17:51 [rtc-linux] [PATCH 0/5] rtc: Reuse rtc-sh driver to support RZ/A1 Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-16 17:51 ` [rtc-linux] [PATCH 1/5] rtc: rtc-sh: add support for rza series Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-17 8:22 ` [rtc-linux] " Geert Uytterhoeven
2017-03-17 8:22 ` Geert Uytterhoeven
2017-03-17 8:22 ` Geert Uytterhoeven
2017-03-17 13:17 ` [rtc-linux] " Chris Brandt
2017-03-17 13:17 ` Chris Brandt
2017-03-17 13:17 ` Chris Brandt
2017-03-17 15:11 ` Alexandre Belloni [this message]
2017-03-17 15:11 ` Alexandre Belloni
2017-03-16 17:51 ` [rtc-linux] [PATCH 2/5] rtc: Add rtc-sh Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-17 8:17 ` [rtc-linux] " Geert Uytterhoeven
2017-03-17 8:17 ` Geert Uytterhoeven
2017-03-17 8:17 ` Geert Uytterhoeven
2017-03-17 13:16 ` [rtc-linux] " Chris Brandt
2017-03-17 13:16 ` Chris Brandt
2017-03-17 13:16 ` Chris Brandt
2017-03-17 13:21 ` [rtc-linux] " Geert Uytterhoeven
2017-03-17 13:21 ` Geert Uytterhoeven
2017-03-17 13:21 ` Geert Uytterhoeven
2017-03-17 13:41 ` [rtc-linux] " Chris Brandt
2017-03-17 13:41 ` Chris Brandt
2017-03-17 13:41 ` Chris Brandt
2017-03-17 13:55 ` [rtc-linux] " Geert Uytterhoeven
2017-03-17 13:55 ` Geert Uytterhoeven
2017-03-17 13:55 ` Geert Uytterhoeven
2017-03-17 15:05 ` [rtc-linux] " Alexandre Belloni
2017-03-17 15:05 ` Alexandre Belloni
2017-03-17 15:05 ` Alexandre Belloni
2017-03-20 15:05 ` [rtc-linux] " Chris Brandt
2017-03-20 15:05 ` Chris Brandt
2017-03-20 15:05 ` Chris Brandt
2017-03-20 16:03 ` [rtc-linux] " Geert Uytterhoeven
2017-03-20 16:03 ` Geert Uytterhoeven
2017-03-20 16:03 ` Geert Uytterhoeven
2017-03-20 16:26 ` [rtc-linux] " Chris Brandt
2017-03-20 16:26 ` Chris Brandt
2017-03-20 16:26 ` Chris Brandt
2017-03-20 22:45 ` [rtc-linux] " Alexandre Belloni
2017-03-20 22:45 ` Alexandre Belloni
2017-03-20 22:45 ` Alexandre Belloni
2017-03-16 17:51 ` [rtc-linux] [PATCH 3/5] ARM: dts: r7s72100: add rtc clock to device tree Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-17 8:27 ` [rtc-linux] " Geert Uytterhoeven
2017-03-17 8:27 ` Geert Uytterhoeven
2017-03-17 8:27 ` Geert Uytterhoeven
2017-03-17 13:20 ` [rtc-linux] " Chris Brandt
2017-03-17 13:20 ` Chris Brandt
2017-03-17 13:20 ` Chris Brandt
2017-03-17 13:33 ` [rtc-linux] " Geert Uytterhoeven
2017-03-17 13:33 ` Geert Uytterhoeven
2017-03-17 13:33 ` Geert Uytterhoeven
2017-03-17 13:48 ` [rtc-linux] " Chris Brandt
2017-03-17 13:48 ` Chris Brandt
2017-03-17 13:48 ` Chris Brandt
2017-03-17 13:57 ` [rtc-linux] " Geert Uytterhoeven
2017-03-17 13:57 ` Geert Uytterhoeven
2017-03-17 13:57 ` Geert Uytterhoeven
2017-03-17 15:16 ` [rtc-linux] " Alexandre Belloni
2017-03-17 15:16 ` Alexandre Belloni
2017-03-17 15:16 ` Alexandre Belloni
2017-03-16 17:51 ` [rtc-linux] [PATCH 4/5] ARM: dts: r7s72100: add rtc " Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-16 17:51 ` [rtc-linux] [PATCH 5/5] ARM: dts: rskrza1: add rtc DT support Chris Brandt
2017-03-16 17:51 ` Chris Brandt
2017-03-16 17:51 ` Chris Brandt
[not found] ` <20170316175112.27913-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-03-28 13:38 ` [PATCH 0/5] rtc: Reuse rtc-sh driver to support RZ/A1 bobethtarsi3-Re5JQEeQqe8AvxtiuMwx3w
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317151117.a7q4fz4ucqg5ngdi@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.