From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Alexander.Steffen@infineon.com
Cc: tpmdd-devel@lists.sourceforge.net, dhowells@redhat.com,
linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com,
linux-security-module@vger.kernel.org, peterhuewe@gmx.de
Subject: Re: [tpmdd-devel] [PATCH v3 4/7] tpm: infrastructure for TPM spaces
Date: Fri, 17 Mar 2017 22:44:29 +0200 [thread overview]
Message-ID: <20170317204429.wsoe4r4jne437kyc@intel.com> (raw)
In-Reply-To: <1aa1c9d32fd446f69551a36c37f0ed16@MUCSE603.infineon.com>
On Fri, Mar 17, 2017 at 03:41:38PM +0000, Alexander.Steffen@infineon.com wrote:
> > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-
> > interface.c
> > index 20b1fe3..db5ffe9 100644
> > --- a/drivers/char/tpm/tpm-interface.c
> > +++ b/drivers/char/tpm/tpm-interface.c
> > @@ -376,11 +376,12 @@ static bool tpm_validate_command(struct
> > tpm_chip *chip, const u8 *cmd,
> > * 0 when the operation is successful.
> > * A negative number for system errors (errno).
> > */
> > -ssize_t tpm_transmit(struct tpm_chip *chip, const u8 *buf, size_t bufsiz,
> > - unsigned int flags)
> > +ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space,
> > + u8 *buf, size_t bufsiz, unsigned int flags)
>
> When adding parameters, please also update the parameter documentation
> at the top of the function. It is missing for the new parameter
> "space" here.
I missed that. I'll update the commits with the proper documentation.
> Alexander
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [tpmdd-devel] [PATCH v3 4/7] tpm: infrastructure for TPM spaces
Date: Fri, 17 Mar 2017 22:44:29 +0200 [thread overview]
Message-ID: <20170317204429.wsoe4r4jne437kyc@intel.com> (raw)
In-Reply-To: <1aa1c9d32fd446f69551a36c37f0ed16@MUCSE603.infineon.com>
On Fri, Mar 17, 2017 at 03:41:38PM +0000, Alexander.Steffen at infineon.com wrote:
> > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-
> > interface.c
> > index 20b1fe3..db5ffe9 100644
> > --- a/drivers/char/tpm/tpm-interface.c
> > +++ b/drivers/char/tpm/tpm-interface.c
> > @@ -376,11 +376,12 @@ static bool tpm_validate_command(struct
> > tpm_chip *chip, const u8 *cmd,
> > * 0 when the operation is successful.
> > * A negative number for system errors (errno).
> > */
> > -ssize_t tpm_transmit(struct tpm_chip *chip, const u8 *buf, size_t bufsiz,
> > - unsigned int flags)
> > +ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space,
> > + u8 *buf, size_t bufsiz, unsigned int flags)
>
> When adding parameters, please also update the parameter documentation
> at the top of the function. It is missing for the new parameter
> "space" here.
I missed that. I'll update the commits with the proper documentation.
> Alexander
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org
Cc: James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v3 4/7] tpm: infrastructure for TPM spaces
Date: Fri, 17 Mar 2017 22:44:29 +0200 [thread overview]
Message-ID: <20170317204429.wsoe4r4jne437kyc@intel.com> (raw)
In-Reply-To: <1aa1c9d32fd446f69551a36c37f0ed16-nFblLGNE8XKJSz+rYg/bSJowlv4uC7bZ@public.gmane.org>
On Fri, Mar 17, 2017 at 03:41:38PM +0000, Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w@public.gmane.org wrote:
> > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-
> > interface.c
> > index 20b1fe3..db5ffe9 100644
> > --- a/drivers/char/tpm/tpm-interface.c
> > +++ b/drivers/char/tpm/tpm-interface.c
> > @@ -376,11 +376,12 @@ static bool tpm_validate_command(struct
> > tpm_chip *chip, const u8 *cmd,
> > * 0 when the operation is successful.
> > * A negative number for system errors (errno).
> > */
> > -ssize_t tpm_transmit(struct tpm_chip *chip, const u8 *buf, size_t bufsiz,
> > - unsigned int flags)
> > +ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space,
> > + u8 *buf, size_t bufsiz, unsigned int flags)
>
> When adding parameters, please also update the parameter documentation
> at the top of the function. It is missing for the new parameter
> "space" here.
I missed that. I'll update the commits with the proper documentation.
> Alexander
/Jarkko
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-03-17 20:46 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 15:19 [PATCH v3 0/7] in-kernel resource manager Jarkko Sakkinen
2017-03-03 15:19 ` Jarkko Sakkinen
2017-03-03 15:19 ` [PATCH v3 1/7] tpm: move length validation to tpm_transmit() Jarkko Sakkinen
2017-03-03 15:19 ` Jarkko Sakkinen
2017-03-03 15:19 ` [PATCH v3 2/7] tpm: validate TPM 2.0 commands Jarkko Sakkinen
2017-03-03 15:19 ` Jarkko Sakkinen
2017-03-17 15:40 ` [tpmdd-devel] " Alexander.Steffen
2017-03-17 15:40 ` Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w
2017-03-17 15:40 ` [tpmdd-devel] " Alexander.Steffen at infineon.com
2017-03-17 16:16 ` Jason Gunthorpe
2017-03-17 16:16 ` Jason Gunthorpe
2017-03-17 16:35 ` Peter.Huewe
2017-03-17 16:35 ` Peter.Huewe-d0qZbvYSIPpWk0Htik3J/w
2017-03-17 16:35 ` [tpmdd-devel] " Peter.Huewe at infineon.com
2017-03-20 9:54 ` Alexander.Steffen
2017-03-20 9:54 ` Alexander.Steffen
2017-03-20 9:54 ` Alexander.Steffen at infineon.com
2017-03-20 17:23 ` Jason Gunthorpe
2017-03-20 17:23 ` Jason Gunthorpe
2017-03-20 17:23 ` [tpmdd-devel] " Jason Gunthorpe
2017-03-20 19:42 ` Ken Goldman
2017-03-20 19:42 ` Ken Goldman
2017-03-20 19:42 ` [tpmdd-devel] " Ken Goldman
2017-03-21 15:44 ` Alexander.Steffen
2017-03-21 15:44 ` Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w
2017-03-21 15:44 ` [tpmdd-devel] " Alexander.Steffen at infineon.com
2017-03-17 20:42 ` Jarkko Sakkinen
2017-03-17 20:42 ` Jarkko Sakkinen
2017-03-17 20:42 ` [tpmdd-devel] " Jarkko Sakkinen
2017-03-20 9:56 ` Alexander.Steffen
2017-03-20 9:56 ` Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w
2017-03-20 9:56 ` [tpmdd-devel] " Alexander.Steffen at infineon.com
2017-03-27 5:25 ` Jarkko Sakkinen
2017-03-27 5:25 ` Jarkko Sakkinen
2017-03-27 5:25 ` [tpmdd-devel] " Jarkko Sakkinen
2017-03-03 15:19 ` [PATCH v3 3/7] tpm: export tpm2_flush_context_cmd Jarkko Sakkinen
2017-03-03 15:19 ` Jarkko Sakkinen
2017-03-03 15:19 ` [PATCH v3 4/7] tpm: infrastructure for TPM spaces Jarkko Sakkinen
2017-03-03 15:19 ` Jarkko Sakkinen
2017-03-17 15:41 ` [tpmdd-devel] " Alexander.Steffen
2017-03-17 15:41 ` Alexander.Steffen-d0qZbvYSIPpWk0Htik3J/w
2017-03-17 15:41 ` [tpmdd-devel] " Alexander.Steffen at infineon.com
2017-03-17 20:44 ` Jarkko Sakkinen [this message]
2017-03-17 20:44 ` Jarkko Sakkinen
2017-03-17 20:44 ` [tpmdd-devel] " Jarkko Sakkinen
2017-03-03 15:19 ` [PATCH v3 5/7] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c Jarkko Sakkinen
2017-03-03 15:19 ` Jarkko Sakkinen
2017-03-03 15:19 ` [PATCH v3 6/7] tpm: expose spaces via a device link /dev/tpmrm<n> Jarkko Sakkinen
2017-03-03 15:19 ` Jarkko Sakkinen
2017-03-03 15:19 ` [PATCH v3 7/7] tpm2: add session handle context saving and restoring to the space code Jarkko Sakkinen
2017-03-03 15:19 ` Jarkko Sakkinen
2017-03-06 21:07 ` [PATCH v3 0/7] in-kernel resource manager Jarkko Sakkinen
2017-03-06 21:07 ` Jarkko Sakkinen
2017-03-11 8:55 ` Jarkko Sakkinen
2017-03-11 8:55 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317204429.wsoe4r4jne437kyc@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.