From: "Michael S. Tsirkin" <mst@redhat.com> To: Jason Wang <jasowang@redhat.com> Cc: Pankaj Gupta <pagupta@redhat.com>, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Date: Thu, 30 Mar 2017 00:47:33 +0300 [thread overview] Message-ID: <20170330004654-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <cea3d380-389e-d258-915a-3d4f60232535@redhat.com> On Wed, Mar 29, 2017 at 06:53:27PM +0800, Jason Wang wrote: > > > On 2017年03月29日 18:46, Pankaj Gupta wrote: > > Hi Jason, > > > > > On 2017年03月23日 13:34, Jason Wang wrote: > > > > > > > > > > +{ > > > > > > + if (rvq->rh != rvq->rt) > > > > > > + goto out; > > > > > > + > > > > > > + rvq->rh = rvq->rt = 0; > > > > > > + rvq->rt = skb_array_consume_batched_bh(rvq->rx_array, rvq->rxq, > > > > > > + VHOST_RX_BATCH); > > > > > A comment explaining why is is -bh would be helpful. > > > > Ok. > > > > > > > > Thanks > > > Rethink about this. It looks like -bh is not needed in this case since > > > no consumer run in bh. > > In that case do we need other variants of "ptr_ring_consume_batched_*()" functions. > > Are we planning to use them in future? > > I think we'd better keep them, since it serves as helpers. You can see that > not all the helpers in ptr_ring has real users, but they were prepared for > the future use. > > Thanks Makes sense for basic building blocks but I'm not sure we need to do it for all APIs. > > > > > Thanks > > >
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Jason Wang <jasowang@redhat.com> Cc: Pankaj Gupta <pagupta@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Date: Thu, 30 Mar 2017 00:47:33 +0300 [thread overview] Message-ID: <20170330004654-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <cea3d380-389e-d258-915a-3d4f60232535@redhat.com> On Wed, Mar 29, 2017 at 06:53:27PM +0800, Jason Wang wrote: > > > On 2017年03月29日 18:46, Pankaj Gupta wrote: > > Hi Jason, > > > > > On 2017年03月23日 13:34, Jason Wang wrote: > > > > > > > > > > +{ > > > > > > + if (rvq->rh != rvq->rt) > > > > > > + goto out; > > > > > > + > > > > > > + rvq->rh = rvq->rt = 0; > > > > > > + rvq->rt = skb_array_consume_batched_bh(rvq->rx_array, rvq->rxq, > > > > > > + VHOST_RX_BATCH); > > > > > A comment explaining why is is -bh would be helpful. > > > > Ok. > > > > > > > > Thanks > > > Rethink about this. It looks like -bh is not needed in this case since > > > no consumer run in bh. > > In that case do we need other variants of "ptr_ring_consume_batched_*()" functions. > > Are we planning to use them in future? > > I think we'd better keep them, since it serves as helpers. You can see that > not all the helpers in ptr_ring has real users, but they were prepared for > the future use. > > Thanks Makes sense for basic building blocks but I'm not sure we need to do it for all APIs. > > > > > Thanks > > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2017-03-29 21:47 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-21 4:04 [PATCH net-next 0/8] vhost-net rx batching Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 10:25 ` Sergei Shtylyov 2017-03-22 3:16 ` Jason Wang 2017-03-22 3:16 ` Jason Wang 2017-03-22 13:43 ` Michael S. Tsirkin 2017-03-22 13:43 ` Michael S. Tsirkin 2017-03-23 5:33 ` Jason Wang 2017-03-23 5:33 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 2/8] skb_array: " Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 3/8] tun: export skb_array Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 4/8] tap: " Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 5/8] tun: support receiving skb through msg_control Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 6/8] tap: support receiving skb from msg_control Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-22 14:16 ` Michael S. Tsirkin 2017-03-22 14:16 ` Michael S. Tsirkin 2017-03-23 5:34 ` Jason Wang 2017-03-23 5:34 ` Jason Wang 2017-03-29 9:58 ` Jason Wang 2017-03-29 9:58 ` Jason Wang 2017-03-29 10:46 ` Pankaj Gupta 2017-03-29 10:46 ` Pankaj Gupta 2017-03-29 10:53 ` Jason Wang 2017-03-29 10:53 ` Jason Wang 2017-03-29 21:47 ` Michael S. Tsirkin [this message] 2017-03-29 21:47 ` Michael S. Tsirkin 2017-03-21 4:04 ` [PATCH net-next 8/8] vhost_net: use lockless peeking for skb array during busy polling Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-29 12:07 ` Michael S. Tsirkin 2017-03-29 12:07 ` Michael S. Tsirkin 2017-03-30 2:16 ` Jason Wang 2017-03-30 2:33 ` Michael S. Tsirkin 2017-03-30 2:33 ` Michael S. Tsirkin 2017-03-30 3:53 ` Jason Wang 2017-03-30 3:53 ` Jason Wang 2017-03-30 2:16 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170330004654-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pagupta@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.