From: kbuild test robot <lkp@intel.com>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: kbuild-all@01.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com,
ckeepax@opensource.wolfsonmicro.com, shengjiu.wang@nxp.com,
viorel.suman@nxp.com, mihai.serban@nxp.com
Subject: Re: [PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL
Date: Wed, 5 Apr 2017 18:17:13 +0800 [thread overview]
Message-ID: <201704051812.RPhrgWdU%fengguang.wu@intel.com> (raw)
In-Reply-To: <1491324314-27067-3-git-send-email-daniel.baluta@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3773 bytes --]
Hi Daniel,
[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20170405]
[cannot apply to v4.11-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Daniel-Baluta/ASoC-codec-wm8960-Relax-bit-clock-computation-when-using-PLL/20170405-144647
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-randconfig-s0-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking':
>> sound/soc/codecs/wm8960.c:743:3: warning: 'best_freq_out' may be used uninitialized in this function [-Wmaybe-uninitialized]
wm8960_set_pll(codec, freq_in, best_freq_out);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/wm8960.c:703:21: note: 'best_freq_out' was declared here
int diff, closest, best_freq_out;
^~~~~~~~~~~~~
sound/soc/codecs/wm8960.c:806:56: warning: 'j' may be used uninitialized in this function [-Wmaybe-uninitialized]
snd_soc_update_bits(codec, WM8960_CLOCK1, 0x7 << 6, j << 6);
~~^~~~
sound/soc/codecs/wm8960.c:802:54: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
snd_soc_update_bits(codec, WM8960_CLOCK1, 3 << 1, i << 1);
~~^~~~
vim +/best_freq_out +743 sound/soc/codecs/wm8960.c
6b662dee Daniel Baluta 2017-04-04 727 *bclk_idx = k;
6b662dee Daniel Baluta 2017-04-04 728 best_freq_out = freq_out;
6b662dee Daniel Baluta 2017-04-04 729 break;
6b662dee Daniel Baluta 2017-04-04 730 }
16c42f46 Daniel Baluta 2017-04-04 731 if (diff > 0 && closest > diff) {
16c42f46 Daniel Baluta 2017-04-04 732 *sysclk_idx = i;
16c42f46 Daniel Baluta 2017-04-04 733 *dac_idx = j;
16c42f46 Daniel Baluta 2017-04-04 734 *bclk_idx = k;
16c42f46 Daniel Baluta 2017-04-04 735 closest = diff;
16c42f46 Daniel Baluta 2017-04-04 736 best_freq_out = freq_out;
16c42f46 Daniel Baluta 2017-04-04 737 }
6b662dee Daniel Baluta 2017-04-04 738 }
6b662dee Daniel Baluta 2017-04-04 739 }
6b662dee Daniel Baluta 2017-04-04 740 }
6b662dee Daniel Baluta 2017-04-04 741
6b662dee Daniel Baluta 2017-04-04 742 if (*bclk_idx != -1)
6b662dee Daniel Baluta 2017-04-04 @743 wm8960_set_pll(codec, freq_in, best_freq_out);
6b662dee Daniel Baluta 2017-04-04 744
6b662dee Daniel Baluta 2017-04-04 745 return *bclk_idx;
6b662dee Daniel Baluta 2017-04-04 746 }
3176bf2d Zidan Wang 2015-08-11 747 static int wm8960_configure_clocking(struct snd_soc_codec *codec)
0e50b51a Zidan Wang 2015-05-12 748 {
0e50b51a Zidan Wang 2015-05-12 749 struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
6b662dee Daniel Baluta 2017-04-04 750 int freq_out, freq_in;
0e50b51a Zidan Wang 2015-05-12 751 u16 iface1 = snd_soc_read(codec, WM8960_IFACE1);
:::::: The code at line 743 was first introduced by commit
:::::: 6b662deec0da0ad4f9dce8112d01828ed72b5a4c ASoC: codec: wm9860: Refactor PLL out freq search
:::::: TO: Daniel Baluta <daniel.baluta@nxp.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33329 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, shengjiu.wang@nxp.com,
patches@opensource.wolfsonmicro.com, tiwai@suse.com,
broonie@kernel.org, kbuild-all@01.org, viorel.suman@nxp.com,
mihai.serban@nxp.com, ckeepax@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL
Date: Wed, 5 Apr 2017 18:17:13 +0800 [thread overview]
Message-ID: <201704051812.RPhrgWdU%fengguang.wu@intel.com> (raw)
In-Reply-To: <1491324314-27067-3-git-send-email-daniel.baluta@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3773 bytes --]
Hi Daniel,
[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20170405]
[cannot apply to v4.11-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Daniel-Baluta/ASoC-codec-wm8960-Relax-bit-clock-computation-when-using-PLL/20170405-144647
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-randconfig-s0-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking':
>> sound/soc/codecs/wm8960.c:743:3: warning: 'best_freq_out' may be used uninitialized in this function [-Wmaybe-uninitialized]
wm8960_set_pll(codec, freq_in, best_freq_out);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/wm8960.c:703:21: note: 'best_freq_out' was declared here
int diff, closest, best_freq_out;
^~~~~~~~~~~~~
sound/soc/codecs/wm8960.c:806:56: warning: 'j' may be used uninitialized in this function [-Wmaybe-uninitialized]
snd_soc_update_bits(codec, WM8960_CLOCK1, 0x7 << 6, j << 6);
~~^~~~
sound/soc/codecs/wm8960.c:802:54: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
snd_soc_update_bits(codec, WM8960_CLOCK1, 3 << 1, i << 1);
~~^~~~
vim +/best_freq_out +743 sound/soc/codecs/wm8960.c
6b662dee Daniel Baluta 2017-04-04 727 *bclk_idx = k;
6b662dee Daniel Baluta 2017-04-04 728 best_freq_out = freq_out;
6b662dee Daniel Baluta 2017-04-04 729 break;
6b662dee Daniel Baluta 2017-04-04 730 }
16c42f46 Daniel Baluta 2017-04-04 731 if (diff > 0 && closest > diff) {
16c42f46 Daniel Baluta 2017-04-04 732 *sysclk_idx = i;
16c42f46 Daniel Baluta 2017-04-04 733 *dac_idx = j;
16c42f46 Daniel Baluta 2017-04-04 734 *bclk_idx = k;
16c42f46 Daniel Baluta 2017-04-04 735 closest = diff;
16c42f46 Daniel Baluta 2017-04-04 736 best_freq_out = freq_out;
16c42f46 Daniel Baluta 2017-04-04 737 }
6b662dee Daniel Baluta 2017-04-04 738 }
6b662dee Daniel Baluta 2017-04-04 739 }
6b662dee Daniel Baluta 2017-04-04 740 }
6b662dee Daniel Baluta 2017-04-04 741
6b662dee Daniel Baluta 2017-04-04 742 if (*bclk_idx != -1)
6b662dee Daniel Baluta 2017-04-04 @743 wm8960_set_pll(codec, freq_in, best_freq_out);
6b662dee Daniel Baluta 2017-04-04 744
6b662dee Daniel Baluta 2017-04-04 745 return *bclk_idx;
6b662dee Daniel Baluta 2017-04-04 746 }
3176bf2d Zidan Wang 2015-08-11 747 static int wm8960_configure_clocking(struct snd_soc_codec *codec)
0e50b51a Zidan Wang 2015-05-12 748 {
0e50b51a Zidan Wang 2015-05-12 749 struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
6b662dee Daniel Baluta 2017-04-04 750 int freq_out, freq_in;
0e50b51a Zidan Wang 2015-05-12 751 u16 iface1 = snd_soc_read(codec, WM8960_IFACE1);
:::::: The code at line 743 was first introduced by commit
:::::: 6b662deec0da0ad4f9dce8112d01828ed72b5a4c ASoC: codec: wm9860: Refactor PLL out freq search
:::::: TO: Daniel Baluta <daniel.baluta@nxp.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33329 bytes --]
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-04-05 10:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 16:45 [PATCH 0/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL Daniel Baluta
2017-04-04 16:45 ` Daniel Baluta
2017-04-04 16:45 ` [PATCH 1/2] ASoC: codec: wm9860: Refactor PLL out freq search Daniel Baluta
2017-04-04 16:45 ` Daniel Baluta
2017-04-05 9:01 ` Charles Keepax
2017-04-05 9:01 ` Charles Keepax
2017-04-05 10:02 ` [alsa-devel] " Daniel Baluta
2017-04-05 10:02 ` Daniel Baluta
2017-04-05 17:30 ` Applied "ASoC: codec: wm9860: Refactor PLL out freq search" to the asoc tree Mark Brown
2017-04-05 17:30 ` Mark Brown
2017-04-04 16:45 ` [PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL Daniel Baluta
2017-04-04 16:45 ` Daniel Baluta
2017-04-05 9:02 ` Charles Keepax
2017-04-05 9:02 ` Charles Keepax
2017-04-05 10:17 ` kbuild test robot [this message]
2017-04-05 10:17 ` kbuild test robot
2017-04-06 11:51 [PATCH 0/2] " Daniel Baluta
2017-04-06 11:51 ` [PATCH 2/2] " Daniel Baluta
2017-04-06 11:51 ` Daniel Baluta
2017-04-21 13:07 [PATCH 0/2] Relax bitclk " Daniel Baluta
2017-04-21 13:07 ` [PATCH 2/2] ASoC: codec: wm8960: Relax bit clock " Daniel Baluta
2017-04-21 13:07 ` Daniel Baluta
2017-04-21 14:44 ` Arnd Bergmann
2017-04-21 14:44 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201704051812.RPhrgWdU%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=daniel.baluta@nxp.com \
--cc=kbuild-all@01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.serban@nxp.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.