From: David Sterba <dsterba@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Btrfs: remove some dead code
Date: Wed, 12 Apr 2017 15:36:05 +0200 [thread overview]
Message-ID: <20170412133605.GJ4781@twin.jikos.cz> (raw)
In-Reply-To: <20170411085715.GA24157@mwanda>
On Tue, Apr 11, 2017 at 11:57:15AM +0300, Dan Carpenter wrote:
> btrfs_get_extent() never returns NULL pointers, so this code introduces
> a static checker warning.
>
> The btrfs_get_extent() is a bit complex, but trust me that it doesn't
> return NULLs and also if it did we would trigger the BUG_ON(!em) before
> the last return statement.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Added to 4.12, thanks. I've updated the subject line so it reflects what
the patch does.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Btrfs: remove some dead code
Date: Wed, 12 Apr 2017 13:36:05 +0000 [thread overview]
Message-ID: <20170412133605.GJ4781@twin.jikos.cz> (raw)
In-Reply-To: <20170411085715.GA24157@mwanda>
On Tue, Apr 11, 2017 at 11:57:15AM +0300, Dan Carpenter wrote:
> btrfs_get_extent() never returns NULL pointers, so this code introduces
> a static checker warning.
>
> The btrfs_get_extent() is a bit complex, but trust me that it doesn't
> return NULLs and also if it did we would trigger the BUG_ON(!em) before
> the last return statement.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Added to 4.12, thanks. I've updated the subject line so it reflects what
the patch does.
next prev parent reply other threads:[~2017-04-12 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 8:57 [PATCH] Btrfs: remove some dead code Dan Carpenter
2017-04-11 8:57 ` Dan Carpenter
2017-04-12 13:36 ` David Sterba [this message]
2017-04-12 13:36 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2016-11-01 10:26 [PATCH] btrfs: Remove " Christophe JAILLET
2016-11-01 10:26 ` Christophe JAILLET
2016-11-02 14:30 ` David Sterba
2016-11-02 14:30 ` David Sterba
2016-11-03 12:43 ` Tobias Klauser
2016-11-03 12:43 ` Tobias Klauser
2016-11-03 18:24 ` Christophe JAILLET
2016-11-03 18:24 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412133605.GJ4781@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.