From: Nicolin Chen <nicoleotsuka@gmail.com> To: Stefan Agner <stefan@agner.ch> Cc: timur@tabi.org, Xiubo.Lee@gmail.com, fabio.estevam@nxp.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type Date: Wed, 19 Apr 2017 23:43:21 -0700 [thread overview] Message-ID: <20170420064320.GA7912@Asurada> (raw) In-Reply-To: <20170420063607.23990-1-stefan@agner.ch> On Wed, Apr 19, 2017 at 11:36:07PM -0700, Stefan Agner wrote: > The direction argument is of type enum dma_transfer_direction, and > not enum dma_data_direction. The enumeration values are the same > so this did not had an effect in practise. > > Signed-off-by: Stefan Agner <stefan@agner.ch> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> Thanks > --- > sound/soc/fsl/fsl_asrc_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c > index dc30d780f874..282d841840b1 100644 > --- a/sound/soc/fsl/fsl_asrc_dma.c > +++ b/sound/soc/fsl/fsl_asrc_dma.c > @@ -76,7 +76,7 @@ static int fsl_asrc_dma_prepare_and_submit(struct snd_pcm_substream *substream) > pair->dma_chan[!dir], runtime->dma_addr, > snd_pcm_lib_buffer_bytes(substream), > snd_pcm_lib_period_bytes(substream), > - dir == OUT ? DMA_TO_DEVICE : DMA_FROM_DEVICE, flags); > + dir == OUT ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM, flags); > if (!pair->desc[!dir]) { > dev_err(dev, "failed to prepare slave DMA for Front-End\n"); > return -ENOMEM; > -- > 2.12.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com> To: Stefan Agner <stefan@agner.ch> Cc: alsa-devel@alsa-project.org, timur@tabi.org, Xiubo.Lee@gmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org, fabio.estevam@nxp.com Subject: Re: [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type Date: Wed, 19 Apr 2017 23:43:21 -0700 [thread overview] Message-ID: <20170420064320.GA7912@Asurada> (raw) In-Reply-To: <20170420063607.23990-1-stefan@agner.ch> On Wed, Apr 19, 2017 at 11:36:07PM -0700, Stefan Agner wrote: > The direction argument is of type enum dma_transfer_direction, and > not enum dma_data_direction. The enumeration values are the same > so this did not had an effect in practise. > > Signed-off-by: Stefan Agner <stefan@agner.ch> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> Thanks > --- > sound/soc/fsl/fsl_asrc_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c > index dc30d780f874..282d841840b1 100644 > --- a/sound/soc/fsl/fsl_asrc_dma.c > +++ b/sound/soc/fsl/fsl_asrc_dma.c > @@ -76,7 +76,7 @@ static int fsl_asrc_dma_prepare_and_submit(struct snd_pcm_substream *substream) > pair->dma_chan[!dir], runtime->dma_addr, > snd_pcm_lib_buffer_bytes(substream), > snd_pcm_lib_period_bytes(substream), > - dir == OUT ? DMA_TO_DEVICE : DMA_FROM_DEVICE, flags); > + dir == OUT ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM, flags); > if (!pair->desc[!dir]) { > dev_err(dev, "failed to prepare slave DMA for Front-End\n"); > return -ENOMEM; > -- > 2.12.2 >
next prev parent reply other threads:[~2017-04-20 6:43 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-20 6:36 [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type Stefan Agner 2017-04-20 6:36 ` Stefan Agner 2017-04-20 6:43 ` Nicolin Chen [this message] 2017-04-20 6:43 ` Nicolin Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170420064320.GA7912@Asurada \ --to=nicoleotsuka@gmail.com \ --cc=Xiubo.Lee@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=fabio.estevam@nxp.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=stefan@agner.ch \ --cc=timur@tabi.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.