From: Jan Kara <jack@suse.cz>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-mm@kvack.org,
jfs-discussion@lists.sourceforge.net, linux-xfs@vger.kernel.org,
cluster-devel@redhat.com, linux-f2fs-devel@lists.sourceforge.net,
v9fs-developer@lists.sourceforge.net, osd-dev@open-osd.org,
linux-nilfs@vger.kernel.org, linux-block@vger.kernel.org,
dhowells@redhat.com, akpm@linux-foundation.org,
hch@infradead.org, ross.zwisler@linux.intel.com,
mawilcox@microsoft.com, jack@suse.com, viro@zeniv.linux.org.uk,
corbet@lwn.net, neilb@suse.de, clm@fb.com, tytso@mit.edu,
axboe@kernel.dk
Subject: Re: [PATCH v3 06/20] dax: set errors in mapping when writeback fails
Date: Mon, 24 Apr 2017 17:54:16 +0200 [thread overview]
Message-ID: <20170424155416.GH23988@quack2.suse.cz> (raw)
In-Reply-To: <20170424132259.8680-7-jlayton@redhat.com>
On Mon 24-04-17 09:22:45, Jeff Layton wrote:
> In order to get proper error codes from fsync, we must set an error in
> the mapping range when writeback fails.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
So I'm fine with the change but please expand the changelog to something
like:
DAX currently doesn't set errors in the mapping when cache flushing fails
in dax_writeback_mapping_range(). Since this function can get called only
from fsync(2) or sync(2), this is actually as good as it can currently get
since we correctly propagate the error up from dax_writeback_mapping_range()
to filemap_fdatawrite(). However in the future better writeback error
handling will enable us to properly report these errors on fsync(2) even if
there are multiple file descriptors open against the file or if sync(2)
gets called before fsync(2). So convert DAX to using standard error
reporting through the mapping.
After improving the changelog you can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/dax.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 85abd741253d..9b6b04030c3f 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -901,8 +901,10 @@ int dax_writeback_mapping_range(struct address_space *mapping,
>
> ret = dax_writeback_one(bdev, mapping, indices[i],
> pvec.pages[i]);
> - if (ret < 0)
> + if (ret < 0) {
> + mapping_set_error(mapping, ret);
> return ret;
> + }
> }
> }
> return 0;
> --
> 2.9.3
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-mm@kvack.org,
jfs-discussion@lists.sourceforge.net, linux-xfs@vger.kernel.org,
cluster-devel@redhat.com, linux-f2fs-devel@lists.sourceforge.net,
v9fs-developer@lists.sourceforge.net, osd-dev@open-osd.org,
linux-nilfs@vger.kernel.org, linux-block@vger.kernel.org,
dhowells@redhat.com, akpm@linux-foundation.org,
hch@infradead.org, ross.zwisler@linux.intel.com,
mawilcox@microsoft.com, jack@suse.com, viro@zeniv.linux.org.uk,
corbet@lwn.net, neilb@suse.de, clm@fb.com, tytso@mit.edu,
axboe@kernel.dk
Subject: Re: [PATCH v3 06/20] dax: set errors in mapping when writeback fails
Date: Mon, 24 Apr 2017 17:54:16 +0200 [thread overview]
Message-ID: <20170424155416.GH23988@quack2.suse.cz> (raw)
In-Reply-To: <20170424132259.8680-7-jlayton@redhat.com>
On Mon 24-04-17 09:22:45, Jeff Layton wrote:
> In order to get proper error codes from fsync, we must set an error in
> the mapping range when writeback fails.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
So I'm fine with the change but please expand the changelog to something
like:
DAX currently doesn't set errors in the mapping when cache flushing fails
in dax_writeback_mapping_range(). Since this function can get called only
from fsync(2) or sync(2), this is actually as good as it can currently get
since we correctly propagate the error up from dax_writeback_mapping_range()
to filemap_fdatawrite(). However in the future better writeback error
handling will enable us to properly report these errors on fsync(2) even if
there are multiple file descriptors open against the file or if sync(2)
gets called before fsync(2). So convert DAX to using standard error
reporting through the mapping.
After improving the changelog you can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/dax.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 85abd741253d..9b6b04030c3f 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -901,8 +901,10 @@ int dax_writeback_mapping_range(struct address_space *mapping,
>
> ret = dax_writeback_one(bdev, mapping, indices[i],
> pvec.pages[i]);
> - if (ret < 0)
> + if (ret < 0) {
> + mapping_set_error(mapping, ret);
> return ret;
> + }
> }
> }
> return 0;
> --
> 2.9.3
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v3 06/20] dax: set errors in mapping when writeback fails
Date: Mon, 24 Apr 2017 17:54:16 +0200 [thread overview]
Message-ID: <20170424155416.GH23988@quack2.suse.cz> (raw)
In-Reply-To: <20170424132259.8680-7-jlayton@redhat.com>
On Mon 24-04-17 09:22:45, Jeff Layton wrote:
> In order to get proper error codes from fsync, we must set an error in
> the mapping range when writeback fails.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
So I'm fine with the change but please expand the changelog to something
like:
DAX currently doesn't set errors in the mapping when cache flushing fails
in dax_writeback_mapping_range(). Since this function can get called only
from fsync(2) or sync(2), this is actually as good as it can currently get
since we correctly propagate the error up from dax_writeback_mapping_range()
to filemap_fdatawrite(). However in the future better writeback error
handling will enable us to properly report these errors on fsync(2) even if
there are multiple file descriptors open against the file or if sync(2)
gets called before fsync(2). So convert DAX to using standard error
reporting through the mapping.
After improving the changelog you can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/dax.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 85abd741253d..9b6b04030c3f 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -901,8 +901,10 @@ int dax_writeback_mapping_range(struct address_space *mapping,
>
> ret = dax_writeback_one(bdev, mapping, indices[i],
> pvec.pages[i]);
> - if (ret < 0)
> + if (ret < 0) {
> + mapping_set_error(mapping, ret);
> return ret;
> + }
> }
> }
> return 0;
> --
> 2.9.3
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-04-24 15:54 UTC|newest]
Thread overview: 180+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 13:22 [PATCH v3 00/20] fs: introduce new writeback error reporting and convert existing API as a wrapper around it Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 01/20] mm: drop "wait" parameter from write_one_page Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:22 ` Christoph Hellwig
2017-04-24 15:22 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:22 ` Christoph Hellwig
2017-04-24 13:22 ` [PATCH v3 02/20] mm: fix mapping_set_error call in me_pagecache_dirty Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:22 ` Christoph Hellwig
2017-04-24 15:22 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:22 ` Christoph Hellwig
2017-04-24 13:22 ` [PATCH v3 03/20] buffer: use mapping_set_error instead of setting the flag Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:22 ` Christoph Hellwig
2017-04-24 15:22 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:22 ` Christoph Hellwig
2017-04-24 15:22 ` Christoph Hellwig
2017-04-24 13:22 ` [PATCH v3 04/20] fs: check for writeback errors after syncing out buffers in generic_file_fsync Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:23 ` Christoph Hellwig
2017-04-24 15:23 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:23 ` Christoph Hellwig
2017-04-24 15:46 ` Jan Kara
2017-04-24 15:46 ` [Cluster-devel] " Jan Kara
2017-04-24 15:46 ` Jan Kara
2017-04-24 13:22 ` [PATCH v3 05/20] orangefs: don't call filemap_write_and_wait from fsync Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:23 ` Christoph Hellwig
2017-04-24 15:23 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:23 ` Christoph Hellwig
2017-04-24 18:18 ` Mike Marshall
2017-04-24 18:18 ` [Cluster-devel] " Mike Marshall
2017-04-24 18:18 ` Mike Marshall
2017-04-24 13:22 ` [PATCH v3 06/20] dax: set errors in mapping when writeback fails Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:24 ` Christoph Hellwig
2017-04-24 15:24 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:24 ` Christoph Hellwig
2017-04-24 15:24 ` Christoph Hellwig
2017-04-24 15:54 ` Jan Kara [this message]
2017-04-24 15:54 ` [Cluster-devel] " Jan Kara
2017-04-24 15:54 ` Jan Kara
2017-04-24 19:16 ` Ross Zwisler
2017-04-24 19:16 ` [Cluster-devel] " Ross Zwisler
2017-04-24 19:16 ` Ross Zwisler
2017-04-24 13:22 ` [PATCH v3 07/20] nilfs2: set the mapping error when calling SetPageError on writeback Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:24 ` Christoph Hellwig
2017-04-24 15:24 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:24 ` Christoph Hellwig
2017-04-24 13:22 ` [PATCH v3 08/20] mm: ensure that we set mapping error if writeout() fails Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:24 ` Christoph Hellwig
2017-04-24 15:24 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:24 ` Christoph Hellwig
2017-04-24 15:56 ` Jan Kara
2017-04-24 15:56 ` [Cluster-devel] " Jan Kara
2017-04-24 15:56 ` Jan Kara
2017-04-24 13:22 ` [PATCH v3 09/20] 9p: set mapping error when writeback fails in launder_page Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:24 ` Christoph Hellwig
2017-04-24 15:24 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:24 ` Christoph Hellwig
2017-04-24 15:57 ` Jan Kara
2017-04-24 15:57 ` [Cluster-devel] " Jan Kara
2017-04-24 15:57 ` Jan Kara
2017-04-24 15:57 ` Jan Kara
2017-04-24 13:22 ` [PATCH v3 10/20] fuse: set mapping error in writepage_locked when it fails Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:25 ` Christoph Hellwig
2017-04-24 15:25 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:25 ` Christoph Hellwig
2017-04-24 16:04 ` Jan Kara
2017-04-24 16:04 ` [Cluster-devel] " Jan Kara
2017-04-24 16:04 ` Jan Kara
2017-04-24 16:04 ` Jan Kara
2017-04-24 17:14 ` Jeff Layton
2017-04-24 17:14 ` [Cluster-devel] " Jeff Layton
2017-04-24 17:14 ` Jeff Layton
2017-04-24 17:14 ` Jeff Layton
2017-04-24 17:14 ` Jeff Layton
2017-04-25 8:17 ` Jan Kara
2017-04-25 8:17 ` [Cluster-devel] " Jan Kara
2017-04-25 8:17 ` Jan Kara
2017-04-25 10:35 ` Jeff Layton
2017-04-25 10:35 ` [Cluster-devel] " Jeff Layton
2017-04-25 10:35 ` Jeff Layton
2017-04-25 10:35 ` Jeff Layton
2017-04-25 10:35 ` Jeff Layton
2017-04-25 11:19 ` Jan Kara
2017-04-25 11:19 ` [Cluster-devel] " Jan Kara
2017-04-25 11:19 ` Jan Kara
2017-04-25 16:43 ` Jeff Layton
2017-04-25 16:43 ` [Cluster-devel] " Jeff Layton
2017-04-25 16:43 ` Jeff Layton
2017-04-25 16:43 ` Jeff Layton
2017-04-25 16:43 ` Jeff Layton
2017-04-25 16:43 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 11/20] cifs: set mapping error when page writeback fails in writepage or launder_pages Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 15:27 ` Christoph Hellwig
2017-04-24 15:27 ` [Cluster-devel] " Christoph Hellwig
2017-04-24 15:27 ` Christoph Hellwig
2017-04-24 17:16 ` Jeff Layton
2017-04-24 17:16 ` [Cluster-devel] " Jeff Layton
2017-04-24 17:16 ` Jeff Layton
2017-04-24 17:16 ` Jeff Layton
2017-04-24 17:16 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 12/20] lib: add errseq_t type and infrastructure for handling it Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 13/20] fs: new infrastructure for writeback error handling and reporting Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 14/20] fs: retrofit old error reporting API onto new infrastructure Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 15/20] mm: remove AS_EIO and AS_ENOSPC flags Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 16/20] mm: don't TestClearPageError in __filemap_fdatawait_range Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 17/20] cifs: cleanup writeback handling errors and comments Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 18/20] mm: clean up error handling in write_one_page Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 19/20] jbd2: don't reset error in journal_finish_inode_data_buffers Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` [PATCH v3 20/20] gfs2: clean up some filemap_* calls Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] " Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 13:22 ` Jeff Layton
2017-04-24 14:12 ` Bob Peterson
2017-04-24 14:12 ` [Cluster-devel] " Bob Peterson
2017-04-24 14:12 ` Bob Peterson
2017-04-24 16:59 ` Jeff Layton
2017-04-24 16:59 ` [Cluster-devel] " Jeff Layton
2017-04-24 16:59 ` Jeff Layton
2017-04-24 16:59 ` Jeff Layton
2017-04-24 16:59 ` Jeff Layton
2017-04-24 17:41 ` Bob Peterson
2017-04-24 17:41 ` [Cluster-devel] " Bob Peterson
2017-04-24 17:41 ` Bob Peterson
2017-04-24 17:52 ` Jeff Layton
2017-04-24 17:52 ` [Cluster-devel] " Jeff Layton
2017-04-24 17:52 ` Jeff Layton
2017-04-24 17:52 ` Jeff Layton
2017-04-24 17:52 ` Jeff Layton
2017-04-24 17:52 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424155416.GH23988@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlayton@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=neilb@suse.de \
--cc=osd-dev@open-osd.org \
--cc=ross.zwisler@linux.intel.com \
--cc=tytso@mit.edu \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.